GRPS: Groups Commune 2.0.x

[sabret00the]

i have found some "ugly" code :p in functions_grps.php

function grps_rewrite_links($template)
.....
.............
................

$vbulletin->options['hometitle'] . ' ' . $vbphrase['grps_groups'],

i see 3 errors in the above code

- $vbulletin->options['hometitle']
My hometitle is only "MYDOMAINNAME" - so the url is only "www.MYDOMAINNAME/..."


- there is an whitespace between the 2 ' '

- why is there a $vbphrase['grps_groups'] ?
using the example of my site:
$vbulletin->options['hometitle'] . ' ' . $vbphrase['grps_groups'] => EBS:L!VE Groups.

[sabret00the]

2. Fix the breadcrumbs.what problem are we referring to here? in a stock installation of vBulletin with GRPS installed can you replicate this problem?

Is there a minimum donation required to remove the copyright links?indeed there is pm me about it.

[sabret00the]

Maybe I missed it, but everyone who posted recently received a response except me.

Are you planning on addressing any of the issues I have raised?

Thanks.
https://vborg.vbsupport.ru/showpost.php?p=1188060&postcount=1181

are you referencing the above post?

[Trana]

https://vborg.vbsupport.ru/showpost.php?p=1188060&postcount=1181

are you referencing the above post?

Yes.

[sabret00the]

I really like what you have done here, but this project will not go anywhere unless posts are indexed on the main site. Otherwise you are just building an island and no one will ever see the activity in each group. If you can get the search working then I imagine RSS and subscriptions will follow very quickly. Don't reinvent the wheel.

You have to get this more integrated with the VB core or it won't take off.

Thanks again.Hey Trana,

Sorry i took some time in getting back to you on this post, in all honesty i didn't feel it warranted a reply in view of the earlier conversation we had regarding your requests/demands.

I appreciate that you are enthusiastic over the possibilities that GRPS can have in regards to your community, in fact i'm in a weird way grateful. However 1250 posts in a support thread, over 150 installations and 15 releases, if this hasn't taken off, then i can only fear the possibilities.

The level of integration you're requesting is nice and dandy but more work than i'm willing to dedicate. in fact it's so much work it's actually unheard of in terms of vBulletin integration even amongst paid products. it would appear like some others, you're looking for assimilation as opposed to integration and theirs a huge difference.

[sabret00the]

If you check "Only the Group Leader (You) can Start Threads" in the group management, it doesn't save the option -- it's always unchecked.fixed.

[sabret00the]

NEW ZIP/RELEASE:
Groups v2.0.7.zip: bug fix including fixing post counts, thread goto's and fatal php errors.

[RvG2]

Oh yeah... testing now! :)

[sabret00the]

Please all note that the feed.php is included but will be unsupported, hence the lack of announcement and/or link to the file in the header or page(s).

[Merriweather]

Just installed and I see posting capabilities are back, that's good! Will test more later today. :)

[bada_bing]

sabret00the's

You mention that the new version fixes the post count? Does this mean that post counts are now intergrated with VB's post count?

[sabret00the]

sabret00the's

You mention that the new version fixes the post count? Does this mean that post counts are now intergrated with VB's post count?

it does not, i was referencing the postcount from the group info box.

[Trana]

Sorry i took some time in getting back to you on this post, in all honesty i didn't feel it warranted a reply in view of the earlier conversation we had regarding your requests/demands.

The level of integration you're requesting is nice and dandy but more work than i'm willing to dedicate. in fact it's so much work it's actually unheard of in terms of vBulletin integration even amongst paid products. it would appear like some others, you're looking for assimilation as opposed to integration and theirs a huge difference.

OK, just to be clear, I'm not demanding anything. I appreciate ANY hacks that people put time into even if I can't use them on my sites. I am merely making an observation that I think is relevant to the people who are evaluating this.

I understand what you are saying, but the lack of a means to search the groups means that all this wonderful group specific content is not indexed and most members won't even know it exists. Now I tried this hack out with my moderators and they seemed to enjoy it, but it doesn't seem like it is going to scale without searches, indexing, and subscriptions. A lot of hacks are a flash in the pan, great idea, poor execution and eventually they get removed. I don't see an easy way to convince my members to check their groups for new messages every time they visit the site.

I hope you're not taking this personally. I would love it for this hack to work because I can see that it would be very valuable, but IMO it is not going to scale enough to be used on any large sites.

BTW, there are a few hacks that do amazing things within the well defined VB datamanagers, DB layout, and hooks system.

[Merriweather]

As a site that has used groups (just as forum threads until now) for over three years now, I have to disagree with your observations, Trana. On my site, groups are just friends posting together over a common bond, but also just personal chit chat. If the community needs general info, they search and post in the forums, there's no need to search a group. Unless you're a member of the group, what goes on in the group really isn't the concern of the other members. My site is considerably large and just has no need for searching the content of the groups.

As for subscribing to threads in groups, sure, it's desirable, but the front page of the group tells you if there's been new posts, so it's not a huge deal (IMO) that you don't get an email.

[abramelin]

are there any major bugs now? i want to install this hack :/

[sabret00the]

OK, just to be clear, I'm not demanding anything. I appreciate ANY hacks that people put time into even if I can't use them on my sites. I am merely making an observation that I think is relevant to the people who are evaluating this.

I understand what you are saying, but the lack of a means to search the groups means that all this wonderful group specific content is not indexed and most members won't even know it exists. Now I tried this hack out with my moderators and they seemed to enjoy it, but it doesn't seem like it is going to scale without searches, indexing, and subscriptions. A lot of hacks are a flash in the pan, great idea, poor execution and eventually they get removed. I don't see an easy way to convince my members to check their groups for new messages every time they visit the site.

I hope you're not taking this personally. I would love it for this hack to work because I can see that it would be very valuable, but IMO it is not going to scale enough to be used on any large sites.

BTW, there are a few hacks that do amazing things within the well defined VB datamanagers, DB layout, and hooks system.
Have you any examples of search integration? i mean? tags, pictures (vBGallery, Photopost vB gallery, Photopost), anything at all?

In regards to major additions to vBulletin, aren't most being sold via your nearest coder through their newly acquired LLC?

And in regards to things like subscriptions, i'm pretty sure i made a post in which i said i had planned said feature along with others and wanted to start working on the next major version of this hack but instead of that i fixed bugs and added more features to this version to the point i don't even have a sketch of on a piece of paper of what i want the new layout to be like or even have anything written down in terms of what features i want other than a post here i made in giddy excitement. i haven't even managed to code the opening PHP bracket in a file.

Anyway all that aside, Trana have you considered this mod to achieve your desires: https://vborg.vbsupport.ru/showthread.php?t=92201

[sabret00the]

are there any major bugs now? i want to install this hack :/
any bugs that have been reported have been fixed.

[MetalLord]

just a small note on vbseo compatibility. as far as i tested all that has to be changed to make the mod compatible is to change all relative URLs to absolute ones (eg. index.php to /groups/index.php). vbseo maps all relative URLs to the root forum. so a relative link to index.php in the /groups folder would map to forum index instead of the group index.

[Peter_Rosado]

When I try to make a thread the buttons (images) of the form don't appear, just the text :( How can I fix that?

[Exitilus]

What is feed.php ..... I think I missed something ... *wataf*

[sabret00the]

What is feed.php ..... I think I missed something ... *wataf*
an RSS feed.

http://yoursite.com/groups/feed.php

[Exitilus]

Ahhh Ok ... I just noticed how you referenced it in another post and I sat here scratching my head like a monkey.

On a side note. The View Last Reply etc... buttons are working fine now :D I'll continue to test. Going to be a busy week for me as I'm moving.

Great updates Sabre ... appreciate all the hard work :)

[abramelin]

i have installed the product without any error but my problem is it doesnt find my css file. i have installed a plugin for using prefix in css path like you said in the readme file but it stils cant find the path. i have checked the source of the groups page and here is how it looks like
<link rel="stylesheet" type="text/css" href="http://www.9nokta2 Groups/clientscript/vbulletin_css/style-4b5abeb1-00007.css" id="vbulletin_css" />
this must be

<link rel="stylesheet" type="text/css" href="http://www.9nokta2.com/clientscript/vbulletin_css/style-4b5abeb1-00007.css" id="vbulletin_css" />
what can i do now?

[Exitilus]

That's odd. It works fine for me. I'd check your Forum URL

[abramelin]

are you using zacharia's css prefix plugin?

[Exitilus]

Yes. The plugin is very simple. all it includes is


if ($vbulletin->options['storecssasfile'])
{
$style['css'] = str_replace('clientscript', "{$vbulletin->options['bburl']}/clientscript", $style['css']);
}

So all it does is add your BB URL that is setup in AdminCP. So if it's picking the wrong URL my guess is thats the problem. But you could replace the {$vbulletin->options['bburl']} with your forum url

[Exitilus]

I have a Feature Request ...

If there could be either a Page Created that could show "all new posts" for the groups you belong to ... OR ... a If Condition that can be created if posts are new. (I could use the If Condition to light up my Groups Button) ...

Anyways .. I'll crawl back in my hole now *grins* ... So far it's working smoothly though :)

[sabret00the]

I have a Feature Request ...

If there could be either a Page Created that could show "all new posts" for the groups you belong to ... OR ... a If Condition that can be created if posts are new. (I could use the If Condition to light up my Groups Button) ...

Anyways .. I'll crawl back in my hole now *grins* ... So far it's working smoothly though :)
planned for the next version ;)

the page thing.

[sabret00the]

in case folks missed this extract from the huge post i made

...some of the other stuff that i'm hoping to put in here are; Subscriptions (not sure if pm based or email based yet), Favourite threads, Favourite photos and some other stuff i've forgotten. Oh and of course some AJAX here and there...

[Exitilus]

Yay!

[abramelin]

i have installed the product without any error but my problem is it doesnt find my css file. i have installed a plugin for using prefix in css path like you said in the readme file but it stils cant find the path. i have checked the source of the groups page and here is how it looks like
<link rel="stylesheet" type="text/css" href="http://www.9nokta2 Groups/clientscript/vbulletin_css/style-4b5abeb1-00007.css" id="vbulletin_css" />
this must be

<link rel="stylesheet" type="text/css" href="http://www.9nokta2.com/clientscript/vbulletin_css/style-4b5abeb1-00007.css" id="vbulletin_css" />
what can i do now?
bump, please help

[sabret00the]

bump, please help
in includes/functions_grps.php find (line 420):
$vbulletin->options['bbtitle'],

and replace with:
'>' . $vbulletin->options['bbtitle'],

now find (line 451):
$vbulletin->options['hometitle'] . ' ' . $vbphrase['grps_groups'],

and replace with:
'>' . $vbulletin->options['hometitle'] . ' ' . $vbphrase['grps_groups'],

now save and upload.

that's untested, but should work.

[abramelin]

now its working but its very weird that it doesnt show my footer (shows the footer but without css styling)

[sabret00the]

now its working but its very weird that it doesnt show my footer (shows the footer but without css styling)
your problem is due to this line
<div style="margin:auto; padding:0; width: 698px; height: 36px;background: #f40000 url(images/style92/main/footer_bg.jpg) no-repeat;">

[Merriweather]

It's almost perfect for me at this point. I am still having issues with the reporting feature. You have it sending a PM to the group owner, and I wnated it to run like regular reporting -- the specified moderator gets the notice, or it gets posted to the specified forum just like any other reported message. When I did a post report, the group owner got this:

Reporting Post: Post ID #61
Reason: testWhich is pretty much useless to her -- how does she know what post is #61?? Is it possible, or desirable to others to have the reporting work the same way as within the forums? I understand groups are a parallel feature to the forums, but I still want the administrators and moderators to maintain the final control, and therefore, want reports to go to them.

Also, this is small but irritating me to no end... on the group thread view, the spot where the post icon is supposed to show is still trying to post from the groups directory, even though I made all of my post icons defined with the full site URL. :(

[silverleaf]

I just did a fresh install and the Header and Footer css files aren't showing. I tried editing the functions_grps.php file like you said, but it still doesn't work. I know how to fix the smilies, but how do you fix the Header & Footer?

http://nwphotoforum.com/groups/groups.php?g=2

[Merriweather]

I just did a fresh install and the Header and Footer css files aren't showing. I tried editing the functions_grps.php file like you said, but it still doesn't work. I know how to fix the smilies, but how do you fix the Header & Footer?

http://nwphotoforum.com/groups/groups.php?g=2Some of your CSS references are relative, and therefore, aren't going to work when you use the CSS outside of the forums folder. For instance:

images/gradients/gradient_panelsurround.gif

Should be

http://nwphotoforum.com/forums/images/gradients/gradient_panelsurround.gif

[silverleaf]

What file/settings panel do I need to change this. Do I change a php file, a groups option setting, a vbulletin options setting, the .css file, a grps template, or something else?

[Merriweather]

What file/settings panel do I need to change this. Do I change a php file, a groups option setting, a vbulletin options setting, the .css file, a grps template, or something else?It's your template.

[Exitilus]

Most likely ... go to the Template CSS Options and you'll see it there. I had to do the same thing.

[silverleaf]

This is the main GROUPS template. I assume this is the template in which the css needs to be made absolute. What code needs to be changed to make it absolute?

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
$headinclude
<title>$vboptions[hometitle] $vbphrase[grps_groups]</title>
<if condition="!empty($bbuserinfo[grps])">
<link rel="alternate" type="application/rss+xml" title="$vboptions[hometitle] Groups RSS Feed" href="feed.php?u=$bbuserinfo[userid]" />
</if>
</head>
<body>
$header
$navbar

<h2>$grps_pagetitle</h2>
<br />
$grps_navbar
<br />
$grps_main

<!-- do not edit this please -->
<div align="center"><br />
GRPS $grps_version by sabret00the for <a href="http://www.ebslive.com">EBS:L!VE</a></div>
<!-- /do not edit this please -->
<!-- latest -->
$footer
</body>
</html>

[Exitilus]

Not that.

go to Styles and Templates. Look at the CSS for all the templates. The images and stuff are setup there. All you need to do is add the exact URL to them.

[silverleaf]

Thanks you for your help. That did the trick. For those who are having the following problem here's how to fix it.

Problem: My header and footer css styles are not showing properly.

Solution: Go to your VB admin--->styles & templates--->main css--->scroll all the way down to "additional css definitions"---> the second box will have the image paths you need to change and make absolute. There are 4 paths to change. That should do the trick.

Thanks everyone

[abramelin]

your problem is due to this line
<div style="margin:auto; padding:0; width: 698px; height: 36px;background: #f40000 url(images/style92/main/footer_bg.jpg) no-repeat;">

so what i am going to do? pff

[sabret00the]

It's almost perfect for me at this point. I am still having issues with the reporting feature. You have it sending a PM to the group owner, and I wnated it to run like regular reporting -- the specified moderator gets the notice, or it gets posted to the specified forum just like any other reported message. When I did a post report, the group owner got this:

Which is pretty much useless to her -- how does she know what post is #61?? Is it possible, or desirable to others to have the reporting work the same way as within the forums? I understand groups are a parallel feature to the forums, but I still want the administrators and moderators to maintain the final control, and therefore, want reports to go to them.

Also, this is small but irritating me to no end... on the group thread view, the spot where the post icon is supposed to show is still trying to post from the groups directory, even though I made all of my post icons defined with the full site URL. :(
I don't understand why she can't click the link to post #61? But i guess i get where you're coming from. What i'll do is in the next (major) version, i'll include the actual post along with the report and i'll add a hook so as that if people want to modify the report system and the way it acts then they can without modifying the original code. I must confess though, that wanting reports to go to admins is mind boggling. surely group owners are there to manage groups? but as i said, i'll add the hook.

for your last problem. can you post a snippet of the html source code please?

[sabret00the]

so what i am going to do? pff
you're having the same problem as silverleaf, basically:
<div style="margin:auto; padding:0; width: 698px; height: 36px;background: #f40000 url(images/style92/main/footer_bg.jpg) no-repeat;">

should be
<div style="margin:auto; padding:0; width: 698px; height: 36px;background: #f40000 url(_____http://yoursite.com/forums/_____images/style92/main/footer_bg.jpg) no-repeat;">

[abramelin]

i have similar css stylings for table header but they are working so why?

[Merriweather]

I don't understand why she can't click the link to post #61? But i guess i get where you're coming from. What i'll do is in the next (major) version, i'll include the actual post along with the report and i'll add a hook so as that if people want to modify the report system and the way it acts then they can without modifying the original code. I must confess though, that wanting reports to go to admins is mind boggling. surely group owners are there to manage groups? but as i said, i'll add the hook.It's not mind boggling, it's that not all groups are as trustworthy as yours, I suppose. I have had issues where users set up groups for the purpose of harassing others on the site and a group owner in such a group isn't going to give a crap if people are breaking forum rules, in which case the site management needs to step in. Also, if the post being reported is the group owner's, and they get the report, again, they aren't going to do anything about it. This is why reports need to go to admin -- at least for me, but I am guessing others would like to be able to have control over their groups as well, and not just let them do as they please. If you can give me a little direction, I can just tweak the code to not pull the userid of the group owner and instead PM it to my userid for now. :)

[Merriweather]

for your last problem. can you post a snippet of the html source code please?Here's the snippet of HTML it's using on the thread view page:

<td class="alt1" id="td_post_59">
<!-- message, attachments, sig -->


<!-- icon and title -->
<div class="smallfont">
<img class="inlineimg" src="images/icons/icon1.gif" alt="Default" border="0" />

</div>
<hr size="1" style="color:#E8D9EC" />

<!-- / icon and title -->


<!-- message -->

The "inlineimg" should be pulling from http://www.mysite.com/forums/images/icons/icon1.gif" but I can't seem to get it to do so. It appears where the post icon is supposed to.

Also, in testing again and getting the HTML for you, I have noticed that entering a post subject serves no purpose if you're replying to a group thread, as it doesn't appear anywhere and selecting a post icon does nothing as well, it's always just "Default" and no title.

Let me know if you need a better explanation than that. :)

[Merriweather]

I've just found that clicking "edit" and then selecting "Delete Message" also does nothing -- the message is still there.

[sabret00the]

It's not mind boggling, it's that not all groups are as trustworthy as yours, I suppose. I have had issues where users set up groups for the purpose of harassing others on the site and a group owner in such a group isn't going to give a crap if people are breaking forum rules, in which case the site management needs to step in. Also, if the post being reported is the group owner's, and they get the report, again, they aren't going to do anything about it. This is why reports need to go to admin -- at least for me, but I am guessing others would like to be able to have control over their groups as well, and not just let them do as they please. If you can give me a little direction, I can just tweak the code to not pull the userid of the group owner and instead PM it to my userid for now. :)
Wouldn't it then be better to have a feature which enables end-users to flag groups for reviewing by the administration team?

anyhoo in report.php find:
$pmdm->set_recipients($reportinfo['username'], $botpermissions);

and replace with:
$pmdm->set_recipients('____YOUR_USERNAME___', $botpermissions);

[sabret00the]

i have similar css stylings for table header but they are working so why?
i'm seeing full paths as your header is controlled mostly by flash.

[Merriweather]

Wouldn't it then be better to have a feature which enables end-users to flag groups for reviewing by the administration team?That's what reporting to the admin would do. ;)

I understand where you're coming from on thinking the group owner should have the control and receive the reports, but my site is just not like that. I am guessing there are others who would want the reports to go to site staff and not the group leader as well. I'll use the fix you provided for now (thanks!) but you might want to consider it as a switch in the future -- reports to group owner or staff.

[abramelin]

i'm seeing full paths as your header is controlled mostly by flash.

table header and the site's header are different things.

[sabret00the]

table header and the site's header are different things.
sorry i misread it.

but even so
.tcat

{

background: #33CCFF url(http://www.9nokta2.com/images/style92/gradients/gradient_tcat.gif) repeat-x top left;

[abramelin]

what about background? :)
it is
#CBE6F9 url(images/style92/main/bg.jpg) repeat-x

but working on the groups page

[Exitilus]

Add the exact URL. http://yourdomain.com/images/style92/main/bg.jpg

The image could be Cached

[abramelin]

you didnt understand the point, nevermind

[Martin Belak]

Thanks for this great plug in sabret00the, it works really fine. But I have two major issues with my installation, and I hope you can solve it for me.

1. I get "Fatal error: Cannot use object of type mysqli_result as array in /path/to/forum/includes/class_grps.php on line 183" every time i try to save changes in a post (editing posts). GRPS updates the post, but the message is still annoying.

2. [i m g]http://path/to/an/image.gif[/i m g] (without spaces) is shown as a link, not as an image in the posts. Is this a permission/setting thing? Where can I change it.

Hope you guys can help me.

/M

[sabret00the]

Thanks for this great plug in sabret00the, it works really fine. But I have two major issues with my installation, and I hope you can solve it for me.

1. I get "Fatal error: Cannot use object of type mysqli_result as array in /path/to/forum/includes/class_grps.php on line 183" every time i try to save changes in a post (editing posts). GRPS updates the post, but the message is still annoying.

2. [i m g]http://path/to/an/image.gif[/i m g] (without spaces) is shown as a link, not as an image in the posts. Is this a permission/setting thing? Where can I change it.

Hope you guys can help me.

/M
1/ is that editgroup.php?

2/ i have no idea what that problem is all about, can i see the html source of said image?

[sabret00the]

I've just found that clicking "edit" and then selecting "Delete Message" also does nothing -- the message is still there.
fixed.

[Martin Belak]

1/ is that editgroup.php?

No, its editpost.php

I have editpost.php?do=editpost&p=49 in the location field before i send the edit-form, and just editpost.php after submitting the form.


2/ i have no idea what that problem is all about, can i see the html source of said image?
Hm... I've added the image with:
[i m g]https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg[/i m g]
but have
<a href="https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg" target="_blank">https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg</a>
in the html output. This issue may maybe be caused by vBSEO...

/M

[Merriweather]

fixed.

Excellent. Are you doing a new release soon? :)

[DJ XtAzY]

interesting idea.

awesome! at least i feel there's some hope. It will be so much better to make the existing threads worth something rather starting all over again. Also is it possible to have the post counts in the groups be added towards the user's forum total post count?

[Merriweather]

Another bug:

I went into the Admin Panel and went to Groups Editor (Delete). I entered the group number I wanted to delete, and then it took me to the confirmation screen, and I deleted. However, it then bounced me back to the Category delete screen, and had I not noticed, I could have wiped out a category with my next deletion!

Not a bug but need help:

I got a DB error when deleting a group:

Database error in vBulletin 3.6.4:

Invalid SQL:

DELETE FROM grps_post
WHERE groupid = 13;

MySQL Error : Incorrect key file for table 'grps_post'; try to repair it
Error Number : 1034
Date : Thursday, March 1st 2007 @ 11:47:10 PM
Script : <edited>/forums/admincp/grps_deleter.php?do=dodeletegroup
Referrer : <edited>/forums/admincp/grps_deleter.php?do=confirm&what=group&groupid=13
IP Address : <edited>
Username : <edited>
Classname : vb_database

I repaired the table, but now the posts from the group are still in my DB, it's just that the group info is gone. So, it doesn't show on any of the groups pages, but if I go to groups.php?g=13 (where 13 is the id of the deleted group), I still see all of the posts and everything. How can I wipe out that data?

Also, I see that if I go to groups.php?g=XX where XX is a non-existent group, I get a blank page that looks like a Group home page, but obviously has no data. Can this be fixed to give a "Group Does Not Exist" error or something?

[Merriweather]

Another request -- when browsing groups via browse.php, if the group has an image or other BBCode in the Group description it shows as BBCode -- can that be changed to either strip code or convert it? If it converts, it could be an issue because my users post images (sometimes large) in their descriptions, so that would take up a lot of space.

Also, I see that the ENTIRE description shows on browse.php which is bad for me, since my users have LONG descriptions for their groups -- my page will scroll for ever at this rate. Is it possible to (1) make group descriptions collapsible on this page and have them collapsed by default or truncate the text included on browse.php?

One unrelated suggestion -- when you're in ACP and go to Groups Editor (Edit) and you enter a non-existant group, the "Group Not Found" message should be at the top, and preferably, the other editing controls should not show at all.

[sabret00the]

No, its editpost.php

I have editpost.php?do=editpost&p=49 in the location field before i send the edit-form, and just editpost.php after submitting the form.


2/ i have no idea what that problem is all about, can i see the html source of said image?
Hm... I've added the image with:
[i m g]https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg[/i m g]
but have
<a href="https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg" target="_blank">https://gnuf.com/community/up/pokerppoker-CCPCQ6.jpg</a>
in the html output. This issue may maybe be caused by vBSEO...

/M
1/ fixed

2/ i'm not sure what that problem revolves around, but i'm guessing it is your SEO mod.

[sabret00the]

Excellent. Are you doing a new release soon? :)
hopefully today.

[sabret00the]

Also is it possible to have the post counts in the groups be added towards the user's forum total post count?
it's not something i'm going to fold into this project but the hooks are in place so as that any developer/hacker/coder can easily add the functionality and release it.

[sabret00the]

Another bug:

I went into the Admin Panel and went to Groups Editor (Delete). I entered the group number I wanted to delete, and then it took me to the confirmation screen, and I deleted. However, it then bounced me back to the Category delete screen, and had I not noticed, I could have wiped out a category with my next deletion!

Not a bug but need help:

I got a DB error when deleting a group:



I repaired the table, but now the posts from the group are still in my DB, it's just that the group info is gone. So, it doesn't show on any of the groups pages, but if I go to groups.php?g=13 (where 13 is the id of the deleted group), I still see all of the posts and everything. How can I wipe out that data?

Also, I see that if I go to groups.php?g=XX where XX is a non-existent group, I get a blank page that looks like a Group home page, but obviously has no data. Can this be fixed to give a "Group Does Not Exist" error or something?
1/ Fixed

2/ you should just be able to go through the deletion process again, however if that doesn't work, run these query DELETE FROM grps_post
WHERE groupid = 13;

DELETE FROM grps_setting
WHERE groupid = 13;

DELETE FROM grps_thread
WHERE groupid = 13;

DELETE FROM grps_user
WHERE groupid = 13;

[sabret00the]

Another request -- when browsing groups via browse.php, if the group has an image or other BBCode in the Group description it shows as BBCode -- can that be changed to either strip code or convert it? If it converts, it could be an issue because my users post images (sometimes large) in their descriptions, so that would take up a lot of space.

Also, I see that the ENTIRE description shows on browse.php which is bad for me, since my users have LONG descriptions for their groups -- my page will scroll for ever at this rate. Is it possible to (1) make group descriptions collapsible on this page and have them collapsed by default or truncate the text included on browse.php?

One unrelated suggestion -- when you're in ACP and go to Groups Editor (Edit) and you enter a non-existant group, the "Group Not Found" message should be at the top, and preferably, the other editing controls should not show at all.
1/ that counts as a bug so it's been fixed.

2/ suggestion noted.

3/ suggestion noted.

[RidinHighSpeeds]

Looks like I'm getting this error when click on one of the Group Categories:

Cannot redeclare fetch_avatar_url()...

I noticed that this was addressed here:
https://vborg.vbsupport.ru/showthread.php?t=127303&page=52

Are you sure this is fixed??

Never mind..found the fix a couple of pages later..

Thanks.

[sabret00the]

New Zip/Release:
Groups v2.0.8.zip: bug fix regarding inability to delete posts, problem with editing posts and other misc errors.

Advanced Users: The only files that have been changed are browse.php (groups folder), edit_post.php (groups folder), groups.php (groups folder), functions_grps.php (forums/includes folder) and class_grps.php (forums/includes folder). make sure to replace the plguin.xml as well as it makes an important template change to groups_editpost and removes some debunked phrases.

[gyankow]

I love this product in fact I'm releasing it to my entire community very soon. I have a few suggestions I think would be great additions.


Group Avatars or Images - Allow the moderator to assign an image to a group to that it can be indentified by graphcal image.
Templates For laying out a Groups. Allow the moderators to hide or display items.
Display Group Stats in Groups Home
CMPS Modules incluing Stats/new groups/newest threads etc.


Any plans on using VB's native forums?
Any plans on using VB's native indexing?

[Merriweather]

Still can't delete a post. Clicked "Edit" on the post, selected "Delete Message", clicked "Delete this Message" and then got:

Invalid Buddy Group specified. If you followed a valid link, please notify the administrator

[Merriweather]

Still not getting the post icon or topic title when posting. Also, after I submit my post, it takes me to the start of the thread instead of my post, so if my post is page 10, I then have to click around to get back to it.

[Merriweather]

I haven't been able to test this yet, but my users are reporting that when they update their group home page (description) it's not updated on the browse.php page.

[sabret00the]

Still can't delete a post. Clicked "Edit" on the post, selected "Delete Message", clicked "Delete this Message" and then got:
i've not been home all weekend so please excuse the skipped posts, i'm just trying to get further information on this one so i can deal with it when i get home. but what is the url of the page that gives you that message?

and are the posts not deleted?

as for everything else, i'll deal with it when i get back to my pc, including noting suggestions and posting the script to test the stylevar (post icon) problem?

[Merriweather]

The posts are not deleted. Let's see... you start at viewthread.php, then you click "Edit" on the post which takes you to editpost.php?do=editpost&p=72 (where 72 is the post id, of course). From there you click the radio for "Delete Message" then click the "Delete this Message" button and you're taken to the error I posted, which is a url of viewthread.php?g=0.

Hope that helps.

A lot of my users are also getting this error when posting:

Invalid SQL:

SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid =;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 Error Number : 1064
Date : Sunday, March 4th 2007 @ 05:43:22 PM
Script : <edited>/groups/newreply.php
Referrer : <edited>/groups/newreply.php?do=newreply&t=25
IP Address : <edited>
Username : <edited>
Classname : vb_database

[Merriweather]

In the deletion issue, I looked at the source code of editpost.php?do=editpost&post=XX and saw this in the form --

<input type="hidden" name="s" value="" />

Perhaps the missing value for "s" is causing issues?

[Merriweather]

Also, on the group creation page:

(1) It should be noted that the description entered there is NOT the group's home page, and should not contain BBCode, etc. That's why I am having the browse issues of code, etc -- people were putting their group home pages there. Now that we've figured it out, it's much better.

(2) After the group is created, it says it's taking you to said group, but it just bounces you back to the hgroups home page.

[sabret00the]

The posts are not deleted. Let's see... you start at viewthread.php, then you click "Edit" on the post which takes you to editpost.php?do=editpost&p=72 (where 72 is the post id, of course). From there you click the radio for "Delete Message" then click the "Delete this Message" button and you're taken to the error I posted, which is a url of viewthread.php?g=0.

Hope that helps.

A lot of my users are also getting this error when posting:
There appears to be something wrong here, in that when you delete a post the option is to "Physically Remove This Message" or "Do Not Delete Message". Could you be using an old template?

https://vborg.vbsupport.ru/ (http://img243.imageshack.us/my.php?image=grpseditpostdeleteyi4.jpg)

[sabret00the]

In the deletion issue, I looked at the source code of editpost.php?do=editpost&post=XX and saw this in the form --

<input type="hidden" name="s" value="" />

Perhaps the missing value for "s" is causing issues?
nope, "s" is the value of the sessionhash. it's basically only used for guests as members have their sessionhash tracked by cookies.

[sabret00the]

I love this product in fact I'm releasing it to my entire community very soon. I have a few suggestions I think would be great additions.


Group Avatars or Images - Allow the moderator to assign an image to a group to that it can be indentified by graphcal image.
Templates For laying out a Groups. Allow the moderators to hide or display items.
Display Group Stats in Groups Home
CMPS Modules incluing Stats/new groups/newest threads etc.


Any plans on using VB's native forums?
Any plans on using VB's native indexing?


planned for next major version.
this i'm not so sure about, depends on how the project unfolds.
what group stats would you like to have displayed?
i don't use CMPS so i'm definitely not the man to provide this functionality.


In terms of using vB native forums or indexing, the answer on both counts is nope, in fact with this version we're already looking like vBulletin than in the previous release and the integration goes as far as using vBulletin's native backend functions. in the coming version we're going to look less like vBulletin again as usability will take a huge precedence and again we'll limit ourselves to backend integration (usergroup permissions) and use of the native vBulletin functions/classes.

[KrisP]

ok here's the instructions

in "ROOT/forums/includes/xml/cpnav_vbulletin.xml" find:
--------
<navoption displayorder="50">
<phrase>moderate_displayorder="50">
<phrase>moderate_users</phrase>
displayorder="50">
<phrase>moderate_users</phrase>
<link>user.php?do=moderate</link>
</navoption>

--------

and below add:
--------
<navoption displayorder="70">
<phrase>moderate_groups</phrase>
<link>grps_moderate.php?do=groups</link>
</navoption>

--------

Cant find


--------
<navoption displayorder="50">
<phrase>moderate_displayorder="50">
<phrase>moderate_users</phrase>
displayorder="50">
<phrase>moderate_users</phrase>
<link>user.php?do=moderate</link>
</navoption>
in "ROOT/forums/includes/xml/cpnav_vbulletin.xml" ?! I use 3.6.4

I presume ROOT/forums means the folder in which vbulletin is installed.. - there is no folder called "forums"

[sabret00the]

Still not getting the post icon or topic title when posting. Also, after I submit my post, it takes me to the start of the thread instead of my post, so if my post is page 10, I then have to click around to get back to it.
please upload this to groups/tools/ and then run it as www.yoursite.com/groups/tools/test_stylevars.php?test=posticons

[sabret00the]

Cant find


in "ROOT/forums/includes/xml/cpnav_vbulletin.xml" ?! I use 3.6.4

I presume ROOT/forums means the folder in which vbulletin is installed..
Yup, just substitute forums with your vBulletin folder.

[KrisP]

yes but

<navoption displayorder="50">
<phrase>moderate_displayorder="50">
<phrase>moderate_users</phrase>
displayorder="50">
<phrase>moderate_users</phrase>
<link>user.php?do=moderate</link>
</navoption>

does not exist anywhere in the file ROOT/forums/includes/xml/cpnav_vbulletin.xml

(The instructions say I should ad code below that - but it is nowhere to be found)

[sabret00the]

yes but



does not exist anywhere in the file ROOT/forums/includes/xml/cpnav_vbulletin.xml

(The instructions say I should ad code below that - but it is nowhere to be found)
sorry i misread your post and updated my post above yours.

look in the file for "<phrase>moderate_users</phrase>" and then you'll just add what i tell you to after the proceeding "</navoption>"

[KrisP]

When I run the installer I get:

Warning: require_once() [function.require-once]: Unable to access ./global.php in /customers/thegame-online.dk/thegame-online.dk/httpd.www/groups/tools/grps_installer.php on line 36

Warning: require_once(./global.php) [function.require-once]: failed to open stream: No such file or directory in /customers/thegame-online.dk/thegame-online.dk/httpd.www/groups/tools/grps_installer.php on line 36

Fatal error: require_once() [function.require]: Failed opening required './global.php' (include_path='.:') in /customers/thegame-online.dk/thegame-online.dk/httpd.www/groups/tools/grps_installer.php on line 36

[KrisP]

Looks like it cant access the folders or something - has it to do with chmod ?

Have installed everything in the root so I didnt change config_grps.php "chdir("../forums/");" - if thats correct

[Merriweather]

There appears to be something wrong here, in that when you delete a post the option is to "Physically Remove This Message" or "Do Not Delete Message". Could you be using an old template?

http://img243.imageshack.us/img243/5784/grpseditpostdeleteyi4.th.jpg (http://img243.imageshack.us/my.php?image=grpseditpostdeleteyi4.jpg)All of my templates are uncustomized -- how do I get the ost recent, in case mine is old?

[Merriweather]

please upload this to groups/tools/ and then run it as www.yoursite.com/groups/tools/test_stylevars.php?test=posticons

sabe these are my image paths:

http://www.<edit>.com/forums/images/icons/icon1.gif
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
http://www.<edit>.com/forums/images/smilies/icon_question.gif
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
http://www.<edit>.com/forums/images/smilies/icon_down.gif
http://www.<edit>.com/forums/images/smilies/icon_up.gif



But it's trying to pull http://www.<edit>.com/groups/images/icons/icon1.gif no matter WHAT icon was selected when posting, and the post title never shows, though it IS there if you go back to edit the post.

I hope that helps.

[Merriweather]

The not able to post issue is huge right now -- is anyone else having that? It's seemingly random and driving me mad! I think it's tied to a group being set to allow threads to be started by the group leader only. Once that setting on a group was changed, users could post again, but they could not reply to threads that were made when that was enabled.

[sabret00the]

sabe these are my image paths:

http://www.<edit>.com/forums/images/icons/icon1.gif
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
http://www.<edit>.com/forums/images/smilies/icon_question.gif
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
http://www.<edit>.com/forums/images/smilies/icon_down.gif
http://www.<edit>.com/forums/images/smilies/icon_up.gif



But it's trying to pull http://www.<edit>.com/groups/images/icons/icon1.gif no matter WHAT icon was selected when posting, and the post title never shows, though it IS there if you go back to edit the post.

I hope that helps.
what are your string replacements from the GRPS admincp options?

[sabret00the]

All of my templates are uncustomized -- how do I get the ost recent, in case mine is old?
uninstall and reinstall. or just replace the contents with this
$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
$headinclude
<title>$vboptions[hometitle] $vbphrase[grps_groups] - $vbphrase[edit_post]</title>
</head>
<body$onload>
$header
$navbar

<if condition="$show['deletepostoption']">
<form action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$postid" />
<input type="hidden" name="url" value="$url" />
<input type="hidden" name="do" value="deletepost" />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="tcat">
<a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('editpost_delete')"><img id="collapseimg_editpost_delete" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_editpost_delete].gif" alt="" border="0" /></a>
$vbphrase[delete_this_message]
</td>
</tr>
<tbody id="collapseobj_editpost_delete" style="$vbcollapse[collapseobj_editpost_delete]">
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:$stylevar[formwidth]" align="$stylevar[left]">

<div class="fieldset">
<div>$vbphrase[delete_message_check_appropriate_option]</div>
<if condition="$show['firstpostnote']">
<div>$vbphrase[deleting_message_deletion_of_thread]</div>
</if>
</div>

<fieldset class="fieldset">
<legend>$vbphrase[deletion_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<div>
<label for="rb_del_leave"><input type="radio" name="deletepost" value="" id="rb_del_leave" tabindex="1" checked="checked" />$vbphrase[do_not_delete_message]</label>
</div>
<div>
<label for="rb_del_hard"><input type="radio" name="deletepost" value="remove" id="rb_del_hard" tabindex="1" />$vbphrase[physically_remove_message]</label>
</div>
</div>
</fieldset>

<div class="smallfont">
<div>$vbphrase[reason_for_deletion]:</div>
<input type="text" class="bginput" name="reason" size="50" tabindex="1" title="$vbphrase[optional]" />
</div>

</div>
</div>

<div style="margin-top:$stylevar[cellpadding]px">
<input type="submit" class="button" value="$vbphrase[delete_this_message]" tabindex="1" accesskey="d" />
</div>

</td>
</tr>
</tbody>
</table>
</form>
<br />
</if>

$postpreview

<form name="vbform" action="editpost.php" method="post"<if condition="!is_browser('webtv')"> onsubmit="return vB_Editor['$editorid'].prepare_submit(0, $vboptions[postminchars])"</if>>

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="tcat">
<span class="smallfont" style="float:$stylevar[right]"><strong>$vbphrase[grps_group]</strong>: <a href="showthread.php?$session[sessionurl]t=$threadinfo[threadid]">$threadinfo[title]</a></span>
$vbphrase[edit_post]
</td>
</tr>
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:$stylevar[formwidth]" align="$stylevar[left]">

$usernamecode

<!-- edit reason field -->
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /></div>
</div>
<!-- / edit reason field -->

<!-- subject field -->
<table cellpadding="0" cellspacing="0" border="0" style="margin-bottom:$stylevar[formspacer]px">
<tr>
<td class="smallfont" colspan="3">$vbphrase[title]:</td>
</tr>
<tr>
<td><input type="text" class="bginput" name="title" value="$title" size="50" maxlength="85" tabindex="1" title="$vbphrase[optional]" /></td>
<td>&nbsp;&nbsp;</td>
<td><img id="display_posticon" src="$selectedicon[src]" alt="$selectedicon[alt]" /></td>
</tr>
</table>
<!-- / subject field -->

<table cellpadding="0" cellspacing="0" border="0">
<tr>
<td>

<!-- message area -->
<div class="smallfont"><phrase 1="member.php?$session[sessionurl]u=$postinfo[userid]" 2="$postinfo[username]" 3="$postinfo[postdate]" 4="$postinfo[posttime]">$vbphrase[message_by_x_on_y_at_z]</phrase>:</div>
$messagearea
<!-- / message area -->

$posticons

</td>
</tr>
</table>

</div>
</div>

<div style="margin-top:$stylevar[cellpadding]px">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$postid" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="submit" class="button" name="sbutton" id="{$editorid}_save" value="$vbphrase[save_changes]" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="$vbphrase[preview_changes]" accesskey="p" tabindex="1" />
</div>

</td>
</tr>
</table>

<br />

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="tcat">
<a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('newpost_options')"><img id="collapseimg_newpost_options" src="$stylevar[imgdir_button]/collapse_tcat$vbcollapse[collapseimg_newpost_options].gif" alt="" border="0" /></a>
<strong>$vbphrase[additional_options]</strong>
</td>
</tr>
<tbody id="collapseobj_newpost_options" style="$vbcollapse[collapseobj_newpost_options]">
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:$stylevar[formwidth]" align="$stylevar[left]">

<fieldset class="fieldset">
<legend>$vbphrase[miscellaneous_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<if condition="$bbuserinfo['signature'] != ''"><div><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" $checked[signature] />$vbphrase[show_your_signature]</label></div></if>
<div><label for="cb_parseurl"><input type="checkbox" name="parseurl" value="1" id="cb_parseurl" tabindex="1" $checked[parseurl] />$vbphrase[automatically_parse_links_in_text]</label></div>
$disablesmiliesoption
</div>
</fieldset>

$threadmanagement

</div>
</div>

<div style="margin-top:$stylevar[cellpadding]px">
<input type="submit" class="button" name="sbutton" value="$vbphrase[save_changes]" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="$vbphrase[preview_changes]" accesskey="p" tabindex="1" />
</div>
</td>
</tr>
</tbody>
</table>

</form>

<br />

$forumrules

$footer

</body>
</html>

But i would suggest you unistall and reinstall because this isn't your first issue where the templates haven't updated correctly.

[sabret00the]

The not able to post issue is huge right now -- is anyone else having that? It's seemingly random and driving me mad! I think it's tied to a group being set to allow threads to be started by the group leader only. Once that setting on a group was changed, users could post again, but they could not reply to threads that were made when that was enabled.
i need slightly more info than this. what error are they getting? where is this happening?

[sabret00the]

Looks like it cant access the folders or something - has it to do with chmod ?

Have installed everything in the root so I didnt change config_grps.php "chdir("../forums/");" - if thats correct

nope, your config should chdir('../');

[Merriweather]

what are your string replacements from the GRPS admincp options?

To find:

image.php, src="images/smilies/, src="customavatars/, member.php, private.php, search.php, sendmessage.php, profile.php, <!-- / post #, imwindow,400,200); return false;">, images/avatars/

To replace:

$vbulletin->options['bburl']/image.php, src="$vbulletin->options['bburl']/images/smilies/, src="$vbulletin->options['bburl']/customavatars/, $vbulletin->options['bburl']/member.php, $vbulletin->options['bburl']/private.php, $vbulletin->options['bburl']/search.php, $vbulletin->options['bburl']/sendmessage.php, $vbulletin->options['bburl']/profile.php, <hr style="visibility: hidden; padding: 0.25em 0 0 0; margin: 0; line-height: 0em" />{\n\n}<!-- / post #, grps_imwindow,400,200,'$vbulletin->options['bburl']'); return false;">, $vbulletin->options['bburl']/images/avatars/

[Merriweather]

i need slightly more info than this. what error are they getting? where is this happening?

I've posted it twice. I will have to find it again, it's a page or two back.

[sabret00the]

The posts are not deleted. Let's see... you start at viewthread.php, then you click "Edit" on the post which takes you to editpost.php?do=editpost&p=72 (where 72 is the post id, of course). From there you click the radio for "Delete Message" then click the "Delete this Message" button and you're taken to the error I posted, which is a url of viewthread.php?g=0.

Hope that helps.

A lot of my users are also getting this error when posting:
due to the fact i can't replicate this or even understand why it's fail for that matter, i can only say arbitrarily fixed it.

[Merriweather]

uninstall and reinstall. or just replace the contents with this

<snip>

But i would suggest you unistall and reinstall because this isn't your first issue where the templates haven't updated correctly.this is a really dumb question, but is it that the templates are updating the default vB style and not the custom one I use?

[Merriweather]

Sweet lord it worked. I used the template you posted above and it's fine. I am so sorry, but I don't get why my templates aren't updating when I reinstall the product????

[Merriweather]

due to the fact i can't replicate this or even understand why it's fail for that matter, i can only say arbitrarily fixed it.Are you referring to the posting error?

[sabret00the]

To find:

image.php, src="images/smilies/, src="customavatars/, member.php, private.php, search.php, sendmessage.php, profile.php, <!-- / post #, imwindow,400,200); return false;">, images/avatars/

To replace:

$vbulletin->options['bburl']/image.php, src="$vbulletin->options['bburl']/images/smilies/, src="$vbulletin->options['bburl']/customavatars/, $vbulletin->options['bburl']/member.php, $vbulletin->options['bburl']/private.php, $vbulletin->options['bburl']/search.php, $vbulletin->options['bburl']/sendmessage.php, $vbulletin->options['bburl']/profile.php, <hr style="visibility: hidden; padding: 0.25em 0 0 0; margin: 0; line-height: 0em" />{\n\n}<!-- / post #, grps_imwindow,400,200,'$vbulletin->options['bburl']'); return false;">, $vbulletin->options['bburl']/images/avatars/
can you please post your viewthread.php and the entire html source of your viewthread in a thread where you're having this icon problem please.

[sabret00the]

Are you referring to the posting error?
indeed.

[sabret00the]

Sweet lord it worked. I used the template you posted above and it's fine. I am so sorry, but I don't get why my templates aren't updating when I reinstall the product????
i have no idea, are you caching templates at all?

[sabret00the]

this is a really dumb question, but is it that the templates are updating the default vB style and not the custom one I use?
i honestly have no idea. they should update in your master style (default vBulletin) and all child styles. when you click user to override installation, do you see it rebuild styles?

[Merriweather]

can you please post your viewthread.php and the entire html source of your viewthread in a thread where you're having this icon problem please.Every single thread has this problem. Maybe its another template issue?

viewthread.php

<?php

/*****************************\
* Name: GRPS: Groups Commune
* Written By: Paul "sabret00the" Walker-Daley
* Concept: 30 October 2003
* Spawned: 26 March 2005
* Copyright Since: 23 April 2004
* Gold: 19 October 2006
* Modified: 07 November 2006
* Contact: sabe@ebslive.com
\*****************************/

// ################ SET SCRIPT LOCATION ENVIRONMENT ######################
require_once('./includes/config_grps.php');

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NO_REGISTER_GLOBALS', 1);
define('THIS_SCRIPT', 'groupsdiscussion');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
$globaltemplates = array(
'GROUPS',
'groups_display',
'groups_display_main',
'groups_display_member',
'groups_display_memberbit',
'groups_display_post',
'groups_display_viewthread',
'groups_navbar',
'groups_viewthread_postbit',
'groups_viewthread_quickreply',
'bbcode_code',
'bbcode_html',
'bbcode_php',
'bbcode_quote',
'editor_clientscript',
'editor_jsoptions_font',
'editor_jsoptions_size',
'im_aim',
'im_icq',
'im_msn',
'im_yahoo',
'navbar',
'postbit',
'postbit_deleted',
'postbit_legacy',
'postbit_ip',
'postbit_onlinestatus',
'postbit_reputation',
'postbit_wrapper',
'showthread_quickreply',
);

// get special phrase groups
$phrasegroups = array('grps', 'postbit', 'posting', 'showthread');

// ######################### REQUIRE BACK-END ############################
require_once("./global.php");
require_once(DIR . '/includes/functions_grps.php');
require_once(DIR . '/includes/functions_bigthree.php');
require_once(DIR . '/includes/class_postbit.php');
require_once(DIR . '/includes/class_grps.php');
$parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

// ################################################## #####################
// ######################## START MAIN SCRIPT ############################
// ################################################## #####################

($hook = vBulletinHook::fetch_hook('grps_global_start')) ? eval($hook) : false;

$navbits = array();
$navbits[''] = $vbphrase['grps_groups'];
$navbits = construct_navbits($navbits);

// pre-cache templates used by all actions
$globaltemplates = array();

// globalize variables
$vbulletin->input->clean_array_gpc('r', array(
'page' => TYPE_INT,
'perpage' => TYPE_INT,
'pagenumber' => TYPE_INT,
'do' => TYPE_STR,
'view' => TYPE_STR,
'g' => TYPE_INT,
't' => TYPE_INT,
'goto' => TYPE_STR,
));

if (!$vbulletin->GPC['g'])
{ // make sure theirs a groupid
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['g']))
{ // make sure it's a number
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!$vbulletin->GPC['t'])
{ // make sure theirs a groupid
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['t']))
{ // make sure it's a number
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

$threadid = intval($vbulletin->GPC['t']);

$groupid = intval($vbulletin->GPC['g']);
$grps_ids = explode(' ', trim($vbulletin->userinfo['grps']));
$show['grps_wordjoin'] = (in_array($groupid, $grps_ids)) ? TRUE : FALSE;
$show['grps_is_member'] = $show['grps_wordjoin'];
$pagenav = FALSE;

// ################################################## ############################
// ####################### HANDLE HEADER() CALLS ################################
// ################################################## ############################

// let's define the page number
if ($vbulletin->GPC['goto'])
{
$grps_numberofposts = $db->query_first("
SELECT COUNT(*) AS posttotal
FROM grps_post
WHERE visible != 0 AND groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . "
");

$whatpage = floor($grps_numberofposts['posttotal'] / $vbulletin->options['grpspostsperpage']);
if ($whatpage > 1)
{
$gotopage = "&amp;page=" . $whatpage;
}
else
{
$gotopage = FALSE;
}
}

switch($vbulletin->GPC['goto'])
{
case 'lastpost':
$getlastpost = $db->query_first("
SELECT MAX(postid) AS postid
FROM grps_post AS post
WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . "
LIMIT 1
");

if ($getlastpost['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getlastpost['postid']);
}
break;
case 'newpost':
$newpost = $db->query_first("
SELECT MIN(postid) AS postid
FROM grps_post
WHERE groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . " AND dateline > " . $vbulletin->userinfo['lastvisit'] . "
LIMIT 1
");

if ($newpost['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $newpost['postid']);
}
else
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
}
break;
case 'mylastreply':
$getmylastreply = $db->query_first("
SELECT MAX(postid) AS postid
FROM grps_post AS post
WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . " AND userid = " . intval($vbulletin->userinfo['userid']) . "
LIMIT 1
");

if ($getmylastreply['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getmylastreply['postid']);
}
else
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
}
break;
}
// end switch($goto)

// ###################### extracts info for grps groups page
// ###################### query for group info
$grps_showgroup = $db->query_first("
SELECT grps.groupid, grps.title, grps.description, grps.approved, grps.create_date, grps.leaderid, user.username AS leadername, grps_categories.catid, grps_categories.title AS catname, grps_setting.image_name, grps_setting.private_posts, grps_setting.moderate_members, grps_setting.hidden_group, grps_setting.hide_image, grps_setting.edit_details, grps_setting.leaderonly_threads, grps_grouptext.pagetext AS spew, grps_grouptext.edit_reason, grps_grouptext.edit_dateline, grps_grouptext.edit_username
FROM grps_post
LEFT JOIN grps_setting ON (grps_setting.groupid = grps_post.groupid)
LEFT JOIN grps ON (grps.groupid = grps_setting.groupid)
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps.leaderid)
LEFT JOIN grps_grouptext ON (grps_grouptext.groupid = grps.groupid)
LEFT JOIN grps_categories ON (grps_categories.catid = grps.catid)
WHERE grps.groupid = $groupid
GROUP BY grps.groupid
ORDER BY grps.groupid DESC
");

$totalposts = $db->query_first("SELECT COUNT(*) AS totalposts FROM grps_post WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']));
$grps_showgroup = array_merge($grps_showgroup, $totalposts);

$grps_pagetitle = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']);
$grps_html_title = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']) . ' - ' . $grps_showgroup['catname'] . ' - ';
$grps_showgroup = grps_getgroupsettings($grps_showgroup);
$show['leaderoptions'] = ($grps_showgroup['leaderid'] == $vbulletin->userinfo['userid']) ? TRUE : FALSE;

// ###################### query for newest members
$grps_newestmembers = grps_getmembers($groupid, 0, 5);
$grps_memberbits = grps_getmemberbits($grps_newestmembers, 5);
$grps_members = '';
$page = FALSE;

eval("\$grps_members .= \"".fetch_template("groups_display_member")."\";");


// ###################### no permission if not a member

$privacy_override = (!empty($vbulletin->options['grps_admins_see_private_content']) AND ($vbulletin->userinfo['permissions']['grpspermissions'] & $vbulletin->bf_ugp_grpspermissions['groupsmoderator'])) ? TRUE : FALSE;

if($grps_showgroup['private_posts'] AND !in_array($grps_showgroup['groupid'], $grps_ids) AND !$privacy_override)
{
print_no_permission();
}

// ###################### pagenav
$page = ($page < 1) ? 1 : intval($page);
$totalposts = $grps_showgroup['totalposts'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid;
$perpage = intval($vbulletin->options['grpspostsperpage']); //lower limit
$pagenumber = $page;
$upperlimit = ($page * $perpage);
$final_calculations = ($upperlimit - $perpage);

// ###################### query for latest posts
$grps_thread = $db->query_first("
SELECT grps_thread.threadid, grps_thread.groupid, grps_thread.userid, grps_thread.username, grps_thread.title, grps_thread.dateline, grps_thread.iconid, grps_thread.lastposterid, user.username AS lastposterusername, grps_thread.lastpostdateline, grps_thread.replies, grps_thread.firstpostid, grps_thread.closed, grps_thread.stuck
FROM grps_thread
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps_thread.lastposterid)
WHERE grps_thread.threadid = $threadid
LIMIT 1
");

$grps_pagetitle = stripslashes($grps_thread['title']);
$grps_pageextras = ($grps_thread['stuck']) ? "<div style=\"text-align: center; font-weight: bold;\">" . $vbphrase['grps_pinned_thread'] . " <img class=\"inlineimg\" src=\"" . $stylevar['imgdir_misc'] . "/sticky.gif\" alt=\"" . $vbphrase['sticky_thread'] . "\" /></div>" : FALSE;

// creates the pagenav
$page = ($vbulletin->GPC['page'] < 1) ? "1" : intval($vbulletin->GPC['page']);
$totalposts = $db->query_first("SELECT COUNT(postid) AS total FROM grps_post WHERE threadid = $threadid");
$totalposts = $totalposts['total'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . "&amp;t=" . $threadid;
$perpage = 25;
$pagenumber = $page;
$lowerlimit = ($page * $perpage);
$query_lowerlimit = ($lowerlimit - $perpage);

$grps_html_title = stripslashes($grps_thread['title']) . (($vbulletin->GPC['page'] < 1) ? '' : ' (' . $page . ')') . ' - ' . $grps_html_title;

// ###################### query for posts
$posts = $db->query_read("
SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN " . TABLE_PREFIX . "user u ON (u.userid = grps_post.userid)
LEFT JOIN " . TABLE_PREFIX . "userfield uf ON (uf.userid = u.userid)
LEFT JOIN " . TABLE_PREFIX . "usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN " . TABLE_PREFIX . "icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN " . TABLE_PREFIX . "avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN " . TABLE_PREFIX . "customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = $groupid and grps_post.threadid = $threadid
ORDER BY grps_post.dateline ASC
LIMIT $query_lowerlimit, $perpage
");

$grps_showgroup['allowposting'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;
$grps_thread['open'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;

$postbits = '';
$show['spacer'] = FALSE;
$show['warning'] = FALSE;

//$vbulletin->options['legacypostbit'] = (empty($vbulletin->options['grps_legacypostbit'])) ? 0 : 1;

$ignore = explode(' ', $vbulletin->userinfo['ignorelist']);

$postbit = '';
$postbit_factory =& new vB_Postbit_Factory();
$postbit_factory->registry =& $vbulletin;
$postbit_factory->forum =& $grps_showgroup;
$postbit_factory->thread =& $grps_thread;
$postbit_factory->cache = array();
$postbit_factory->bbcode_parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

$cell = 0;

while ($post = $db->fetch_array($posts))
{
if ($tachyuser = in_coventry($post['userid']))
{
$fetchtype = 'post_global_ignore';
}
else if (isset($ignore[$post['userid']]))
{
$fetchtype = 'post_ignore';
}
else if ($post['visible'] == 2)# OR ($thread['visible'] == 2 AND $postcount == 1))
{
$fetchtype = 'post_deleted';
}
else
{
$fetchtype = 'post';
}

$postbit_obj =& $postbit_factory->fetch_postbit($fetchtype);

$postbit .= $postbit_obj->construct_postbit($post);

$cell++;

} //got all that info

// let's rewrite the postbit links and make the images work
$vbulletin->options['grps_viewthreadfind'] = str_replace(
array(
'$stylevar[\'imgdir_button\']',
'$vbulletin->options[\'bburl\']',
'$vbulletin->options[\'homeurl\']',
'{\n\n}'
),
array(
$stylevar['imgdir_button'],
$vbulletin->options['bburl'],
$vbulletin->options['homeurl'],
'' . "\n\n" . ''
),
$vbulletin->options['grps_viewthreadfind']);

$vbulletin->options['grps_viewthreadreplace'] = str_replace(
array(
'$stylevar[\'imgdir_button\']',
'$vbulletin->options[\'bburl\']',
'$vbulletin->options[\'homeurl\']',
'{\n\n}'
),
array(
$stylevar['imgdir_button'],
$vbulletin->options['bburl'],
$vbulletin->options['homeurl'],
'' . "\n\n" . ''
),
$vbulletin->options['grps_viewthreadreplace']);

$viewthread = array(
'find' => explode(', ', $vbulletin->options['grps_viewthreadfind']),
'replace' => explode(', ', $vbulletin->options['grps_viewthreadreplace'])
);

$postbit = str_replace($viewthread['find'], $viewthread['replace'], $postbit);

// ************************************************** *******************************
$show['quickreply'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed'] AND $vbulletin->options['quickreply']) ? TRUE : FALSE;
// ************************************************** *******************************

// build quick reply if appropriate
if ($show['quickreply'])
{
require_once(DIR . '/includes/functions_editor.php');

$forum = array();

$show['wysiwyg'] = ($forum['allowbbcode'] = TRUE) ? is_wysiwyg_compatible() : 0;
$istyles_js = construct_editor_styles_js();

// set show signature hidden field
$showsig = ($vbulletin->userinfo['signature']) ? 1 : 0;
$vbulletin->options['quickreply'] = 1;
$threadedmode = FALSE;
$qrpostid = 'who cares';
$effective_lastpost = FALSE;

$show['qr_require_click'] = 0;
$show['threadedmode'] = 0;

// temporarily?
$threadedmode = 0;
$show['allow_ajax_qr'] = 0;
// end temp

$editorid = construct_edit_toolbar('', 0, $foruminfo['forumid'], ($foruminfo['allowsmilies'] ? 1 : 0), 1, false, 'qr');
$messagearea = "
<script type=\"text/javascript\">
<!--
var threaded_mode = $threadedmode;
var require_click = $show[qr_require_click];
var is_last_page = $show[allow_ajax_qr]; // leave for people with cached JS files
var allow_ajax_qr = $show[allow_ajax_qr];
var ajax_last_post = " . intval($effective_lastpost) . ";
// -->
</script>
$messagearea
";

if (is_browser('mozilla') AND $show['wysiwyg'] == 2)
{
// Mozilla WYSIWYG can't have the QR collapse button,
// so remove that and force QR to be expanded
$show['quickreply_collapse'] = false;

unset(
$vbcollapse["collapseobj_quickreply"],
$vbcollapse["collapseimg_quickreply"],
$vbcollapse["collapsecel_quickreply"]
);
}
else
{
$show['quickreply_collapse'] = true;
}
}
else if ($show['ajax_js'])
{
require_once(DIR . '/includes/functions_editor.php');

$vBeditJs = construct_editor_js_arrays();
eval('$vBeditTemplate[\'clientscript\'] = "' . fetch_template('editor_clientscript') . '";');
}

$show['quickedit'] = ($vbulletin->options['quickedit'] AND !$show['threadedmode']);

$vBeditTemplate['clientscript'] = str_replace('="clientscript', '="' . $vbulletin->options['bburl'] . '/clientscript', $vBeditTemplate['clientscript']);

// ###################### query for number of new posts
$grps_newpoststext = grps_newgroupposts($groupid);
$grps_moderation = display_mod_options($grps_thread, $grps_showgroup);

eval("\$grps_mainspace = \"".fetch_template("groups_display_viewthread")."\";");
eval("\$grps_main = \"".fetch_template("groups_display_main")."\";");

$pagenav = construct_page_nav($pagenumber, $perpage, $totalposts, 'viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $threadid, '' . (!empty($vbulletin->GPC['perpage']) ? '&amp;pp=' . $perpage : '') . '');
// draw nav bar
$navbits = array();
$navbits['browse.php?' . $vbulletin->session->vars['sessionurl'] . 'c=' . $grps_showgroup['catid']] = $grps_showgroup['catname'];
$navbits['groups.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $grps_showgroup['groupid']] = $grps_showgroup['title'];
$navbits[''] = stripslashes($grps_thread['title']);
$navbits = construct_navbits($navbits);

//handles the rest of the page and layout.
eval('$grps_navbar = "' . fetch_template('groups_navbar') . '";');
eval('$headinclude = "' . fetch_template('headinclude') . '";');
$headinclude = grps_rewrite_links($headinclude);
eval('$navbar = "' . fetch_template('navbar') . '";');
$navbar = grps_rewrite_links($navbar);
eval('$footer = "' . fetch_template('footer') . '";');
$footer = grps_rewrite_links($footer);
($hook = vBulletinHook::fetch_hook('grps_global_complete')) ? eval($hook) : false;

$final_template= 'groups_display';
eval("print_output(\"".fetch_template($final_template)."\");");

?>

PMing you the source as it has links to my board in it.

[Merriweather]

i have no idea, are you caching templates at all?I don't tihnk so, but I don't know how to check, either.

[Merriweather]

i honestly have no idea. they should update in your master style (default vBulletin) and all child styles. when you click user to override installation, do you see it rebuild styles?Yep.

[sabret00the]

Every single thread has this problem. Maybe its another template issue?

viewthread.php

<?php

/*****************************\
* Name: GRPS: Groups Commune
* Written By: Paul "sabret00the" Walker-Daley
* Concept: 30 October 2003
* Spawned: 26 March 2005
* Copyright Since: 23 April 2004
* Gold: 19 October 2006
* Modified: 07 November 2006
* Contact: sabe@ebslive.com
\*****************************/

// ################ SET SCRIPT LOCATION ENVIRONMENT ######################
require_once('./includes/config_grps.php');

// ####################### SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);

// #################### DEFINE IMPORTANT CONSTANTS #######################
define('NO_REGISTER_GLOBALS', 1);
define('THIS_SCRIPT', 'groupsdiscussion');

// ################### PRE-CACHE TEMPLATES AND DATA ######################
$globaltemplates = array(
'GROUPS',
'groups_display',
'groups_display_main',
'groups_display_member',
'groups_display_memberbit',
'groups_display_post',
'groups_display_viewthread',
'groups_navbar',
'groups_viewthread_postbit',
'groups_viewthread_quickreply',
'bbcode_code',
'bbcode_html',
'bbcode_php',
'bbcode_quote',
'editor_clientscript',
'editor_jsoptions_font',
'editor_jsoptions_size',
'im_aim',
'im_icq',
'im_msn',
'im_yahoo',
'navbar',
'postbit',
'postbit_deleted',
'postbit_legacy',
'postbit_ip',
'postbit_onlinestatus',
'postbit_reputation',
'postbit_wrapper',
'showthread_quickreply',
);

// get special phrase groups
$phrasegroups = array('grps', 'postbit', 'posting', 'showthread');

// ######################### REQUIRE BACK-END ############################
require_once("./global.php");
require_once(DIR . '/includes/functions_grps.php');
require_once(DIR . '/includes/functions_bigthree.php');
require_once(DIR . '/includes/class_postbit.php');
require_once(DIR . '/includes/class_grps.php');
$parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

// ################################################## #####################
// ######################## START MAIN SCRIPT ############################
// ################################################## #####################

($hook = vBulletinHook::fetch_hook('grps_global_start')) ? eval($hook) : false;

$navbits = array();
$navbits[''] = $vbphrase['grps_groups'];
$navbits = construct_navbits($navbits);

// pre-cache templates used by all actions
$globaltemplates = array();

// globalize variables
$vbulletin->input->clean_array_gpc('r', array(
'page' => TYPE_INT,
'perpage' => TYPE_INT,
'pagenumber' => TYPE_INT,
'do' => TYPE_STR,
'view' => TYPE_STR,
'g' => TYPE_INT,
't' => TYPE_INT,
'goto' => TYPE_STR,
));

if (!$vbulletin->GPC['g'])
{ // make sure theirs a groupid
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['g']))
{ // make sure it's a number
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_group'], $vbulletin->options['contactuslink'])));
}

if (!$vbulletin->GPC['t'])
{ // make sure theirs a groupid
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

if (!intval($vbulletin->GPC['t']))
{ // make sure it's a number
eval(standard_error(fetch_error('invalidid', $vbphrase['grps_thread'], $vbulletin->options['contactuslink'])));
}

$threadid = intval($vbulletin->GPC['t']);

$groupid = intval($vbulletin->GPC['g']);
$grps_ids = explode(' ', trim($vbulletin->userinfo['grps']));
$show['grps_wordjoin'] = (in_array($groupid, $grps_ids)) ? TRUE : FALSE;
$show['grps_is_member'] = $show['grps_wordjoin'];
$pagenav = FALSE;

// ################################################## ############################
// ####################### HANDLE HEADER() CALLS ################################
// ################################################## ############################

// let's define the page number
if ($vbulletin->GPC['goto'])
{
$grps_numberofposts = $db->query_first("
SELECT COUNT(*) AS posttotal
FROM grps_post
WHERE visible != 0 AND groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . "
");

$whatpage = floor($grps_numberofposts['posttotal'] / $vbulletin->options['grpspostsperpage']);
if ($whatpage > 1)
{
$gotopage = "&amp;page=" . $whatpage;
}
else
{
$gotopage = FALSE;
}
}

switch($vbulletin->GPC['goto'])
{
case 'lastpost':
$getlastpost = $db->query_first("
SELECT MAX(postid) AS postid
FROM grps_post AS post
WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . "
LIMIT 1
");

if ($getlastpost['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getlastpost['postid']);
}
break;
case 'newpost':
$newpost = $db->query_first("
SELECT MIN(postid) AS postid
FROM grps_post
WHERE groupid = $groupid AND threadid = " . intval($vbulletin->GPC['t']) . " AND dateline > " . $vbulletin->userinfo['lastvisit'] . "
LIMIT 1
");

if ($newpost['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $newpost['postid']);
}
else
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
}
break;
case 'mylastreply':
$getmylastreply = $db->query_first("
SELECT MAX(postid) AS postid
FROM grps_post AS post
WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']) . " AND userid = " . intval($vbulletin->userinfo['userid']) . "
LIMIT 1
");

if ($getmylastreply['postid'])
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . $gotopage . '#post' . $getmylastreply['postid']);
}
else
{
exec_header_redirect('viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $vbulletin->GPC['t'] . '&amp;goto=lastpost');
}
break;
}
// end switch($goto)

// ###################### extracts info for grps groups page
// ###################### query for group info
$grps_showgroup = $db->query_first("
SELECT grps.groupid, grps.title, grps.description, grps.approved, grps.create_date, grps.leaderid, user.username AS leadername, grps_categories.catid, grps_categories.title AS catname, grps_setting.image_name, grps_setting.private_posts, grps_setting.moderate_members, grps_setting.hidden_group, grps_setting.hide_image, grps_setting.edit_details, grps_setting.leaderonly_threads, grps_grouptext.pagetext AS spew, grps_grouptext.edit_reason, grps_grouptext.edit_dateline, grps_grouptext.edit_username
FROM grps_post
LEFT JOIN grps_setting ON (grps_setting.groupid = grps_post.groupid)
LEFT JOIN grps ON (grps.groupid = grps_setting.groupid)
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps.leaderid)
LEFT JOIN grps_grouptext ON (grps_grouptext.groupid = grps.groupid)
LEFT JOIN grps_categories ON (grps_categories.catid = grps.catid)
WHERE grps.groupid = $groupid
GROUP BY grps.groupid
ORDER BY grps.groupid DESC
");

$totalposts = $db->query_first("SELECT COUNT(*) AS totalposts FROM grps_post WHERE groupid = " . intval($groupid) . " AND threadid = " . intval($vbulletin->GPC['t']));
$grps_showgroup = array_merge($grps_showgroup, $totalposts);

$grps_pagetitle = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']);
$grps_html_title = construct_phrase($vbphrase['grps_x_discussion'], $grps_showgroup['title']) . ' - ' . $grps_showgroup['catname'] . ' - ';
$grps_showgroup = grps_getgroupsettings($grps_showgroup);
$show['leaderoptions'] = ($grps_showgroup['leaderid'] == $vbulletin->userinfo['userid']) ? TRUE : FALSE;

// ###################### query for newest members
$grps_newestmembers = grps_getmembers($groupid, 0, 5);
$grps_memberbits = grps_getmemberbits($grps_newestmembers, 5);
$grps_members = '';
$page = FALSE;

eval("\$grps_members .= \"".fetch_template("groups_display_member")."\";");


// ###################### no permission if not a member

$privacy_override = (!empty($vbulletin->options['grps_admins_see_private_content']) AND ($vbulletin->userinfo['permissions']['grpspermissions'] & $vbulletin->bf_ugp_grpspermissions['groupsmoderator'])) ? TRUE : FALSE;

if($grps_showgroup['private_posts'] AND !in_array($grps_showgroup['groupid'], $grps_ids) AND !$privacy_override)
{
print_no_permission();
}

// ###################### pagenav
$page = ($page < 1) ? 1 : intval($page);
$totalposts = $grps_showgroup['totalposts'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid;
$perpage = intval($vbulletin->options['grpspostsperpage']); //lower limit
$pagenumber = $page;
$upperlimit = ($page * $perpage);
$final_calculations = ($upperlimit - $perpage);

// ###################### query for latest posts
$grps_thread = $db->query_first("
SELECT grps_thread.threadid, grps_thread.groupid, grps_thread.userid, grps_thread.username, grps_thread.title, grps_thread.dateline, grps_thread.iconid, grps_thread.lastposterid, user.username AS lastposterusername, grps_thread.lastpostdateline, grps_thread.replies, grps_thread.firstpostid, grps_thread.closed, grps_thread.stuck
FROM grps_thread
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = grps_thread.lastposterid)
WHERE grps_thread.threadid = $threadid
LIMIT 1
");

$grps_pagetitle = stripslashes($grps_thread['title']);
$grps_pageextras = ($grps_thread['stuck']) ? "<div style=\"text-align: center; font-weight: bold;\">" . $vbphrase['grps_pinned_thread'] . " <img class=\"inlineimg\" src=\"" . $stylevar['imgdir_misc'] . "/sticky.gif\" alt=\"" . $vbphrase['sticky_thread'] . "\" /></div>" : FALSE;

// creates the pagenav
$page = ($vbulletin->GPC['page'] < 1) ? "1" : intval($vbulletin->GPC['page']);
$totalposts = $db->query_first("SELECT COUNT(postid) AS total FROM grps_post WHERE threadid = $threadid");
$totalposts = $totalposts['total'];
$currentlocation = "viewthread.php?" . $vbulletin->session->vars['sessionurl'] . "g=" . $groupid . "&amp;t=" . $threadid;
$perpage = 25;
$pagenumber = $page;
$lowerlimit = ($page * $perpage);
$query_lowerlimit = ($lowerlimit - $perpage);

$grps_html_title = stripslashes($grps_thread['title']) . (($vbulletin->GPC['page'] < 1) ? '' : ' (' . $page . ')') . ' - ' . $grps_html_title;

// ###################### query for posts
$posts = $db->query_read("
SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN " . TABLE_PREFIX . "user u ON (u.userid = grps_post.userid)
LEFT JOIN " . TABLE_PREFIX . "userfield uf ON (uf.userid = u.userid)
LEFT JOIN " . TABLE_PREFIX . "usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN " . TABLE_PREFIX . "icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN " . TABLE_PREFIX . "avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN " . TABLE_PREFIX . "customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = $groupid and grps_post.threadid = $threadid
ORDER BY grps_post.dateline ASC
LIMIT $query_lowerlimit, $perpage
");

$grps_showgroup['allowposting'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;
$grps_thread['open'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed']) ? TRUE : FALSE;

$postbits = '';
$show['spacer'] = FALSE;
$show['warning'] = FALSE;

//$vbulletin->options['legacypostbit'] = (empty($vbulletin->options['grps_legacypostbit'])) ? 0 : 1;

$ignore = explode(' ', $vbulletin->userinfo['ignorelist']);

$postbit = '';
$postbit_factory =& new vB_Postbit_Factory();
$postbit_factory->registry =& $vbulletin;
$postbit_factory->forum =& $grps_showgroup;
$postbit_factory->thread =& $grps_thread;
$postbit_factory->cache = array();
$postbit_factory->bbcode_parser =& new vB_BbCodeParser($vbulletin, fetch_tag_list());

$cell = 0;

while ($post = $db->fetch_array($posts))
{
if ($tachyuser = in_coventry($post['userid']))
{
$fetchtype = 'post_global_ignore';
}
else if (isset($ignore[$post['userid']]))
{
$fetchtype = 'post_ignore';
}
else if ($post['visible'] == 2)# OR ($thread['visible'] == 2 AND $postcount == 1))
{
$fetchtype = 'post_deleted';
}
else
{
$fetchtype = 'post';
}

$postbit_obj =& $postbit_factory->fetch_postbit($fetchtype);

$postbit .= $postbit_obj->construct_postbit($post);

$cell++;

} //got all that info

// let's rewrite the postbit links and make the images work
$vbulletin->options['grps_viewthreadfind'] = str_replace(
array(
'$stylevar[\'imgdir_button\']',
'$vbulletin->options[\'bburl\']',
'$vbulletin->options[\'homeurl\']',
'{\n\n}'
),
array(
$stylevar['imgdir_button'],
$vbulletin->options['bburl'],
$vbulletin->options['homeurl'],
'' . "\n\n" . ''
),
$vbulletin->options['grps_viewthreadfind']);

$vbulletin->options['grps_viewthreadreplace'] = str_replace(
array(
'$stylevar[\'imgdir_button\']',
'$vbulletin->options[\'bburl\']',
'$vbulletin->options[\'homeurl\']',
'{\n\n}'
),
array(
$stylevar['imgdir_button'],
$vbulletin->options['bburl'],
$vbulletin->options['homeurl'],
'' . "\n\n" . ''
),
$vbulletin->options['grps_viewthreadreplace']);

$viewthread = array(
'find' => explode(', ', $vbulletin->options['grps_viewthreadfind']),
'replace' => explode(', ', $vbulletin->options['grps_viewthreadreplace'])
);

$postbit = str_replace($viewthread['find'], $viewthread['replace'], $postbit);

// ************************************************** *******************************
$show['quickreply'] = ($vbulletin->userinfo['userid'] AND in_array($grps_showgroup['groupid'], $grps_ids) AND !$grps_thread['closed'] AND $vbulletin->options['quickreply']) ? TRUE : FALSE;
// ************************************************** *******************************

// build quick reply if appropriate
if ($show['quickreply'])
{
require_once(DIR . '/includes/functions_editor.php');

$forum = array();

$show['wysiwyg'] = ($forum['allowbbcode'] = TRUE) ? is_wysiwyg_compatible() : 0;
$istyles_js = construct_editor_styles_js();

// set show signature hidden field
$showsig = ($vbulletin->userinfo['signature']) ? 1 : 0;
$vbulletin->options['quickreply'] = 1;
$threadedmode = FALSE;
$qrpostid = 'who cares';
$effective_lastpost = FALSE;

$show['qr_require_click'] = 0;
$show['threadedmode'] = 0;

// temporarily?
$threadedmode = 0;
$show['allow_ajax_qr'] = 0;
// end temp

$editorid = construct_edit_toolbar('', 0, $foruminfo['forumid'], ($foruminfo['allowsmilies'] ? 1 : 0), 1, false, 'qr');
$messagearea = "
<script type=\"text/javascript\">
<!--
var threaded_mode = $threadedmode;
var require_click = $show[qr_require_click];
var is_last_page = $show[allow_ajax_qr]; // leave for people with cached JS files
var allow_ajax_qr = $show[allow_ajax_qr];
var ajax_last_post = " . intval($effective_lastpost) . ";
// -->
</script>
$messagearea
";

if (is_browser('mozilla') AND $show['wysiwyg'] == 2)
{
// Mozilla WYSIWYG can't have the QR collapse button,
// so remove that and force QR to be expanded
$show['quickreply_collapse'] = false;

unset(
$vbcollapse["collapseobj_quickreply"],
$vbcollapse["collapseimg_quickreply"],
$vbcollapse["collapsecel_quickreply"]
);
}
else
{
$show['quickreply_collapse'] = true;
}
}
else if ($show['ajax_js'])
{
require_once(DIR . '/includes/functions_editor.php');

$vBeditJs = construct_editor_js_arrays();
eval('$vBeditTemplate[\'clientscript\'] = "' . fetch_template('editor_clientscript') . '";');
}

$show['quickedit'] = ($vbulletin->options['quickedit'] AND !$show['threadedmode']);

$vBeditTemplate['clientscript'] = str_replace('="clientscript', '="' . $vbulletin->options['bburl'] . '/clientscript', $vBeditTemplate['clientscript']);

// ###################### query for number of new posts
$grps_newpoststext = grps_newgroupposts($groupid);
$grps_moderation = display_mod_options($grps_thread, $grps_showgroup);

eval("\$grps_mainspace = \"".fetch_template("groups_display_viewthread")."\";");
eval("\$grps_main = \"".fetch_template("groups_display_main")."\";");

$pagenav = construct_page_nav($pagenumber, $perpage, $totalposts, 'viewthread.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $groupid . '&amp;t=' . $threadid, '' . (!empty($vbulletin->GPC['perpage']) ? '&amp;pp=' . $perpage : '') . '');
// draw nav bar
$navbits = array();
$navbits['browse.php?' . $vbulletin->session->vars['sessionurl'] . 'c=' . $grps_showgroup['catid']] = $grps_showgroup['catname'];
$navbits['groups.php?' . $vbulletin->session->vars['sessionurl'] . 'g=' . $grps_showgroup['groupid']] = $grps_showgroup['title'];
$navbits[''] = stripslashes($grps_thread['title']);
$navbits = construct_navbits($navbits);

//handles the rest of the page and layout.
eval('$grps_navbar = "' . fetch_template('groups_navbar') . '";');
eval('$headinclude = "' . fetch_template('headinclude') . '";');
$headinclude = grps_rewrite_links($headinclude);
eval('$navbar = "' . fetch_template('navbar') . '";');
$navbar = grps_rewrite_links($navbar);
eval('$footer = "' . fetch_template('footer') . '";');
$footer = grps_rewrite_links($footer);
($hook = vBulletinHook::fetch_hook('grps_global_complete')) ? eval($hook) : false;

$final_template= 'groups_display';
eval("print_output(\"".fetch_template($final_template)."\");");

?>

PMing you the source as it has links to my board in it.
ok, can you do me a favour and just go to your postbit template, and then click save and reload then recheck a thread and let me know is the problem still exists.

[Merriweather]

I went to Postbit Templates >> postbit, clicked "Save and Reload", then went back to a thread, reloaded the page.... and still have the same issue.

[sabret00the]

I went to Postbit Templates >> postbit, clicked "Save and Reload", then went back to a thread, reloaded the page.... and still have the same issue.
Just to confirm, this is a problem which all of your users have not just you correct?

[Merriweather]

Hm, let me check.

[Merriweather]

Yes, other members have the same issue. They see the red x where the image is missing, and no post title.

[Merriweather]

Also just found out that a member who joins a group and then gets moved to a usergroup WITHOUT group permissions can still see the group and post to it. Seems like a future bug fix, unless it's just me again. :(

[sabret00the]

Hm, let me check.
can you run this plugin (it's a plugin not a product) and then go to a thread within your groups and let give me the results please.

[Merriweather]

Doing that now.

[Merriweather]

Same as the last one:

sabe these are my image paths:

http://www.<edit>.com/forums/images/icons/icon1.gif
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
http://www.<edit>.com/forums/images/smilies/icon_question.gif
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
http://www.<edit>.com/forums/images/smilies/icon_down.gif
http://www.<edit>.com/forums/images/smilies/icon_up.gif



Are you not having these issues on your site? Are you able to see post icons and thread titles?

[sabret00the]

Same as the last one:

sabe these are my image paths:

http://www.<edit>.com/forums/images/icons/icon1.gif
http://www.<edit>.com/forums/images/smilies/icon_arrow.gif
http://www.<edit>.com/forums/images/smilies/icon_idea.gif
http://www.<edit>.com/forums/images/smilies/icon_exclaim.gif
http://www.<edit>.com/forums/images/smilies/icon_question.gif
http://www.<edit>.com/forums/images/smilies/icon_smile.gif
http://www.<edit>.com/forums/images/smilies/icon_evil.gif
http://www.<edit>.com/forums/images/smilies/icon_sad.gif
http://www.<edit>.com/forums/images/smilies/icon_lol.gif
http://www.<edit>.com/forums/images/smilies/icon_redface.gif
http://www.<edit>.com/forums/images/smilies/icon_wink.gif
http://www.<edit>.com/forums/images/smilies/icon_down.gif
http://www.<edit>.com/forums/images/smilies/icon_up.gif



Are you not having these issues on your site? Are you able to see post icons and thread titles?
nope, this problem seems to be unique to you. can you install this plugin and print the results please. feel free to delete both plugins straight after you've collected the results.

[sabret00the]

oh and here's the patch for the posting problem:

[sabret00the]

do your post icons show up on groups.php?g=ANYGROUP

[Merriweather]

do your post icons show up on groups.php?g=ANYGROUP

Nope.

[Merriweather]

oh and here's the patch for the posting problem:Stupid question -- where do I put it??

[sabret00the]

Nope.
So the only page they appear on is editpost.php?

[sabret00the]

Stupid question -- where do I put it??
forums/includes/

folder.

[Merriweather]

So the only page they appear on is editpost.php?

Yes.

[sabret00the]

Yes.
i'm still trying to figure this out. bare with me.

[sabret00the]

Yes.

can you upload these two to the groups folder please.

and then run:
www.yoursite.com/groups/test_groups.php?g=XX
www.yoursite.com/groups/test_viewthread.php?g=XX&t=YY

please substitute XX and YY for numbers in which icons display or in your case don't, in the normal groups.php and viewthread.php

[Merriweather]

On the posting issue, some users are still getting this database error:

Invalid SQL:

SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid =;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3 Error Number : 1064
Date : Monday, March 5th 2007 @ 01:04:01 PM
Script : http://www.<edit>.com/groups/newreply.php
Referrer : http://www.<edit>.com/groups/newreply.php?do=newreply&t=36
IP Address : <edit>
Username : <edit>
Classname : vb_database

I will do the other tests for you this evening, I have to go for a while.

[Merriweather]

can you upload these two to the groups folder please.

and then run:
www.yoursite.com/groups/test_groups.php?g=XX
www.yoursite.com/groups/test_viewthread.php?g=XX&t=YY

please substitute XX and YY for numbers in which icons display or in your case don't, in the normal groups.php and viewthread.php
test_groups.php just gave this:

=>


test_viewthread.php gave this:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>

[Merriweather]

Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.

[Merriweather]

This whole random inability to post is really troublesome on my forums. It's the same DB error over and over:

Database error in vBulletin 3.6.5:

Invalid SQL:

SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid =;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number : 1064
Date : Monday, March 5th 2007 @ 09:47:35 PM
Script : http://www.<edit>.com/groups/newreply.php
Referrer : http://www.<edit>.com/groups/newreply.php?do=newreply&t=98
IP Address : <edit>
Username : <edit>
Classname : vb_database

We can't find any rhyme or reason for it, but some of my groups, you can only start threads and can't reply to them at all!!!

[sabret00the]

Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.
can i get a screenshot of this one please?

as for the database error, i'm on it

[sabret00the]

This whole random inability to post is really troublesome on my forums. It's the same DB error over and over:



We can't find any rhyme or reason for it, but some of my groups, you can only start threads and can't reply to them at all!!!
can you run this query please and give me the results SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid = 98

[sabret00the]

Another issue users are having is that it's putting HTML in the text entry box if a user previews their post. Seeing as we don't allow HTML in posts on the fourm, it's casuing a problem with formatting.
can i get a screenshot of that because i'm unable to replicate that.

[sabret00the]

test_groups.php just gave this:

=>


test_viewthread.php gave this:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>
And there was DEFINITELY use of posticons on both pages correct?

[sabret00the]

test_groups.php just gave this:

=>


test_viewthread.php gave this:

=>=>=>=>=>=>=>=>=>=>=>=>=>=>
can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC


and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

[Merriweather]

can you run this query please and give me the results SELECT COUNT(*) AS replies
FROM grps_thread
WHERE threadid = 98
Results: 1

[Merriweather]

can i get a screenshot of this one please?I PMed you the screenshot. :)

[Merriweather]

can you please run this query with the same values for which you used XX and YY on the test_viewthread.php please

SELECT grps_post.postid, grps_post.groupid, grps_post.username AS postusername, grps_post.ipaddress AS ip, grps_post.title AS posttitle, grps_post.dateline, grps_post.pagetext, grps_post.iconid, i.title AS icontitle, i.iconpath, grps_post.visible, grps_post.allowsmilie, grps_post.showsignature, grps_post.edit_username, grps_post.edit_userid, grps_post.edit_reason, grps_post.edit_dateline, grps_post.delete_username, grps_post.delete_userid, grps_post.delete_reason, grps.leaderid, u.*, uf.*, utf.*, a.avatarid, a.avatarpath, NOT ISNULL(ca.userid) AS hascustomavatar, ca.dateline AS avatardateline, ca.width AS avwidth, ca.height AS avheight
FROM grps_post
LEFT JOIN grps ON (grps.groupid = grps_post.groupid)
LEFT JOIN user u ON (u.userid = grps_post.userid)
LEFT JOIN userfield uf ON (uf.userid = u.userid)
LEFT JOIN usertextfield utf ON (utf.userid = u.userid)
LEFT JOIN icon i ON (i.iconid = grps_post.iconid) > 0
LEFT JOIN avatar a ON (a.avatarid = u.avatarid)
LEFT JOIN customavatar ca ON (ca.userid = u.userid)
WHERE grps_post.groupid = XX and grps_post.threadid = YY
ORDER BY grps_post.dateline ASC


and please just look for the iconpath column and let me know if it's empty on all counts.

hold on, i think i've figured it out. are you using a default icon on your forums?

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.

[sabret00the]

I am using a default icon. But even if a different icon is selected, it doesn't show.

The results are 0 for all iconids, null for all icontitles and paths. Posttitle is NOT blank for some, but the title doesn't show on the posts.
can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.

[sabret00the]

can i get a screenshot of that because i'm unable to replicate that.
confirmed, it's a problem with the WYSIWYG editor. being worked on now.

[Merriweather]

can you please go to your Admin CP => vBulletin Options => Thread Display Options

and check your default post icon path please.
Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)

[sabret00the]

Adding my full URL there fixed the default (YAY!) but there is still the issue that if you choose a different icon, or enter a title, they don't show. :)
enter a title?

[Merriweather]

enter a title?
Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon. Neither the selected post icon (if you select one) nor the post title (if you enter one) ever show. It only shows the default post icon. It's saving the titles, because I can see them in the DB, but they aren't displayed. I'm not sure about the post icons.

[Merriweather]

Other issues my users have reported:

(1) If a user has no avatar, it shows a red X or missing image placeholder for the user. It should not show anything, or at least some default "missing avatar" placeholder.

(2) When you post to a thread, the page refreshes to the start of page one, instead of where you just posted. So if you post to page five, it bounces you back to page one, and you have to click and scroll to get back where you left off.

(3) The [View My Last Reply] [View New Posts] [View Last Reply] links just take you to the start of the thread.

My own issue is that the system does not seem to check a user's permissions, only if they are a member. So when I had a member join a group, then get changed to a usergroup without group joining privileges, she could still see and post to the group because she was still a member. If the system could check the user against their usergroup permissions to make sure that they have permissions to access the groups, whether or not they are a member or leader of a group would be great. Perhaps a cron job to remove users from groups once their permissions change, even.

[Merriweather]

I've made some progress figuring out this maddening DB error on replying to posts as well as why it takes you to the start of the post and not where you left off. :)

If I click to reply on certain group threads, the HTML source looks like this:

<input type="hidden" name="s" value="" />
<input type="hidden" name="do" value="postreply" />
<input type="hidden" name="t" value="0" />
<input type="hidden" name="p" value="" />
<input type="hidden" name="posthash" value="" />
<input type="hidden" name="poststarttime" value="" />
<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

Obviously, the topicid and postid are missing.

On the ones that work, the source is like this:

<input type="hidden" name="s" value="" />
<input type="hidden" name="do" value="postreply" />
<input type="hidden" name="t" value="47" />
<input type="hidden" name="p" value="" />
<input type="hidden" name="posthash" value="" />
<input type="hidden" name="poststarttime" value="" />
<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

The topicid is there, though the postid is not. This is why I can reply to the post, but it takes me to the start of the thread, and not the post I made, after I submit.

Interestingly, on threads that have no topicid when replying, you CAN quote them -- the topicid gets pulled there. So perhaps an investigation of the code to see what the difference is in pulling the topicid for the quote vs. the new reply will help you solve this?

I will let you know if I figure out any more. :)

[Merriweather]

Another bug -- I deleted a post from a thread, but it still shows the thread as having a reply, which it no longer does. The info block on the right, however, that says "Posts in this Thread" has the correct count.

[sabret00the]

I've made some progress figuring out this maddening DB error on replying to posts as well as why it takes you to the start of the post and not where you left off. :)

If I click to reply on certain group threads, the HTML source looks like this:

<input type="hidden" name="s" value="" />
<input type="hidden" name="do" value="postreply" />
<input type="hidden" name="t" value="0" />
<input type="hidden" name="p" value="" />
<input type="hidden" name="posthash" value="" />
<input type="hidden" name="poststarttime" value="" />
<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

Obviously, the topicid and postid are missing.

On the ones that work, the source is like this:

<input type="hidden" name="s" value="" />
<input type="hidden" name="do" value="postreply" />
<input type="hidden" name="t" value="47" />
<input type="hidden" name="p" value="" />
<input type="hidden" name="posthash" value="" />
<input type="hidden" name="poststarttime" value="" />
<input type="submit" class="button" name="sbutton" id="vB_Editor_001_save" value="Submit Reply" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Post" accesskey="p" tabindex="1" />

The topicid is there, though the postid is not. This is why I can reply to the post, but it takes me to the start of the thread, and not the post I made, after I submit.

Interestingly, on threads that have no topicid when replying, you CAN quote them -- the topicid gets pulled there. So perhaps an investigation of the code to see what the difference is in pulling the topicid for the quote vs. the new reply will help you solve this?

I will let you know if I figure out any more. :)
is there any commonality between the threads/groups in which the threadid appears <input type="hidden" name="t" value="47" /> and comes up as zero?

[sabret00the]

Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon.
fixed.

[sabret00the]

Other issues my users have reported:

(1) If a user has no avatar, it shows a red X or missing image placeholder for the user. It should not show anything, or at least some default "missing avatar" placeholder.

(2) When you post to a thread, the page refreshes to the start of page one, instead of where you just posted. So if you post to page five, it bounces you back to page one, and you have to click and scroll to get back where you left off.

(3) The [View My Last Reply] [View New Posts] [View Last Reply] links just take you to the start of the thread.

My own issue is that the system does not seem to check a user's permissions, only if they are a member. So when I had a member join a group, then get changed to a usergroup without group joining privileges, she could still see and post to the group because she was still a member. If the system could check the user against their usergroup permissions to make sure that they have permissions to access the groups, whether or not they are a member or leader of a group would be great. Perhaps a cron job to remove users from groups once their permissions change, even.
1/ It was mentioned somewhere that admins were supposed to put a noavatar.gif in there misc folders.

2/ fixed again

3/ fixed

4/ will fix this issue in a future release

[sabret00the]

Yes, when you post, you can enter a post title and your message. If you enter a title, it is supposed to show next to the post icon. Neither the selected post icon (if you select one) nor the post title (if you enter one) ever show. It only shows the default post icon. It's saving the titles, because I can see them in the DB, but they aren't displayed. I'm not sure about the post icons.

can you please run test_viewthread.php for any thread in which you have selected a posticon for a post and it's not appearing please.

[Merriweather]

is there any commonality between the threads/groups in which the threadid appears <input type="hidden" name="t" value="47" /> and comes up as zero?

I'm sick today, forgive me for my slowness. I looked up two groups -- both created y me, one which has the posting problem and one which does not. I compared the DB tables for each group and found NO difference between the two, so I am really at a loss. :(

[Merriweather]

1/ It was mentioned somewhere that admins were supposed to put a noavatar.gif in there misc folders.I missed that, will do. Sorry.

[Merriweather]

can you please run test_viewthread.php for any thread in which you have selected a posticon for a post and it's not appearing please.

=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>

I selected a post icon and saved the post. Ran the test and got the above. Went back to edit the post and the post icon was back to the default, so it never saved it. The post title was there, however, but doesn't show on the post.

[skorzguy]

I install the GRPS and set the usergroups. It shows everything but will not let me log in. I must have a permission problem somewhere unless its because I am using Vbulletin 3.6. Has anyone managed to install this on 3.6?

[Merriweather]

Another maddening problem. I've fixed the missing avatar issue with the noavatar.gif image, but now some groups (not all) aren't showing the avatars of members who have them. On []isome[/i] groups, it works fine, in others (again, can't find a reason for this), it's trying to get the avatars from http://www.<edit>.com/groups/cusomtavatar... but it makes no sense that some groups will find the avatars properly and others won't!

While I was investingating this via the DB, I found a really strange issue. I saw that in the grps_grouptext table, the edit_userid only allows 4 integers. Well my site's userids are 6 digits, so I changed it to 6, but no matter what I enter if I edit a row, it comes back with "127"! Why the heck 127? Here is an exampe query, yet the row shows 127 as the edit_userid:

UPDATE `grps_grouptext` SET `edit_userid` = '101524' WHERE `grps_grouptext`.`groupid` =75 LIMIT 1 ;

But the row shows "127" for the edit_userid.

[Merriweather]

=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>

I selected a post icon and saved the post. Ran the test and got the above. Went back to edit the post and the post icon was back to the default, so it never saved it. The post title was there, however, but doesn't show on the post.

I've also found that if you select a post icon for a new thread, it does save the icon to the DB and the icon will show on the group home page, but once you read the thread, it's again just showing the default. So new thread is saving the icon info to the DB, but new reply is not, and view thread is not displaying the info from the DB properly.

[Merriweather]

On the avatar thing, I've checked my replacement variables, and I've got src="customavatars/ being replaced with src="$vbulletin->options['bburl']/customavatars/, so I see no reason why some groups aren't doing that! Ugh.

***UPDATE***

I found the common thread between the groups that don't show custom avatars! If the group leader does not have an avatar, those with avatars won't show properly. If the group leader DOES have an avatar, then everyone else's avatars show properly. Hopefully that's enough enough to get it fixed! :) No matter what the group leader's avatar situation is, users without avatars correctly show the noavatar.gif image.

[Merriweather]

I have found that the grps table has no info for any group in the replycount or lastpost column. Not sure it that's intentional or the possible sounce of some of these issues.

[Martin Belak]

1/ fixed

2/ i'm not sure what that problem revolves around, but i'm guessing it is your SEO mod.

Thanks for the quick fixes sabret00the!

But I have still some small issues.. I've blacklisted the GRPS-pages in vBSEO but the [i m g]-tag is still parsed as <a href="....></a>.

And a second issue is the thread title in editpost.php. I have the name/title of the group instead of the thread title in the "title" input-box when i try to edit a post, and the input box doesn't work when saving the edited post. The thread title doesn't change.

/M

[sabret00the]

While I was investingating this via the DB, I found a really strange issue. I saw that in the grps_grouptext table, the edit_userid only allows 4 integers. Well my site's userids are 6 digits, so I changed it to 6, but no matter what I enter if I edit a row, it comes back with "127"! Why the heck 127? Here is an exampe query, yet the row shows 127 as the edit_userid:

UPDATE `grps_grouptext` SET `edit_userid` = '101524' WHERE `grps_grouptext`.`groupid` =75 LIMIT 1 ;

But the row shows "127" for the edit_userid.

run this query then try the above query again ALTER TABLE `grps_grouptext` CHANGE `edit_userid` `edit_userid` TINYINT( 10 ) NULL DEFAULT NULL;

can i also confirm that you're using PHP5 on your server?

[sabret00the]

I install the GRPS and set the usergroups. It shows everything but will not let me log in. I must have a permission problem somewhere unless its because I am using Vbulletin 3.6. Has anyone managed to install this on 3.6?

Set your usergroup permissions in the admincp.

[sabret00the]

=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>=>

I selected a post icon and saved the post. Ran the test and got the above. Went back to edit the post and the post icon was back to the default, so it never saved it. The post title was there, however, but doesn't show on the post.

and checking the database, the posticon didn't save there either?

[Merriweather]

run this query then try the above query again ALTER TABLE `grps_grouptext` CHANGE `edit_userid` `edit_userid` TINYINT( 10 ) NULL DEFAULT NULL;

can i also confirm that you're using PHP5 on your server?
Still can't update the userid, it always says 127. And it appears I am on php 4.3.10, though I can upgrade if needed -- not sure if/how that will affect the rest of my site.

[Merriweather]

and checking the database, the posticon didn't save there either?Not for replies. It's only there for new threads, if one is selected.

[skorzguy]

I tried installing this following the directions but I could not get it to work correctly. I tried following the directions but I was unable to login into the groups to create a group: I checked the premissions in the admincp. I managed to get the groups mod to work correctly by installing the groups folder inside of my forums folder. Everything and all features are working correctly but I am unable to see posts a user creates. The post is added and it shows on the groups page but unable to view it. I get the following error when trying to view the post. I have alot of other mods on my forum and this might be the problem.

--------------------------------------------------------------------------------------------

Fatal error: Call to a member function query_first() on a non-object in /home/allswac1/public_html/forums/includes/class_postbit.php(294) : eval()'d code on line 20

I am not sure what this error message means, I am guessing I need to add a piece of code here but unsure what to add.

--------------------------------------------------------------------------------------------

if (!isset($GLOBALS['vbulletin']->db))
{
exit;
}


define('POST_FLAG_INVISIBLE', 1);
define('POST_FLAG_DELETED', 2);
define('POST_FLAG_ATTACH', 4);
define('POST_FLAG_GUEST', 8);


***** I think I need to define something? not sure

The only other feature not working correctly is the groups photos. It appears to be 8 different gifs but am not sure. You only have 3 gifs in your folder.

******A cool option idea

It would be cool if one could add a box showing groups one belongs too or is a member of in the members template. Its probably a simple piece of code.

Here is a link to where I have the groups mod installed to see the problem.

http://www.allstarchat.com/forums/groups/groups.php?g=2

[sabret00the]

Still can't update the userid, it always says 127. And it appears I am on php 4.3.10, though I can upgrade if needed -- not sure if/how that will affect the rest of my site.

please upgrade if possible. i'm not sure what other mods you have installed but this mod was specifically designed for PHP 5. To the point i took my site offline for two days just waiting for it to be upgraded by the host. However, of course i suggest you check PHP 5 compatibility with any other mods you have installed first.

and run this query and it should fix ALTER TABLE `grps_grouptext` CHANGE `edit_userid` `edit_userid` INT( 10 ) NULL DEFAULT NULL;

[sabret00the]

I tried installing this following the directions but I could not get it to work correctly. I tried following the directions but I was unable to login into the groups to create a group: I checked the premissions in the admincp. I managed to get the groups mod to work correctly by installing the groups folder inside of my forums folder. Everything and all features are working correctly but I am unable to see posts a user creates. The post is added and it shows on the groups page but unable to view it. I get the following error when trying to view the post. I have alot of other mods on my forum and this might be the problem.

--------------------------------------------------------------------------------------------

Fatal error: Call to a member function query_first() on a non-object in /home/allswac1/public_html/forums/includes/class_postbit.php(294) : eval()'d code on line 20

I am not sure what this error message means, I am guessing I need to add a piece of code here but unsure what to add.

--------------------------------------------------------------------------------------------

if (!isset($GLOBALS['vbulletin']->db))
{
exit;
}


define('POST_FLAG_INVISIBLE', 1);
define('POST_FLAG_DELETED', 2);
define('POST_FLAG_ATTACH', 4);
define('POST_FLAG_GUEST', 8);


***** I think I need to define something? not sure

The only other feature not working correctly is the groups photos. It appears to be 8 different gifs but am not sure. You only have 3 gifs in your folder.

******A cool option idea

It would be cool if one could add a box showing groups one belongs too or is a member of in the members template. Its probably a simple piece of code.

Here is a link to where I have the groups mod installed to see the problem.

http://www.allstarchat.com/forums/groups/groups.php?g=2
Just to confirm, you're using 3.6.2+ right?

And do you have any other postbit modifications running on your site?

For your image problem, go to your admincp and set the total to three instead of eight.

The suggestion has been requested a few times, but sadly i'm not interested in working on the member.php template, however i'm pretty sure that someone will pop up to work on it.

[gyankow]

fixed for 2.0.6

and to piggy-bank this post

can i take this moment to state that if anyone would like to remove the branding, then contact me, this is not a free option you're able to remove on a whim. please either donate or display the branding as a show of appreciation.


For Branding Free just tell me what the donation should be and I will gladly comply. For the record I want to ask for a amount NOT to insult you. I appreciate your work , I wish you knew how much!

G

[sabret00the]

For Branding Free just tell me what the donation should be and I will gladly comply. For the record I want to ask for a amount NOT to insult you. I appreciate your work , I wish you knew how much!

G
I PM'd you Gyankow.

[Merriweather]

I don't know when I can get to php5, as I obviously need to be very careful I do not break the rest of my site. Are you still working on the posting problems I have? As I've said, posting works fine if you use the "quote" button, so whatever the difference is between the "quote" and "new reply" is where the issue is. We've had this issue for a week and my users aren't too happy about it. :(

[sabret00the]

I don't know when I can get to php5, as I obviously need to be very careful I do not break the rest of my site. Are you still working on the posting problems I have? As I've said, posting works fine if you use the "quote" button, so whatever the difference is between the "quote" and "new reply" is where the issue is. We've had this issue for a week and my users aren't too happy about it. :(
I was actually waiting for you to upgrade to PHP5 to see which of your problems subside with the upgrade. but try and replace your groups/newreply.php with this one and let me know if there's still a problem.

[Merriweather]

I was actually waiting for you to upgrade to PHP5 to see which of your problems subside with the upgrade. but try and replace your groups/newreply.php with this one and let me know if there's still a problem.

YAY!!!!!

(1) [View My Last Reply] [View New Posts] [View Last Reply] -- All seem to work correctly
(2) You are taken to your post instead of the beginning of the thread when posting
(3) I was able to post to a thread that previously gave DB errors without errors!!!!!!!

[sabret00the]

YAY!!!!!

(1) [View My Last Reply] [View New Posts] [View Last Reply] -- All seem to work correctly
(2) You are taken to your post instead of the beginning of the thread when posting
(3) I was able to post to a thread that previously gave DB errors without errors!!!!!!!
great news, so what are your outstanding problems. the one i'm currently working on is the html when you use the WYSIWYG.

[Merriweather]

That and that when a group leader has no avatar, no members WITH avatars show properly as well as the missing post icons and titles.

I think those are the last "broken" things I am aware of.

Non broken things would be:

(1) Something to allow admin to see users in groups (and remove them) who shouldn't have access (you mentioned a new release would check user permissions in addition to whether they are a member -- this is very important)
(2) View post history when replying (like forums)
(3) Subscribe to groups somehow? (I, personally, don't care about this, but my members sure seem to be in a tizzy without it). Perhaps even just a temp fix of showing "Posts since last visit" in the User CP under the group name or something... ??

[sabret00the]

Another maddening problem. I've fixed the missing avatar issue with the noavatar.gif image, but now some groups (not all) aren't showing the avatars of members who have them. On []isome[/i] groups, it works fine, in others (again, can't find a reason for this), it's trying to get the avatars from http://www.<edit>.com/groups/cusomtavatar... but it makes no sense that some groups will find the avatars properly and others won't!is this in threads or on the side panel (newest members)?

[Merriweather]

is this in threads or on the side panel (newest members)?
Both.

[Merriweather]

Any progress?

[bada_bing]

When is this hack going to intergrate features like vb post and thread count?

[sabret00the]

When is this hack going to intergrate features like vb post and thread count?
It's not, i keep telling you, i've added the hooks, i don't intend to have that as part of the stock feature set. put in a request for a mod and hopefully someone will make it for you, it's surplus to my requirements and not conducive to the progress of GRPS at all.

[sabret00the]

Both.
i cannot replicate this

https://vborg.vbsupport.ru/ (http://img252.imageshack.us/my.php?image=cantreplicateavprobyi2.jpg)

i'm still looking at it, but as of yet i can't replicate it.

[bada_bing]

It's not, i keep telling you, i've added the hooks, i don't intend to have that as part of the stock feature set. put in a request for a mod and hopefully someone will make it for you, it's surplus to my requirements and not conducive to the progress of GRPS at all.


Can I put in the request to you since you are best familur with this product and I will pay you for this?

[sabret00the]

Can I put in the request to you since you are best familur with this product and I will pay you for this?
ok pm me what you're after.

[sabret00the]

NEW ZIP/RELEASE:
Groups v2.0.9.zip: various bug fixes including wywiwyg error, admin cp error and redirect/goto errors.

[bada_bing]

NEW ZIP/RELEASE:
Groups v2.0.9.zip: various bug fixes including wywiwyg error, admin cp error and redirect/goto errors.

Has the plugin for vb 3.5.x been updated to reflect the recent changes?

[hitboy]

Does this hack work more or less what bugs are there left.........

[sabret00the]

yes it does work, as for bugs there are incompatibilities with PHP4 but bar that, there are no known bugs i know of to be fixed in 2.0.x i know of one to do with userid's i forgot to include but have repackaged as part of 2.0.9 to please redownload.

[sabret00the]

Has the plugin for vb 3.5.x been updated to reflect the recent changes?
as always; yes.

[bada_bing]

Just sent you a PM..

[sabret00the]

if you're having problems with viewing threads, redownload the zip and replace groups/viewthread.php

[bada_bing]

How do I add it so that My Groups show up in my Profile using $grps_mygroupsbits
tried adding $grps_mygroupsbits to MEMEBERINFO but it didnt show up?

[fusiongoddess]

There are no upgrade instructions. I am assuming I overwrite all the files from the zip and re-upload the product?

I don't have to re-run the installer or redo any template edits right?

Thanks!! :)

[sabret00the]

There are no upgrade instructions. I am assuming I overwrite all the files from the zip and re-upload the product?

I don't have to re-run the installer or redo any template edits right?

Thanks!! :)
there's one template change, in "grps_newthread", it changes $title to $subject.

then it's just a matter of replacing all the files and running /groups/tools/upgrade4.php

[sabret00the]

How do I add it so that My Groups show up in my Profile using $grps_mygroupsbits
tried adding $grps_mygroupsbits to MEMEBERINFO but it didnt show up?
that would require another seperate modification, as $grps_memberinfo isn't globalised.

[MetalLord]

Hello!
After a couple of updates to your very nice product (last version I tried was a 2.0 RC) I tested it again on one of our sites. The main problem this mod has or many people have with it (as far as I read this thread) is that there is no good and consequent way it handles internal URLs (links to php files, images, css ...). In many posts I read about changing image URLs and templates to include the forum URL to make things work correctly. But why go the complicated way and change existing templates and files that already work quite well? The only thing IMHO that has to be changed to make this mod run out of the box in almost all situations is an additional config option for the forum url and a change to the grps templates to include that variable and make absulte URLs out of the relative ones. This way the mod would work with standard vb installations as well as with most seo mods without additional modifications.

Consider that as a feature request! :)

(sorry for my bad english)

[chriszep]

hello
got pb
icons & color style doesn't appear
http://www...../forums/groups/

:confused:

[bada_bing]

You need to install this plugin
if you're storing your CSS as files, you'll need to install this: https://vborg.vbsupport.ru/showthread.php?t=97298

[salata]

can someone help me please, i have spent the better part of my night going through this thread to find my answer. unfortunately i have not found it, or i may be doing something wrong. Help is greatly appreciated.


first everything appears to be working, BUT the image icons such as "new post", "no new posts", etc... draw images from

http://www.mysite.com/forums/groups/images/statusicon1/thread.gif

but the image is actually located at

http://www.mysite.com/forums/images/statusicon1/thread.gif


alot of my images are having the same problem. As well as my forum header is not showing up. when the images should be drawn from www.mysite.com/forum/images

BUT its drawing from www.mysdite.com/forums/groups/images



beside this everything seems to be functioning fine.

I also tried uploading the plugin that bada bing reccommended but without no luck, my images still do not show up.


My navbar links also suffer from this problem instead of forums/calendar.php its showing up as forums/groups/calendar.php

[MetalLord]

You have IMO 2 options:
1. Change your whole style and all links in it to the absolute URL of your board
or
2. Only change the GRPS templates and put the following in your headerinclude:
<base href="http://www.your-board.com/forums/" />

The rewriting functions in GRPS didn't work for me well.

[chriszep]

You need to install this plugin
if you're storing your CSS as files, you'll need to install this: https://vborg.vbsupport.ru/showthread.php?t=97298

thanks it's working

[chriszep]

hello
now it"s seem to working fine great :)

just a basic question
I want to run my forums & groups
is possible to tranform one of my sub forum in a group ?

thanks a lot

[salata]

You have IMO 2 options:
1. Change your whole style and all links in it to the absolute URL of your board
or
2. Only change the GRPS templates and put the following in your headerinclude:
<base href="http://www.your-board.com/forums/" />

The rewriting functions in GRPS didn't work for me well.


thanks for the response.

but is this because i have installed this incorrectly?

[Merriweather]

i cannot replicate this

http://img252.imageshack.us/img252/6942/cantreplicateavprobyi2.th.jpg (http://img252.imageshack.us/my.php?image=cantreplicateavprobyi2.jpg)

i'm still looking at it, but as of yet i can't replicate it.
It looks like your group leader in that example has an avatar? I cna't tell -- the image is so small. I am about to upgrade after I read through this thread, so we will see if it's still an issue.

[Merriweather]

hello
now it"s seem to working fine great :)

just a basic question
I want to run my forums & groups
is possible to tranform one of my sub forum in a group ?

thanks a lotNo.

[sabret00the]

It looks like your group leader in that example has an avatar? I cna't tell -- the image is so small. I am about to upgrade after I read through this thread, so we will see if it's still an issue.
that's my noavatar.gif image, anyway let me know how you get one.

[Merriweather]

Fatal error when upgrading -- I uploaded all files except the config (left my config there, I do have groups/includes/config_grps.php) --

Warning: main(./includes/config_grps.php): failed to open stream: No such file or directory in /var/www/html/<edit>/groups/tools/upgrade4.php on line 3

Fatal error: main(): Failed opening required './includes/config_grps.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/html/<edit>/groups/tools/upgrade4.php on line 3

Help!

ETA ~ Fixed issue #1 by changing
require_once('./includes/config_grps.php');
to
require_once('../includes/config_grps.php');
But now it can't find "global.php" and I'm actually not even seeing where that file is?

[Merriweather]

Has ANYONE upgraded successfully? I changed:
require_once("./global.php");
to
require_once("../../forums/global.php");
to get it to the right location for the global.php file, but now I get:
Warning: chdir(): No such file or directory (errno 2) in /var/www/html/<edit>/groups/includes/config_grps.php on line 15

Warning: main(/var/www/html/<edit>/groups/tools/includes/init.php): failed to open stream: No such file or directory in /var/www/html/<edit>/forums/global.php on line 20

Fatal error: main(): Failed opening required '/var/www/html/<edit>/groups/tools/includes/init.php' (include_path='.:/usr/share/php:/usr/share/pear') in /var/www/html/<edit>/forums/global.php on line 20
I give up for now, until someone can help me figure out what I am doing wrong, or if the upgrade file is messed up.

[salata]

can someone help me please, i have spent the better part of my night going through this thread to find my answer. unfortunately i have not found it, or i may be doing something wrong. Help is greatly appreciated.


first everything appears to be working, BUT the image icons such as "new post", "no new posts", etc... draw images from

http://www.mysite.com/forums/groups/images/statusicon1/thread.gif

but the image is actually located at

http://www.mysite.com/forums/images/statusicon1/thread.gif


alot of my images are having the same problem. As well as my forum header is not showing up. when the images should be drawn from www.mysite.com/forum/images

BUT its drawing from www.mysdite.com/forums/groups/images



beside this everything seems to be functioning fine.

I also tried uploading the plugin that bada bing reccommended but without no luck, my images still do not show up.


My navbar links also suffer from this problem instead of forums/calendar.php its showing up as forums/groups/calendar.php

You have IMO 2 options:
1. Change your whole style and all links in it to the absolute URL of your board
or
2. Only change the GRPS templates and put the following in your headerinclude:
<base href="http://www.your-board.com/forums/" />

The rewriting functions in GRPS didn't work for me well.

thanks for the response.

but is this because i have installed this incorrectly?

bump!

[sabret00the]

working upgrade4.php, sadly i won't have time to update the zip until this evening.

[sabret00the]

bump!
images need to be prefixed with your forums url. by default vBulletin it designed to have everything running from within the forums directory, with GRPS you globalise vBulletin as a community engine. thus you're required to as stated in the instructions:
you may notice that the smilies and posticons are not working, you will have to edit them individually and prefix them with your forums path. i.e. images/smilies/smilie1.gif BECOMES http://www.yoursite.com/forums/images/smilies/smilie1.gif

In order to do this, please go to your admincp, find the relevant input box and prefix the text in said book with the url to your forums.

--------

If you are having problems with your gradients, you will need to find the relevant CSS and do the same.

Apologies for the delayed response.

[sabret00the]

the updated upgrade4.php is now in the zip file.

[Merriweather]

I've got groups complaining now that they are getting a blank extra page in their group when they click [View New Posts]. For example, they are taken to "Page 4 of 3" and page 4 has nothing on it. This happened before the latest upgrade. Any ideas?

ETA ~ It's happening with all of the [View My Last Reply] [View New Posts] [View Last Reply] links after the group has more then 1 or 2 pages, unfortunately.

[Merriweather]

I also still have the avatar issue where if the leader has no avatar, those in the group with avatars don't show. Where do I need to start troubleshooting this?

[Merriweather]

Thread titles now work, but post icons still do not. no matter what you choose, it just shows the default.

[akulion]

installed it today
it is very very good
great job and thanks

[ReadOrDie]

I have installed this on a locally hosted test forum and my initial problem was the template images werent showing up. I solved this by copying my images folder into root/groups as well as root/forums and also changing the Image Paths in the style manager from /images/... to root/forums/images/...

The problem I have now is that every link I click on the template (for example USERCP it redirects me to root/groups/usercp.php, however I obviously want it to redirect me to root/forums/usercp.php

The other problem I am having is that when I click view $user's Groups in the postbit DHTML drop down I am getting directed to /groups/viewgroups.php?u=1 (without the root folder, which is obviously giving me a 404 error.

Now I know that there will be a very simple solution here that I have missed, more than likely a mistake in my config, while I have been looking through code.

Any help you could offer would be greatly appreciated as it will help me to get a project off //localhost/ and onto the www.

Thanks In Advance

[sabret00the]

Thread titles now work, but post icons still do not. no matter what you choose, it just shows the default.

that issue is most definitely a php4 incompatibility; thus i can't fix it. i also suspect your avatar problem is down to the same thing.

[sabret00the]

I have installed this on a locally hosted test forum and my initial problem was the template images werent showing up. I solved this by copying my images folder into root/groups as well as root/forums and also changing the Image Paths in the style manager from /images/... to root/forums/images/...it's not a recommendation i'd make, but if it works for you. however please note, you were given directions for images within the install.txt.

The problem I have now is that every link I click on the template (for example USERCP it redirects me to root/groups/usercp.php, however I obviously want it to redirect me to root/forums/usercp.phpare you compressing your templates at all?

The other problem I am having is that when I click view $user's Groups in the postbit DHTML drop down I am getting directed to /groups/viewgroups.php?u=1 (without the root folder, which is obviously giving me a 404 error.where is your groups installation located at in regards to your forum?

[sabret00the]

I've got groups complaining now that they are getting a blank extra page in their group when they click [View New Posts]. For example, they are taken to "Page 4 of 3" and page 4 has nothing on it. This happened before the latest upgrade. Any ideas?

ETA ~ It's happening with all of the [View My Last Reply] [View New Posts] [View Last Reply] links after the group has more then 1 or 2 pages, unfortunately.
can anyone else confirm this?

[Merriweather]

that issue is most definitely a php4 incompatibility; thus i can't fix it. i also suspect your avatar problem is down to the same thing.php4 -> php5 was not that huge of a change that a simple insert into database and retrieve from database should be affected, and it works in the regular forums, just not this modification. Does it work on your board?

ETA ~ I just looked at your site and I only see post icons and title on the first post of your threads in groups, which is what I had until a few of your upgrades -- now I have default post icons and titles, but still no post icons when you select something other than the default.

I also see that you aren't even using the [View Last Reply] etc, is it because they aren't working right?

[fusiongoddess]

How can I remove "Last Edited By" on the group's description next to its image? (it's the block before post listing in a group)

[sabret00the]

php4 -> php5 was not that huge of a change that a simple insert into database and retrieve from database should be affected, and it works in the regular forums, just not this modification. Does it work on your board?

ETA ~ I just looked at your site and I only see post icons and title on the first post of your threads in groups, which is what I had until a few of your upgrades -- now I have default post icons and titles, but still no post icons when you select something other than the default.

I also see that you aren't even using the [View Last Reply] etc, is it because they aren't working right?
while i understand where you're coming from with your point. you have to understand i'm at a loss regarding this problem of yours, and the only thing of not between our installations of which mine is working perfectly is that your using dated php software this modification wasn't designed to run upon.

if you would like to registers at my site and test the feature then feel free however i assure you that my installation is running as designed, please not that by default [view last reply] do not show for guests but i assure you for members they work as designed. granted i have no threads longer than two pages long in my groups hence the request for confirmation of your problems but within what i'm able to provide and see everything works as designed in that regard. in stating that the posticon problem worked up until recently doesn't help the problem. i know for a fact it won't work until you upgrade to php5; the simple fact of the matter is that one is designed to work with objects while the other isn't and considering that making posts was changed to work as though it were an object, you require php5. i did request you looked into updating your PHP version from last week for this very reason and assumed it was in the works. i take every issue reported here just as seriously and would like to see your installation working perfectly but i honestly believe it's a software (PHP) issue.

[sabret00the]

How can I remove "Last Edited By" on the group's description next to its image? (it's the block before post listing in a group)
Either untick "Show Group Text Edit Details" or edit the template "groups_display_main" and remove this chunk of html
<if condition="$grps_showgroup[edit_details]">
<div class="smallfont" align="right"><br /><br /><br />
<em>
<phrase 1="$grps_showgroup[edit_username]" 2="$grps_showgroup[edit_date]" 3="$grps_showgroup[edit_time]">$vbphrase[last_edited_by_x_on_y_at_z]</phrase>.
<if condition="$grps_showgroup[edit_reason]">$vbphrase[reason]: $grps_showgroup[edit_reason]</if>
</em>
</div>
</if>

[Merriweather]

while i understand where you're coming from with your point. you have to understand i'm at a loss regarding this problem of yours, and the only thing of not between our installations of which mine is working perfectly is that your using dated php software this modification wasn't designed to run upon.

if you would like to registers at my site and test the feature then feel free however i assure you that my installation is running as designed, please not that by default [view last reply] do not show for guests but i assure you for members they work as designed. granted i have no threads longer than two pages long in my groups hence the request for confirmation of your problems but within what i'm able to provide and see everything works as designed in that regard. in stating that the posticon problem worked up until recently doesn't help the problem. i know for a fact it won't work until you upgrade to php5; the simple fact of the matter is that one is designed to work with objects while the other isn't and considering that making posts was changed to work as though it were an object, you require php5. i did request you looked into updating your PHP version from last week for this very reason and assumed it was in the works. i take every issue reported here just as seriously and would like to see your installation working perfectly but i honestly believe it's a software (PHP) issue.I am doing a test upgrade to php5 on my site on Friday, but because of how much programming is involved with my site, it's not as easy as flipping a switch. Hopefully I can move to php5 without breaking everything else and that will fix some things with the groups.

The problem with the View Last Reply, etc seems to happen once the group has 3 pages -- I experienced it myself today. :(

I am also happy to give you a login to my site so you can experience some of these issues yourself. :)

[fusiongoddess]

Hi there, me again. :) How do groups set their own pics?

[sabret00the]

Hi there, me again. :) How do groups set their own pics?
This isn't possible with 2.0.x however it will be available with 3.0.x

[ReadOrDie]

it's not a recommendation i'd make, but if it works for you. however please note, you were given directions for images within the install.txt.


Yeah I should probably change that


are you compressing your templates at all?


I dont think so. This is basically on a new vB 3.6.4 forum run on my localhost with a skn other than the default, the advanced product management and GPRS installed. I havent enabled skin compression.

[QUOTE=sabret00the;1207274
where is your groups installation located at in regards to your forum?[/QUOTE]

Forums: http://localhost/vb021/forums/
Groups: http://localhost/vb021/groups/

[sabret00the]

and your bburl is set in the admincp correct? (i apologise for the question, but it has to be asked).

[Martin Belak]

sabret00the, i have a small issue with editing posts in the groups. When the edit form shows up the name of the group is shown as a default value in the post title input field, instead of the title of the actual post. Have I messed up something in my templates or this a bug?

/M

[ReadOrDie]

and your bburl is set in the admincp correct? (i apologise for the question, but it has to be asked).

Yes, i figured out the problem. The default vBulletin skin worked fine because the images were listed as the full path (using the BBUrl) and so were the links.

The template I was using, the customised links and images were simply sourced to images/...

I added two replacement variables, modified the style CSS and it works a treat. As I said, probably something simple I missed >.<

Sorry to waste your time.

[Merriweather]

"Preview Post" still doesn't work right. I posted something with a quote, and it only showed through the end of the quote and no more. I also noticed that the title it showed was some random title from a forum thread. I also have the problem that is shows the forum description of one of my private forums when reporting a thread. Can you please look into this, and if you can't replicate it, please accept my offer of a login to my site so you can see what I am talking about??

[Merriweather]

Another bug -- when you edit your post, it's taking users back to the start of the thread, instead of the post they edited.

[Merriweather]

BIG problem -- it seems that the group leader can assign ANYONE as the new group leader, regardless of their permissions. For instance, I have a usergroup that can start and join groups and another usergroup that can only join groups. However, the ones who can only join groups are listed in the drop down as options to turn the group leadership over to, and that is bad because my members pay to be able to lead groups -- I can't have it so someone with starting permissions can start them then just start turning them over to users who aren't supposed to be able to start them.

There is also the issue of what happens to a user when their usergroup changes to no longer allow them group permissions -- has this been addressed at all yet? Right now, if they change to a usergroup with no group permissions, but are members of a group, their group membership remains, and that needs to change as well.

[sabret00the]

sabret00the, i have a small issue with editing posts in the groups. When the edit form shows up the name of the group is shown as a default value in the post title input field, instead of the title of the actual post. Have I messed up something in my templates or this a bug?

/M
that's indeed a bug.

[sabret00the]

Yes, i figured out the problem. The default vBulletin skin worked fine because the images were listed as the full path (using the BBUrl) and so were the links.

The template I was using, the customised links and images were simply sourced to images/...

I added two replacement variables, modified the style CSS and it works a treat. As I said, probably something simple I missed >.<

Sorry to waste your time.
don't be silly, glad you got it working :)

[sabret00the]

"Preview Post" still doesn't work right. I posted something with a quote, and it only showed through the end of the quote and no more. I also noticed that the title it showed was some random title from a forum thread. I also have the problem that is shows the forum description of one of my private forums when reporting a thread. Can you please look into this, and if you can't replicate it, please accept my offer of a login to my site so you can see what I am talking about??
are both of these happening on your php 5 board. i must confess i don't get the quote problem you're referring to. can you please use screenshots to explain better i'm at a loss. btw if your board is running php5 then please feel free to set me up an account and i'll take a look.

[sabret00the]

Another bug -- when you edit your post, it's taking users back to the start of the thread, instead of the post they edited.
fixed.

[sabret00the]

BIG problem -- it seems that the group leader can assign ANYONE as the new group leader, regardless of their permissions. For instance, I have a usergroup that can start and join groups and another usergroup that can only join groups. However, the ones who can only join groups are listed in the drop down as options to turn the group leadership over to, and that is bad because my members pay to be able to lead groups -- I can't have it so someone with starting permissions can start them then just start turning them over to users who aren't supposed to be able to start them.

There is also the issue of what happens to a user when their usergroup changes to no longer allow them group permissions -- has this been addressed at all yet? Right now, if they change to a usergroup with no group permissions, but are members of a group, their group membership remains, and that needs to change as well.

i understand where you're coming from with both of these problems, but bugs they are not. i'll have a look into a solution for both of these problems for 3.0.

[bada_bing]

I think there is another small issue with the postbit Currently my postbit on vb shows field=xx example which is Location and shows up fine when in VB but when in the Groups some of the Fields are missing like the Location.. How do I make sure that my postbit fields match up like the fields in VB? I also noticed that I have an awards hack which shows the awards assigned to that member in the postbit but when I am in Groups that awards does now show up so this tells me that the postbit is out of sync with VB

[sabret00the]

I think there is another small issue with the postbit Currently my postbit on vb shows field=xx example which is Location and shows up fine when in VB but when in the Groups some of the Fields are missing like the Location.. How do I make sure that my postbit fields match up like the fields in VB? I also noticed that I have an awards hack which shows the awards assigned to that member in the postbit but when I am in Groups that awards does now show up so this tells me that the postbit is out of sync with VB
Are you using a modification to display these fields are is it just a template edit?

[bada_bing]

Are you using a modification to display these fields are is it just a template edit?

I am using the Show Profile fields in Postbits hack to display the extra fields.

[bada_bing]

How can I change the wording on the main (index.php) page under
Search For Group is says (e.g. journals, football, makeup, dating) I want to make that more related to my site?

[Merriweather]

How can I change the wording on the main (index.php) page under
Search For Group is says (e.g. journals, football, makeup, dating) I want to make that more related to my site?Edit it in your phrases.

[Merriweather]

are both of these happening on your php 5 board. i must confess i don't get the quote problem you're referring to. can you please use screenshots to explain better i'm at a loss. btw if your board is running php5 then please feel free to set me up an account and i'll take a look.I'll be testing the board on php5 on Friday. I don't recall ever seeing anything in your mod about needing php5 (but I could have easily missed it) -- you might want to make sure that's made clear for other users. :) I hope php5 fixes some of these issues. :)

[Merriweather]

i understand where you're coming from with both of these problems, but bugs they are not. i'll have a look into a solution for both of these problems for 3.0.I'll politely disagree that they aren't bugs... there's barely a point to usergroup permissions if once permissions are granted they can't be revoked. ;)

Just want you to know I don't intend to be a thorn in your side and hope I'm not -- I just want this awesome mod to work perfectly. :) You do great work and give great support! :up:

[akulion]

so far so good for me

this is a really cool mod

[sabret00the]

I'll politely disagree that they aren't bugs... there's barely a point to usergroup permissions if once permissions are granted they can't be revoked. ;)

Just want you to know I don't intend to be a thorn in your side and hope I'm not -- I just want this awesome mod to work perfectly. :) You do great work and give great support! :up:
You're not a thorn in my side so don't worry.

As for being a bug, they're definitely not bugs, 100% so. Reason being is that the function works as designed. A bug is about unexpected behaviour. When you made the feature request, you mentioned nothing of checking a users permissions thus the scope of design was basic. Now you feel that more work should go into it so it can work as you'd like. that's not a bug fix, that's further development. two totally different things. hence me saying i'll look into it for 3.0.x