View Full Version : Links and Downloads Manager
Pages :
[
1]
2
3
4
5
6
7
8
9
10
AndrewD
06-25-2005, 10:00 PM
LDM extends VBulletin to manage a library of documents, files and links to other web sites. Documents can be stored on your own web site, stored on your server separate from the web site, uploaded by your user community, or held somewhere else altogether. So you can use LDM to provide your user community with access to your own files and allow them to share files with each other.
12/08/06 - Versions that work with vb36 are available and supported in the VB36 thread. Version 2.2.1, which works with VB 3.5 but not with VB 3.6, remains available here.
Thanks to everyone who has helped with all the design, testing, etc.
Translations are provided (thanks dLutt and LeeWicked) into German, (thanks to Allan) into French, and (thanks to Hugo) into Spanish. Harry1951 has handled the Dutch translation.
Screenshots, Instructions and How to Install
Full details and instructions are available as a Wiki at http://www.eirma.org/wikis/index.php/Links_and_Downloads_Manager
LDM installs as a VBulletin product. There are no modifications required to standard VB code.
Basically - upload php files and run the installer through VB's Product installer. No changes needed to VB code. Remember to BACKUP YOUR DATABASE. By default, LDM prefixes its database tables 'local_'. Edit the configuration file, local_links_init.php, if you need/wish to change this.
LDM can handle an essentially unlimited number of categories and nested subcategories, and an unlimited number of entries (hyperlinks or downloadable files). Each entry can be placed in one or several categories. Categories can have styles. Descriptions and titles can optionally include BBcodes, smilies, images and html, giving the possibility to add images, colouring, etc. File types can be flagged using icons and individual entries can also have associated thumbnail images.
Standards templates are provided for libraries of links, files, documents, and photographs.
Users can offer comments and rate the links/downloads. Each user is allowed one rating and many comments per entry, and can freely edit these if they change their mind.
Permission to use specific features is established via the product's admin page, where the administrator specifies which usergroups can add and edit entries, comment and rate these entries, moderate, etc.
By default, all entries are visible to all users. You can restrict visibility/access to links and categories by using the permissions masks from your board's forums.
Moderation of new entries is available but turned off by default.
Users can report bad links to the relevant moderators/administrators.
Each user can flag links as his/her "Favourites".
Modules are provided for VBAdvanced.
Hooks are provided in suitable places in LDM and sample plugins are included in the release (see extras directory), for example to integrate with ID3 tags in mp3 files, for slideshows, to autocreate new threads in your forums, etc.
Plus much more.
Jenta
06-26-2005, 11:02 AM
oh man, thank you so much
i just as of 5 minutes ago upgraded to beta 2 and was going to upload all the files as as attachments
your my hero!
If a user is a guest, can I say they CAN'T see the downloadlink/url link BUT CAN see the filename/linkname and description?
In that case, this is what I'm looking for :)
AndrewD
06-26-2005, 11:30 AM
If a user is a guest, can I say they CAN'T see the downloadlink/url link BUT CAN see the filename/linkname and description?
In that case, this is what I'm looking for :)
Yes, you can configure it in this way, but you need to understand how the permissions system works, see instructions.txt.
a) Out of the box, all entries are available to all users and only administrators can create/edit links. The admin page provides a large number of permission settings to change this per user group.
b) You give each a url/download access permissions by 'associating' it with one of your board's forums which has the required permissions masks. The admin page can be used to provide a default forum.
c) You can set it up either so that usergroups only see the urls/downloads they are allowed to access, or so that they see everything but can't get at the file
d) You need to read the instructions file - in particular, look at the explanation of the admin parameters *default_forumid* and the group settings for *can_see_protected_links_on_portal*
lttcoder
07-05-2005, 08:30 PM
screenshot please
Allan
07-05-2005, 08:34 PM
screenshot please
yep ;)
tinjon
07-08-2005, 05:05 PM
very nice. useful. however it would be better if admins were able to upload files from the control panel so you could offer files from your own site. i mean many of us use uploading services like rapidshare, yousendit and others, but they don't allow direct links. so ..yah.. please consider it. will really appreciate the ability to add downloads from the admin cp. thanks.
TCooper
07-21-2005, 05:30 PM
I couldnt find an add category link but i can still add a category by going to the url at http://myurl.com/forum/local_links.php?action=addcat Can anyone help me on why it doesnt show.
AndrewD
07-24-2005, 08:30 AM
very nice. useful. however it would be better if admins were able to upload files from the control panel so you could offer files from your own site. i mean many of us use uploading services like rapidshare, yousendit and others, but they don't allow direct links. so ..yah.. please consider it. will really appreciate the ability to add downloads from the admin cp. thanks.
I avoided offering this with the VB3.0 version, but am willing to think again. Question - what is the maximum file size you would want to upload?
Ian Emu-UK
07-24-2005, 03:36 PM
I sort links by date in descending order, and when I validate all links, it forgets which ones were uploaded last and screws around with the order they are displayed. Is there a fix for this?
AndrewD
07-25-2005, 04:12 AM
I sort links by date in descending order, and when I validate all links, it forgets which ones were uploaded last and screws around with the order they are displayed. Is there a fix for this?
Will take a look. Currently the sort order is not retained between accesses - it will probably need storing in a cookie or such like.
cclaerhout
07-25-2005, 06:34 PM
This new version works great ! Thank you. :)
TCooper
07-25-2005, 07:24 PM
I avoided offering this with the VB3.0 version, but am willing to think again. Question - what is the maximum file size you would want to upload?
Why do you need to know the max file size as you are usually limited by the server setting like in you php.ini file... which we have ours set higher for the bigger uploads we do via the browser.
AndrewD
07-26-2005, 04:15 AM
Why do you need to know the max file size as you are usually limited by the server setting like in you php.ini file... which we have ours set higher for the bigger uploads we do via the browser.
Exactly so ;) - before coding this, I want to make sure people aren't expecting to be able to handle arbitrarily large files. Those who run on shared servers are often limited by a small upload_max_filesize and post_max_size, around 2M.
EasyTarget
07-26-2005, 03:35 PM
/me signs petition for upload capability/integration
EasyTarget
07-26-2005, 04:49 PM
The security issue for
our servers is still severe and we will still be turning off the
allow_url_fopen...
If you are currently using this functionality in your PHP code, there is
a more powerful and
flexible option available. PHP provides excellent support for curl
library and its associated
functions.
One of our own users has written a short article describing how it is
used and that can be found
here:
http://blog.unitedheroes.net/archives/p/1630/
The official PHP documentation for it is here:
http://us2.php.net/manual/en/ref.curl.php
This change will significantly improve the security of PHP-based
applications running on our
serversany possiblity of getting curl support in this script?
also why does it rely on the allow_url_fopen function for links/files within the same site? I added some folders inside my forums directory for the downloads and the hack picks them up in the scan but then the links to the files don't work because the allow_url_fopen function isn't allowed, but it seems that that function shouldn't be necessary for this ability.
EasyTarget
07-26-2005, 04:56 PM
when trying to delete a category which still has files/subcategories in it I am brought to the Invalid delete error, but this error gives a link which is invalid.
vBulletin Message
Invalid delete - category 1 still contains links/subcategories. Return (www.yoursite.com/forum/$url)
Maybe its some error on my part, but the $url address doesn't lead anywhere for me.
*edit*
I'm running 3.5 beta 4 btw.
AndrewD
07-27-2005, 06:42 PM
when trying to delete a category which still has files/subcategories in it I am brought to the Invalid delete error, but this error gives a link which is invalid.
Maybe its some error on my part, but the $url address doesn't lead anywhere for me.
*edit*
I'm running 3.5 beta 4 btw.
OK, will check - probably something simple.
Also will take a look at the curl/fopen situation
ExpertDomino
08-01-2005, 10:36 PM
Claps my hands and stomps my feet.........wow that was easy to install *clicks Installs*
Boofo
08-06-2005, 02:48 AM
Excellent Mod! Just what I have been looking for for my new site! ;)
One question ... is there a way to only allow links to sites added and not downloads? ;)
AndrewD
08-06-2005, 07:11 AM
One question ... is there a way to only allow links to sites added and not downloads? ;)
Currently, this choice is not available, but it would be easy to add - up to a point.
The code works out if the entry is a 'link' or a 'download' by checking the VB attachment info to look for a mimetype that corresponds to the file suffix. If there's mimetype info available, then it's handled as a download. It would be easy enough to accept only entries that *do* or *do not* have mimetypes available. I'm not sure if that is sufficient.
Boofo
08-06-2005, 08:34 AM
Currently, this choice is not available, but it would be easy to add - up to a point.
The code works out if the entry is a 'link' or a 'download' by checking the VB attachment info to look for a mimetype that corresponds to the file suffix. If there's mimetype info available, then it's handled as a download. It would be easy enough to accept only entries that *do* or *do not* have mimetypes available. I'm not sure if that is sufficient.
I'm using this on my new site which is a Fathers' Rights site and all I want is links to law and informational Fathers' Rights sites. I know sooner or later someone will try to link a file or something. ;)
If you could maybe have a setting for this then that would be great! ;)
Excellent job, by the way. It was almost TOO easy to install. ;)
AndrewD
08-06-2005, 12:31 PM
I'm using this on my new site which is a Fathers' Rights site and all I want is links to law and informational Fathers' Rights sites. I know sooner or later someone will try to link a file or something. ;)
If you could maybe have a setting for this then that would be great! ;)
Excellent job, by the way. It was almost TOO easy to install. ;)
Thx, will give this some thought.
It's going to get even easier to install - I've got the product management install/uninstall script written - I like the system they've introduced for this.
Boofo
08-06-2005, 12:38 PM
Thx, will give this some thought.
It's going to get even easier to install - I've got the product management install/uninstall script written - I like the system they've introduced for this.
I love the product management system! I ran 3.0 RC 1 (with all security updates through the 3.0 releases) and never upgraded because my board was too heeavily hacked and I really didn't want to have to re-do everythiing every time a new version came out. Now upgrading is a snap. A few template changes and we're back in business. ;)
Let me know if you need any testing done with the links as only links. ;)
AndrewD
08-07-2005, 03:38 PM
Uploaded the first official release of the Links and Downloads Manager.
New features:
- Uses VB's product installer
- Includes user comments on links/files
- Categories can be given different styles
- Bad links can be reported
Grateful for reports.
Boofo
08-07-2005, 04:00 PM
Do we need to re-run the install file or anything to upgrade?
AndrewD
08-07-2005, 04:34 PM
Do we need to re-run the install file or anything to upgrade?
This version uses the VB product installer - it no longer has a separate installation script. All you need to do is upload the five php files, then install the product.
Boofo
08-08-2005, 02:51 AM
Works great! ;)
There is one small thing I noticed ... If you set this up as a forum link, when you first go into it, the Administer link is not clickable. If you click the Moderate link, then it becomes clickable. It only seems to happen if it opens in a new window. ;)
AndrewD
08-08-2005, 04:23 AM
Works great! ;)
There is one small thing I noticed ... If you set this up as a forum link, when you first go into it, the Administer link is not clickable. If you click the Moderate link, then it becomes clickable. It only seems to happen if it opens in a new window. ;)
Are you running this on a board that you have upgraded from VB3.0? I had a similar problem at first, because my board also included edits to some of the standard VB templates (header, for example). Suggest you take a look at the main VB admin page -> Styles and Templates -> Find Updated Templates. You may need to 'revert' some of the standard templates, because they've changed the way they handle drop downs.
If you're running this on a clean new VB3.5 install, I can't reproduce it.
Boofo
08-08-2005, 04:57 AM
Nope, running a clean 3.5. ;)
The link is there it just isn't active until I click the Moderate link.
Dream
08-08-2005, 05:00 AM
can i just upload everything and install the product or am i required to go thru the installation.txt and edit files
Boofo
08-08-2005, 05:54 AM
can i just upload everything and install the product or am i required to go thru the installation.txt and edit files
You might want to check the instructions file out as the files get uploaded to different directories. ;)
Boofo
08-08-2005, 05:57 AM
Are you running this on a board that you have upgraded from VB3.0? I had a similar problem at first, because my board also included edits to some of the standard VB templates (header, for example). Suggest you take a look at the main VB admin page -> Styles and Templates -> Find Updated Templates. You may need to 'revert' some of the standard templates, because they've changed the way they handle drop downs.
If you're running this on a clean new VB3.5 install, I can't reproduce it.
It only happens when I set the links as a forum with the link in it. I notice none of the drop downs (in the nabvar or links) work when I first go into it. I checked the find updated templates and there were none listed. Strange. ;)
EDIT: Found the problem. I have the links db mod as the link for my forum but I had it opening up in a new wondow instead of the way it is by default. I took the target part out of it and the drop downs work fine now. ;)
AndrewD
08-08-2005, 07:12 AM
can i just upload everything and install the product or am i required to go thru the installation.txt and edit files
It's explained at the start of the instructions file:
Five php files to upload using FTP, two into your main forums directory, three into the includes directory
Then you use the main VB admin CP to upload and run the xml product installer, which loads templates, plugins and phrases and runs the install/upgrade code
No code changes are needed.
Boofo
08-08-2005, 10:50 AM
I think I found something else here. Sorry. ;)
If you have links in one category and you move them to another category, when you set the display order, it defaults back to one when you view it in the new category. You have to reset the display order after you move it. Shouldn't that be set as you edit it to move it?
AndrewD
08-08-2005, 10:53 AM
I think I found something else here. Sorry. ;)
If you have links in one category and you move them to another category, when you set the display order, it defaults back to one when you view it in the new category. You have to reset the display order after you move it. Shouldn't that be set as you edit it to move it?
You're right - will check this evening.
Thanks
Boofo
08-08-2005, 10:59 AM
Now that's what I call service! Was there a smile with that? ;)
Let me know what you find out and thank you, sir. ;)
I'm having a blast with this Mod! ;)
AndrewD
08-08-2005, 06:20 PM
Now that's what I call service! Was there a smile with that? ;)
Let me know what you find out and thank you, sir. ;)
I'm having a blast with this Mod! ;)
A big smile :) Actually there was a rather subtle bug lurking in the code, which you helped me find. Just upload the revised local_links.php - no need to rerun the installed. Let me know if if's ok.
Boofo
08-08-2005, 07:18 PM
That did the trick! Working fine now. Thank you, sir. ;)
I have to know, what was the subtle bug? ;)
AndrewD
08-09-2005, 04:08 AM
That did the trick! Working fine now. Thank you, sir. ;)
I have to know, what was the subtle bug? ;)
In earlier versions, suppose you had put a link into more than one category and given it a new display order in all of these (e.g. 2). If you then tried to change its display order again but in only one of its categories (e.g. to 3), all the rest would be reset to 1. Rather an obscure situation, but it took me a little while to work out what was happening.
Boofo
08-09-2005, 08:28 AM
Ahhhh, I could see where that would be hard to emulate. ;)
Would there be a way to maybe have the links show their display order number somewhere in the listing? If you get enough links added (is there a limit?), it would be nice to know what the next number should be instead of having to open the last link in a category for editing to find out. ;)
AndrewD
08-09-2005, 08:39 AM
Ahhhh, I could see where that would be hard to emulate. ;)
Would there be a way to maybe have the links show their display order number somewhere in the listing? If you get enough links added (is there a limit?), it would be nice to know what the next number should be instead of having to open the last link in a category for editing to find out. ;)
Yes, good idea. I'm also thinking about an approach similar to the new VB inline moderation system (the right hand column in the thread list) so that one can more easily mass edit the entries.
There is no limit on the number of links - the list will paginate automatically. If you don't provide a sequence number, then they will default to "1" and appear in alphabetical order.
Boofo
08-09-2005, 08:52 AM
Yes, good idea. I'm also thinking about an approach similar to the new VB inline moderation system (the right hand column in the thread list) so that one can more easily mass edit the entries.
There is no limit on the number of links - the list will paginate automatically. If you don't provide a sequence number, then they will default to "1" and appear in alphabetical order.
Oooohh, I like the mass edit idea. ;)
Maybe have a sorting option where you can do it by display number or alphabetrically? Or maybe even link creation date/time? ;)
It might be nice to also know the creation date/time so if the link is ever dead, how long it has been there. ;)
And here I thought you couldn't make this any better. ;)
Boofo
08-09-2005, 08:55 AM
The clear/delete ratings can only be done by the Admin, right?
AndrewD
08-09-2005, 02:34 PM
The clear/delete ratings can only be done by the Admin, right?
Yes, and by the user who submitted it.
Boofo
08-09-2005, 03:02 PM
Yes, and by the user who submitted it.
Do you really want the person who submitted the link to be able to clear the rating? If they didn't like how it was rated, then they could start the rating all over. ;)
AndrewD
08-09-2005, 06:27 PM
Do you really want the person who submitted the link to be able to clear the rating? If they didn't like how it was rated, then they could start the rating all over. ;)
No, I'm being unclear. Anyone who has *can_rate_link* privilege can rate/comment on any link. They can also change their own rating/comment but they cannot change anyone else's. The admin can delete any rating/comment but can only change his own. The person who created the link in the first place has no special privileges in this regard, unless he's an admin.
Boofo
08-09-2005, 06:29 PM
I don't think you were being unclear, I was just misunderstanding. Sorry about that. ;)
GrendelKhan{TSU
08-10-2005, 09:38 AM
I'm getting this error when I try to change the admistrater settings:
The following setting(s) are invalid
monitor_dir :
any ideas?
(note:
MySQL version 4.0.22-log
PHP version 4.3.10 )
AndrewD
08-10-2005, 03:40 PM
I'm getting this error when I try to change the admistrater settings:
any ideas?
(note:
MySQL version 4.0.22-log
PHP version 4.3.10 )
This error is flagged if you enter something in the monitor_dir text box and the code can't find a directory that matches. But your error message suggests that you haven't put anything in this box? Do you get this error every time you try to change admin settings?
SpankMe
08-13-2005, 03:35 AM
I've upgraded from version 1.01 and the upgrade doesn't appear to have modified the dB correctly as I get:
MySQL Error : Unknown column 'link.numrate' in 'field list'
AndrewD
08-13-2005, 06:03 AM
I've upgraded from version 1.01 and the upgrade doesn't appear to have modified the dB correctly as I get:
MySQL Error : Unknown column 'link.numrate' in 'field list'
Wow, version 1.01 - long time ago.
I tried doing a clean install of 1.0 onto a VB3.0 database, then upgraded to VB 3.5 and LDM 2.0.1 and everything has run fine for me, including creating/updating the ratings table.
Question - did you use the new product installation process via the VB admin CP or did you just follow the old procedure of droppping the code in the VB directories?
If no joy, maybe you could backup the local_links* tables from your database and email them to me (ad_rodin at noos.fr)
SpankMe
08-13-2005, 06:24 AM
I did the new product installation process via the VB admin CP. No problem. I just added the columns manually and all ok. Thanks anyway.
Installed and works well .. very useful addition.
I am using this extra (https://vborg.vbsupport.ru/showpost.php?p=632889&postcount=944) item which certainly saves time in adding to the database of links, however, the code seems to disable the scroll bars in IE6 .. anyone else having the same problems.
lttcoder
08-13-2005, 10:37 PM
is it possible to add images to description. or links to image.
AndrewD
08-14-2005, 05:43 AM
is it possible to add images to description. or links to image.
There are two ways. You are free to include IMG tags (or any other BBCodes) within individual descriptions. That is very flexible but you may not get a systematic layout if the images are different sizes.
Alternatively, you can go to the product's admin settings page and set the parameter link_imagesize. In that case, when you create the link/download, you also specify a thumbnail file/url, which is displayed, rescaled to link_imagesize pixels in size at the left of the entry. This requires that your php installation has the GD2 library available.
Boofo
08-14-2005, 05:48 AM
What did you update yesterday for this, sir? ;)
AndrewD
08-14-2005, 05:49 AM
Installed and works well .. very useful addition.
I am using this extra (https://vborg.vbsupport.ru/showpost.php?p=632889&postcount=944) item which certainly saves time in adding to the database of links, however, the code seems to disable the scroll bars in IE6 .. anyone else having the same problems.
You've probably got a space character in your Javascript. Slave warned about this - VB.org has introduced some unwanted spaces.
Make sure that your Javascript url says "scrollbars=1" not "scrollbar s=1"
AndrewD
08-14-2005, 05:59 AM
What did you update yesterday for this, sir? ;)
Just the text - I noticed I'd missed out something.
Boofo
08-14-2005, 06:00 AM
Just the text - I noticed I'd missed out something.
Oh, you mean in the first post?
AndrewD
08-14-2005, 06:42 AM
I sort links by date in descending order, and when I validate all links, it forgets which ones were uploaded last and screws around with the order they are displayed. Is there a fix for this?
I realise that this was a 'feature' which I included a long time ago. When the validation finds that the file has changed size, it treats it as new and changes the datestamp. I think this is probably an unwanted feature, so will remove it in 2.0.2, so that dates of submission should not change. Version 2.0.2 also has per-category preferred sort orders.
lttcoder
08-14-2005, 05:21 PM
Ok I am switching from Vbdownloads to Links and downloasd manager 2.0.1 mainly because I am tired of the support I get there. And there is a search bug that pisses me off.
lttcoder
08-15-2005, 12:29 PM
I installed this.
And when I go to categories page I cannot see any "Create new category button" only this screen
https://vborg.vbsupport.ru/ (http://img339.imageshack.us/my.php?image=locallinks1xx.jpg)
And when I click on the SUBMIT button (the only button on that page)
I get this error
Invalid SQL:
UPDATE local_linkscat SET
catclosed=1
WHERE catid IN (0,);
MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3
Error Number : 1064
Date : Monday, August 15th 2005 @ 05:05:31 AM
Script : http://www.opensc.ws/local_links_admin.php
Referrer : http://www.opensc.ws/local_links_admin.php?action=admin&set=categories
IP Address : *.*.*.*
Username : LttCoder
Classname : vb_database
AndrewD
08-15-2005, 01:36 PM
I installed this.
And when I go to categories page I cannot see any "Create new category button" only this screen
http://img339.imageshack.us/img339/1927/locallinks1xx.th.jpg (http://img339.imageshack.us/my.php?image=locallinks1xx.jpg)
And when I click on the SUBMIT button (the only button on that page)
I get this error
Invalid SQL:
UPDATE local_linkscat SET
catclosed=1
WHERE catid IN (0,);
MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3
Error Number : 1064
Date : Monday, August 15th 2005 @ 05:05:31 AM
Script : http://www.opensc.ws/local_links_admin.php
Referrer : http://www.opensc.ws/local_links_admin.php?action=admin&set=categories
IP Address : *.*.*.*
Username : LttCoder
Classname : vb_database
I'll check the error - probably the link you hit was not supposed to be hit with an empty database.
To create a new category, select the drop down menu under Category (the new banner menu) and chose Home Category. That takes you to the base Category. The menu now has a new item, Add Category, which allows you to create your first category. After you create the category, the menu will have a new item on it Add Link
lttcoder
08-15-2005, 06:03 PM
Andrew, I doesnt display the "ADD CATEGORY". Is there a way you can sign-up at my forums, and I'll give u privileges to create/manage links??
AndrewD
08-16-2005, 04:04 AM
Andrew, I doesnt display the "ADD CATEGORY". Is there a way you can sign-up at my forums, and I'll give u privileges to create/manage links??
By all means - but where is your board? Maybe you can create me an account with administrator privs and send me a private message with the details?
lttcoder
08-16-2005, 03:01 PM
AndrewD, check private message.
lttcoder
08-16-2005, 03:48 PM
ok problem solved, the "add category" isnt showing on Internet Explorer 7 beta.
Else it works fine.
AndrewD
08-16-2005, 05:00 PM
Version 2.0.2 uploaded - comments please.
Boofo
08-16-2005, 05:15 PM
What do we need to do to go from 2.01 to 2.02?
lttcoder
08-16-2005, 05:15 PM
<font color="DarkOliveGreen">* LttCoder signs petition for upload capability/integration</font>
AndrewD
08-16-2005, 05:23 PM
What do we need to do to go from 2.01 to 2.02?
You just upload the php files, then reinstall product_eirma-ldm.xml via the VB Product Manager. Select Add/Import Product, upload product_eirma-ldm.xml, making sure you select Allow Overwrite.
Boofo
08-16-2005, 06:01 PM
I ididn't see where this setting was. Did I miss it?
admin settings include a master title for the LDM database, used in navbar
AndrewD
08-16-2005, 06:25 PM
I ididn't see where this setting was. Did I miss it?
Administer -> Settings and Permissions -> database_name
Maybe the explanation was a bit terse :devious:
Boofo
08-16-2005, 06:33 PM
Ahhh, cryptic. ;)
It didn't like this:
Fathers' Rights Links
It gave a db error when I used the apostrophe. ;)
AndrewD
08-17-2005, 04:48 AM
Ahhh, cryptic. ;)
It didn't like this:
Fathers' Rights Links
It gave a db error when I used the apostrophe. ;)
Ouch - forgot to catch quotes - thanks
Boofo
08-17-2005, 06:03 AM
Also, on your statistics page under validate, you have this:
all broken invalid
The broken and invalid are 2 separate links. ;)
Boofo
08-17-2005, 06:19 AM
Yes, these are two different possibilities - a link may be valid but broken (e.g. www.site.com (http://www.site.com/), where site.com exists but is down) or invalid - someonne has entered a link which is syntactically incorrect
Sorry, I guess I didn't explain it very well. What I meant was it looks as though there is one line under both links. It makes it look like one link instead of 2. ;)
AndrewD
08-17-2005, 06:20 AM
Sorry, I guess I didn't explain it very well. What I meant was it looks as though there is one line under both links. It makes it look like one link instead of 2. ;)
OK, got you, thanks
Boofo
08-17-2005, 06:24 AM
It wasn't major, just a display bug is all. ;)
Boofo
08-17-2005, 06:55 AM
Does this also have the apostrophe fix?
AndrewD
08-17-2005, 08:55 AM
Does this also have the apostrophe fix?
No, that requires a change to the code, which I need to think about.
Boofo
08-17-2005, 08:58 AM
addslashes and stripslashes should do it. ;)
Installed/upgraded on RC2 and running nicely. Great job as always :up:. Am adding a slew of content to it and will take it public on my board shortly.
I notice your installer still insists on prefixing the links tables with local_, so rather than hack the code I finally relented and just changed my links_ prefixes to comply. No big deal but that local_ prefix still bugs me some. I know you did this to match your file prefixes but in the overall db schema it really doesn't make sense. Maybe I'll get used to it :).
Regardless, thanks for providing this. I'm willing to declare it as one of the (if not the) best supported and developed hacks at vb.org.
AndrewD
08-20-2005, 06:47 AM
Installed/upgraded on RC2 and running nicely. Great job as always :up:. Am adding a slew of content to it and will take it public on my board shortly.
I notice your installer still insists on prefixing the links tables with local_, so rather than hack the code I finally relented and just changed my links_ prefixes to comply. No big deal but that local_ prefix still bugs me some. I know you did this to match your file prefixes but in the overall db schema it really doesn't make sense. Maybe I'll get used to it :).
Regardless, thanks for providing this. I'm willing to declare it as one of the (if not the) best supported and developed hacks at vb.org.
I appreciate your kind remarks, thanks.
Probably the table prefix does need rethinking, now that we have full product support in VB. Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?
Boofo
08-20-2005, 07:25 AM
I appreciate your kind remarks, thanks.
Probably the table prefix does need rethinking, now that we have full product support in VB. Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?
I think that would be a good idea as it would allow us to know which tables are vb tables and which tables have been added for a specific mod/hack.
Perhaps tables should use a product prefix (e.g. this one would be LDM). I want to keep this clearly separate from VB. What do you think?
I agree product tables should be differentiated from those used by VB. I could live with an ldm_ table prefix. However, your code is already setup to allow for user-defined prefixes. I just get kinda stumped that it never asks me what mine are during the upgrade process.
Regardless, I realize this is a nitpickery db-geek thing that has nothing to do with the functionality of your script. Out of close to 300 people having installed the VB 3.0.X version I seem to be the only one having an issue with it :). I just like my database to make as much sense as possible, is all.
lttcoder
08-21-2005, 02:28 PM
Upgrade doesnt work from 2.0.2->> 2.0.3
Critical error: different versions of software, templates, phrases and database.
Software: 2.0.3 database: 2.0.2
Cannot continue - ask administrator to correct.
lttcoder
08-21-2005, 02:41 PM
I uninstalled the old one and clean installed the new.
It works fine, I like the little box at the bottom telling my settings :)
Links and Downloads Database
Code 2.0.3
MySQL 4.1.13a-Debian_1-log
PHP 4.3.10
allow_url_fopen No
cURL Yes
GD2 Yes
open_basedir
AndrewD
08-21-2005, 02:50 PM
I uninstalled the old one and clean installed the new.
It works fine, I like the little box at the bottom telling my settings :)
Links and Downloads Database
Code 2.0.3
MySQL 4.1.13a-Debian_1-log
PHP 4.3.10
allow_url_fopen No
cURL Yes
GD2 Yes
open_basedir
OK, seems to work fine - not sure what went wrong with the upgrade - ran fine for me.
I added a remote file download - worked ok - removed it again from your d/b
Boofo
08-21-2005, 10:41 PM
Won't we lose our links doing it that way?
WhisperPntr
08-22-2005, 01:40 AM
This is an amazing hack Andrew. If in the future I make changes to this code, ie an addon or port to function with another code, would you mind my asking permission to release modifications? All credit for the original hack would be yours btw and any modifications will be documented.
And thanks for being such a good sport handling the questions :) It makes me wonder if you work full time as a customer service rep...though on that note most of them don't have the same charm and capability you've shown. :)
AndrewD
08-22-2005, 04:02 AM
Won't we lose our links doing it that way?
The upgrade should work properly - I don't understand why Ltlcoder had difficulties.
However, uninstalling and reinstalling is also ok, as the database tables are not deleted during uninstallation. (There's another script to run if you really want to kill LDM.)
If you are concerned, best idea is always to back up the local_xx tables before running an upgrade.
AndrewD
08-22-2005, 04:05 AM
If in the future I make changes to this code, ie an addon or port to function with another code, would you mind my asking permission to release modifications? All credit for the original hack would be yours btw and any modifications will be documented.
Please feel free. My only concern would be if we started having separate streams of code that have to be kept in sync - we'd need to be careful how this was managed.
For the first time since installing this I visited my style manager to make a few template tweaks, to discover LDM has added all its templates alphabetically to the main forum templates list rather than to a "Custom templates" set. If you insist on going ahead with this method could you at least subcategorize the LDM templates so they can be collapsed? Adding no less than 40 links_ templates to the main display is cumbersome at best.
AndrewD
08-23-2005, 03:59 AM
For the first time since installing this I visited my style manager to make a few template tweaks, to discover LDM has added all its templates alphabetically to the main forum templates list rather than to a "Custom templates" set. If you insist on going ahead with this method could you at least subcategorize the LDM templates so they can be collapsed? Adding no less than 40 links_ templates to the main display is cumbersome at best.
Welo, yes, will do - it's been a matter of gradually working out how everything in VB35 works, so that everything slots in smoothly.
AndrewD
08-23-2005, 03:33 PM
Having made a quick check on Welo's suggestion, the best way to group these templates is through a plugin attached to template_groups:
$only['links_'] = 'Links and Database Manager';
I will include this in the release, but - Welo - you might like to check that this works for you.
Boofo
08-23-2005, 04:41 PM
Will the apostrophe fix for the db name be in the new version, also? ;)
AndrewD
08-23-2005, 05:26 PM
Will the apostrophe fix for the db name be in the new version, also? ;)
It's already in 2.0.3, a few posts up. Should be ok - maybe you can give it a try?
Boofo
08-23-2005, 07:06 PM
No problem, sir. ;)
Do I need to upload files is all then?
Boofo
08-23-2005, 07:22 PM
Just tested it and the apostrophe problem is now fixed. ;)
Is CURL actually better to use with this or the other way? I apparently have CURL installed on the server. Or is CURL only for remote file links?
AndrewD
08-24-2005, 04:13 AM
Just tested it and the apostrophe problem is now fixed. ;) Good!
Is CURL actually better to use with this or the other way? I apparently have CURL installed on the server. Or is CURL only for remote file links?
I don't know which is better/faster/etc - some advisors recommend that allow_url_fopen() is turned off, because this improves overall site security, but as far as LDM is concerned, I'm not sure that it makes any difference.
cURL is only being used for remote file links and remote thumbnails. This includes local files and thumbnails if these are set up with a complete url rather than a relative filename. The code tries the fopen() route first before falling back onto cURL.
Boofo
08-24-2005, 09:24 AM
Ahhh, ok, sinve I have remore files truned off, then it doesn't even use CURL, right? I think I get it now. ;)
Having made a quick check on Welo's suggestion, the best way to group these templates is through a plugin attached to template_groups:
$only['links_'] = 'Links and Database Manager';
I will include this in the release, but - Welo - you might like to check that this works for you.
Woo-hoo! Much nicer. :up:
GrendelKhan{TSU
08-26-2005, 05:39 AM
as to the "allow_url_fopen" issue....
can someone tell me WHERE or HOW to actually turn it ON? (mine is off, but I want it on...but don't know where to go to do this) :/
AndrewD
08-26-2005, 05:42 AM
as to the "allow_url_fopen" issue....
can someone tell me WHERE or HOW to actually turn it ON? (mine is off, but I want it on...but don't know where to go to do this) :/
allow_url_fopen is set in the php.ini file. Depending on how your site is handled, either you or your ISP must edit this file. If your ISP has turned it off, it is likely to be because they think it is a security risk, in which case you will have to go the cURL route (configure php to access the curl library)
GrendelKhan{TSU
08-26-2005, 06:31 AM
allow_url_fopen is set in the php.ini file. Depending on how your site is handled, either you or your ISP must edit this file. If your ISP has turned it off, it is likely to be because they think it is a security risk, in which case you will have to go the cURL route (configure php to access the curl library)
ok...contacted them but waiting for a reply.
in the meantime (cause I have a feel they won't turn it on for me).....
how do I go about using the cURL route? Is that something I have to request from my ISP as well? Then what?
This error is flagged if you enter something in the monitor_dir text box and the code can't find a directory that matches. But your error message suggests that you haven't put anything in this box? Do you get this error every time you try to change admin settings?
sorry. been working on other parts of my board...and just got to this. :ninja:
yes. I get this error everytime.
the monitor_dir box is empty.
any help would be greatly appreciated...this hack RULES!! I can't edit ANY of my settings right now. :/
AndrewD
08-26-2005, 06:35 AM
ok...contacted them but waiting for a reply.
in the meantime (cause I have a feel they won't turn it on for me).....
how do I go about using the cURL route? Is that something I have to request from my ISP as well? Then what?
sorry. been working on other parts of my board...and just got to this. :ninja:
yes. I get this error everytime.
the monitor_dir box is empty.
any help would be greatly appreciated...this hack RULES!! I can't edit ANY of my settings right now. :/
Could you create me an account with admin privs and send me a PM - also the URL of your (VB308/VB35??) forums so that I can take a look?
GrendelKhan{TSU
08-26-2005, 07:11 AM
Could you create me an account with admin privs and send me a PM - also the URL of your (VB308/VB35??) forums so that I can take a look?
done. :D
GenSec
08-26-2005, 10:00 AM
Seaching link:
Fatal error: Call to undefined function get_linksratings() in C:\Apache2\htdocs\upload\local_links.php on line 580
I couldn't find function get_linksratings too
AndrewD
08-26-2005, 10:10 AM
Seaching link:
I couldn't find function get_linksratings too
Yup, it was removed in a recent release but I forgot to remove this call. Just comment out the call to get_linksratings on line 580 of local_links.php.
This kills the search facility as you have observed. Sorry about that...
GenSec
08-26-2005, 10:36 AM
Thanks for so fast reply!
The hack is excellent!!!
GrendelKhan{TSU
08-29-2005, 11:10 AM
n00b questions:
how do you add/use all the cool icons you have included in the zip?
what is the Template.xml file with the zip? what does that template look like? and the "codes.xml"....are we supposed to do something with that?
<<< n00b confused easily. :( :p
AndrewD
08-29-2005, 11:15 AM
n00b questions:
how do you add/use all the cool icons you have included in the zip?
what is the Template.xml file with the zip? what does that template look like? and the "codes.xml"....are we supposed to do something with that?
<<< n00b confused easily. :( :p
It is all explained in the 'instructions.txt'
You don't need to do anything with the template or code file. These have already been packaged into the product xml file. They're included in the zip for completeness.
To use the icons, upload as a subdirectory onto your site, then tell the LDM admin page which directory to use (settings and permissions/file_icons_dir)
GrendelKhan{TSU
08-30-2005, 03:47 AM
It is all explained in the 'instructions.txt'
You don't need to do anything with the template or code file. These have already been packaged into the product xml file. They're included in the zip for completeness.
To use the icons, upload as a subdirectory onto your site, then tell the LDM admin page which directory to use (settings and permissions/file_icons_dir)
DOH! thanks!!^^ :nervous:
AndrewD
08-30-2005, 05:39 PM
Links and Downloads Manager 2.0.4 uploaded as the supported release. Mainly bug fixes (oh I am so embarassed by the broek search command..):
- LDM template group created within main VB admincp style display
- Uses cURL library if available when *allow_url_fopen* is switched off in php.ini
- bugs fixed
reporting of access permissions in admin/categories
redirection after moderate link
navbar and title settings when texts include bbcodes
handling of unset monitor_dir
search facility (broken since v2.00 alpha 1!!)
mass edits
addslashes check on admin param settings
To upgrade, re-upload the code files and then re-import the product file via the VB admincp
GrendelKhan{TSU
09-09-2005, 08:16 PM
Links and Downloads Manager 2.0.4 uploaded as the supported release. Mainly bug fixes (oh I am so embarassed by the broek search command..):
- LDM template group created within main VB admincp style display
- Uses cURL library if available when *allow_url_fopen* is switched off in php.ini
- bugs fixed
reporting of access permissions in admin/categories
redirection after moderate link
navbar and title settings when texts include bbcodes
handling of unset monitor_dir
search facility (broken since v2.00 alpha 1!!)
mass edits
addslashes check on admin param settings
To upgrade, re-upload the code files and then re-import the product file via the VB admincp
Awesome :D
BUG: I think...
the default sort order doesn't seem to want to change no matter what I set it to. :/ or that could be just mine. :(
AndrewD
09-10-2005, 05:07 AM
Awesome :D
BUG: I think...
the default sort order doesn't seem to want to change no matter what I set it to. :/ or that could be just mine. :(
You're right - sorry about that. It will be fixed in 2.0.5 in a few days.
If it's urgent, you can edit local_links.php. Find line 386:
default:
$sort = $vbulletin->GPC['sort'];
if ($sort == "") {
$sort = iif($linkscat["$viewcatid"]['catsortorder'] == ' ',
iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N'),
$linkscat["$viewcatid"]['catsortorder']);
}
and change to
default:
$sort = $vbulletin->GPC['sort'];
if ($sort == "") {
$sort = iif(trim($linkscat["$viewcatid"]['catsortorder']),
$linkscat["$viewcatid"]['catsortorder'],
iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N')
);
}
Sadie Frost
09-11-2005, 02:58 AM
I'm having a little problem installing this - when I try to add the product, I get this error:
Links and Downloads Manager
Checking installation status...
Currently installed version: 2.0.4
Checking environment...
Environment checked
Creating/Verifying database tables
--------------------------------------------------------------------------------
Step 1 - Verifying database tables
Fatal error: Call to a member function on a non-object in /path/to/forums/includes/local_links_admininclude.php on line 414
Anyone have any ideas? Thanks :)
AndrewD
09-11-2005, 05:50 AM
I'm having a little problem installing this - when I try to add the product, I get this error:
Anyone have any ideas? Thanks :)
Sorry about that - you must be the first person who's used this to upgrade from version 1.50 or earlier, as you've hit a bad line of code to deal with that situtation.
I've repaired the zip file in the first post - please redownload and reinstall - you'll probably have to use the product manager to uninstall LDM first (don't worry, you won't lose your database tables).
Alternatively, just edit links_admininclude.php, go to line 414 and change the two adjacent dollar signs
$asb = $$db->query_write("
into a single dollar sign:
$asb = $db->query_write("
Sadie Frost
09-11-2005, 02:49 PM
Oh thank you so much Andrew! Yeah I hadn't updated the hack on my board in a while lol
lttcoder
09-11-2005, 09:06 PM
you planning any vbadvanced addon?
displaying latest 10 links?
AndrewD
09-12-2005, 03:59 AM
you planning any vbadvanced addon?
displaying latest 10 links?
There is some code and instructions available in the 'Natch' directory for this - I haven't tested it recently, as I don't use vbadvanced. Are you able to check?
Boofo
09-12-2005, 07:31 AM
Andrew, this template is showing up as uncached when you edit a category. ;)
links_styleselect
I added it to local_links.php under globaltemplates.
Also, on the mext release, would you please put the files in the forums dirs in your file to make easier uploading? I always have to try to rememeber where they go. ;)
Thank you, sir, and great Mod! ;)
AndrewD
09-12-2005, 07:34 AM
Andrew, this template is showing up as uncached when you edit a category. ;)
I added it to local_links.php under globaltemplates.
Also, on the next release, would you please put the files in the forums dirs in your file to make easier uploading? I always have to try to rememeber where they go. ;)
Thank you, sir, and great Mod! ;)
Thanks, Bob! Will do.
Viperlx
09-20-2005, 06:26 AM
How do I set the directory? Nothing is working.
GrendelKhan{TSU
09-20-2005, 12:22 PM
You're right - sorry about that. It will be fixed in 2.0.5 in a few days.
If it's urgent, you can edit local_links.php. Find line 386:
default:
$sort = $vbulletin->GPC['sort'];
if ($sort == "") {
$sort = iif($linkscat["$viewcatid"]['catsortorder'] == ' ',
iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N'),
$linkscat["$viewcatid"]['catsortorder']);
}
and change to
default:
$sort = $vbulletin->GPC['sort'];
if ($sort == "") {
$sort = iif(trim($linkscat["$viewcatid"]['catsortorder']),
$linkscat["$viewcatid"]['catsortorder'],
iif(isset($links_defaults['default_sort_order']), $links_defaults['default_sort_order'], 'N')
);
}
thanks!! :D
GrendelKhan{TSU
09-20-2005, 12:31 PM
suggestion/request:
ok. I'm constantly going back and forth between which system I want to use....
this one or ecDownloads.
Right now I'm with this one for various reasons....but 2 things keep bringing me back to wanting to put ecDownloads on as well or in lieu of (to be honest).
1. the fact that you can direct UPLOAD to the forum server. (this the main thing).
2. the layout of SHOWING the top downloads/new downloads. (not in a drop down menu.) the looks is clean and better, imo than LDM, in that regard (only).
right now, LDM is winning out cause of functionality and listing (it looks better and cleaner).
but the not having a direct upload is a drag.
Any chance of getting that into the next versoin (the uploads)? as far as I can tell that would be deathnoll for ecDownloads for me. I wouldn't think twice about using this one.
the listing of the new/popular uploads is close second.
this is just just imho. :D but I only mention it cause I do love this addon. :)
Meltingfire
09-20-2005, 03:10 PM
suggestion/request:
ok. I'm constantly going back and forth between which system I want to use....
this one or ecDownloads.
Right now I'm with this one for various reasons....but 2 things keep bringing me back to wanting to put ecDownloads on as well or in lieu of (to be honest).
1. the fact that you can direct UPLOAD to the forum server. (this the main thing).
2. the layout of SHOWING the top downloads/new downloads. (not in a drop down menu.) the looks is clean and better, imo than LDM, in that regard (only).
right now, LDM is winning out cause of functionality and listing (it looks better and cleaner).
but the not having a direct upload is a drag.
Any chance of getting that into the next versoin (the uploads)? as far as I can tell that would be deathnoll for ecDownloads for me. I wouldn't think twice about using this one.
the listing of the new/popular uploads is close second.
this is just just imho. :D but I only mention it cause I do love this addon. :)
Is there any possibility to integrate this in vbAdvanced as with vBindex?
Im currently running vBindex together with links on the 3.0.x but want to upgrade to 3.5 as soon as possible.
AndrewD
09-20-2005, 06:34 PM
suggestion/request:
ok. I'm constantly going back and forth between which system I want to use....
this one or ecDownloads.
Right now I'm with this one for various reasons....but 2 things keep bringing me back to wanting to put ecDownloads on as well or in lieu of (to be honest).
1. the fact that you can direct UPLOAD to the forum server. (this the main thing).
2. the layout of SHOWING the top downloads/new downloads. (not in a drop down menu.) the looks is clean and better, imo than LDM, in that regard (only).
right now, LDM is winning out cause of functionality and listing (it looks better and cleaner).
but the not having a direct upload is a drag.
Any chance of getting that into the next versoin (the uploads)? as far as I can tell that would be deathnoll for ecDownloads for me. I wouldn't think twice about using this one.
the listing of the new/popular uploads is close second.
this is just just imho. :D but I only mention it cause I do love this addon. :)
I deliberately kept away from offering uploads with the vb 3.0 version, for a number of reasons. I'm prepared to rethink that decision with vb 3.5, but it's a matter of finding the time to code and test. Let me check it out.
As for the layout of new links/hot links, that's probably straightforward to address. Again, I'll take a look.
I'm not terribly interested in getting into a 'feature' race with another hack - I'd rather that this one does what it claims to do and is reliable.
AndrewD
09-20-2005, 06:35 PM
Is there any possibility to integrate this in vbAdvanced as with vBindex?
Im currently running vBindex together with links on the 3.0.x but want to upgrade to 3.5 as soon as possible.
The version 3.0 code did intergrate with vbadvanced, as far as I know. When I have a chance to look, I'll test it out.
AndrewD
09-20-2005, 06:37 PM
How do I set the directory? Nothing is working.
If your site is 'Broken Surf Forums', it looks as if everything is installed properly - what's the problem?
GrendelKhan{TSU
09-20-2005, 07:17 PM
I'm prepared to rethink that decision with vb 3.5, but it's a matter of finding the time to code and test. Let me check it out.
As for the layout of new links/hot links, that's probably straightforward to address. Again, I'll take a look.
that would be awesome if you could. I know its a huge investment of time ...but I still got my fingers crossed.
I'm not terribly interested in getting into a 'feature' race with another hack - I'd rather that this one does what it claims to do and is reliable.
fair enough. that's not really what I wanted to imply either. both are great hacks.
just as a "consumer"... its such a waste to have to use both hacks to get to use features that are wanted/needed. it still comes down to a person's personal preference, I'm just saying, I'd choose this hack definitively if those two things alone where a part of the hack (and I'll assert that other people would as well).
NOT trying to breed competittion... just being selfish and saying what I love if you could throw in. ;) :p :D heehee.
in any case, thanks for the all the help and this awesome hack. :D I'll keep checking in and reporting any bugs or whatever if I find em. :nervous:
Viperlx
09-20-2005, 09:27 PM
If your site is 'Broken Surf Forums', it looks as if everything is installed properly - what's the problem?
are you going to the map downloads section? Thats edownloads but with yours I can't set a directory.
AndrewD
09-21-2005, 04:14 AM
are you going to the map downloads section? Thats edownloads but with yours I can't set a directory.
No, I went to http://brokensurf.com/forums/local_links.php, where I can see an empty installation.
I'm not sure I understand 'can't set a directory' - do you mean you can't set a value for monitor_dir? PM me with an admin account + more details, and I'll gladly take a look.
Viperlx
09-21-2005, 07:54 PM
I need to set the local_file_root and monitor_dir but i am not sure how.
AndrewD
09-22-2005, 04:31 AM
I need to set the local_file_root and monitor_dir but i am not sure how.
Logged on as an admin, you either go to local_links.php and select Admin/Settings and Permissions, or you go directly to local_links_admin.php. You'll find the whole set of permissions/settings there.
You set local_file_root either to 0 or 1. If you set it to zero, then any subsequent download file which is identified using a local directory/file name (e.g. /dir/file.pdf) is assumed to sit at http://yoursite/dir.pdf. If you set it to 1, then it is actually assumed to be /dir/file.pdf in terms of the web server's file system.
Advantage of using 1 is to hide files from prying eyes, but you then need to be careful who has permission to set up new downloads, so that they don't start linking to systems files you want to keep private.
Depending on how you set local_file_root, you might also want to set local_file_root_prefix. This is simply a string that gets added to the front of all local directory/files, e.g. if you set it to /dir2, then the previous example will automatically map to /dir2/dir/file.pdf
You can set monitor_dir on the same page, or on the admin/import & export page. It holds one or a comma separated list of directories, any of which can end with a wild card *., e.g. /dir1 or /dir1/* It defines the directory(ies) which are searched during an Admin/Import & Export/Scan for new files
Boofo
09-22-2005, 04:41 AM
AndrewD, was version 2.0.5 going to be released anytime soon? Just checking, sir. ;)
AndrewD
09-22-2005, 05:01 AM
AndrewD, was version 2.0.5 going to be released anytime soon? Just checking, sir. ;)
It's sitting live on my site, but I'd held off because the changes are deep in the guts and I want to be sure that there are no new bugs. I also thought I'd deal with the questions about VbAdvanced and a prettier 'front page', see a few posts back. Perhaps this weekend.
Boofo
09-22-2005, 05:06 AM
It's sitting live on my site, but I'd held off because the changes are deep in the guts and I want to be sure that there are no new bugs. I also thought I'd deal with the questions about VbAdvanced and a prettier 'front page', see a few posts back. Perhaps this weekend.
Ok, just checking, sir. ;)
If you need any help testing, let me know. ;)
elsupremo
09-25-2005, 02:05 AM
Hi Andrew, I just installed your hack after installing a Download hack by a different creator. I must say that your hack is vastly superior in both functionality and layout. I am very impressed and grateful for your time and effort in creating this hack. I only have one question:
I would like for users to be able to add more than one comment. I am hoping that this is an easy thing to be able to implement, and if you could tell me how to enable more than one comment I would be very grateful.
If there is no practical way to implement this, would it perhaps be easier to link the comments to an active forum thread?
Any help with this one thing is truly appreciated.
Best,
Dave
AndrewD
09-25-2005, 04:45 AM
I would like for users to be able to add more than one comment. I am hoping that this is an easy thing to be able to implement, and if you could tell me how to enable more than one comment I would be very grateful.
If there is no practical way to implement this, would it perhaps be easier to link the comments to an active forum thread?
Thanks for your kind words.
The code as written stops people from having more than one comment. It's not hard to change - and I can easily add this to the 'to do' list - but I'd welcome thoughts on the following:
- Should a user also be able to provide more than one rating?
- Should her first or last or average rating be counted?
- Should she also be able to edit all her previous comments and ratings?
- The admin currently decides which user groups can add comments at all. Should the admin also decde if they can add multiple comments, or should this be the same for everything.
The current solution is 'one comment and one rating, both of which can be edited/changed'. I think the alternative would be 'multiple comments, one rating, all of which can be changed'.
By the way, I don't want to provide as fancy an editor as is used for the main VB forums - simply text edit, with BBCodes, etc, is straightfoward to maintain.
Thoughts?
elsupremo
09-25-2005, 04:53 AM
Thanks for your kind words.
The code as written stops people from having more than one comment. It's not hard to change - and I can easily add this to the 'to do' list - but I'd welcome thoughts on the following:
- Should a user also be able to provide more than one rating?
- Should her first or last or average rating be counted?
- Should she also be able to edit all her previous comments and ratings?
- The admin currently decides which user groups can add comments at all. Should the admin also decde if they can add multiple comments, or should this be the same for everything.
The current solution is 'one comment and one rating, both of which can be edited/changed'. I think the alternative would be 'multiple comments, one rating, all of which can be changed'.
By the way, I don't want to provide as fancy an editor as is used for the main VB forums - simply text edit, with BBCodes, etc, is straightfoward to maintain.
Thoughts?
Your alternative of multiple comments, one rating, all of which can be edited seems very good to me.
I am very in need of the functionality of multiple comments, so that users may correspond with each other in their comments re: the video. Almost like a mini-forum within the download section (since your download/link hack is now becoming a centerpiece of the entire forum).
So, with that in mind, my vote would be the multiple comments, one rating, all of which can be edited.
Boofo
09-25-2005, 05:21 AM
I agree with the multiple conmments and one rating idea. I don't think the user should be ablle to edit their comments or ratings. That might lead to abuse of the implamentation of it. The only ones who should be able to have those editing permissions would be those that have moderating status of the links. Just my 2 1/2 cents worth. ;)
Boofo
09-26-2005, 04:08 PM
Now that you've got things a little easier to upload, I'll give it a shot, sir. ;)
Boofo
09-26-2005, 04:51 PM
Andrew, I'm getting this nasty error now whenever I try to access the links db or the settings for it.
Critical error: different versions of software, templates, phrases and database.
Software: 2.0.5 database: 2.0.4
Cannot continue - ask administrator to correct.
AndrewD
09-26-2005, 04:54 PM
Andrew, I'm getting this nasty error now whenever I try to access the links db or the settings for it.
Just uninstall and reinstall via the VB products page. I'll check - I've probably forgotten to update something.
Boofo
09-26-2005, 05:00 PM
Just uninstall and reinstall via the VB products page. I'll check - I've probably forgotten to update something.
Will that delete the links already there?
AndrewD
09-26-2005, 05:01 PM
Will that delete the links already there?
No - it leaves the database intact
Boofo
09-26-2005, 05:02 PM
Now I'm getting this error:
Fatal error: Cannot redeclare cache_styles() (previously declared in /xxxx/xxxx/xxxxxx_xxxx/xxxxxx/includes/adminfunctions_template.php:2190) in /xxxx/xxxx/xxxxxx_xxxx/xxxxxx/includes/local_links_include.php on line 497
AndrewD
09-26-2005, 05:07 PM
Now I'm getting this error:
That is not something I get - which version of VB are you using?
I'm out of time with my internet connection - should be back on line tomorrow evening.
Boofo
09-26-2005, 05:11 PM
3.5 Rc 3.
AndrewD
09-26-2005, 05:13 PM
3.5 Rc 3.
Will have to investigate - I don't understand at the moment.
Boofo
09-26-2005, 05:35 PM
Ok, I got it working. I cleared my cache and that seemed to fix it for some reason. It must have been using the old file.
I noticed the What's Hot table at the top seems to be a little off. But other than that, it look ok so far.
elsupremo
09-27-2005, 04:08 AM
<very thankful>Andrew - I'm loving the comments system. Thank you. Loving the whole new release, actually.
</very thankful>
elsupremo
09-27-2005, 05:28 AM
One bug popped up - I used the scan function to bring in about 24 files. However, now when I navigate to that category, when I get into the category, the dropdown menus do not work. This was only the case for that one category. Then I changed attributes of all of the links in that category, essentially moving them to a different category. Now, THAT new category had the problem (no dropdowns available), and the old link that used to have the problem now had fully functional drop-downs. Whatever directory has the links that I scanned in (mpg's, avi's and wmv's) now has no drop-down functionality. The standard link buttons still work fine (Moderate, Addlink, etc.)
I also replicated the problem in both Mozilla Firefox and IE, including clearing my cache and trying again. It did not fix it.
AndrewD
09-27-2005, 10:48 AM
One bug popped up - I used the scan function to bring in about 24 files. However, now when I navigate to that category, when I get into the category, the dropdown menus do not work. This was only the case for that one category. Then I changed attributes of all of the links in that category, essentially moving them to a different category. Now, THAT new category had the problem (no dropdowns available), and the old link that used to have the problem now had fully functional drop-downs. Whatever directory has the links that I scanned in (mpg's, avi's and wmv's) now has no drop-down functionality. The standard link buttons still work fine (Moderate, Addlink, etc.)
I also replicated the problem in both Mozilla Firefox and IE, including clearing my cache and trying again. It did not fix it.
Can I hazard a guess? The category in which you have imported the entries now has more than one page of entries - so there is a page navigator section?? And you have customised some of the standard VBulletin templates (I think the header or navbar template?) This combination kills the drop downs, because of some incompatibilities between the javascripts. You have to revert the standard VB templates then reimplement your changes into the VB3.5 templates.
Let me know if I'm wrong - I had this problem myself a month or so back, but it doesn't happen now that I've fixed the standard templates.
AndrewD
09-27-2005, 10:58 AM
Ok, I got it working. I cleared my cache and that seemed to fix it for some reason. It must have been using the old file.
I noticed the What's Hot table at the top seems to be a little off. But other than that, it look ok so far.
I wonder if you have other hacks installed that use the adminfunctions_template code. In any case, I'm modifying the code to trap the 'multiple loading' bug.
Not sure what you mean by the table seeming a little off? Wrong counts or what?
Boofo
09-27-2005, 11:04 AM
I wonder if you have other hacks installed that use the adminfunctions_template code. In any case, I'm modifying the code to trap the 'multiple loading' bug.
It seemed to work fine after I emptied my IE cache. It gave me the error one time right after emptying it and then started working ok.
Not sure what you mean by the table seeming a little off? Wrong counts or what?
No, the header table that has What's Hot in it. It looks like it has a blank <tr> in it at the bottom. I haven't looked it it yet, but it looks like the is an extra line at the bottom of it. Just a cosmetic thing. ;)
elsupremo
09-27-2005, 05:37 PM
Can I hazard a guess? The category in which you have imported the entries now has more than one page of entries - so there is a page navigator section?? And you have customised some of the standard VBulletin templates (I think the header or navbar template?) This combination kills the drop downs, because of some incompatibilities between the javascripts. You have to revert the standard VB templates then reimplement your changes into the VB3.5 templates.
Let me know if I'm wrong - I had this problem myself a month or so back, but it doesn't happen now that I've fixed the standard templates.
Exactly correct. Bravo, bravo. Thank you. :)
rfairbairn
09-27-2005, 06:33 PM
Can a form be created to allow users to add links, but not going into too much detail as the add link form currently does, i.e. just a description, url and name of site ? no other settings, they would be added on moderation?
elsupremo
09-28-2005, 05:27 AM
Andrew - here is the includes file I Pm'd you about. I know it's sloppy and I don't know what I'm doing, but here it is anyways. :)
For anyone else who's curious, I am adding a lot of .jpg's to my site using the "Scan" function, and I wanted the hack to automatically create a thumbnail whenever I added a .jpg. Andrew was going to do it, but I decided to try it myself. It is expandable to other file types by modifying the preg_match string pattern.
AndrewD
09-28-2005, 06:42 PM
Can a form be created to allow users to add links, but not going into too much detail as the add link form currently does, i.e. just a description, url and name of site ? no other settings, they would be added on moderation?
To do this, you would edit the link_addnewlink template. Surround the fields that you want to have as optional with a test <if condition="$linkmod">..</if>. You would have to add a hidden input field to provide the initial default value for the missing fields, although this can be blank for everything except the category - which would need to have an acceptable value.
Meltingfire
09-29-2005, 02:17 PM
Why did all my dates get set with todays date when upgrading?
Now everything is f*ckedup in "latest links"...
AndrewD
09-29-2005, 05:04 PM
Why did all my dates get set with todays date when upgrading?
Now everything is f*ckedup in "latest links"...
Maybe if you gave me more information and less expletive, I could work out the answer.
dethfire
09-29-2005, 05:12 PM
any way to import the 3.0 links into this new 3.5 links hack?
Vizionz
09-29-2005, 05:19 PM
why is there so many damn files included and its so unorganized i couldnt even figure out what is what to try to install this
Vizionz
09-29-2005, 05:33 PM
where does it install the database tables ? i ran the product after uploading all the files and now it says its missing a table in the database
AndrewD
09-29-2005, 05:56 PM
any way to import the 3.0 links into this new 3.5 links hack?
The installation script should smoothly upgrade you from the 3.0 version to the 3.5 version. Just follow the instructions.
AndrewD
09-29-2005, 05:57 PM
why is there so many damn files included and its so unorganized i couldnt even figure out what is what to try to install this
Actually, the files are extremely organised, and if you read the instructions.txt, it tells you precisely what to do.
There are so many files because during the last year, people have asked for so many options.
AndrewD
09-29-2005, 05:59 PM
where does it install the database tables ? i ran the product after uploading all the files and now it says its missing a table in the database
It installs the database tables during the product installation process. Which table is it telling you is missing. I can't help if you don't give sufficient information.
AndrewD
09-29-2005, 06:00 PM
Andrew - here is the includes file I Pm'd you about. I know it's sloppy and I don't know what I'm doing, but here it is anyways. :)
For anyone else who's curious, I am adding a lot of .jpg's to my site using the "Scan" function, and I wanted the hack to automatically create a thumbnail whenever I added a .jpg. Andrew was going to do it, but I decided to try it myself. It is expandable to other file types by modifying the preg_match string pattern.
Thanks, I'll take a look when I have some free time, and see how to incorporate this into the standard release.
Vizionz
09-29-2005, 06:04 PM
It installs the database tables during the product installation process. Which table is it telling you is missing. I can't help if you don't give sufficient information.
MySQL Error : Table 'AsylumGold.linksadmin' doesn't exist
Error Number : 1146
it might be i am doing something wrong
AndrewD
09-29-2005, 06:34 PM
MySQL Error : Table 'AsylumGold.linksadmin' doesn't exist
Error Number : 1146
it might be i am doing something wrong
OK - did you run the VBulletin product installer (VB/admincp/plugin system) as per the instructions?
If you did - and if it seemed to run ok - send me a pm with details of your forum url, plus an admin account and pwd, and I'll gladly take a look
gyankow
09-29-2005, 06:51 PM
Is there a 3.5 gold release on the way?
Meltingfire
09-29-2005, 08:49 PM
Maybe if you gave me more information and less expletive, I could work out the answer.
Upgraded to vBulletin 3.5.0 and L & D Manager 2.0.4 earlier and all dates on files/links (linkdate) are changed like they were "NOW()":ed or something.
I dont see why this happend really and now all "order by date desc" that is my default is just crazy and same thing on vBadvanced where i use a module showing newest files/links.
2.04 is working perfectly for me under 3.5 gold ;)
AndrewD
09-30-2005, 04:20 AM
Is there a 3.5 gold release on the way?
Yes, version 2.0.4 should work fine. 2.0.5 (beta testing) has some fixes and enhancements, and should go live this weekend.
AndrewD
09-30-2005, 04:34 AM
Upgraded to vBulletin 3.5.0 and L & D Manager 2.0.4 earlier and all dates on files/links (linkdate) are changed like they were "NOW()":ed or something.
I dont see why this happend really and now all "order by date desc" that is my default is just crazy and same thing on vBadvanced where i use a module showing newest files/links.
I took a look at your site, and don't understand - linkdates seem ok to me - you've got five files uploaded two days ago and the rest earlier. This is the link I used to check
http://forum.directconnect.se/links.php?catid=-8&page=1&limit=250&sort=d
Am I looking at the wrong place?
Meltingfire
09-30-2005, 10:29 PM
I took a look at your site, and don't understand - linkdates seem ok to me - you've got five files uploaded two days ago and the rest earlier. This is the link I used to check
http://forum.directconnect.se/links.php?catid=-8&page=1&limit=250&sort=d
Am I looking at the wrong place?
http://forum.directconnect.se/links.php?catid=7&page=1&sort=d
How can 23/02/2004 be before 16/07/2005 ?
Why doesnt the file with 16/07/2005 show up at Whats new when files from 22/05/2005 are shown? http://forum.directconnect.se/links.php?action=links&catid=-8
Is it me beeing drunk or is the date-stamps wrong?
Edit: I see now that the timestamp for when it was posted is updated when you Edit a file, dont think that is necessary or is it?
AndrewD
10-01-2005, 05:00 AM
Edit: I see now that the timestamp for when it was posted is updated when you Edit a file, dont think that is necessary or is it?
This was a point of discussion way back, when the general view was that the date stamp should be updated when the entry was edited. I don't feel strongly one way or the other.
Easiest solution is to add an additional configuration parameter so that the code does or does not make this adjustment during an edit.
Meltingfire
10-01-2005, 05:14 AM
This was a point of discussion way back, when the general view was that the date stamp should be updated when the entry was edited. I don't feel strongly one way or the other.
Easiest solution is to add an additional configuration parameter so that the code does or does not make this adjustment during an edit.
Best case whould be to see the date in a text-field with the "current (first)" date, then you could either change it manually, or have a radiobutton/checkbox to choose "Set to todays date"
or maybe even to fields, one for added date and one for last edited...
AndrewD
10-01-2005, 05:27 AM
Best case whould be to see the date in a text-field with the "current (first)" date, then you could either change it manually, or have a radiobutton/checkbox to choose "Set to todays date"
or maybe even to fields, one for added date and one for last edited...
OK, will ponder. Thanks
AndrewD
10-01-2005, 10:11 AM
I have uploaded version 2.0.5 as the new supported release, tested with VB 3.5.0 Gold. This has some minor changes to the beta version uploaded a few days ago.
Grateful for reports, as always.
Changes from 2.0.4 (those marked * are changes from beta 2.0.5):
+ rating/comments system extended to allow users to make multiple comments (one rating)
+ option included to update existing permissions when *default_forumid* is changed on admin page
+ users with *can_set_display_order* permission see the display orders in the linkbit
+ category forum links to work both ways category<=>forum
+ 'advanced search' added, e.g. to limit searches to certain categories
* option in edit link to retain or update the original timestamp
+ interface provided for vbAdvanced 2.0
= layout of category home page modified to provide better overview
= admin/settings and admin/permissions split into two pages
= various bugs fixed
changes to default sort order work properly
another attempt to deal correctly with changes to category forum links
another attempt to deal correctly with category display orders
cached missing template (styleselect)
phrasing tidied up
- removed support for obsolete vbindex interface
In the vbAdvanced modules the header of the module has an incorect link to local_links.php, look below to fix.
ldm-new.php
Line 91
change this
$hottitle = '<a href="'.$vbulletin->options['homeurl'].'/'.LINKS_SCRIPT.'.php">'.'New Links'.'</a>';
to this
$hottitle = '<a href="'.$vbulletin->options['bburl'].'/'.LINKS_SCRIPT.'.php">'.'New Links'.'</a>';
================================================== ========================
ldm-hot.php
Line 91
change this
$hottitle = '<a href="'.$vbulletin->options['homeurl'].'/'.LINKS_SCRIPT.'.php">'.'Hot Links'.'</a>';
to this
$hottitle = '<a href="'.$vbulletin->options['bburl'].'/'.LINKS_SCRIPT.'.php">'.'Hot Links'.'</a>';
Also was there a reason you changed the links_hotlinks template in your 2.05 beta to this version
From this
<tr>
<td class="alt1"><span class="smallfont">
<a href="$vboptions[bburl]/local_links.php?action=jump&id=$linkid" target="_blank">$linkname</a>
</span>
</td>
<td class="alt2">
<span class="smallfont">$linkhits</span>
</td>
</tr>
To this
<a href="$vboptions[bburl]/local_links.php?action=jump&id=$linkid" target="_blank">$linkname</a> ($linkhits)<br />
As it makes the vbAdvanced module look very bland and boring.
AndrewD
10-01-2005, 12:27 PM
In the vbAdvanced modules the header of the module has an incorect link to local_links.php, look below to fix.
thanks
Also was there a reason you changed the links_hotlinks template in your 2.05 beta to this version as it makes the vbAdvanced module look very bland and boring.
I thought it was an improvement ;) - but as I don't use vbAdvanced (yet) I'm not really the best judge.
Will revert to the beta layout if you think this is better.
I started to wonder if I was just being opinionated in my comment of the template, I have attached the old (beta template) and the new template for your own opinion, I honestly think the old beta one looks classier. See what you think.
AndrewD
10-01-2005, 01:06 PM
I started to wonder if I was just being opinionated in my comment of the template, I have attached the old (beta template) and the new template for your own opinion, I honestly think the old beta one looks classier. See what you think.
I think what was bugging me about the first try was 'too much line spacing' - I switched over to putting everything in one table row, with line breaks. I agree with you that the two-column style is better than the one column parenthesised version, but still wonder about the table length. What do you think?
Meltingfire
10-01-2005, 03:26 PM
I think what was bugging me about the first try was 'too much line spacing' - I switched over to putting everything in one table row, with line breaks. I agree with you that the two-column style is better than the one column parenthesised version, but still wonder about the table length. What do you think?
How do you successfully upgrade?
Is the uninstall/install better or should i use install and use overwrite / no overwrite?
AndrewD
10-01-2005, 04:03 PM
How do you successfully upgrade?
Is the uninstall/install better or should i use install and use overwrite / no overwrite?
Either approach will work, - install/overwrite or uninstall/reinstall - the uninstall does not harm the LDM database tables.
The only tricky situation with the new VB system is when an install only partly completes, and VB thinks it has finished the job. This is because installation code is only executed when the VB installer thinks it is installing a higher version. So if , e.g. (for any reason) you have part-installed version 2.0.5, then to complete the job you have to uninstall and start again.
Boofo
10-01-2005, 04:06 PM
Either approach will work, - install/overwrite or uninstall/reinstall - the uninstall does not harm the LDM database tables.
The only tricky situation with the new VB system is when an install only partly completes, and VB thinks it has finished the job. This is because installation code is only executed when the VB installer thinks it is installing a higher version. So if , e.g. (for any reason) you have part-installed version 2.0.5, then to complete the job you have to uninstall and start again.
As we found out during the beta phase of 2.0.5. ;)
AndrewD
10-01-2005, 04:08 PM
As we found out during the beta phase of 2.0.5. ;)
Don't be too sarcastic or you may find an unexpected worm in the next release ;););)
Boofo
10-01-2005, 04:11 PM
Don't be too sarcastic or you may find an unexpected worm in the next release ;););)
LOL I wasn't being sarcastic, actually. But now that you mention it ... ;)
Meltingfire
10-01-2005, 04:14 PM
Don't be too sarcastic or you may find an unexpected worm in the next release ;););)
I have created a own module i call "ldm-hotcat.php" that is basicly a hot category.
Since i use the category as a filename, lets say "miranda" and then post a link for each version "miranda 1.0", "miranda 2.0" etc i want all hits to be collected together inside that category so i use the following code as SQL, other then that there is no changes made to the original "ldm-hot.php"
SELECT cat.catid AS linkid, cat.catname AS linkname, cat.catdesc AS linkdesc,
SUM(link.linkhits) AS linkhits, link.linkstatus AS linkstatus
FROM ".THIS_TABLE."linksltoc AS ltoc
LEFT JOIN ".THIS_TABLE."linkslink AS link
ON ltoc.linkid = link.linkid
LEFT JOIN ".THIS_TABLE."linkscat as cat
ON ltoc.catid = cat.catid
GROUP BY cat.catid
$order
LIMIT $linksee
The problem is that when i use the $filter i get a SQL error, cant see why...
if the filter is "WHERE link.linkmoderate = 0" it gives a error which it shouldnt, or am i just blind
Meltingfire
10-01-2005, 04:21 PM
I started to wonder if I was just being opinionated in my comment of the template, I have attached the old (beta template) and the new template for your own opinion, I honestly think the old beta one looks classier. See what you think.
Since i see that you have a small empty row on top, here is a fix for you, i also added the linkstatus-thingie that was used in older LDM but not in this 3.5, how come?
well here is the code for links_hotlinks if you want a 2 column module, and also dont forget to edit module to use 2 in colspan.
<if condition="$linkstatus==1">
<a href="$vboptions[bburl]/local_links.php?action=jump&id=$linkid">$linkname</a>
</if>
<if condition="$linkstatus>1">
<a href="$vboptions[bburl]/local_links.php?action=jump&id=$linkid">$linkname</a</if>
<if condition="$linkstatus<=0">
$linkname (n/a)
</if>
</span>
</td>
<td class="alt2">
<span class="smallfont">[$linkhits]</span>
</td>
</tr>
<if condition="$nhits<4">
<tr>
<td class="alt1"><span class="smallfont">
</if>
the part with <if condition="$nhits<4"> should be changes if you have 10 rows then it should be 9, and so on...
EDIT:
i dont know what the intension was of using a both linkstatus==1 and linkstatus>1 but i guess it has to do that at one of them you can also show filesize if i recall right.
Meltingfire
10-01-2005, 04:31 PM
Im on fire tonight! :P
Sorry for trippleposting but i want to keep each feature/bug in a new post.
Shouldnt ldp-new.php use the current link instead to show "Whats New" when you click on the header.
$hottitle = '<a href="'.$vbulletin->options['bburl'].'/'.LINKS_SCRIPT.'.php?action=links&catid=-8">'.'New files'.'</a>';
Meltingfire
10-01-2005, 05:06 PM
After debugging and editing for half an hour this is my last feedback for today.
It is impossible to run both new and hot at the same time, probably because they use same variablenams etc.
What i had to do was to rename everything with "hot" in ldm-new.php to "new", after that i duplicated one styles for each "links_hotlinks" and "links_newlinks", and also "adv_portal_custom_ldm_hot" and "adv_portal_custom_ldm_new".
I removed the <tr><td><span> $hotlinks </span></td></tr> part from the "adv_portal_custom_ldm_hot" since i wanted to use more then one colulmn and or row per file, and added the part with <tr><td><span> <a href> ... </a></span></td></tr> in "links_hotlinks" instead. Did same thing for the "_new"-versions.
This also removes the need to use $hottitle, $collapseobj_custom_ldm and $collapseimg_custom_ldm, since they can now be set in the template instead.
This is my $0.05, now its saturday night here and time to party! :P
AndrewD
10-01-2005, 05:08 PM
Im on fire tonight! :P
Sorry for trippleposting but i want to keep each feature/bug in a new post.
Shouldnt ldp-new.php use the current link instead to show "Whats New" when you click on the header.
$hottitle = '<a href="'.$vbulletin->options['bburl'].'/'.LINKS_SCRIPT.'.php?action=links&catid=-8">'.'New files'.'</a>';
I think that's right - ditto What's hot?
AndrewD
10-01-2005, 05:10 PM
After debugging and editing for half an hour this is my last feedback for today.
It is impossible to run both new and hot at the same time, probably because they use same variablenams etc.
What i had to do was to rename everything with "hot" in ldm-new.php to "new", after that i duplicated one styles for each "links_hotlinks" and "links_newlinks", and also "adv_portal_custom_ldm_hot" and "adv_portal_custom_ldm_new".
I removed the <tr><td><span> $hotlinks </span></td></tr> part from the "adv_portal_custom_ldm_hot" since i wanted to use more then one colulmn and or row per file, and added the part with <tr><td><span> <a href> ... </a></span></td></tr> in "links_hotlinks" instead. Did same thing for the "_new"-versions.
This also removes the need to use $hottitle, $collapseobj_custom_ldm and $collapseimg_custom_ldm, since they can now be set in the template instead.
This is my $0.05, now its saturday night here and time to party! :P
Greatly appreciated - as I've said elsewhere, I don't use vbAdvaced, so have had to work a bit in the dark - will try to pull these things together soon.
Your easrlier equstion about $linkstatus = 1 or >1 - the variable is positive if the link is good, and >1 if it should be treated as a file size - maybe I should have used two variables but I was a bit lazy at one point
Meltingfire
10-01-2005, 05:18 PM
Greatly appreciated - as I've said elsewhere, I don't use vbAdvaced, so have had to work a bit in the dark - will try to pull these things together soon.
Your easrlier equstion about $linkstatus = 1 or >1 - the variable is positive if the link is good, and >1 if it should be treated as a file size - maybe I should have used two variables but I was a bit lazy at one point
Also, adding a phrase for "local_links.php" would be appreciated so you can translade it to for example "links.php", so i dont have to word-replace all urls in styles after a upgrade ;) even if that only takes 2 seconds.
Maybe not the best solution but would work and phrases wouldnt be changed after an upgrade as styles do.
AndrewD
10-02-2005, 05:32 AM
I have created a own module i call "ldm-hotcat.php" that is basicly a hot category.
Since i use the category as a filename, lets say "miranda" and then post a link for each version "miranda 1.0", "miranda 2.0" etc i want all hits to be collected together inside that category so i use the following code as SQL, other then that there is no changes made to the original "ldm-hot.php"
SELECT cat.catid AS linkid, cat.catname AS linkname, cat.catdesc AS linkdesc,
SUM(link.linkhits) AS linkhits, link.linkstatus AS linkstatus
FROM ".THIS_TABLE."linksltoc AS ltoc
LEFT JOIN ".THIS_TABLE."linkslink AS link
ON ltoc.linkid = link.linkid
LEFT JOIN ".THIS_TABLE."linkscat as cat
ON ltoc.catid = cat.catid
GROUP BY cat.catid
$order
LIMIT $linksee
The problem is that when i use the $filter i get a SQL error, cant see why...
if the filter is "WHERE link.linkmoderate = 0" it gives a error which it shouldnt, or am i just blind
Because the filter (WHERE) has to come before the GROUP BY
AndrewD
10-02-2005, 08:56 AM
Also, adding a phrase for "local_links.php" would be appreciated so you can translade it to for example "links.php", so i dont have to word-replace all urls in styles after a upgrade ;) even if that only takes 2 seconds.
Maybe not the best solution but would work and phrases wouldnt be changed after an upgrade as styles do.
In the next version, I will parameterise the script names using DEFINES in the local_links_init file. That way, there is one file to edit for configuration changes to code and database.
GrendelKhan{TSU
10-02-2005, 10:06 AM
I think what was bugging me about the first try was 'too much line spacing' - I switched over to putting everything in one table row, with line breaks. I agree with you that the two-column style is better than the one column parenthesised version, but still wonder about the table length. What do you think?
yah I gotta agree with PtP. the 2 column look was better. Column spacing is not as big a deal as the overall is much better with the two column approach. The one table row looks like a beta version....ie: no styling.
definitely go with the 2 column. (imho)
MissKalunji
10-03-2005, 04:24 PM
okay lets try this i installed it but n e one can help me make it look like this :
http://www.dancehallareaz.com/links/
Meltingfire
10-03-2005, 05:10 PM
okay lets try this i installed it but n e one can help me make it look like this :
http://www.dancehallareaz.com/links/
Edit the styles?
MissKalunji
10-03-2005, 06:32 PM
Edit the styles?
i suck at these things.......can n e one help me? if i gotta pay i dont mind....
lttcoder
10-03-2005, 07:07 PM
Andrew, How can I change the category display order?
I know how to set links display order but I want to change category display order by date. The recent added categories should come first and old last.
Is there a way?
AndrewD
10-04-2005, 04:23 AM
Andrew, How can I change the category display order?
I know how to set links display order but I want to change category display order by date. The recent added categories should come first and old last.
Is there a way?
In the current version, you can only do this by manually editing the categories and changing the last field "Display Order" so that the numbers decrease in the order you created them.
Currently, there is no datestamp in the database showing when a category was created - only datestamps showing when links were created and when a link was last added to each category.
If this is a big deal, I'll add it to the 'to do' list.
Feature Request
dunno if this has been requested before but would it be possible to add a kind of chart for the most visited / downloaded items in the system
AndrewD
10-04-2005, 11:29 AM
Feature Request
dunno if this has been requested before but would it be possible to add a kind of chart for the most visited / downloaded items in the system
Chart rather than just a list?
well list yeah wondering if it would be possible to filter list by cat and maybe if possible by day week month...
AndrewD
10-04-2005, 01:31 PM
well list yeah wondering if it would be possible to filter list by cat and maybe if possible by day week month...
The administrator can already do this. Go to admin/statistics, then View Hits, and you can produce reports by date, IP, username - and if you have installed a particular ip-to-country database, you can even get a listing by country.
Are you wanting the normal users to see this information?
bhxtyrant
10-04-2005, 01:38 PM
Hey Andrew,
Once again a small question.No errors or anything this time.I was thinking aboiut upgrading our forums to 3.5 today but of course that means updating all the mods we have installed as well including Links and Files Database.I was just wondering and hopeing that there is an Upgrade option from the old version to this newer versions so i don't have to re-add all the 1000+ links i already added to the database.Is this possible?Thanks alot.
AndrewD
10-04-2005, 01:40 PM
Hey Andrew,
Once again a small question.No errors or anything this time.I was thinking aboiut upgrading our forums to 3.5 today but of course that means updating all the mods we have installed as well including Links and Files Database.I was just wondering and hopeing that there is an Upgrade option from the old version to this newer versions so i don't have to re-add all the 1000+ links i already added to the database.Is this possible?Thanks alot.
It upgrades automatically - just take a backup to be on the safe side.
The administrator can already do this. Go to admin/statistics, then View Hits, and you can produce reports by date, IP, username - and if you have installed a particular ip-to-country database, you can even get a listing by country.
Are you wanting the normal users to see this information?
yeah i am, im planning to letting users upload mp3s so they can battle it out to see who can get to the top of the "chart" so id preferably need daily weekly monthly stats which can be filtered into their respective cats... but hey not all are curial, just need a list to start with :D
cheers
csidlernet
10-05-2005, 02:36 AM
thankyouverymuch!!!!
bhxtyrant
10-06-2005, 12:03 AM
Thanks Andrew.got some more questions now that i have this mod and vB3.5 up and running.Near the top of the main page of LDM it has this text.
Links and Downloads Database
The database contains 2 categories and 0 entries that you can access/download.
During the last 30 days, 0 entries have been added [what's new] and there have been 0 hits [what's hot].
Since your last visit, 0 new entries have been added [view].
is there a way i can change what it says?
and in the main breadcrumb it says "Links and Downloads Database" i'd like to change that to just "Downloads" is this possible as well?I remember someone told me how to do it in the 3.0 version of this mod but the files are different in theis version so i can't find it.Thanks
AndrewD
10-06-2005, 04:03 AM
Thanks Andrew.got some more questions now that i have this mod and vB3.5 up and running.Near the top of the main page of LDM it has this text.
is there a way i can change what it says?
Yes. That particular text is built in the links_introbit template, which you can edit as you wish. If you want to refer to the particular statistics that are displayed, these are built from three phrases, ll_recent, ll_lastvisit and ll_visible, which you can edit. The code that actually constructs this text is function get_ldm_summary at line 802 in local_links_include.php. Easiest is probably to edit the template.
and in the main breadcrumb it says "Links and Downloads Database" i'd like to change that to just "Downloads" is this possible as well?I remember someone told me how to do it in the 3.0 version of this mod but the files are different in theis version so i can't find it.Thanks
Go to the links admin page/settings. Look for the setting database_name and enter whatever text you want to appear in the breadcrumb.
Suggestion for improvement: change all php tags from <? to <?php
AndrewD
10-06-2005, 05:28 AM
Suggestion for improvement: change all php tags from <? to <?php
A huge task - will sweat blood for many hours. Thanks - consider it done.
*grin* That was quick. Thanks!
yeah i am, im planning to letting users upload mp3s so they can battle it out to see who can get to the top of the "chart" so id preferably need daily weekly monthly stats which can be filtered into their respective cats... but hey not all are curial, just need a list to start with :D
cheers
andrew !!! lol sorry thought you might have missed my post
AndrewD
10-06-2005, 09:04 AM
andrew !!! lol sorry thought you might have missed my post
Yes, I saw it - am thinking about this and will try to do something at the weekend - I'm also thinking of modifying the 'autoload' feature that's available to admins, so that mp3s and jpgs and so get illustrated, annotated, etc, according to the ID3, EXIf, etc, tags in the files.
But I have to do my paid job first ;)
whats that sounds sick (amazing) thanks man... what exactly do you mean by illustrated ?
just wondering if there is or if your concidering adding the option to upload the file. instead of linking to it
bhxtyrant
10-06-2005, 04:33 PM
just wondering if there is or if your concidering adding the option to upload the file. instead of linking to it
Would be nice to have both options :) possibly in a future version?
AmpSul
10-07-2005, 03:11 AM
been using this for months on my old 3.0.x and it rocks!
two minute upgrade and it still rocks hard!
thanks andrewd!!!!!!!
AndrewD
10-07-2005, 04:06 AM
whats that sounds sick (amazing) thanks man... what exactly do you mean by illustrated ?
For example, if it's an mp3 with cover art in the file, then the picture would appear in the linkbit. If it's a photo, then a thumbnail would appear. I have to work out the details.
AndrewD
10-07-2005, 04:08 AM
Would be nice to have both options :) possibly in a future version?
This is the most-asked-for upgrade. I need to think through the details. No promises, just a strong maybe.
Brandon Sheley
10-07-2005, 04:17 AM
nice looking hack AndrewD
I haven't installed it, but I will. this weekend or next
thx :)
This is the most-asked-for upgrade. I need to think through the details. No promises, just a strong maybe.
nice one andrew :D
EasyTarget
10-07-2005, 02:55 PM
/me puts a vote in for uploading capabilities.
did you ever look into that fopen stuff more?
AndrewD
10-07-2005, 03:01 PM
* EasyTarget puts a vote in for uploading capabilities.
did you ever look into that fopen stuff more?
You're asking about cURL support? - that's fully integrated now.
so andrew how do you get this built in media jukebox thing to work then? enabled it for mp3s added a link to an mp3 doesnt work :S any ideas :P playing atm lovin this so far man......
cheers
benj
WNxWakko
10-09-2005, 08:30 PM
Uploaded files, installed plugin,
When I click any option for this mod in admincp or try to access the file.
Critical Error: Links and Downloads Manager not installed properly - cannot find database tables
elsupremo
10-09-2005, 10:54 PM
Uploaded files, installed plugin,
When I click any option for this mod in admincp or try to access the file.
Critical Error: Links and Downloads Manager not installed properly - cannot find database tables
Just to make sure:
When you say "installed plugin", did you (inside AdminCP):
Click "Plugin System"
-Click "Manage Products"
--Click [Add/Import Product] (below table)
---Browse your harddrive for file: product-eirma_ldm.xml, Allow Overwrite: YES ---->IMPORT
If you are not entirely sure, I would go ahead and do it again.
dethfire
10-10-2005, 03:32 AM
Moderating the links doesn't work for me. I click accept and it's still in the mod queue.
AndrewD
10-10-2005, 04:14 AM
Uploaded files, installed plugin,
When I click any option for this mod in admincp or try to access the file.
Critical Error: Links and Downloads Manager not installed properly - cannot find database tables
The tables are created by the product installer, so I wonder if you installed the plugin rather than the product. Do check that you used admin/plugins/manage products and not admin/plugins/install plugin.
If the installer failed, it would have displayed some error messages during the process, but these can race by on the vb admin screen. If necessary, use the vb admin to uninstall and reinstall, don't just overwrite the product xml.
By all means pm me with details of your board - if you require help, I'll need an admin username and password
elsupremo
10-10-2005, 04:23 AM
Moderating the links doesn't work for me. I click accept and it's still in the mod queue.
Unfortunately, it's true - accepting a moderated link does not remove it from the moderation queue.
However - I just checked something, I could be wrong - but if you have anything other than "0" in the Review frequency field of the link properties, then it will stay in the moderation queue. So, if you want the entries gone, put "0" in that field and it will be gone.
David
EasyTarget
10-10-2005, 07:53 AM
You're asking about cURL support? - that's fully integrated now.
wow, thanks. apart from the fopen function being disabled so I couldn't use this hack before, curl is much more secure.. thanks for the work, I'm looking forward to the updates.
AndrewD
10-10-2005, 08:50 AM
Unfortunately, it's true - accepting a moderated link does not remove it from the moderation queue.
However - I just checked something, I could be wrong - but if you have anything other than "0" in the Review frequency field of the link properties, then it will stay in the moderation queue. So, if you want the entries gone, put "0" in that field and it will be gone.
David
OK, will investigate - I wish software didn't take on a life of its own!!
AndrewD
10-10-2005, 03:15 PM
so andrew how do you get this built in media jukebox thing to work then? enabled it for mp3s added a link to an mp3 doesnt work :S any ideas :P playing atm lovin this so far man......
cheers
benj
This is indeed an interesting question.
The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.
I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.
If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.
AndrewD
10-10-2005, 04:15 PM
Unfortunately, it's true - accepting a moderated link does not remove it from the moderation queue.
However - I just checked something, I could be wrong - but if you have anything other than "0" in the Review frequency field of the link properties, then it will stay in the moderation queue. So, if you want the entries gone, put "0" in that field and it will be gone.
David
Bug confirmed. As you say, it occurs when there is a value other than zero in the review frequency field. It will be fixed in 2.0.6, but in the meantime, if this is urgent, the fix in version 2.0.5 is as follows.
Edit local_links.php. Go to line 1881 to 1893, which read as follows:
if ($submit == 'submit') {
if ($statuscheck == $LINK_NO_ACCESS) {
$err = $vbphrase['ll_error_protocol'].' '.$linkurl.' <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
eval(standard_error($err));
exit;
} elseif ($statuscheck == $LINK_NO_REMOTE_DOWNLOADS) {
$err = $vbphrase['ll_error_remote'].' '.$linkurl.'. <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
eval(standard_error($err));
exit;
}
$statustime = TIMENOW;
Move line 1893 $statustime = TIMENOW; immediately before 1881, ie just before the if test, so that the code reads as follows: $statustime = TIMENOW;
if ($submit == 'submit') {
if ($statuscheck == $LINK_NO_ACCESS) {
$err = $vbphrase['ll_error_protocol'].' '.$linkurl.' <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
eval(standard_error($err));
exit;
} elseif ($statuscheck == $LINK_NO_REMOTE_DOWNLOADS) {
$err = $vbphrase['ll_error_remote'].' '.$linkurl.'. <a href='.$url.'><b>'.$vbphrase['ll_return'].'</b></a>';
eval(standard_error($err));
exit;
}
Boofo
10-10-2005, 04:21 PM
My version 2.0.5 already reads like the fix.
AndrewD
10-10-2005, 05:14 PM
My version 2.0.5 already reads like the fix.
Check again! I've just looked at the code sitting on this site and it reads as I said. It's a subtle change - just moving one line up a dozen lines.
elsupremo
10-10-2005, 06:45 PM
This is indeed an interesting question.
The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.
I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.
If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.
When I tried this feature recently, it worked approximately 1/20 times. My point here is that it does work on occasion, although I am not sure what is the variable that allows it to work or not.
I do not see a very important reason for this function to remain. I believe there are better "jukebox" modifications out there made expressly for that purpose.
Boofo
10-10-2005, 07:51 PM
Check again! I've just looked at the code sitting on this site and it reads as I said. It's a subtle change - just moving one line up a dozen lines.
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)
elsupremo
10-10-2005, 08:38 PM
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)
Lol, this is a funny one. :)
This is indeed an interesting question.
The jukebox worked correctly through version 1.61 and that version still works correctly today. However, I find that I cannot get the version 2.0.x to work at all. I'm not sure why, as I don't think I've changed any of the code (obviously I must have). It fires up the windows media player correctly but refuses to play anything.
I wrote this as an add-on for someone who said that it was very important to him, and then decided that he didn't want it after all. I wonder - is this actually a very useful feature? If you have an mp3-aware application on your pc, then this will load and run anyway when you click on an mp3 file. I'm not sure what advantage there is to having it play inside an embedded media player running in the browser.
If anyone can give me good reasons for this feature, I'll continue to try to fix it, otherwise it seems like a feature that could be removed.
NOOOOOOOO! Keep it i need it coz as you might remember i plan to play mp3s thru this addon. and my artists dont want people to be able to download there mp3's just stream them. i dunno if it would be possible with the media player thing / or will be possible in some other way but i was gonna make a flash player so users can only stream music from my site not download it... this is kinda crutal to my site. unless you have anyother ideas that is :rolleyes: :D
cheers andrew
AndrewD
10-11-2005, 03:58 AM
I know, sir. I've checked it over and over again and it is already fixed in the version I have. ;)
Now I understand. I broke this between the beta 2.0.5 and the final 2.0.5. You must have got the beta code installed.
vBulletin® v3.8.12 by vBS, Copyright ©2000-2025, vBulletin Solutions Inc.