Private Message Delete Error

[Boofo]

Can someone please tell me what I have wrong with this code? I am getting a db error when I click "All Messages" and hit the delete button in the private messages sent folder. Here is the code in questiom, I think.

PHP Code:

 if ($what=="delete") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0';
        $DB_site->query("DELETE FROM privatemessage WHERE userid=$bbuserinfo[userid] AND folderid=$thefolder");
    } else {
        if (is_array($privatemessage) or $allmsgs==1) {
          while(list($key,$val)=each($privatemessage)) {
            $DB_site->query("DELETE FROM privatemessage WHERE privatemessageid=".intval($key)." AND userid=$bbuserinfo[userid]");
          } //end while
        } else {
          eval("standarderror(\"".gettemplate("error_pmnoselected")."\");");
          exit;
         }
    } 


and here is the db error I am getting.

Database error in vBulletin 2.2.5:

Invalid SQL: DELETE FROM privatemessage WHERE userid=1 AND folderid=thisfolder mysql error: Unknown column 'thisfolder' in 'where clause'

mysql error number: 1054

Date: Monday 26th of August 2002 09:24:57 AM
Script: http://www.bearfacts2.com/forum/forum/private.php
Referer: http://www.bearfacts2.com/forum/private.php

[g-force2k2]

Boofo find this line:

PHP Code:

 if ($what=="delete") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0'; 


replace it with:

PHP Code:

if($what=="delete") {
  if($allmsgs == 1) { 
    if($thisfolder != "") {
      $thefolder = $thisfolder;
    } else {
      $thefolder = 0;
    } 


regards...

g-force2k2

[Boofo]

g-force2k2, that fixed it. I knew I was doing something wrong but it didn't dawn on me what it was. The wierd thing is, the line I changed works fine in the following piece of code. Can you please explain to me why? This has me stumped now.

PHP Code:

if ($what=="move") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0';
        $DB_site->query("UPDATE privatemessage SET folderid=".intval($folderid)." WHERE userid=$bbuserinfo[userid] AND folderid='$thefolder'");
    } else {
        if (is_array($privatemessage)) {
          while(list($key,$val)=each($privatemessage)) {
            $DB_site->query("UPDATE privatemessage SET folderid=".intval($folderid)." WHERE privatemessageid=".intval($key)." AND userid=$bbuserinfo[userid]");
          } //end while
        } else {
        eval("standarderror(\"".gettemplate("error_pmnoselected")."\");");
        exit;
        }
    } 


[g-force2k2]

Boofo your coding was fine it just looks different because i use a different style of coding i guess

but the error was because:

PHP Code:

(thisfolder!='') 


should be:

PHP Code:

($thisfolder!='') 


just forgot the dollar sign regards...

g-force2k2

[Boofo]

Ok, I see that now. Duhh!!

But why does it work fine with the move code I posted above? :surprised:

[g-force2k2]

perhaps because it just evaluated the 'else' code then? not really sure :P

g-force2k2

[FrankR310]

can someone point me to the hack that allows users to have a check all box to delete pm's?

thanks