vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   Private Message Delete Error (https://vborg.vbsupport.ru/showthread.php?t=42758)

Boofo 08-26-2002 07:32 AM
Private Message Delete Error
 
Can someone please tell me what I have wrong with this code? I am getting a db error when I click "All Messages" and hit the delete button in the private messages sent folder. Here is the code in questiom, I think.

PHP Code:
 if ($what=="delete") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0';
        $DB_site->query("DELETE FROM privatemessage WHERE userid=$bbuserinfo[userid] AND folderid=$thefolder");
    } else {
        if (is_array($privatemessage) or $allmsgs==1) {
          while(list($key,$val)=each($privatemessage)) {
            $DB_site->query("DELETE FROM privatemessage WHERE privatemessageid=".intval($key)." AND userid=$bbuserinfo[userid]");
          } //end while
        } else {
          eval("standarderror(\"".gettemplate("error_pmnoselected")."\");");
          exit;
         }
    } 
and here is the db error I am getting.

Quote:
Database error in vBulletin 2.2.5:

Invalid SQL: DELETE FROM privatemessage WHERE userid=1 AND folderid=thisfolder mysql error: Unknown column 'thisfolder' in 'where clause'

mysql error number: 1054

Date: Monday 26th of August 2002 09:24:57 AM
Script: http://www.bearfacts2.com/forum/forum/private.php
Referer: http://www.bearfacts2.com/forum/private.php

g-force2k2 08-26-2002 01:58 PM
Boofo find this line:

PHP Code:
 if ($what=="delete") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0'; 
replace it with:

PHP Code:
if($what=="delete") {
  if($allmsgs == 1) { 
    if($thisfolder != "") {
      $thefolder = $thisfolder;
    } else {
      $thefolder = 0;
    } 
regards...

g-force2k2

Boofo 08-26-2002 02:35 PM
g-force2k2, that fixed it. I knew I was doing something wrong but it didn't dawn on me what it was. The wierd thing is, the line I changed works fine in the following piece of code. Can you please explain to me why? This has me stumped now. :)

PHP Code:
if ($what=="move") {
    if ($allmsgs==1) {
        if (thisfolder!='') $thefolder=thisfolder; else $thefolder='0';
        $DB_site->query("UPDATE privatemessage SET folderid=".intval($folderid)." WHERE userid=$bbuserinfo[userid] AND folderid='$thefolder'");
    } else {
        if (is_array($privatemessage)) {
          while(list($key,$val)=each($privatemessage)) {
            $DB_site->query("UPDATE privatemessage SET folderid=".intval($folderid)." WHERE privatemessageid=".intval($key)." AND userid=$bbuserinfo[userid]");
          } //end while
        } else {
        eval("standarderror(\"".gettemplate("error_pmnoselected")."\");");
        exit;
        }
    } 

g-force2k2 08-26-2002 02:41 PM
Boofo your coding was fine ;) it just looks different because i use a different style of coding i guess :p

but the error was because:

PHP Code:
(thisfolder!='') 
should be:

PHP Code:
($thisfolder!='') 
just forgot the dollar sign ;) regards...

g-force2k2

Boofo 08-26-2002 02:55 PM
Ok, I see that now. Duhh!! :)

But why does it work fine with the move code I posted above? :surprised:

g-force2k2 08-26-2002 03:28 PM
perhaps because it just evaluated the 'else' code then? not really sure :P

g-force2k2

FrankR310 01-28-2003 05:29 AM
can someone point me to the hack that allows users to have a check all box to delete pm's?

thanks


All times are GMT. The time now is 10:46 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01107 seconds
  • Memory Usage 1,751KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_php_printable
  • (1)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (7)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete