Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 10-12-2013, 08:00 AM
axelfx07 axelfx07 is offline
 
Join Date: Aug 2012
Posts: 8
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default HTML5 issue. VB4 changing empty attributes.

Hey guys,

I am using 8WR Media LIbrary on my forum. I wanted HTML5 Youtube player, so I updated the cod to use <iframe> and all works fine. However, VB is changing empty allowfullscreen attribute to allowfullscreen="", which disables fullscreen.

I tried almost everything, including adding webkitallowfullscreen="true" mozallowfullscreen="true" allowfullscreen="true" and adding ?fs=0 to the link, but nothing works.

Here is the code:

Code:
<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}" frameborder="0" allowfullscreen></iframe>
it turns into:

Code:
<iframe width="640" height="385" src="http://www.youtube.com/v/xEXg0hw6uZk?rel=0&showinfo=0"  frameborder="0" allowfullscreen=""/>
Any way to fix this?

Thank you!
Reply With Quote
  #2  
Old 10-12-2013, 02:08 PM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by axelfx07 View Post
Hey guys,

I am using 8WR Media LIbrary on my forum. I wanted HTML5 Youtube player, so I updated the cod to use <iframe> and all works fine. However, VB is changing empty allowfullscreen attribute to allowfullscreen="", which disables fullscreen.

I tried almost everything, including adding webkitallowfullscreen="true" mozallowfullscreen="true" allowfullscreen="true" and adding ?fs=0 to the link, but nothing works.

Here is the code:

Code:
<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}" frameborder="0" allowfullscreen></iframe>
it turns into:

Code:
<iframe width="640" height="385" src="http://www.youtube.com/v/xEXg0hw6uZk?rel=0&showinfo=0"  frameborder="0" allowfullscreen=""/>
Any way to fix this?

Thank you!
The attribute allowfullscreen is not a valid attribute for an iframe tag in xhtml, much less html5, further valid xhtml/html5 requires that all attributes have a value, hence why you see the ="". To fix you'll probably need to append the fs=0 to the src for the iframe like:

Code:
src="{vb:var media.svcMovie}&amp;fs=0"
Reply With Quote
  #3  
Old 10-12-2013, 02:27 PM
axelfx07 axelfx07 is offline
 
Join Date: Aug 2012
Posts: 8
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by squidsk View Post
The attribute allowfullscreen is not a valid attribute for an iframe tag in xhtml, much less html5, further valid xhtml/html5 requires that all attributes have a value, hence why you see the ="". To fix you'll probably need to append the fs=0 to the src for the iframe like:

Code:
src="{vb:var media.svcMovie}&amp;fs=0"
Thank you for your reply!
If its not a valid attribute why does youtube puts it there by default?
Default code for embedding a youtube video is:

<iframe width="480" height="360" src="//www.youtube.com/embed/G7SqvJA79bk?rel=0" frameborder="0" allowfullscreen></iframe>

Anyway, I've tried adding &amp;fs=0 before (although fs=0 actually removes the fullscreen button , fs=1 puts it back) and it makes the icon clickable, but nothing happens when you click on it.

This is how it looks with the following src code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}&amp;fs=1" frameborder="0"></iframe>

Before click:


After click:


As you can see it simply greys out and is unclickable after 1 click and no fullscreen ofc.
Reply With Quote
  #4  
Old 10-13-2013, 01:55 AM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by axelfx07 View Post
Thank you for your reply!
If its not a valid attribute why does youtube puts it there by default?
Default code for embedding a youtube video is:

<iframe width="480" height="360" src="//www.youtube.com/embed/G7SqvJA79bk?rel=0" frameborder="0" allowfullscreen></iframe>

Anyway, I've tried adding &amp;fs=0 before (although fs=0 actually removes the fullscreen button , fs=1 puts it back) and it makes the icon clickable, but nothing happens when you click on it.

This is how it looks with the following src code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}&amp;fs=1" frameborder="0"></iframe>

Before click:


After click:


As you can see it simply greys out and is unclickable after 1 click and no fullscreen ofc.
I'm not sure where you're getting the default youtube iframe stuff from, but according to the youtube player api (https://developers.google.com/youtube/player_parameters) that attribute is not used with an iframe, it was used with the old method of embedding a youtube video. Also checkout the link because the link that you've reported as being generated does not seem correct either. The link you posted in the op goes to www.youtube.com/v/ instead of www.youtube.com/embed/
Reply With Quote
Благодарность от:
tbworld
  #5  
Old 10-13-2013, 04:21 AM
Digital Jedi's Avatar
Digital Jedi Digital Jedi is offline
 
Join Date: Oct 2006
Location: PopCulturalReferenceLand
Posts: 5,171
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Default code is:
HTML Code:
<iframe width="420" height="315" src="//www.youtube.com/embed/BpqNvskS_kM" frameborder="0" allowfullscreen></iframe>
You don't need &fs1 for the iframe. allowfullscreen, for whatever reason, puts it in there. Supposedly, allowfullscreen will pass validation now.

But yeah, your problem was probably that you were using v instead of embed.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:27 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03759 seconds
  • Memory Usage 2,218KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (6)bbcode_code
  • (1)bbcode_html
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (5)post_thanks_box
  • (1)post_thanks_box_bit
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete