vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=251)
-   -   HTML5 issue. VB4 changing empty attributes. (https://vborg.vbsupport.ru/showthread.php?t=303287)

axelfx07 10-12-2013 08:00 AM

HTML5 issue. VB4 changing empty attributes.
 
Hey guys,

I am using 8WR Media LIbrary on my forum. I wanted HTML5 Youtube player, so I updated the cod to use <iframe> and all works fine. However, VB is changing empty allowfullscreen attribute to allowfullscreen="", which disables fullscreen.

I tried almost everything, including adding webkitallowfullscreen="true" mozallowfullscreen="true" allowfullscreen="true" and adding ?fs=0 to the link, but nothing works.

Here is the code:

Code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}" frameborder="0" allowfullscreen></iframe>
it turns into:

Code:

<iframe width="640" height="385" src="http://www.youtube.com/v/xEXg0hw6uZk?rel=0&showinfo=0"  frameborder="0" allowfullscreen=""/>
Any way to fix this?

Thank you!

squidsk 10-12-2013 02:08 PM

Quote:

Originally Posted by axelfx07 (Post 2452530)
Hey guys,

I am using 8WR Media LIbrary on my forum. I wanted HTML5 Youtube player, so I updated the cod to use <iframe> and all works fine. However, VB is changing empty allowfullscreen attribute to allowfullscreen="", which disables fullscreen.

I tried almost everything, including adding webkitallowfullscreen="true" mozallowfullscreen="true" allowfullscreen="true" and adding ?fs=0 to the link, but nothing works.

Here is the code:

Code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}" frameborder="0" allowfullscreen></iframe>
it turns into:

Code:

<iframe width="640" height="385" src="http://www.youtube.com/v/xEXg0hw6uZk?rel=0&showinfo=0"  frameborder="0" allowfullscreen=""/>
Any way to fix this?

Thank you!

The attribute allowfullscreen is not a valid attribute for an iframe tag in xhtml, much less html5, further valid xhtml/html5 requires that all attributes have a value, hence why you see the ="". To fix you'll probably need to append the fs=0 to the src for the iframe like:

Code:

src="{vb:var media.svcMovie}&amp;fs=0"

axelfx07 10-12-2013 02:27 PM

Quote:

Originally Posted by squidsk (Post 2452615)
The attribute allowfullscreen is not a valid attribute for an iframe tag in xhtml, much less html5, further valid xhtml/html5 requires that all attributes have a value, hence why you see the ="". To fix you'll probably need to append the fs=0 to the src for the iframe like:

Code:

src="{vb:var media.svcMovie}&amp;fs=0"

Thank you for your reply!
If its not a valid attribute why does youtube puts it there by default?
Default code for embedding a youtube video is:

<iframe width="480" height="360" src="//www.youtube.com/embed/G7SqvJA79bk?rel=0" frameborder="0" allowfullscreen></iframe>

Anyway, I've tried adding &amp;fs=0 before (although fs=0 actually removes the fullscreen button :), fs=1 puts it back) and it makes the icon clickable, but nothing happens when you click on it.

This is how it looks with the following src code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}&amp;fs=1" frameborder="0"></iframe>

Before click:
https://vborg.vbsupport.ru/external/2013/10/50.png

After click:
https://vborg.vbsupport.ru/external/2013/10/51.png

As you can see it simply greys out and is unclickable after 1 click and no fullscreen ofc.

squidsk 10-13-2013 01:55 AM

Quote:

Originally Posted by axelfx07 (Post 2452631)
Thank you for your reply!
If its not a valid attribute why does youtube puts it there by default?
Default code for embedding a youtube video is:

<iframe width="480" height="360" src="//www.youtube.com/embed/G7SqvJA79bk?rel=0" frameborder="0" allowfullscreen></iframe>

Anyway, I've tried adding &amp;fs=0 before (although fs=0 actually removes the fullscreen button :), fs=1 puts it back) and it makes the icon clickable, but nothing happens when you click on it.

This is how it looks with the following src code:

<iframe width="<vb:if condition="$media['embed_stream']">100%<vb:else />{vb:var media.svcWidth}</vb:if>" height="{vb:var media.svcHeight}" src="{vb:var media.svcMovie}&amp;fs=1" frameborder="0"></iframe>

Before click:
https://vborg.vbsupport.ru/external/2013/10/50.png

After click:
https://vborg.vbsupport.ru/external/2013/10/51.png

As you can see it simply greys out and is unclickable after 1 click and no fullscreen ofc.

I'm not sure where you're getting the default youtube iframe stuff from, but according to the youtube player api (https://developers.google.com/youtube/player_parameters) that attribute is not used with an iframe, it was used with the old method of embedding a youtube video. Also checkout the link because the link that you've reported as being generated does not seem correct either. The link you posted in the op goes to www.youtube.com/v/ instead of www.youtube.com/embed/

Digital Jedi 10-13-2013 04:21 AM

Default code is:
HTML Code:

<iframe width="420" height="315" src="//www.youtube.com/embed/BpqNvskS_kM" frameborder="0" allowfullscreen></iframe>
You don't need &fs1 for the iframe. allowfullscreen, for whatever reason, puts it in there. Supposedly, allowfullscreen will pass validation now.

But yeah, your problem was probably that you were using v instead of embed.


All times are GMT. The time now is 01:43 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01117 seconds
  • Memory Usage 1,736KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_code_printable
  • (1)bbcode_html_printable
  • (3)bbcode_quote_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (5)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete