'&pp=' Tag Search Results Per page

[TWood]

The number of results shown for a Tag search is not set in the ACP. I found this in tags.php (about line 160)

        $base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
                'tag=' . $vbulletin->GPC['tag'] . '&pp=' . $perpage;

It appears that a number can be placed after the = sign in '&pp=' but I don't know the syntax. Can someone tell me how that is structured?

Thanx

[Lynne]

tags.php?tag=xxxx&pp=yyyy

[TWood]

I'm sorry Lynne, you woofed me. I know you're telling me something but I don't know what it is. I was expecting to enter a number into '&pp=' after the '=' sign, with some syntax around the number. What are you telling me?

[Lynne]

You just enter a number after the =. pp means "per page". So enter the number of tags results you want shown per page.

[TWood]

I tried that, three different ways:

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp= 5 ' . $perpage;

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5 ' . $perpage;

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5' . $perpage;

It still shows all the threads with a given tag on one page, much more than 5, in this example.

[Lynne]

You can't have .$perpage after the number - 5 *is* the $perpage variable! Either set $perpage beforehand, or remove it:

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5';

[kh99]

I think maybe part of the problem is that that's the base url for making links in the results page, but you'd still need to set the perpage passed to $view->showpage() below that.

I don't understand the code since $perpage is never set (unless it's set in another file somewhere, but I couldn't find it).

I'd think that this section of code (lines 159 to 164):

	$base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
		'tag=' . $vbulletin->GPC['tag'] . '&pp=' . $perpage;

	$navbits = array('search.php' . $vbulletin->session->vars['sessionurl_q'] => $vbphrase['search_forums']);
	$view = new vb_Search_Resultsview($results);
	$view->showpage($vbulletin->GPC['pagenumber'], $vbulletin->GPC['perpage'], $base, $navbits);

should be something like this (green is what I added, red is a change to existing line):

               
	$perpage = intval($vbulletin->GPC['perpage']);
	if ($perpage < 1)  $perpage = 5; /* or whatever you want as default value */	
	$base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
		'tag=' . $vbulletin->GPC['tag'] . '&amp;pp=' . $perpage;

	$navbits = array('search.php' . $vbulletin->session->vars['sessionurl_q'] => $vbphrase['search_forums']);
	$view = new vb_Search_Resultsview($results);
	$view->showpage($vbulletin->GPC['pagenumber'], $perpage, $base, $navbits);

There's also code in vb/search/resultsview.php in the showpage function that checks for the value of perpage (the second parameter), and if it's not set it uses the value of $vbulletin->options['searchperpage'] with a max of 200, so if you used the above code you'd be overriding that.

BTW, I haven't actually tried any of the above.

[TWood]

No go Lynne, still shows too many in the list.

Thank you for researching this kh99, but what you are proposing there is beyond me. I was hoping for a one-place setting.

[Lynne]

I guess I am not seeing the same problem. If I go to search by tags and add "&pp=2" to the end of the url, I get only two threads on each page of my results:

tags.php?tag=cats&pp=2

Are you saying that if you add "&pp=2" to the end of your url, that you still get 20 threads per page?

[kh99]

FWIW, I assumed that TWood was trying to change the default results per page for all tags searches, and not just for a specific search.