vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB4 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=252)
-   -   '&pp=' Tag Search Results Per page (https://vborg.vbsupport.ru/showthread.php?t=263859)

TWood 05-19-2011 12:01 AM

'&pp=' Tag Search Results Per page
 
The number of results shown for a Tag search is not set in the ACP. I found this in tags.php (about line 160)

HTML Code:

        $base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
                'tag=' . $vbulletin->GPC['tag'] . '&pp=' . $perpage;

It appears that a number can be placed after the = sign in '&pp=' but I don't know the syntax. Can someone tell me how that is structured?

Thanx

Lynne 05-19-2011 03:45 AM

tags.php?tag=xxxx&pp=yyyy

TWood 05-19-2011 04:05 AM

I'm sorry Lynne, you woofed me. I know you're telling me something but I don't know what it is. I was expecting to enter a number into '&pp=' after the '=' sign, with some syntax around the number. What are you telling me?

Lynne 05-19-2011 03:59 PM

You just enter a number after the =. pp means "per page". So enter the number of tags results you want shown per page.

TWood 05-19-2011 04:31 PM

I tried that, three different ways:

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp= 5 ' . $perpage;

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5 ' . $perpage;

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5' . $perpage;

It still shows all the threads with a given tag on one page, much more than 5, in this example.

Lynne 05-19-2011 07:05 PM

You can't have .$perpage after the number - 5 *is* the $perpage variable! Either set $perpage beforehand, or remove it:

$base = 'tags.php?' . $vbulletin->session->vars['sessionurl'] .
'tag=' . $vbulletin->GPC['tag'] . '&pp=5';

kh99 05-19-2011 07:18 PM

I think maybe part of the problem is that that's the base url for making links in the results page, but you'd still need to set the perpage passed to $view->showpage() below that.

I don't understand the code since $perpage is never set (unless it's set in another file somewhere, but I couldn't find it).

I'd think that this section of code (lines 159 to 164):

Code:

        $base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
                'tag=' . $vbulletin->GPC['tag'] . '&pp=' . $perpage;

        $navbits = array('search.php' . $vbulletin->session->vars['sessionurl_q'] => $vbphrase['search_forums']);
        $view = new vb_Search_Resultsview($results);
        $view->showpage($vbulletin->GPC['pagenumber'], $vbulletin->GPC['perpage'], $base, $navbits);


should be something like this (green is what I added, red is a change to existing line):

Code:

             
        $perpage = intval($vbulletin->GPC['perpage']);
        if ($perpage < 1)  $perpage = 5; /* or whatever you want as default value */
       
        $base =  'tags.php?' . $vbulletin->session->vars['sessionurl'] .
                'tag=' . $vbulletin->GPC['tag'] . '&amp;pp=' . $perpage;

        $navbits = array('search.php' . $vbulletin->session->vars['sessionurl_q'] => $vbphrase['search_forums']);
        $view = new vb_Search_Resultsview($results);
        $view->showpage($vbulletin->GPC['pagenumber'], $perpage, $base, $navbits);


There's also code in vb/search/resultsview.php in the showpage function that checks for the value of perpage (the second parameter), and if it's not set it uses the value of $vbulletin->options['searchperpage'] with a max of 200, so if you used the above code you'd be overriding that.

BTW, I haven't actually tried any of the above.

TWood 05-19-2011 10:19 PM

No go Lynne, still shows too many in the list.

Thank you for researching this kh99, but what you are proposing there is beyond me. I was hoping for a one-place setting.

Lynne 05-19-2011 10:23 PM

I guess I am not seeing the same problem. If I go to search by tags and add "&pp=2" to the end of the url, I get only two threads on each page of my results:

tags.php?tag=cats&pp=2

Are you saying that if you add "&pp=2" to the end of your url, that you still get 20 threads per page?

kh99 05-19-2011 10:59 PM

FWIW, I assumed that TWood was trying to change the default results per page for all tags searches, and not just for a specific search.


All times are GMT. The time now is 01:10 AM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01049 seconds
  • Memory Usage 1,737KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (1)bbcode_html_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (10)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • pagenav_page
  • pagenav_complete
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete