clean up condtional statements

[oldgoat]

Hello to all

I have the following modification that i am currently testing on my forum site, i am asking for help in cleaning up the code syntax.

The modification uses a conditional array to display forum id links on specific pages. Also having a slight problem with the alignment of the links.

thanks to all in advance.

PHP Code:

<!-- FORUM SPECIFIC LINK MODIFICATION -->
<if condition="in_array($GLOBALS['forumid'], array(19,25,20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="left">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=55"><B><I><font color="#999966">label #1</font><I><B><WBR>
</tr>
</table>
</if>
<if condition="in_array($GLOBALS['forumid'], array(18,20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="center">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=54"><B><I><font color="#999966">label #2</font><I><B><WBR>
</tr>
</table>
</if>
<if condition="in_array($GLOBALS['forumid'], array(20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="center">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=28"><B><I><font color="#999966">label #3</font><I><B><WBR>
</tr>
</table>
</if>

<!-- FORUM SPECIFIC LINK MODIFICATION --> 


[noppid]

Try align="left" or center tags in your table and td tags. You don't have closing </td> tags.

PS: do the table output if any of your IDs is in the array.

output the TD tags for the specific TD tags with specific conditionals for each of the 3 possible TD outputs.

Less code.

[calorie]

One alternative...

<!-- FORUM SPECIFIC LINK MODIFICATION -->

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
	<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" width="30%">
</if>

<if condition="in_array($GLOBALS['forumid'], array(19,20,25))">
	<tr>
		<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
			<a href="forumdisplay.php?f=55">label #1</a>
		</td>
	</tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,20))">
	<tr>
		<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
			<a href="forumdisplay.php?f=54">label #2</a>
		</td>
	</tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(20))">
	<tr>
		<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
			<a href="forumdisplay.php?f=28">label #3</a>
		</td>
	</tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
	</table>
</if>

<!-- /FORUM SPECIFIC LINK MODIFICATION -->

Another alternative...

<!-- FORUM SPECIFIC LINK MODIFICATION -->

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
	<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" width="100%">
	<tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(19,20,25))">
	<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
		<a href="forumdisplay.php?f=55">label #1</a>
	</td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,20))">
	<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
		<a href="forumdisplay.php?f=54">label #2</a>
	</td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(20))">
	<td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
		<a href="forumdisplay.php?f=28">label #3</a>
	</td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
	</tr>
	</table>
</if>

<!-- /FORUM SPECIFIC LINK MODIFICATION -->

[noppid]

Nice work. The second one is what I attempted to describe.

Thanks

[oldgoat]

thanks for the replies, will test it out.