vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)
-   -   clean up condtional statements (https://vborg.vbsupport.ru/showthread.php?t=119273)

oldgoat 06-21-2006 05:17 PM
clean up condtional statements
 
Hello to all

I have the following modification that i am currently testing on my forum site, i am asking for help in cleaning up the code syntax.

The modification uses a conditional array to display forum id links on specific pages. Also having a slight problem with the alignment of the links.

thanks to all in advance.
PHP Code:
<!-- FORUM SPECIFIC LINK MODIFICATION -->
<if condition="in_array($GLOBALS['forumid'], array(19,25,20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="left">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=55"><B><I><font color="#999966">label #1</font><I><B><WBR>
</tr>
</table>
</if>
<if condition="in_array($GLOBALS['forumid'], array(18,20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="center">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=54"><B><I><font color="#999966">label #2</font><I><B><WBR>
</tr>
</table>
</if>
<if condition="in_array($GLOBALS['forumid'], array(20))">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="1" width="30%" align="center">
<tr>
<td class="alt1" width="50%">
<a href="forumdisplay.php?f=28"><B><I><font color="#999966">label #3</font><I><B><WBR>
</tr>
</table>
</if>

<!-- FORUM SPECIFIC LINK MODIFICATION --> 

noppid 06-21-2006 05:50 PM
Try align="left" or center tags in your table and td tags. You don't have closing </td> tags.

PS: do the table output if any of your IDs is in the array.

output the TD tags for the specific TD tags with specific conditionals for each of the 3 possible TD outputs.

Less code.

calorie 06-21-2006 06:14 PM
One alternative...
Code:
<!-- FORUM SPECIFIC LINK MODIFICATION -->

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
        <table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" width="30%">
</if>

<if condition="in_array($GLOBALS['forumid'], array(19,20,25))">
        <tr>
                <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                        <a href="forumdisplay.php?f=55">label #1</a>
                </td>
        </tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,20))">
        <tr>
                <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                        <a href="forumdisplay.php?f=54">label #2</a>
                </td>
        </tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(20))">
        <tr>
                <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                        <a href="forumdisplay.php?f=28">label #3</a>
                </td>
        </tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
        </table>
</if>

<!-- /FORUM SPECIFIC LINK MODIFICATION -->
Another alternative...
Code:
<!-- FORUM SPECIFIC LINK MODIFICATION -->

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
        <table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" width="100%">
        <tr>
</if>

<if condition="in_array($GLOBALS['forumid'], array(19,20,25))">
        <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                <a href="forumdisplay.php?f=55">label #1</a>
        </td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,20))">
        <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                <a href="forumdisplay.php?f=54">label #2</a>
        </td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(20))">
        <td style="background: #F5F5FF; color: #999966; font-style: italic; font-weight: bold;">
                <a href="forumdisplay.php?f=28">label #3</a>
        </td>
</if>

<if condition="in_array($GLOBALS['forumid'], array(18,19,20,25))">
        </tr>
        </table>
</if>

<!-- /FORUM SPECIFIC LINK MODIFICATION -->

noppid 06-21-2006 06:46 PM
Nice work. The second one is what I attempted to describe.

Thanks

oldgoat 06-21-2006 07:55 PM
thanks for the replies, will test it out.


All times are GMT. The time now is 12:27 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.00950 seconds
  • Memory Usage 1,744KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code_printable
  • (1)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (5)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete