The Arcive of vBulletin Modifications Site.

harmor19 · #1 01-27-2006, 09:03 PM

Can someone do a quick scan of my hack and report any vulnabilities.

http://vbtest.iconrate.net/vb_hack/hosting.phps

Andreas · #2 01-27-2006, 09:18 PM

PHP Code:


			
  '" . $hp['title'] . "',

This could cause SQL errors.

PHP Code:


			
   $db->query_write("

                UPDATE " . TABLE_PREFIX . "temp_host_request

                SET userid =  '" . $user['userid'] . "',

                    subdomain = '" . $user['subdomain'] . "',

                    host_username = '" . $user['host_username'] . "',

                    host_password = '$pass',

                    planid = '" . $hp['planid'] . "',

                    title = '" . $hp['title'] ."'

                    WHERE userid = '".$vbulletin->userinfo['userid']."'  

                   ");

Depending on the data, this might also cause SQL errors.

PHP Code:


			
   $db->query_write("

                UPDATE " . TABLE_PREFIX . "user

                SET hosting_plan =  '" . $hp['title'] . "',

                    subdomain = '" . $hp['subdomain'] . "',

                    host_username = '" . $hp['host_username'] . "',

                    host_password = '" . $hp['host_password'] . "',

                    planid = '" . $hp['planid'] . "'

                    WHERE userid = '" . $user['postuserid'] . "'  

                   ");

                 

   

   $db->query_write("

                UPDATE " . TABLE_PREFIX . "thread

                SET title =  '".$hpost['title']."\n\n[Accepted]'

                    WHERE firstpostid = '" . $hpost['firstpostid'] . "'  

                   ");

This as well.

PHP Code:


			
   $db->query_write("

                UPDATE " . TABLE_PREFIX . "thread

                SET title =  '".$hpost['title']."\n\n[Declined]'

                    WHERE firstpostid = '" . $hpost['firstpostid'] . "'  

                   ");

And here too.

You should not call do_set() directly!

harmor19 · #3 01-27-2006, 09:32 PM

I chnaged all the do_set()'s to set() and setr() but they don't work.
Only do_set() works.

Andreas · #4 01-27-2006, 10:25 PM

Then you're doing smth. wrong - set/setr is the correct way.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.07315 seconds Memory Usage 4,679KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (4)bbcode_php (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (4)post_thanks_box (4)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (4)post_thanks_postbit_info (4)postbit (4)postbit_onlinestatus (4)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages: