vb.org Archive

vb.org Archive (https://vborg.vbsupport.ru/index.php)
-   vB3 General Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=111)
-   -   How secure is my hack (https://vborg.vbsupport.ru/showthread.php?t=106500)

harmor19 01-27-2006 09:03 PM
How secure is my hack
 
Can someone do a quick scan of my hack and report any vulnabilities.

http://vbtest.iconrate.net/vb_hack/hosting.phps

Andreas 01-27-2006 09:18 PM
PHP Code:
  '" . $hp['title'] . "', 
This could cause SQL errors.

PHP Code:
   $db->query_write("
                UPDATE " . TABLE_PREFIX . "temp_host_request
                SET userid =  '" . $user['userid'] . "',
                    subdomain = '" . $user['subdomain'] . "',
                    host_username = '" . $user['host_username'] . "',
                    host_password = '$pass',
                    planid = '" . $hp['planid'] . "',
                    title = '" . $hp['title'] ."'
                    WHERE userid = '".$vbulletin->userinfo['userid']."'  
                   "); 
Depending on the data, this might also cause SQL errors.

PHP Code:
   $db->query_write("
                UPDATE " . TABLE_PREFIX . "user
                SET hosting_plan =  '" . $hp['title'] . "',
                    subdomain = '" . $hp['subdomain'] . "',
                    host_username = '" . $hp['host_username'] . "',
                    host_password = '" . $hp['host_password'] . "',
                    planid = '" . $hp['planid'] . "'
                    WHERE userid = '" . $user['postuserid'] . "'  
                   ");
                 
   
   $db->query_write("
                UPDATE " . TABLE_PREFIX . "thread
                SET title =  '".$hpost['title']."\n\n[Accepted]'
                    WHERE firstpostid = '" . $hpost['firstpostid'] . "'  
                   "); 
This as well.

PHP Code:
   $db->query_write("
                UPDATE " . TABLE_PREFIX . "thread
                SET title =  '".$hpost['title']."\n\n[Declined]'
                    WHERE firstpostid = '" . $hpost['firstpostid'] . "'  
                   "); 
And here too.

You should not call do_set() directly!

harmor19 01-27-2006 09:32 PM
I chnaged all the do_set()'s to set() and setr() but they don't work.
Only do_set() works.

Andreas 01-27-2006 10:25 PM
Then you're doing smth. wrong - set/setr is the correct way.


All times are GMT. The time now is 05:15 PM.

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.

X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01141 seconds
  • Memory Usage 1,734KB
  • Queries Executed 10 (?)
More Information
Template Usage:
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_php_printable
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_navbar_search
  • (1)printthread
  • (4)printthreadbit
  • (1)spacer_close
  • (1)spacer_open 
Phrase Groups Available:
  • global
  • postbit
  • showthread
Included Files:
  • ./printthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/class_bbcode_alt.php
  • ./includes/class_bbcode.php
  • ./includes/functions_bigthree.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • printthread_start
  • bbcode_fetch_tags
  • bbcode_create
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • printthread_post
  • printthread_complete