Most ever Visitors, Posters & Chatters (Add-on)

This modification is no longer available or supported.

Warning: Do not run this vb 3.5 version on a vb 3.6 forum.

This is an add-on for the following hacks ;

FlashChat - Who is in the chat
Members who have visited the forum (Today or last 24 hours)
Members who have posted on the forum (Today or last 24 hours)

If you don't have any of these installed then this add-on will do precisely nothing. [high]Please note that you should have the latest version of the above hacks installed for this to work properly.[/high] If you do have any of these installed then this will add a "most ever" count similar to the one in the active users display.

Just download the product XML file and import using the Product Manager.


Note: Obviously it will only count from the time you install it, neither it nor I can see backwards in time.



History:

v2.02 : First Release.
v2.03 : Changed logic of IF statement.
v2.04 : Minor changes, no update necessary.

[kennn]

Hmmm...well it definitely happened and I see no signs of database corruption. Guess I'll just have to keep an eye on it and see how it goes. Thanks for the response.

[kennn]

This really has me curious and I happened to do a MySQL dump yesterday to back up my database, so I decided to do another one today and compare files.

From 04/25/2006:

INSERT INTO `vb_datastore` VALUES ('maxloggedin', 'a:6:{s:9:"maxonline";i:5;s:13:"maxonlinedate";i:1144430493;s:11:"maxvisitors";i:8;s:15:"maxvisitorsdate";i:1145928403;s:10:"maxposters";i:6;s:14:"maxpostersdate";i:1145918246;}');

From 04/26/2006:

INSERT INTO `vb_datastore` VALUES ('maxloggedin', 'a:6:{s:9:"maxonline";i:5;s:13:"maxonlinedate";i:1146065294;s:10:"maxposters";i:5;s:14:"maxpostersdate";i:1146067830;s:11:"maxvisitors";i:6;s:15:"maxvisitorsdate";i:1146065007;}');

As you can see, yesterday the maxvisitors was 8 and maxposters was 6 and today they are 6 and 5.

I did a file comparison between both database dumps and there is nothing out of the ordinary - just the usual changes from new posts, events, cron jobs running, etc. No sign of hacking or any corruption that I can see.

I would love to know how these records got changed. All other stats and information are spot on as they should be, even the "most online at once" which VB itself maintains is still correct.

[Paul M]

Well something is resetting the counts - possibly you have something that is rewriting the maxloggedin record without the maxposters & maxvisitors data.

[kennn]

These are the hacks I've got installed:

Number of Threads in User Profile
Show An Avatar On Who's Online
Mood Hack 3.5
bbSpoiler
Timezone Image In Profile
Members Who Have Posted Today
Who Has Read A Thread
Borgs BBCode Pack
Forum Skin In Profile
Join Days
Simple Breadcrumb Below Last Post
Separate Sticky & Normal Threads
Members Who Have Visited Today
Most Ever Visitors, Posters, Chatters

I've gone through the code of each and none of them make any reference to the maxloggedin datastore (except of course for "most ever visitors, posters, chatters").

I am also running vbAdvanced CMPS which does have a "who's online" module which makes references to maxloggedin. Do you think it could be the culprit? Thanks.

[kennn]

I think this is the salient portion of the onlineusers module for CMPS:

	$maxusers['maxonline'] = $vbulletin->maxloggedin['maxonline'];

	if ($vbulletin->maxloggedin['maxonline'] <= $totalonline)
	{
		$maxusers['maxonline'] = $totalonline;
		$maxusers['maxonlinedate'] = TIMENOW;
		$db->query_write("UPDATE " . TABLE_PREFIX . "datastore SET data='" . addslashes(serialize($maxusers)) . "' WHERE title = 'maxloggedin'");
	}

	$recordusers = $maxusers['maxonline'];
	$recorddate = vbdate($vbulletin->options['dateformat'], $vbulletin->maxloggedin['maxonlinedate'], 1);
	$recordtime = vbdate($vbulletin->options['timeformat'], $vbulletin->maxloggedin['maxonlinedate']);

If you think this might be the culprit, do you have any suggestions on changes I could make to the CMPS module to keep its functionality but prevent it from overwriting your plugin's data (if that is what it is doing)?

I guess I could always turn off that module but I would like to keep it if possible. Thanks!

[Paul M]

Ouch, yes, that is the culprit - it's using an sql query to directly write the maxloggedin record, erasing the maxposters and visitors data, that's very bad of whoever wrote it, the correct way is to use the build_datastore() function;

Try changing this line ;

PHP Code:

$db->query_write("UPDATE " . TABLE_PREFIX . "datastore SET data='" . addslashes(serialize($maxusers)) . "' WHERE title = 'maxloggedin'"); 


to this

PHP Code:

build_datastore('maxloggedin', serialize($vbulletin->maxloggedin)); 


[kennn]

Much thanks, Paul!

I've added your code change to my CMPS onlineusers module and will see how it goes. Hard to believe I'm the first to encounter this. I assume a lot of people are using vBAdvanced CMPS and your plugin. If this change stops the CMPS onlineusers module from stepping on the "most" plugin's toes, I'll call it to their attention over at vbadvanced.com. Thanks again!

[MorrisMcD]

Originally Posted by kennn

Much thanks, Paul!

I've added your code change to my CMPS onlineusers module and will see how it goes. Hard to believe I'm the first to encounter this. I assume a lot of people are using vBAdvanced CMPS and your plugin. If this change stops the CMPS onlineusers module from stepping on the "most" plugin's toes, I'll call it to their attention over at vbadvanced.com. Thanks again!

Wow.. That is some bull.. Anyway.. I disabled that plugin.. That sucks.. It happened to me so I came in search of answers, and I guess I ran into the same problem.. Its the first time its ever happened though which is weird. Also what is weird is it now says the most guests even online was 266 last night at 2am.. I highly doubt this.. My site usually has no more than 30 members/guests online.. Before the stats were reset I think we managed to have like 100 on a one time.. But never 266 guests!

any idea why?

[Paul M]

You obviously had 266 guests - probably a load of spiders.

[MorrisMcD]

Originally Posted by Paul M

You obviously had 266 guests - probably a load of spiders.

You think so?? I will check the logs.. I just thought it was odd.. I disabled guest access all last week due to the NFL Draft because I run a Bengals site.. Maybe they were queued up just waiting for it lol