Forumdisplay Optimization

Forumdisplay Optimization for vB 1.1.2 & 1.1.3 by rangersfan 2000

Open forumdisplay.php, and dont put in the dashes! As always backup forumdisplay.php in case something goes wrong.

Find this Code:
---------------
$threads=$DB_site->query("SELECT threadid,title,open,lastpost,replycount,postusername,lastposter,notes,iconid,views FROM thread WHERE forumid=$forumid AND visible=1 $datecut ORDER BY lastpost DESC LIMIT $limitlower,$perpage");
---------------

(editor note.. If you have changed this query and it no longer matches the above, the important part is to replace "iconid" with "thread.iconid", add "icon.title AS icontitle",
   add "icon.iconpath", replace "title" with "thread.title AS threadtitle" and add "LEFT JOIN icon ON (icon.iconid = thread.iconid)" after "FROM thread")

Replace with:
---------------
$threads=$DB_site->query("SELECT thread.iconid, icon.title AS icontitle, icon.iconpath,threadid,thread.title AS threadtitle,
                                 open,lastpost,replycount,postusername,lastposter,notes,views,userindex
                          FROM thread
                          LEFT JOIN icon ON (icon.iconid = thread.iconid)
                          WHERE forumid=$forumid AND visible=1 $datecut
                          ORDER BY lastpost
                          DESC LIMIT $limitlower,$perpage");
----------------

Find this code:
----------------
  if ($showicons==1 and $thread[iconid]!=0) {
    if ($icon=$DB_site->query_first("SELECT title,iconpath FROM icon WHERE iconid=$thread[iconid]")) {
      $threadicon="<img src=\"$icon[iconpath]\" alt=\"$icon[title]\" border=0>";
    } else {
      $threadicon="&nbsp;";
    }
  } else {
    $threadicon="&nbsp;";
  }
----------------

Replace with:
----------------
  $threadicon="&nbsp;";
  if ($showicons==1 and $thread[iconid]!=0)
  {
     $threadicon="<img src=\"$thread[iconpath]\" alt=\"$thread[icontitle]\" border=0>";
  }
-----------------

version 1.1.2 and version 1.1.3beta1 and 2 Find this code:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[title]);
  }
  $threadtitle=htmlspecialchars($thread[title]);
-----------------

Replace with:
-----------------
  if ($wordwrap!=0) {
    $thread[threadtitle]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[threadtitle]);
  }
  $threadtitle=htmlspecialchars($thread[threadtitle]);
-----------------

version 1.1.3beta3 find this code:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[title]);
  }
  $threadtitle=htmlspecialchars($thread[title]);

Replace with:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[threadtitle]);
  }
  $threadtitle=htmlspecialchars($thread[threadtitle]);

That's it! Enjoy. This will cut your queries on forumdisplay from (Num of threads on page + 6) to 6!

Also please forgive me but I have a thing about code structure and readability.

[Edited by rangersfan on 10-26-2000 at 04:43 PM]

Hi,

I have looked thru all files and cannot find the above statement. I have vb 1.1.3 too.

Can you find the instances of $wordwrap in forumdisplay.php? You can also send me your forumdisplay.php and I will see what you are missing.

webmaster@hedgehogwheels.com

Cheers for this, have sent email now.


The only instance of it is as follows:

if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[title]);
  }

Originally posted by rangersfan

Can you find the instances of $wordwrap in forumdisplay.php? You can also send me your forumdisplay.php and I will see what you are missing.

webmaster@hedgehogwheels.com

Originally posted by rangersfan
Well, hopefully, any update would have this in it already.

Yes it will

good saved me some work

same i couldn't find it if i searched for the entire code... but searching just for the first line i found it

if ($wordwrap!=0) {

and then the next 3 lines under it was it

When I search in forumdisplay this is what I get:

if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[title]);
  }

it went in fine for me and seems to be doing it's trick

the combination of this, the showthread and global optimizations seem to be helping my board along.

I'm getting between 3-5k posts a day and every little bit helps

Ok I fixed the problem. It seems I am still using 1.1.3beta2 and with beta3 John moved the eregi line into a function hence the differences. If you have already changed the code, it will work either way as the function just calls the same code you pasted in.

Yeah I installed it before you found a problem. It is producing no error...and seems to be running smooth...I get around 290+ concurrent users during peak hours.

Thanks.