Forumdisplay Optimization

Forumdisplay Optimization for vB 1.1.2 & 1.1.3 by rangersfan 2000

Open forumdisplay.php, and dont put in the dashes! As always backup forumdisplay.php in case something goes wrong.

Find this Code:
---------------
$threads=$DB_site->query("SELECT threadid,title,open,lastpost,replycount,postusername,lastposter,notes,iconid,views FROM thread WHERE forumid=$forumid AND visible=1 $datecut ORDER BY lastpost DESC LIMIT $limitlower,$perpage");
---------------

(editor note.. If you have changed this query and it no longer matches the above, the important part is to replace "iconid" with "thread.iconid", add "icon.title AS icontitle",
   add "icon.iconpath", replace "title" with "thread.title AS threadtitle" and add "LEFT JOIN icon ON (icon.iconid = thread.iconid)" after "FROM thread")

Replace with:
---------------
$threads=$DB_site->query("SELECT thread.iconid, icon.title AS icontitle, icon.iconpath,threadid,thread.title AS threadtitle,
                                 open,lastpost,replycount,postusername,lastposter,notes,views,userindex
                          FROM thread
                          LEFT JOIN icon ON (icon.iconid = thread.iconid)
                          WHERE forumid=$forumid AND visible=1 $datecut
                          ORDER BY lastpost
                          DESC LIMIT $limitlower,$perpage");
----------------

Find this code:
----------------
  if ($showicons==1 and $thread[iconid]!=0) {
    if ($icon=$DB_site->query_first("SELECT title,iconpath FROM icon WHERE iconid=$thread[iconid]")) {
      $threadicon="<img src=\"$icon[iconpath]\" alt=\"$icon[title]\" border=0>";
    } else {
      $threadicon="&nbsp;";
    }
  } else {
    $threadicon="&nbsp;";
  }
----------------

Replace with:
----------------
  $threadicon="&nbsp;";
  if ($showicons==1 and $thread[iconid]!=0)
  {
     $threadicon="<img src=\"$thread[iconpath]\" alt=\"$thread[icontitle]\" border=0>";
  }
-----------------

version 1.1.2 and version 1.1.3beta1 and 2 Find this code:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[title]);
  }
  $threadtitle=htmlspecialchars($thread[title]);
-----------------

Replace with:
-----------------
  if ($wordwrap!=0) {
    $thread[threadtitle]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[threadtitle]);
  }
  $threadtitle=htmlspecialchars($thread[threadtitle]);
-----------------

version 1.1.3beta3 find this code:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[title]);
  }
  $threadtitle=htmlspecialchars($thread[title]);

Replace with:
-----------------
  if ($wordwrap!=0) {
    $thread[title]=dowordwrap($thread[threadtitle]);
  }
  $threadtitle=htmlspecialchars($thread[threadtitle]);

That's it! Enjoy. This will cut your queries on forumdisplay from (Num of threads on page + 6) to 6!

Also please forgive me but I have a thing about code structure and readability.

[Edited by rangersfan on 10-26-2000 at 04:43 PM]

Originally posted by rangersfan
Also please forgive me but I have a thing about code structure and readability.

Forgive you? I think *all* queries should be structured exactly like you've done... it makes it sooo much easier to read and maintain the code that way.

Wonderful optimization by the way, I am sure this will be a very nice performance increase

-Chris

Its amazing how this could slip the cracks. I would at least have thought they would have used a caching system, or maybe one query of all icons before loading the page.

People, this hack will increase performance (if mysql is your bottleneck, as it is in my case) greatly. Get it now.

Originally posted by Stallion
Its amazing how this could slip the cracks. I would at least have thought they would have used a caching system, or maybe one query of all icons before loading the page.

People, this hack will increase performance (if mysql is your bottleneck, as it is in my case) greatly. Get it now.

hmmmm... mysql is my problem from day one... would these instructions change if i had hacks already ?

I dont' think there are any hacks (outside of my dot hack or VirtueTech's forum display sorting) that would have changed this code.

thanks i tried it on my long forgotten private testing vB which has the poll hack added also... seems to work.. gonna add it to my forums once i finish defragging my other pc with my working copy of my site files

great stuff rangersfan with me lowering my join buffers and adding this optimisation i survived my first forum peak hour without needing to reboot my server

Find this code:
-----------------
if ($wordwrap!=0) {
$thread[title]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[title]);
}
$threadtitle=htmlspecialchars($thread[title]);
-----------------

Replace with:
-----------------
if ($wordwrap!=0) {
$thread[threadtitle]=eregi_replace("([^\n\r <>\"\\-]{$wordwrap})"," \\1 ",$thread[threadtitle]);
}
$threadtitle=htmlspecialchars($thread[threadtitle]);
-----------------
[/code]

Hi,

I have looked thru all files and cannot find the above statement. I have vb 1.1.3 too.

I will try this out after the major update!

Originally posted by vBoard.co.uk
I will try this out after the major update!

Well, hopefully, any update would have this in it already.