:) NEed help - 2 Questions MYSQL

[kiril_cvetkov]

I have problems while coding vbulletin
Please help me.. i will be very happy if someone replay..

First question :
i get error when i put

PHP Code:

    $featured = $db->query_read("SELECT title2,picture2,catid2 FROM " . TABLE_PREFIX . "tabeladva order by views2 desc LIMIT 5 where number=" .$_GET['id']); 


when i remove this

where number=" .$_GET['id']

i don't have error anymore.. but i don't get the function that i want..
***How is possible to use order by and where together*****

Second question :

How i can count, how many rows have in one field

Please help me :erm:

[Lynne]

I think you need to have your WHERE clause before your ORDER BY clause.

[Farcaster]

Lynne is correct. Your clauses are out of order. In addition, I would add that the query you provided is extremely vulnerable to SQL injection attacks--and DB errors if an ID isn't passed. You should consider using vbulletin's internal functions for fetching passed parameters. Example:

PHP Code:

// Additionally using intval, because I am not 100% sure var is set to 0 by vbulletin if no parameter was passed.
$myID = intval($vbulletin->input->clean_gpc('g', 'id', TYPE_INT));

$featured = $db->query_read("
    SELECT title2,picture2,catid2 
    FROM " . TABLE_PREFIX . "tabeladva 
    where number = $myID
    ORDER BY views2 desc 
    LIMIT 5"

); 


[kiril_cvetkov]

thanks and please one more question
how to make ex. " file.php?cat=1?thread=5 " double id's!!!

[Farcaster]

Originally Posted by kiril_cvetkov

thanks and please one more question
how to make ex. " file.php?cat=1?thread=5 " double id's!!!

If I am understanding you correctly, you are wanting to know how to pass and fetch multiple parameters. First, you separate variables in the URL using the ampersand. So, your URL query string should be: http://www.yoursite.com/file.php?cat=1&thread=5

As to getting those variables, here is a link the vBulletin manual that explains using vBulletin's built in functions for accessing $_GET, $_POST, and $_REQUEST: http://www.vbulletin.com/docs/html/codestandards_gpc

Note that in the example code, the code highlighted in red is the undesirable method.