vb.org Archive - :) NEed help - 2 Questions MYSQL

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - :) NEed help - 2 Questions MYSQL (https://vborg.vbsupport.ru/showthread.php?t=175439)

kiril_cvetkov

04-07-2008 04:12 PM

:) NEed help - 2 Questions MYSQL

I have problems while coding vbulletin
Please help me.. i will be very happy if someone replay..

First question :
i get error when i put

PHP Code:


		
			
    $featured = $db->query_read("SELECT title2,picture2,catid2 FROM " . TABLE_PREFIX . "tabeladva order by views2 desc LIMIT 5 where number=" .$_GET['id']);

when i remove this

HTML Code:

where number=" .$_GET['id']

i don't have error anymore.. but i don't get the function that i want..
***How is possible to use order by and where together*****

Second question :

How i can count, how many rows have in one field

Please help me :erm:

Lynne

04-07-2008 04:15 PM

I think you need to have your WHERE clause before your ORDER BY clause.

Farcaster

04-07-2008 04:52 PM

Lynne is correct. Your clauses are out of order. In addition, I would add that the query you provided is extremely vulnerable to SQL injection attacks--and DB errors if an ID isn't passed. You should consider using vbulletin's internal functions for fetching passed parameters. Example:

PHP Code:


		
			
// Additionally using intval, because I am not 100% sure var is set to 0 by vbulletin if no parameter was passed.

$myID = intval($vbulletin->input->clean_gpc('g', 'id', TYPE_INT));



$featured = $db->query_read("

    SELECT title2,picture2,catid2 

    FROM " . TABLE_PREFIX . "tabeladva 

    where number = $myID

    ORDER BY views2 desc 

    LIMIT 5"



);

kiril_cvetkov

04-07-2008 05:57 PM

thanks and please one more question
how to make ex. " file.php?cat=1?thread=5 " double id's!!!

Farcaster

04-07-2008 06:18 PM

Quote:

Originally Posted by kiril_cvetkov (Post 1485392)

thanks and please one more question
how to make ex. " file.php?cat=1?thread=5 " double id's!!!

If I am understanding you correctly, you are wanting to know how to pass and fetch multiple parameters. First, you separate variables in the URL using the ampersand. So, your URL query string should be: http://www.yoursite.com/file.php?cat=1&thread=5

As to getting those variables, here is a link the vBulletin manual that explains using vBulletin's built in functions for accessing $_GET, $_POST, and $_REQUEST: http://www.vbulletin.com/docs/html/codestandards_gpc

Note that in the example code, the code highlighted in red is the undesirable method.

All times are GMT. The time now is 09:00 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01268 seconds Memory Usage 1,725KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_html_printable (2)bbcode_php_printable (1)bbcode_quote_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (5)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: