New VB broke a hack... Email notification

[badran]

I had made a simple modification to the "include/functions_newpost.php" file , on line 489

PHP Code:

    // ### DO EMAIL NOTIFICATION ###
    //if ($post['visible'] AND !$prevpostfound AND $type != 'thread' AND !in_coventry($vbulletin->userinfo['userid'], true))
    if ($post['visible'] AND $type != 'thread' AND !in_coventry($vbulletin->userinfo['userid'], true))
    {
        exec_send_notification($threadinfo['threadid'], $vbulletin->userinfo['userid'], $post['postid']);
    } 


(removed the "AND !$prevpostfound" from the If line)

It worked on 3.7 but now it is not working any help.... This would cause the email notification be sent even if the user already got an email from the corresponding subtopic/thread.

[Paul M]

There is no reason that would not work in 3.6.8 - Did you actually remember to re-edit the file after you upgraded ?

[badran]

I did... no results..

[Paul M]

Having looked in functions_newpost I cannot see any link between the variable you have removed and the functionality you seem to require - $prevpostfound is the duplicate post check. In fact I can't see how it could ever be 'true' at the point of that code, so it seems to be a redundant check you are removing.

[badran]

Then how did this actually work in older versions of VB, This worked in 3.6 and 3.7 ... and if so (as It does appear to be so) what do I need to do to get this to work. (when sending a notification, not check if an email was sent to that person before).

Thank you.

[chinch]

any updates or ideas to get this working? (ie. always notify, even if member did NOT visit)