vb.org Archive - New VB broke a hack... Email notification

vb.org Archive (https://vborg.vbsupport.ru/index.php)

- vB3 Programming Discussions (https://vborg.vbsupport.ru/forumdisplay.php?f=15)

- - New VB broke a hack... Email notification (https://vborg.vbsupport.ru/showthread.php?t=155306)

badran

08-15-2007 01:35 PM

New VB broke a hack... Email notification

I had made a simple modification to the "include/functions_newpost.php" file , on line 489

PHP Code:


		
			
    // ### DO EMAIL NOTIFICATION ###
    //if ($post['visible'] AND !$prevpostfound AND $type != 'thread' AND !in_coventry($vbulletin->userinfo['userid'], true))
    if ($post['visible'] AND $type != 'thread' AND !in_coventry($vbulletin->userinfo['userid'], true))
    {
        exec_send_notification($threadinfo['threadid'], $vbulletin->userinfo['userid'], $post['postid']);
    }

(removed the "AND !$prevpostfound" from the If line)

It worked on 3.7 but now it is not working any help.... This would cause the email notification be sent even if the user already got an email from the corresponding subtopic/thread.

Paul M

08-15-2007 06:20 PM

There is no reason that would not work in 3.6.8 - Did you actually remember to re-edit the file after you upgraded ?

badran

08-15-2007 07:27 PM

I did... no results..

Paul M

08-15-2007 08:49 PM

Having looked in functions_newpost I cannot see any link between the variable you have removed and the functionality you seem to require - $prevpostfound is the duplicate post check. In fact I can't see how it could ever be 'true' at the point of that code, so it seems to be a redundant check you are removing.

badran

08-16-2007 02:27 AM

Then how did this actually work in older versions of VB, This worked in 3.6 and 3.7 ... and if so (as It does appear to be so) what do I need to do to get this to work. (when sending a notification, not check if an email was sent to that person before).

Thank you.

chinch

03-10-2008 11:52 PM

any updates or ideas to get this working? (ie. always notify, even if member did NOT visit)

All times are GMT. The time now is 11:12 AM.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.00919 seconds Memory Usage 1,721KB Queries Executed 10 (?)
More Information
Template Usage: (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_php_printable (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_navbar_search (1)printthread (6)printthreadbit (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit showthread	Included Files: ./printthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/class_bbcode_alt.php ./includes/class_bbcode.php ./includes/functions_bigthree.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete printthread_start bbcode_fetch_tags bbcode_create bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete printthread_post printthread_complete
Messages: