PDA

View Full Version : [AJAX] Post Thank You Hack


Pages : 1 [2] 3 4

mfizzel
12-04-2005, 03:23 AM
Imported 2.6 and 1-1,999 still read 'thanked 1 time in 1 post'

Bubble #5
12-04-2005, 03:47 AM
Hi Abe :) When we're upgrading from 2.5 do we just do the template changes, or do we do the template changes, uninstall the 2.5 plugin and reinstall 2.6 plugin?

mfizzel
12-04-2005, 03:55 AM
just import and overwrite the product

masterross
12-04-2005, 11:17 AM
in vBulletin Options look for Post Thank You Hack in the drop down menu
thank you!

BR,
Ross

lazytown
12-04-2005, 11:26 AM
Thanks! Love the mod. However....

I may have to uninstall this after seeing the load / performance problems it is causing my server. If I click search->find all thanks, it causes a load on my server like I've never seen before (even with regular searches). Now I do have over 10,000 members and 850,000 posts. Is it scanning each and every post when a user clicks that? Why the huge load?

Thanks -vissa

Abe1
12-04-2005, 12:20 PM
Imported 2.6 and 1-1,999 still read 'thanked 1 time in 1 post'

Did you do the template changes in the file 'template changes from v2.5 to 2.6"?

Abe1
12-04-2005, 12:21 PM
Thanks! Love the mod. However....

I may have to uninstall this after seeing the load / performance problems it is causing my server. If I click search->find all thanks, it causes a load on my server like I've never seen before (even with regular searches). Now I do have over 10,000 members and 850,000 posts. Is it scanning each and every post when a user clicks that? Why the huge load?

Thanks -vissa

1) You can dissable the view all thanks button by not doing that template edit.

2) Can you please explain more were the extra load is?

lazytown
12-04-2005, 12:33 PM
The load occurs whenever someone clicks "view all thanks" either in the memberinfo or navbar templates. I removed both of them, but it's a shame not to be able to do that.

It looks like the reason is because the search query it creates scans through every single post and does some very large joins. It creates by far the largest load of anything I have on my vbulletin (and I have a lot of mods, search enabled, etc). If you need more details please ask a specific question.

thanks -vissa
1) You can dissable the view all thanks button by not doing that template edit.

2) Can you please explain more were the extra load is?

mfizzel
12-04-2005, 02:40 PM
Did you do the template changes in the file 'template changes from v2.5 to 2.6"?

nope, now I did, works great thanks

Dollah
12-04-2005, 03:49 PM
i am running 3.5.1 and i dont see any of template edits you are refering to. is their any way u can help me out

Dollah
12-04-2005, 05:06 PM
i am running 3.5.1 and i dont see any of template edits you are refering to. is their any way u can help me out

i found it just been tired late ly so thanx and installed

Abe1
12-04-2005, 10:19 PM
The load occurs whenever someone clicks "view all thanks" either in the memberinfo or navbar templates. I removed both of them, but it's a shame not to be able to do that.

It looks like the reason is because the search query it creates scans through every single post and does some very large joins. It creates by far the largest load of anything I have on my vbulletin (and I have a lot of mods, search enabled, etc). If you need more details please ask a specific question.

thanks -vissa


It uses the same query that VB uses to search posts. Can you see if there is a differencein the load time of searching for all posts of one user?

SCRIPT3R
12-05-2005, 01:48 AM
for template changes between version 2.5 and 2.6, you have the following instructions...

in postbit AND postbit_lagacy:

find:
--------------------------------------------------------------------
<if condition="$post[post_thanks_thanked_posts] == 1">
--------------------------------------------------------------------

REPLACE WITH:
--------------------------------------------------------------------
<if condition="$post[post_thanks_thanked_posts] == 1">
--------------------------------------------------------------------

shouldn't the REPLACE line read as..

REPLACE WITH:
--------------------------------------------------------------------
<if condition="$post[post_thanks_thanked_posts_on] == 1">
--------------------------------------------------------------------
just want to double-check prior to template modification.

Abe1
12-05-2005, 12:02 PM
for template changes between version 2.5 and 2.6, you have the following instructions...


shouldn't the REPLACE line read as..


just want to double-check prior to template modification.

Yes. Thanks alot. Uploading new zip.

lazytown
12-06-2005, 08:27 AM
I installed this mod: https://vborg.vbsupport.ru/showthread.php?t=82628 to prevent the search from being used during high server load.

Would using phpmyadmin to index some of the rows in the table help the search for thanks speed at all?

thanks -vissa

havefun
12-06-2005, 11:35 AM
thx for the update :)

Abe1
12-06-2005, 12:06 PM
I installed this mod: https://vborg.vbsupport.ru/showthread.php?t=82628 to prevent the search from being used during high server load.

Would using phpmyadmin to index some of the rows in the table help the search for thanks speed at all?

thanks -vissa

I dont know.

dan35
12-07-2005, 09:32 PM
Edit! Managed to integrate it with uCash ;-)

Cool! Do you have any instruction? ;)

Bubble #5
12-09-2005, 04:16 AM
Hi Abe. We're having trouble with the thank you button not centering properly when a thread is closed. What template or script is $post_thanks_button calling to?

lazytown
12-09-2005, 10:22 AM
I've attempted to uninstall this mod and it doesn't uninstall quite properly. I believe it removed most of the tables, but all the phrases and one template still remain.

thanks -vissa

bashy
12-09-2005, 12:02 PM
Hi..

I have installed this and is working well apart from...

Rep points do not go up (is enabled to 1)
Post count does not go up (is enabled to 1)

Also, I am using the mod that hides the attachments until the member
has posted, is there away that you could sort this so that when they have
clicked the thanks button it will allow you to see the attachments instead of having to post as well?

Regards

Bashy

Abe1
12-09-2005, 12:30 PM
I've attempted to uninstall this mod and it doesn't uninstall quite properly. I believe it removed most of the tables, but all the phrases and one template still remain.

thanks -vissa

Were they customized? vB's unistaller may not remove something you costomized.

Abe1
12-09-2005, 12:31 PM
Hi..

I have installed this and is working well apart from...

Rep points do not go up (is enabled to 1)
Post count does not go up (is enabled to 1)

Also, I am using the mod that hides the attachments until the member
has posted, is there away that you could sort this so that when they have
clicked the thanks button it will allow you to see the attachments instead of having to post as well?

Regards

Bashy

Do you have a link to the hack?

Abe1
12-09-2005, 12:32 PM
Hi Abe. We're having trouble with the thank you button not centering properly when a thread is closed. What template or script is $post_thanks_button calling to?

It called from the plugin. I may make it a template some day.

bashy
12-09-2005, 01:03 PM
Hi,

Thanks for your quick response, here the link https://vborg.vbsupport.ru/showthread.php?t=94539&highlight=attachment
Will look forward to the out come :)

Do you have a link to the hack?

Regards

Bashy

Abe1
12-09-2005, 06:31 PM
Hi,

Thanks for your quick response, here the link https://vborg.vbsupport.ru/showthread.php?t=94539&highlight=attachment
Will look forward to the out come :)



Regards

Bashy

I have to code to make it work, i'm just waiting right now. For some reason the guys code doesn't work now. Look at the last few posts in the thread.

LEAD_WEIGHT
12-09-2005, 06:49 PM
3.5.2?

Will this work for vB3.5.2? I will wait a couple of more weeks to see if any bugs come out.

Ncturnal
12-10-2005, 04:16 PM
Will this work for vB3.5.2? I will wait a couple of more weeks to see if any bugs come out.

Working great for us on 3.5.2. :D

Something I'd like to see to compliment this is a Top Ten similiar to Paul M's Top Ten posters. https://vborg.vbsupport.ru/showthread.php?t=92177 :D

Abe1
12-10-2005, 09:10 PM
Working great for us on 3.5.2. :D

Something I'd like to see to compliment this is a Top Ten similiar to Paul M's Top Ten posters. https://vborg.vbsupport.ru/showthread.php?t=92177 :D

I did a top ten for the CMPS portal.

Bubble #5
12-11-2005, 02:51 AM
Abe is there a "align = "left" assigned to the post thanks button anywhere? We can't seem to get it to center :ermm:

Ncturnal
12-11-2005, 02:53 AM
It should be right next to your "Edit" button. You may want to recheck your template modifications.

Bubble #5
12-11-2005, 04:38 AM
No, we're not talking about where the button goes, we're talking about the code that feeds this:

$post_thanks_button

It is aligning LEFT, even though it is wrapped in center tags.

<center><if condition="$show['quickreply'] AND !$show['threadedmode']"><a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a></if>

<!-- Start Post Thank You Hack -->
$post_thanks_button
<!-- End Post Thank You Hack -->

<if condition="$post['editlink']"><a href="$post[editlink]" name="vB::QuickEdit::$post[postid]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a></if></center>

All of the other buttons in our fieldset align center as they should. The post thanks button is the ONLY one that aligns left :ermm: When a thread is closed the edit and quick reply buttons do not appear, just the thanks button appears, only it aligns left :ermm: We need to fix that or we cannot use the hack, and we'd really like to use it. We just need to know where that button is picking up the left align from...

Abe1
12-11-2005, 02:55 PM
No, we're not talking about where the button goes, we're talking about the code that feeds this:

$post_thanks_button

It is aligning LEFT, even though it is wrapped in center tags.

<center><if condition="$show['quickreply'] AND !$show['threadedmode']"><a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a></if>

<!-- Start Post Thank You Hack -->
$post_thanks_button
<!-- End Post Thank You Hack -->

<if condition="$post['editlink']"><a href="$post[editlink]" name="vB::QuickEdit::$post[postid]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a></if></center>

All of the other buttons in our fieldset align center as they should. The post thanks button is the ONLY one that aligns left :ermm: When a thread is closed the edit and quick reply buttons do not appear, just the thanks button appears, only it aligns left :ermm: We need to fix that or we cannot use the hack, and we'd really like to use it. We just need to know where that button is picking up the left align from...

The code is in the plugin. I will move it to a template some day in the future.

Tulsa
12-11-2005, 03:29 PM
* Tulsa drops a reminder in Abe's ear, "groan button". ;)

Abe1
12-11-2005, 03:32 PM
* Tulsa drops a reminder in Abe's ear, "groan button". ;)

Thanks. Any other feature people are waiting for?

Dollah
12-11-2005, 04:00 PM
i had to unistall it and now when i got to reinstall its not showing the template mods i need to do. i'm usuing 3.5.1 havent upgraded as of yet

Abe1
12-11-2005, 06:49 PM
i had to unistall it and now when i got to reinstall its not showing the template mods i need to do. i'm usuing 3.5.1 havent upgraded as of yet

The template mods are in the zip file.

siriuxs
12-11-2005, 08:48 PM
Hi, I want installed the hack, but i don't see a button tank...:S Why?

Bubble #5
12-11-2005, 10:15 PM
The code is in the plugin.
Can we get to the code through the ACP in anyway?

Bubble #5
12-11-2005, 10:17 PM
i don't see a button tank...:S Why?
Did you double check your template installs?

Did you upload the button to the correct place on the server?

Abe1
12-11-2005, 11:32 PM
Can we get to the code through the ACP in anyway?
Sure.

ACP -> Plugin System -> Plugin Manager -> postbit_display_start hook location

siriuxs
12-12-2005, 06:55 AM
Did you double check your template installs?

Did you upload the button to the correct place on the server?

Yes, I do all...:'(

Abe1
12-12-2005, 12:13 PM
Yes, I do all...:'(

Are you looking at your own post? You can't thank yourself so you have to look at someone elses post to see if it's there.

siriuxs
12-12-2005, 12:19 PM
Are you looking at your own post? You can't thank yourself so you have to look at someone elses post to see if it's there.

Ahhhhhhh..... ok...Tank...;)

webspider
12-12-2005, 07:39 PM
I love this hack as do my users but I was thinking today that it would be great is the VB promotion system could use the thanks data for auto promotions. Right now it will count posts, reputation,and check date.

VaaKo
12-18-2005, 02:41 PM
can you integrate this hack with the hide hack?

Abe1
12-18-2005, 03:09 PM
can you integrate this hack with the hide hack?

Can you give me a link?

pipin
12-18-2005, 08:23 PM
thanx abe for this one.

just 2 points.

you should phrase the "Thanked Post" for the reputation in showthread_start

$db->query(" INSERT INTO ". TABLE_PREFIX ."reputation
(postid, userid, reputation, whoadded, reason, dateline)
VALUES ('$postid', '$postinfo[userid]', '$vboptions[post_thanks_reputation]', '$bbuserinfo[userid]', 'Thanked Post', " . TIMENOW . ") ");




and is it right that removing the thanks wont remove the given reputation?

Abe1
12-18-2005, 09:10 PM
thanx abe for this one.

just 2 points.

you should phrase the "Thanked Post" for the reputation in showthread_start

$db->query(" INSERT INTO ". TABLE_PREFIX ."reputation
(postid, userid, reputation, whoadded, reason, dateline)
VALUES ('$postid', '$postinfo[userid]', '$vboptions[post_thanks_reputation]', '$bbuserinfo[userid]', 'Thanked Post', " . TIMENOW . ") ");




and is it right that removing the thanks wont remove the given reputation?

I fixed the pharse. It will be realised in my update comming out in the next day or two.

The replutation should be deleted. Right now I just tested it and fixed up a drop and know it works. Let me know once I release the update.

Abe1
12-18-2005, 09:29 PM
Version 2.7 (12/18/05):

[ADDED] Made the Thanks button a template
[ADDED] Made a template group for this hacks templates
[FIXED] One template edit. Find correction in zip file.
[CHANGED] Made a pop-up now when you click Thanks instead of refreshing the page.
[FIXED] Made the line when you give reputation points for thanks, a phrase.
[ADDED] Paypal link so you can make a donation for this hack.

stinger2
12-18-2005, 10:46 PM
Can you give me a link?

https://vborg.vbsupport.ru/showthread.php?t=99918&highlight=hide

i would also love it if they were integrated
this is a link to a working hide

regards and thanks for this great hack

Abe1
12-18-2005, 10:48 PM
https://vborg.vbsupport.ru/showthread.php?t=99918&highlight=hide

i would also love it if they were integrated
this is a link to a working hide

regards and thanks for this great hack

How do you want me to intergrade it?

SCRIPT3R
12-18-2005, 11:03 PM
Version 2.7 (12/18/05):

current zip (update?) reads as Version 2.6 still. ;)

- <product productid="post_thanks" active="1">
<title>Post Thank You Hack</title>
<description>Post Thank You Hack</description>
<version>2.6</version>
- <codes>
- <code version="2.6">
- <installcode>

SCRIPT3R
12-18-2005, 11:07 PM
Version 2.7 (12/18/05):

[CHANGED] Made a pop-up now when you click Thanks instead of refreshing the page.
could this "feature" be an option at all for the user? how will pop-up blockers respond/interfere with this?

Abe1
12-19-2005, 12:15 AM
current zip (update?) reads as Version 2.6 still. ;)

Fixed.

Abe1
12-19-2005, 12:17 AM
could this "feature" be an option at all for the user? how will pop-up blockers respond/interfere with this?

It is a direct pop-up on the click so a pop-up blocker should not disrupt it. They only block pop-ups that pop-up while a page is doing something else and not when a user clicks on a link that is a pop-up.

stinger2
12-19-2005, 02:58 PM
can you integrate this hack with the hide hack?


How do you want me to intergrade it?

sorry for not explaining ...
i responded to Don corleone.......who asked about integrating th thank yu hack with hide hack.......

it would either be with the lockdown hack.....(reply to view the link) or the hide hack (register to view)......
but instead of (register to view link) in the hide hack....or instead of (reply to view the link) in lockdown hack.......i think he refeered to press thankyou button to see the link.....


again my apologies .......
kind regards

Abe1
12-19-2005, 03:14 PM
sorry for not explaining ...
i responded to Don corleone.......who asked about integrating th thank yu hack with hide hack.......

it would either be with the lockdown hack.....(reply to view the link) or the hide hack (register to view)......
but instead of (register to view link) in the hide hack....or instead of (reply to view the link) in lockdown hack.......i think he refeered to press thankyou button to see the link.....


again my apologies .......
kind regards

I can't intergade with a hack that blocks unregistered users. I can intergrade with a reply hack. I need a link.

stinger2
12-19-2005, 05:21 PM
yap sure i forgot where i saw that but a little search in my favourite ....i found it...

this is an example of integrated for vb 3.0.9

http://www.vbhackers.com/forum/showthread.php?t=2187&highlight=Lockdown+hack

and here is the last lockdown hack ......there is no integrated version yet.....

http://www.vbhackers.com/forum/showthread.php?t=2096&highlight=Lockdown+hack

kind regards

AnhTuanCool
12-19-2005, 05:26 PM
Hey, nice hack there you made Abe1. /me clicked installed.

I made a modification to optimize the querying part of the hack as follow:
In plugin Post Thank You Hack at postbit_display_start, I'd changed:

$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Into


$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE post.postid = post_thanks.postid AND post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");


It shortened the querying by one query, for some small or moderate boards, it doesn't make any noticeable different. But in any large board, it does help a lot.

You can include the mod if you want. Thanks for great hack! ;)

aranthorn
12-20-2005, 04:31 PM
Hey, nice hack there you made Abe1. /me clicked installed.

I made a modification to optimize the querying part of the hack as follow:
In plugin Post Thank You Hack at postbit_display_start, I'd changed:

$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Into


$post_thanks_cashe = $db->query("SELECT post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE post.postid = post_thanks.postid AND post.threadid = '$post[threadid]'");


It shortened the querying by one query, for some small or moderate boards, it doesn't make any noticeable different. But in any large board, it does help a lot.

You can include the mod if you want. Thanks for great hack! ;)
changed mine over, thanks :D

masterross
12-20-2005, 09:05 PM
Hey, nice hack there you made Abe1. /me clicked installed.

I made a modification to optimize the querying part of the hack as follow:
In plugin Post Thank You Hack at postbit_display_start, I'd changed:

$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Into


$post_thanks_cashe = $db->query("SELECT post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE post.postid = post_thanks.postid AND post.threadid = '$post[threadid]'");


It shortened the querying by one query, for some small or moderate boards, it doesn't make any noticeable different. But in any large board, it does help a lot.

You can include the mod if you want. Thanks for great hack! ;)

i've change too but get:
Database error in vBulletin 3.5.2:

Invalid SQL:
SELECT post_thanks.* FROM vb_post_thanks, vb_post WHERE post.postid = post_thanks.postid AND post.threadid = '43120';

MySQL Error : Unknown table 'post_thanks'
Error Number : 1051

AnhTuanCool
12-21-2005, 03:20 PM
materros - Replace this line in that same plugin (Post Thank You Hack at postbit_display_start hook location)


$post_thanks_cashe = $db->query("SELECT post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE post.postid = post_thanks.postid AND post.threadid = '$post[threadid]'");


OR (if you haven't applied the change from post 310 of mine)


$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


To


$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE post.postid = post_thanks.postid AND post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");

That should fix it. Good luck ;)

masterross
12-22-2005, 05:14 PM
thanks for the update
after applied a little bit different error: :)
Database error in vBulletin 3.5.2:

Invalid SQL:
SELECT vb_post_thanks.* FROM vb_post_thanks, vb_post WHERE post.postid = post_thanks.postid AND post.threadid = '44699' ORDER BY vb_post_thanks.username ASC;

MySQL Error : Unknown table 'post' in where clause
Error Number : 1109
Date : Thursday, December 22nd 2005 @ 09:10:17 PM

masterross
12-22-2005, 05:16 PM
i forgot to tell that i have table prefix - "vb_"

BR,
Ross

Abe1
12-22-2005, 05:17 PM
thanks for the update
after applied a little bit different error: :)
Database error in vBulletin 3.5.2:

Invalid SQL:
SELECT vb_post_thanks.* FROM vb_post_thanks, vb_post WHERE post.postid = post_thanks.postid AND post.threadid = '44699' ORDER BY vb_post_thanks.username ASC;

MySQL Error : Unknown table 'post' in where clause
Error Number : 1109
Date : Thursday, December 22nd 2005 @ 09:10:17 PM

Here: Use this.$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE " . TABLE_PREFIX . "post.postid = post_thanks.postid AND " . TABLE_PREFIX . "post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");

masterross
12-22-2005, 09:05 PM
sorry guys...
again prob:

Database error in vBulletin 3.5.2:

Invalid SQL:
SELECT vb_post_thanks.* FROM vb_post_thanks, vb_post WHERE vb_post.postid = post_thanks.postid AND vb_post.threadid = '44699' ORDER BY vb_post_thanks.username ASC;

MySQL Error : Unknown table 'post_thanks' in where clause
Error Number : 1109

masterross
12-22-2005, 09:15 PM
i've handled it :))
thanks to Abe1 !

i've added everywhere - " . TABLE_PREFIX . "

and here is the final strings:

$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE " . TABLE_PREFIX . "post.postid = " . TABLE_PREFIX . "post_thanks.postid AND " . TABLE_PREFIX . "post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");

Abe1
12-23-2005, 12:14 AM
sorry guys...
again prob:

Database error in vBulletin 3.5.2:

Invalid SQL:
SELECT vb_post_thanks.* FROM vb_post_thanks, vb_post WHERE vb_post.postid = post_thanks.postid AND vb_post.threadid = '44699' ORDER BY vb_post_thanks.username ASC;

MySQL Error : Unknown table 'post_thanks' in where clause
Error Number : 1109

Yup, forgot one place.$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE " . TABLE_PREFIX . "post.postid = " . TABLE_PREFIX . "post_thanks.postid AND " . TABLE_PREFIX . "post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");

lolo?
12-27-2005, 10:17 AM
works great thanks for this hack :p
i have one suggestion
it's possible to bump a thread when a member use the thanks button like a basic answer ?
hum i hope you understand
sorry for my bad english

Abe1
12-27-2005, 12:06 PM
works great thanks for this hack :p
i have one suggestion
it's possible to bump a thread when a member use the thanks button like a basic answer ?
hum i hope you understand
sorry for my bad english

I'd have to see about that I'm not sure i'd want to implement it but I will try to see.

AquilaEagle
12-27-2005, 12:32 PM
Hey, Thanks!

YLP1
12-28-2005, 10:32 PM
I think I fixed the original db error of duplicate record in the post_thanks. However, I ran into a bit of a snag..... I went through and double checked to ensure I had made all the template changes but the thank you button does not appear on either post bits.

I successfuly installed the post thanks stats (no db errors like with the thanks mod) and it shows where it should except the main cmps page.

I am fairly new at this php stuff can someone point me in the right direction on how to get the post thanks button to appear?

Thanks in advance.

Abe1
12-29-2005, 12:17 PM
I think I fixed the original db error of duplicate record in the post_thanks. However, I ran into a bit of a snag..... I went through and double checked to ensure I had made all the template changes but the thank you button does not appear on either post bits.

I successfuly installed the post thanks stats (no db errors like with the thanks mod) and it shows where it should except the main cmps page.

I am fairly new at this php stuff can someone point me in the right direction on how to get the post thanks button to appear?

Thanks in advance.

Are you looking at your post? Your own post will not show the thanks button.

klaush
12-29-2005, 05:50 PM
Thanks for this great job!

Today i got this vb 3.5.2:

Invalid SQL:

UPDATE vb3_user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times
WHERE userid =;

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3

------------

And after upgrade to the newest version:

Uncached templates: STANDARD_ERROR_LITE (1)

Any idea?

Thanks!

Abe1
12-30-2005, 03:01 AM
Thanks for this great job!

Today i got this vb 3.5.2:

Invalid SQL:

UPDATE vb3_user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times
WHERE userid =;

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3

------------

And after upgrade to the newest version:

Uncached templates: STANDARD_ERROR_LITE (1)

Any idea?

Thanks!

Why would the userid be blank? Were you thanking a guest?

klaush
12-30-2005, 06:30 AM
Why would the userid be blank? Were you thanking a guest?

No Abe1, guests have no permission to do postings.

And i had this error only once.

The "STANDARD_ERROR_LITE" was cached by me, so this is o.k. by now.

SCRIPT3R
12-31-2005, 12:40 AM
suggestion to add a simple Close Window button in the pop-up window in future release.

DrewM
01-03-2006, 08:37 PM
Well I found a issuse it is when everyou change your user name it does not update your thanks.

Ncturnal
01-03-2006, 08:39 PM
Well I found a issuse it is when everyou change your user name it does not update your thanks.

I'm not sure if this is a fix or not, but have you tried updating the counters?

DrewM
01-03-2006, 08:46 PM
no but I will.

Iain M
01-06-2006, 12:20 PM
is there a way to show the total number of thanks given throughout the whole forum, beside the number of threads, posts in the forum stats?

i've tried adding in index.php

$totalthanks = $db->query_read("SELECT COUNT(*) AS count FROM " . TABLE_PREFIX ."post_thanks");

AFTER

$totalposts = 0;

and

$totalthanks = vb_number_format($totalthanks);

AFTER

$totalposts = vb_number_format($totalposts);

and in the FORUMHOME template

Thanks: $totalthanks

AFTER

$vbphrase[posts]: $totalposts

but it doesn't display the correct number,

i know its adding an extra query but that doesn't bother me too much,

any idea anyone?

Abe1
01-09-2006, 02:06 AM
Add-on released for this hack.

Can't See Attachments Before Thanking a Post

thedvs
01-09-2006, 02:08 PM
this is about the 8th time i've tried to install this.

yes the template postbit/legacy were done correctly.
the gfx is in the right place.
the import was fine.
all options set correctly...

the button isnt showing even when logged in as another user at all

running vb 3.5.3, tren_Z skin from extremepixels.com

bashy
01-09-2006, 03:14 PM
HI

Do i need to do the template edits as i already have the Thank You Hack installed?

The edits look very similar to the thank you hack?

Not sure what to do please advise asap asi am am inthe middle of installing it :(

Regards

Bashy

Abe1
01-09-2006, 03:20 PM
HI

Do i need to do the template edits as i already have the Thank You Hack installed?

The edits look very similar to the thank you hack?

Not sure what to do please advise asap asi am am inthe middle of installing it :(

Regards

Bashy

Look at the files that say changes from one version to another.

bashy
01-09-2006, 03:30 PM
hi m8...would help if i new what version i am using atm lol :o

Bahsy

Abe1
01-09-2006, 03:36 PM
hi m8...would help if i new what version i am using atm lol :o

Bahsy

Go to your product list. They have the version numbers there.

bashy
01-09-2006, 04:07 PM
Hi, doh, silly me..
Have done the edit...but..

I can still download with having to say thank you...
Aint sure whats gone wrong...

I have gone through the edits but cant see anything untoward!
If you want access you can by all means...

Regards

Bashy

Abe1
01-09-2006, 04:25 PM
Hi, doh, silly me..
Have done the edit...but..

I can still download with having to say thank you...
Aint sure whats gone wrong...

I have gone through the edits but cant see anything untoward!
If you want access you can by all means...

Regards

Bashy

Try to follow the tempate edit updates. If you cant find what to replace, then you dont have to do it.

bashy
01-09-2006, 04:31 PM
Thats exactly what i have done but still can download without saying thanks :)

Tis a shame cause when i installed your other 1 i actually asked for this :( lol

Bashy

bashy
01-09-2006, 05:47 PM
Hi m8...

Just gone through all the edits again, yet still the same problem
We can download attatchments without having to say thanks :(

Your normal thank you hack works fine though :) lol

Bashy

Abe1
01-09-2006, 06:38 PM
Hi m8...

Just gone through all the edits again, yet still the same problem
We can download attatchments without having to say thanks :(

Your normal thank you hack works fine though :) lol

Bashy

This should go into the other thread then. Any ways, since you are an admin, you can download. Mods dont get effected.

bashy
01-09-2006, 06:42 PM
Whoops sorry, forgot there was another thread,
But yes i know about the staff not limited by this, this is why i am using a standard user account :)

Bashy

Could you ask a mod on here to move these posts to the other thread please?

sniper0
01-09-2006, 07:09 PM
this is about the 8th time i've tried to install this.

yes the template postbit/legacy were done correctly.
the gfx is in the right place.
the import was fine.
all options set correctly...

the button isnt showing even when logged in as another user at all

running vb 3.5.3, tren_Z skin from extremepixels.com

I am having the same problem, I have 3 styles installed, I upload the image into the /buttons/ folder for each style, but it only works for the default style

The 2 extra styles are child styles of the original one so I'm assuming the code is edited automatically in the templates and if not thats my problem, but if not what might be my problem?

Abe1
01-09-2006, 07:11 PM
I am having the same problem, I have 3 styles installed, I upload the image into the /buttons/ folder for each style, but it only works for the default style

The 2 extra styles are child styles of the original one so I'm assuming the code is edited automatically in the templates and if not thats my problem, but if not what might be my problem?

Did you make the template edit to all styles also?

subnet_rx
01-10-2006, 06:39 PM
Does this hack bypass the reputation system rules for anyone else?

Watson
01-10-2006, 07:34 PM
I agree with an earlier post, a timed closure on the pop up window in a future release would be nice.

Apart from that, great hack. Cheers

/me clicks install

pipin
01-11-2006, 09:27 AM
I fixed the pharse. It will be realised in my update comming out in the next day or two.

The replutation should be deleted. Right now I just tested it and fixed up a drop and know it works. Let me know once I release the update.

works now.

thx.

Iain M
01-11-2006, 06:39 PM
is there a way to show the total number of thanks given throughout the whole forum, beside the number of threads, posts in the forum stats?

i've tried adding in index.php

$totalthanks = $db->query_read("SELECT COUNT(*) AS count FROM " . TABLE_PREFIX ."post_thanks");

AFTER

$totalposts = 0;

and

$totalthanks = vb_number_format($totalthanks);

AFTER

$totalposts = vb_number_format($totalposts);

and in the FORUMHOME template

Thanks: $totalthanks

AFTER

$vbphrase[posts]: $totalposts

but it doesn't display the correct number,

i know its adding an extra query but that doesn't bother me too much,

any idea anyone?

any idea Abe1?

or can i request it for a future release?

with an on/off setting?

Abe1
01-11-2006, 06:42 PM
any idea Abe1?

or can i request it for a future release?

with an on/off setting?

Not sure. I have to test if it automaticly goes.

VBUsers
01-11-2006, 08:46 PM
great hack installing now thanks!

onetwomany
01-12-2006, 11:05 AM
Great hack thank you,

Hopefully this hasnt been allready requested I scanned thorugh the first 10 or so pages, but is it possible to have the attachment link appear in the popup window that appears after you click the thanks button?

if this could work with the hide hack aswell that would be great as it would save clogging up the threads with rpelys just so ppl can see the hidden text.

Thanks

nader
01-12-2006, 01:47 PM
i am not using postbit_legacy style where can i find postbit !!!

LBSources
01-17-2006, 03:53 PM
cant find this..

$vbphrase[posts]: $post[posts]

and i kind of stopped at this point...

whatelse might not be found? and what might i have to do to correct this?

im using postbit..

EDIT: clash of the hacks.. got it and /me clicks installed.. :)

vakvak
01-17-2006, 04:47 PM
thanks for thanks hack :)

Dollah
01-18-2006, 09:56 PM
i have used this on my default skin werks fine.........but on my new in my navar bar template this is what i have<script type="text/javascript">
<!--
function log_out()
{
ht = document.getElementsByTagName("html");
ht[0].style.filter = "progid:DXImageTransform.Microsoft.BasicImage(grays cale=1)";
if (confirm('$vbphrase[sure_you_want_to_log_out]'))
{
return true;
}
else
{
ht[0].style.filter = "";
return false;
}
}
//-->
</script>

<br />

<!-- breadcrumb, login, pm info -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="alt1" width="100%">
<if condition="is_array($navbits)">
<table cellpadding="0" cellspacing="0" border="0">
<tr valign="bottom">
<td><a href="#" onclick="history.back(1); return false;"><img src="$stylevar[imgdir_misc]/navbits_start.gif" alt="$vbphrase[go_back]" border="0" /></a></td>
<td>&nbsp;</td>
<td width="100%"><span class="navbar"><a href="$vboptions[forumhome].php$session[sessionurl_q]" accesskey="1">$vboptions[bbtitle]</a></span> $navbits[breadcrumb]</td>
</tr>
<tr>
<td class="navbar" style="font-size:10pt; padding-top:1px" colspan="3"><a href="$scriptpath"><img class="inlineimg" src="$stylevar[imgdir_misc]/navbits_finallink.gif" alt="$vbphrase[reload_this_page]" border="0" /></a> <strong>$navbits[lastelement]</strong></td>
</tr>
</table>
<else />
<div class="navbar" style="font-size:10pt"><a href="$vboptions[forumhome].php$session[sessionurl_q]" accesskey="1"><img class="inlineimg" src="$stylevar[imgdir_misc]/navbits_start.gif" alt="" border="0" /></a> <strong>$vboptions[bbtitle]</strong></div>
</if>
</td>

<if condition="$show['member']">

<td class="alt2" valign="top" nowrap="nowrap">
<div class="smallfont">
<strong><phrase 1="$bbuserinfo[username]">$vbphrase[welcome_x]</phrase></strong><br />
<phrase 1="$pmbox[lastvisitdate]" 2="$pmbox[lastvisittime]">$vbphrase[last_visited_x_at_y]</phrase>
<if condition="$show['pmstats']"><br /><phrase 1="$vbphrase[unread_x_nav_compiled]" 2="$vbphrase[total_x_nav_compiled]" 3="$session[sessionurl_q]">$vbphrase[private_messages_nav]</phrase></if>
</div>
</td>

<else />

<td class="alt2" nowrap="nowrap" style="padding:0px">

<!-- login form -->
<form action="login.php" method="post" onsubmit="md5hash(vb_login_password, vb_login_md5password, vb_login_md5password_utf, $show[nopasswordempty])">
<script type="text/javascript" src="clientscript/vbulletin_md5.js"></script>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
<tr>
<td class="smallfont">$vbphrase[username]</td>
<td><input type="text" class="bginput" style="font-size: 11px" name="vb_login_username" id="navbar_username" size="10" accesskey="u" tabindex="101" value="$vbphrase[username]" onfocus="if (this.value == '$vbphrase[username]') this.value = '';" /></td>
<td class="smallfont" colspan="2" nowrap="nowrap"><label for="cb_cookieuser_navbar"><input type="checkbox" name="cookieuser" value="1" tabindex="103" id="cb_cookieuser_navbar" accesskey="c" />$vbphrase[remember_me]</label></td>
</tr>
<tr>
<td class="smallfont">$vbphrase[password]</td>
<td><input type="password" class="bginput" style="font-size: 11px" name="vb_login_password" size="10" accesskey="p" tabindex="102" /></td>
<td><input type="submit" class="button" value="$vbphrase[log_in]" tabindex="104" title="$vbphrase[enter_username_to_login_or_register]" accesskey="s" /></td>
</tr>
</table>
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="login" />
<input type="hidden" name="vb_login_md5password" />
<input type="hidden" name="vb_login_md5password_utf" />
</form>
<!-- / login form -->

</td>

</if>

</tr>
</table>
<!-- / breadcrumb, login, pm info -->

<div class="spacer"></div>

<if condition="$show['forumdesc']">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="alt1" width="100%"><strong>$foruminfo[title]</strong> <span class="smallfont">$foruminfo[description]</span></td>
</tr>
</table>
<br />
</if>

is their any way u can help me with this please my users loves this and so do i thanx....

smdani
01-19-2006, 02:03 PM
IÂ’ve ridden all 357 posts looking for my solution, but no way

I try to install the last version 2.7 in my vb3.5.0, upload the product, see that all features are on, upload the image button, and go to the forum and no changes have appeared posts. There are no thanks button or not other add in any message not in mine nor at other people ones

I try it with the default style

When I look into my templates there are some new ones but there arenÂ’t any changes in posbit, nor memberinfo, nor other template.

¿I have to edit my templates by hand? In this case ¿where can I find the instructions and the code? The ones included in the zip are for upgrading from an older version

Any suggestion
Any way thanks for the hack and for the help in advance

pipin
01-19-2006, 03:39 PM
I?ve ridden all 357 posts looking for my solution, but no way

I try to install the last version 2.7 in my vb3.5.0, upload the product, see that all features are on, upload the image button, and go to the forum and no changes have appeared posts. There are no thanks button or not other add in any message not in mine nor at other people ones

I try it with the default style

When I look into my templates there are some new ones but there aren?t any changes in posbit, nor memberinfo, nor other template.

?I have to edit my templates by hand? In this case ?where can I find the instructions and the code? The ones included in the zip are for upgrading from an older version

Any suggestion
Any way thanks for the hack and for the help in advance

There is a txt file in the zip with the instructions!

smdani
01-19-2006, 05:19 PM
Sorry, I missed part of the txt file
I think that the problem was solved

Sorry and thanks for your help

Dollah
01-19-2006, 08:05 PM
[QUOTE=Dollah]i have used this on my default skin werks fine.........but on my new in my navar bar template this is what i have<script type="text/javascript">
<!--
function log_out()
{
ht = document.getElementsByTagName("html");
ht[0].style.filter = "progid:DXImageTransform.Microsoft.BasicImage(grays cale=1)";
if (confirm('$vbphrase[sure_you_want_to_log_out]'))
{
return true;
}
else
{
ht[0].style.filter = "";
return false;
}
}
//-->
</script>

<br />

<!-- breadcrumb, login, pm info -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="alt1" width="100%">
<if condition="is_array($navbits)">
<table cellpadding="0" cellspacing="0" border="0">
<tr valign="bottom">
<td><a href="#" onclick="history.back(1); return false;"><img src="$stylevar[imgdir_misc]/navbits_start.gif" alt="$vbphrase[go_back]" border="0" /></a></td>
<td>&nbsp;</td>
<td width="100%"><span class="navbar"><a href="$vboptions[forumhome].php$session[sessionurl_q]" accesskey="1">$vboptions[bbtitle]</a></span> $navbits[breadcrumb]</td>
</tr>
<tr>
<td class="navbar" style="font-size:10pt; padding-top:1px" colspan="3"><a href="$scriptpath"><img class="inlineimg" src="$stylevar[imgdir_misc]/navbits_finallink.gif" alt="$vbphrase[reload_this_page]" border="0" /></a> <strong>$navbits[lastelement]</strong></td>
</tr>
</table>
<else />
<div class="navbar" style="font-size:10pt"><a href="$vboptions[forumhome].php$session[sessionurl_q]" accesskey="1"><img class="inlineimg" src="$stylevar[imgdir_misc]/navbits_start.gif" alt="" border="0" /></a> <strong>$vboptions[bbtitle]</strong></div>
</if>
</td>

<if condition="$show['member']">

<td class="alt2" valign="top" nowrap="nowrap">
<div class="smallfont">
<strong><phrase 1="$bbuserinfo[username]">$vbphrase[welcome_x]</phrase></strong><br />
<phrase 1="$pmbox[lastvisitdate]" 2="$pmbox[lastvisittime]">$vbphrase[last_visited_x_at_y]</phrase>
<if condition="$show['pmstats']"><br /><phrase 1="$vbphrase[unread_x_nav_compiled]" 2="$vbphrase[total_x_nav_compiled]" 3="$session[sessionurl_q]">$vbphrase[private_messages_nav]</phrase></if>
</div>
</td>

<else />

<td class="alt2" nowrap="nowrap" style="padding:0px">

<!-- login form -->
<form action="login.php" method="post" onsubmit="md5hash(vb_login_password, vb_login_md5password, vb_login_md5password_utf, $show[nopasswordempty])">
<script type="text/javascript" src="clientscript/vbulletin_md5.js"></script>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
<tr>
<td class="smallfont">$vbphrase[username]</td>
<td><input type="text" class="bginput" style="font-size: 11px" name="vb_login_username" id="navbar_username" size="10" accesskey="u" tabindex="101" value="$vbphrase[username]" onfocus="if (this.value == '$vbphrase[username]') this.value = '';" /></td>
<td class="smallfont" colspan="2" nowrap="nowrap"><label for="cb_cookieuser_navbar"><input type="checkbox" name="cookieuser" value="1" tabindex="103" id="cb_cookieuser_navbar" accesskey="c" />$vbphrase[remember_me]</label></td>
</tr>
<tr>
<td class="smallfont">$vbphrase[password]</td>
<td><input type="password" class="bginput" style="font-size: 11px" name="vb_login_password" size="10" accesskey="p" tabindex="102" /></td>
<td><input type="submit" class="button" value="$vbphrase[log_in]" tabindex="104" title="$vbphrase[enter_username_to_login_or_register]" accesskey="s" /></td>
</tr>
</table>
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="login" />
<input type="hidden" name="vb_login_md5password" />
<input type="hidden" name="vb_login_md5password_utf" />
</form>
<!-- / login form -->

</td>

</if>

</tr>
</table>
<!-- / breadcrumb, login, pm info -->

<div class="spacer"></div>

<if condition="$show['forumdesc']">
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="alt1" width="100%"><strong>$foruminfo[title]</strong> <span class="smallfont">$foruminfo[description]</span></td>
</tr>
</table>
<br />
</if>

is their any way u can help me with this please my users loves this and so do i thanx....[/QUbesides that i wave noticed it raise the post count but doesnt change th erep or is not adding it ..and it does not display whom has thanked a post or any thing so please help some one....

thedvs
01-20-2006, 01:12 PM
this is about the 8th time i've tried to install this.

yes the template postbit/legacy were done correctly.
the gfx is in the right place.
the import was fine.
all options set correctly...

the button isnt showing even when logged in as another user at all

running vb 3.5.3, tren_Z skin from extremepixels.com

aranthorn
01-20-2006, 02:33 PM
This is odd, I've recently had a couple users say the button "disappeared". Checked all the settings, checked all the styles. I can see it and most other users can, but they're saying they can't. Even provided a screenshot of it. There wouldn't be anything M$ may have done in an update or something is there?

Abe1
01-20-2006, 02:39 PM
This is odd, I've recently had a couple users say the button "disappeared". Checked all the settings, checked all the styles. I can see it and most other users can, but they're saying they can't. Even provided a screenshot of it. There wouldn't be anything M$ may have done in an update or something is there?

If they gave thanks already, then they wont see it.

aranthorn
01-20-2006, 07:55 PM
I should have given more info. They don't see it anywhere at all. Not even in new threads.

Damien2005
01-24-2006, 04:29 PM
thanks for this great hack mate ;)

Dreamchaser
01-26-2006, 04:28 AM
everything went fine, but I don't see the thankyou button in any threads ? am i missing something ? using vb 3.5.3 and iSkin from exteremepixels!

Abe1
01-26-2006, 12:16 PM
everything went fine, but I don't see the thankyou button in any threads ? am i missing something ? using vb 3.5.3 and iSkin from exteremepixels!

You wont see it in your own posts. Look at someone elses.

Dreamchaser
01-26-2006, 02:24 PM
You wont see it in your own posts. Look at someone elses.

I did confirm that, I could not see the thank you button even on others post... any help on this issue ?

vietfancy
01-28-2006, 02:19 AM
great, installed

Abe1
01-28-2006, 09:52 PM
I did confirm that, I could not see the thank you button even on others post... any help on this issue ?

Did you do all the template edits? (In all styles if you have more then one)

cd1986
01-29-2006, 12:54 AM
Same problem as above - the button doesn't appear to be showing in postbit for everyone, including me as admin. All template edits done correctly etc.

Tulsa
01-29-2006, 04:08 AM
It can't be the hack as it works flawlessly on my site. I've tested with both PC and MAC, all sorts of browsers and I have 2200 users who love this hack.

I did have a guy on my site say the Thanks button went away for him, he turned off his ZoneAlarm Pro and everything came back.



those users sure would like a groan button though.. ;)

kregger
01-29-2006, 05:59 PM
Works great!

*clicks thanks err....install*

aranthorn
02-01-2006, 12:47 AM
HAH! I found the answer for sometimes the button not appearing! (at least for Zone alarm users)

Here is what you do if you want to fix it:
Open up your Zone Alarm control panel
Under the PRIVACY tab you have to disable the following
Cookie control > OFF
AD Blocking > OFF
Mobile Control Code > OFF

worked for the people having the issue on my forum :D

Abe1
02-01-2006, 12:50 AM
HAH! I found the answer for sometimes the button not appearing! (at least for Zone alarm users)

Here is what you do if you want to fix it:
Open up your Zone Alarm control panel
Under the PRIVACY tab you have to disable the following
Cookie control > OFF
AD Blocking > OFF
Mobile Control Code > OFF

worked for the people having the issue on my forum :D

Does this have to do with the button leading to a pop-up?

lazyseller
02-01-2006, 02:27 PM
This is a great mod and thanks for releasing it. I do have a question though what happans if there is around 20 to 30 thanks per thread ? How is it formatted ?

Abe1
02-01-2006, 03:05 PM
This is a great mod and thanks for releasing it. I do have a question though what happans if there is around 20 to 30 thanks per thread ? How is it formatted ?

Each post gets it's own box. In each box shows all users who gave thanks. The box only shows once a user has thanked a post.

lazyseller
02-01-2006, 04:18 PM
How do i fix this ?

after i remove thanks it says cannot find phrase post_ thanks

Abe1
02-01-2006, 04:29 PM
How do i fix this ?

after i remove thanks it says cannot find phrase post_ thanks

I have to see why that happens. I hope to have it fixed by next version.

lazyseller
02-01-2006, 04:31 PM
Thanks... i do have a question though... if a thread is deleted will it also delete the thank you's as well ?

Abe1
02-01-2006, 04:43 PM
Thanks... i do have a question though... if a thread is deleted will it also delete the thank you's as well ?

No it will not. They will remain in the database as of now.

lazyseller
02-01-2006, 04:51 PM
I have to see why that happens. I hope to have it fixed by next version.

When can we expect another release ? and whats new in this release ?

How do i display how many thanks are given on a certain thread ?

For example:

The following user says thank you to x for this useful post:

I would like it to say

The following user says thank you to x for this useful post(10 members)

Abe1
02-01-2006, 06:05 PM
When can we expect another release ? and whats new in this release ?

How do i display how many thanks are given on a certain thread ?

For example:

The following user says thank you to x for this useful post:

I would like it to say

The following user says thank you to x for this useful post(10 members)

Look at the screen shots.

A new version is expected in the near future.

lazyseller
02-03-2006, 01:28 AM
this is a weird request but is there a simple way where i can allow members to give thanks to their own thread ?

Abe1
02-03-2006, 02:47 AM
this is a weird request but is there a simple way where i can allow members to give thanks to their own thread ?

Simple if you know php.

Morning Glory
02-03-2006, 06:41 AM
Works great.

Thank you.

lazyseller
02-03-2006, 10:27 AM
Not so simple then =) Thanks though working great so far..

One more question i am trying to integrate this great mod with show first post on every page

https://vborg.vbsupport.ru/showthread.php?t=93706

but for some reason on the 2nd page... the thank you list and button isnt there anymore

Any ideas whats happening ?

Parham
02-04-2006, 07:10 AM
i had install this extension on my site and after edit template I can't see thanks button or Thanks Option ... btw I use VBulletin 3.5.3

Parham
02-04-2006, 07:17 AM
where can i find these (https://vborg.vbsupport.ru/attachment.php?attachmentid=35088) option :) ?!

Tulsa
02-04-2006, 07:58 AM
admincp/vbulletin options/post thank you hack

Parham
02-04-2006, 02:23 PM
Thanks Tulsa, btw I had try to edit template again but i can't see any Post Thanks Option on my Forum ... Like This (https://vborg.vbsupport.ru/attachment.php?attachmentid=35082) or This (https://vborg.vbsupport.ru/attachment.php?attachmentid=35083)

Tulsa
02-04-2006, 03:04 PM
Did you make the edit changes in the Postbit and/or Postbit_Legacy templates, depending upon which one you use or preferrably both?

Parham
02-04-2006, 03:13 PM
oops i forgot to change postbit templates... thanks again ...

keithnec
02-04-2006, 03:52 PM
in the latest version one of the listed changes is as follows: "[CHANGED] Made a pop-up now when you click Thanks instead of refreshing the page."
can anybody tell me if this is selectable back to the earlier version as I would prefer the hack to just update the thread with the user name in the thanked box rather than have a pop-up that the user then has to close?.

Abe1
02-04-2006, 10:58 PM
in the latest version one of the listed changes is as follows: "[CHANGED] Made a pop-up now when you click Thanks instead of refreshing the page."
can anybody tell me if this is selectable back to the earlier version as I would prefer the hack to just update the thread with the user name in the thanked box rather than have a pop-up that the user then has to close?.

Next release will either go back to the other way or have an option to do either.

keithnec
02-05-2006, 05:34 AM
thanks for the info abe1

lazyseller
02-05-2006, 02:40 PM
If you can make a option to be able to thank your own post im willing to give a 20.00 donation.

Tulsa
02-05-2006, 02:59 PM
You want to thank yourself, publicly?

LBSources
02-05-2006, 03:23 PM
Lmao! :d

Tulsa
02-05-2006, 03:53 PM
Typos can be fun! :)

Abe1
02-05-2006, 06:06 PM
If you can make a option to be able to thank your own post im willing to give a 20.00 donation.

Ok. I'll stick in that option into next version.

Darkfire122333
02-05-2006, 06:13 PM
is there any way to connect this to also add a post, so that it can be used in combination with a hide hack? becuase thats what i mainly want it to do. So the user selects thank you, and it counts as a post and allows the m to see the hidden content.

bashy
02-05-2006, 06:13 PM
I have been racking my brain since seeing that post, what would the need be to actually thank your own post?

Abe1
02-05-2006, 06:15 PM
is there any way to connect this to also add a post, so that it can be used in combination with a hide hack? becuase thats what i mainly want it to do. So the user selects thank you, and it counts as a post and allows the m to see the hidden content.

What is the link to the hide hack?

Darkfire122333
02-05-2006, 06:18 PM
<a href="https://vborg.vbsupport.ru/showthread.php?t=90985" target="_blank">https://vborg.vbsupport.ru/showthread.php?t=90985</a>

that is the link to it.

Abe1
02-05-2006, 06:20 PM
https://vborg.vbsupport.ru/showthread.php?t=90985

that is the link to it.

Ok. I will try to release an add-on.

Darkfire122333
02-05-2006, 06:21 PM
Thank you, it would be much appreciated.

(i know this sounds kinda rude, but i do not want to be but..)
how long est. do you think it will take?

Tulsa
02-05-2006, 06:24 PM
Although I have no reason to thank myself, I will toss in the same $20 donation for a "groan" button!

Abe1
02-05-2006, 06:25 PM
Thank you, it would be much appreciated.

(i know this sounds kinda rude, but i do not want to be but..)
how long est. do you think it will take?

Can take a day or a month. I'm not realy that predicatable. I assume with-in a week.

Abe1
02-05-2006, 06:26 PM
Although I have no reason to thank myself, I will toss in the same $20 donation for a "groan" button!

I'll be working on the "groan hack" soon also. Your not the only one that wants it.

Darkfire122333
02-05-2006, 06:26 PM
ok well thank you, it is really great of you to make this! it is awesome!

forumsoup.com
02-05-2006, 06:26 PM
Does this work for 3.5.3 (saw that it said 3.5.2 but sometimes hacks work with multiple versions).

Abe1
02-05-2006, 06:27 PM
Does this work for 3.5.3 (saw that it said 3.5.2 but sometimes hacks work with multiple versions).

Yes, this works for 3.5.3.

Tulsa
02-05-2006, 06:34 PM
I'll be working on the "groan hack" soon also. Your not the only one that wants it.

Most humble thanks!


Now I need to find those other guys to split the $20! :D

I'm kidding!

Abe1
02-06-2006, 12:50 AM
Version 2.8 (2/5/06):

[FIXED] Removed one query thanks to AnhTuanCool (abe clicks 'thanks')
[ADDED] Option to allow users to thank their own post
[ADDED] Option to allow a pop=up or refresh after a user clicks thanks

Tulsa
02-06-2006, 02:00 AM
Going from 2.7 to 2.8 do we do any template edits or just upload the xml file set to overwrite?

Abe1
02-06-2006, 03:00 AM
Going from 2.7 to 2.8 do we do any template edits or just upload the xml file set to overwrite?

Just over write. No template edits although if you edited the button template, you have to revert it.

vietfancy
02-06-2006, 03:19 AM
I dont know if this is only me or the code. I set "use Pop-up" to "no", then when i clicked on "thanks" button. there still a popup.

MioTraGusa
02-06-2006, 04:19 AM
the same problem fom me ...

lazyseller
02-06-2006, 04:50 AM
Same problem for me ... looks like a html error somewhere..

IrPr
02-06-2006, 07:21 AM
/me clicks Thanks!

Tuan Ly
02-06-2006, 09:03 AM
I wanna report 2 another bugs :

1. After MOD/SMOD/ADMIN use QuickEdit to edit a post, the "THANKS" button will be disappeared !

2. After removing THANKS in a post, THANKS-Counter of the Poster (who get THANKS) is decreased, but THANKS-Counter of the Giver (who give THANKS) isn't decreased !

Abe1
02-06-2006, 12:08 PM
Same problem for me ... looks like a html error somewhere..

Did you do a refresh on your page after you sent to know or just tested it on a page already there. There is a differant button script if you set to no.

Abe1
02-06-2006, 12:10 PM
I wanna report 2 another bugs :

1. After MOD/SMOD/ADMIN use QuickEdit to edit a post, the "THANKS" button will be disappeared !

2. After removing THANKS in a post, THANKS-Counter of the Poster (who get THANKS) is decreased, but THANKS-Counter of the Giver (who give THANKS) isn't decreased !

1) There maybe nothing I can do about that. I have seen this hppen to other hacks that put buttons there also.

2) I will look into. I assum you are talking about where you mass remove thanks.

lazyseller
02-06-2006, 01:20 PM
Did you do a refresh on your page after you sent to know or just tested it on a page already there. There is a differant button script if you set to no.

I refreshed the page just to be safe.

When i click the link it brings up a popup than redirects the popup to the existing thread.

Abe1
02-06-2006, 01:22 PM
I refreshed the page just to be safe.

When i click the link it brings up a popup than redirects the popup to the existing thread.

Hmmm... I will have another look at it.

D.Ilyin
02-06-2006, 02:26 PM
PROBLEM:
Someone bad man (as logged user) came to forum and add above 1000 THANKS for posts in different threads. He was banned but.....
QUESTION:
What SQL query i must run additionaly to that one:DELETE FROM `post_thanks` WHERE `userid` = XXXX
Because others counters (like post thank's) are still in threads.

Abe1
02-06-2006, 02:41 PM
PROBLEM:
Someone bad man (as logged user) came to forum and add above 1000 THANKS for posts in different threads. He was banned but.....
QUESTION:
What SQL query i must run additionaly to that one:DELETE FROM `post_thanks` WHERE `userid` = XXXX
Because others counters (like post thank's) are still in threads.

Yes. That would be the right query to remove all thanks given by that user.

RFViet
02-06-2006, 04:58 PM
does it effect hide hack ?? I mean, unregistered member can see hiden link after posting thanks button ?? (registered member should be ok to do this)

smdani
02-06-2006, 05:12 PM
I have this plugin installed for some weeks and it works fine, but my users suggest me that a good add on could be to have the possibility to choose the phrase which will appear with the reputation count I mean the $vbphrase[post_thanks_thanked_post] phrase. (Thanked Post)

The idea would be to select one phrase from a list randomly or picked by the user

Well itÂ’s only a suggestion for that great hack
thanks

RS_Jelle
02-06-2006, 06:25 PM
Hmmm... I will have another look at it.
I've got the same problem :ermm:

Tuan Ly
02-07-2006, 01:06 AM
1) There maybe nothing I can do about that. I have seen this hppen to other hacks that put buttons there also.

2) I will look into. I assum you are talking about where you mass remove thanks.

1. You may misunderstood. I tested your hack on a totally fresh board & QuickEdit is not a hack, it's a feature available in vBulletin 3.5.x.

2. Yes you should. A fresh board with only 2 usernames : A & B. A give B a "THANK", then A remove it. B will have 0 "thanked" but A still have 1 thank given out. This also happen with mass remove by Admin. You got one plugin which miss reducing thank-given-counter of thank-giver. I wanted to help you fix this but I couldn't understand "name" meaning of variables you used.

Hopefully you feel happy when someone help you find out bugs even they could be right or wrong

Abe1
02-07-2006, 01:47 AM
1. You may misunderstood. I tested your hack on a totally fresh board & QuickEdit is not a hack, it's a feature available in vBulletin 3.5.x.

2. Yes you should. A fresh board with only 2 usernames : A & B. A give B a "THANK", then A remove it. B will have 0 "thanked" but A still have 1 thank given out. This also happen with mass remove by Admin. You got one plugin which miss reducing thank-given-counter of thank-giver. I wanted to help you fix this but I couldn't understand "name" meaning of variables you used.

Hopefully you feel happy when someone help you find out bugs even they could be right or wrong

I will (try to) fix number 2.

As for number one, it has to do with the quick eidt. There is something there that it does not pull all the post_bit info. The same thing appens when you quick reply but you wont realize it because you dont allow your self you thank you own posts.

lazyseller
02-07-2006, 01:49 AM
IM ready to send my donation right after the popup fix...

Abe1
02-07-2006, 01:50 AM
IM ready to send my donation right after the popup fix...

Can you tell me if any of the thanks templates were edited?

lazyseller
02-07-2006, 02:11 AM
nope i didnt modify any thanks templates

XtremeOffroad
02-07-2006, 02:23 AM
This thank you phrase is missing now
(User Name) says you are very welcome. Your thanks will show up once you refresh the page you gave the thanks in.

Love the hack and looking foreward to a fix.

snowlion
02-07-2006, 06:56 AM
This thank you phrase is missing now
(User Name) says you are very welcome. Your thanks will show up once you refresh the page you gave the thanks in.

oh yes, popup show post we ckicked thank button but not show phrase (User Name) says you are very welcome. Your thanks will show up once you refresh the page you gave the thanks in.
please fix

Abe1
02-07-2006, 12:29 PM
Ok guys, I found the problem why you were getting a pop-up and not just refreshing. It should work now.

lazyseller
02-07-2006, 01:28 PM
Abe1 thanks i sent a 20.00 donation as promised...

Abe1
02-07-2006, 01:28 PM
Abe1 thanks i sent a 20.00 donation as promised...

Thanks. I just got it.

IrPr
02-07-2006, 05:27 PM
Ok guys, I found the problem why you were getting a pop-up and not just refreshing. It should work now.

Thanks. i think i luv ya:x

Abe1
02-08-2006, 03:35 AM
Version 2.9 (2/8/06):

[FIXED] Fixed allot of things in regard to deleting thanks using the "remove all thanks" and "Remove your thanks".


I recommend to run the counters for this hack after you upgrade. Ther had been a big problem with the count for how may posts thanked.

The Realist
02-08-2006, 09:11 AM
Upgrade to 2.9 is just the xml files yes?

No edits etc.

Abe1
02-08-2006, 11:58 AM
Upgrade to 2.9 is just the xml files yes?

No edits etc.

Correct. Just the xml upload.

If there are edits, it would be include in a text file saying like edits for 2.8 -> 2.9.

bashy
02-08-2006, 03:08 PM
I have upgraded but still get the popup, Strange thing is, the popup dont say thanks anymore..... I cant see what it says :(
Will uplad an image in a sec

Abe1
02-08-2006, 03:10 PM
I have upgraded but still get the popup, Strange thing is, the popup dont say thanks anymore..... I cant see what it says :(
Will uplad an image in a sec

Did you refresh the page after you upgrade? Did you ever edit the button template?

bashy
02-08-2006, 03:11 PM
Damn your quick ;)

I did refresh the page anbd i do not remeber ever doing a button template

Abe1
02-08-2006, 03:14 PM
Damn your quick ;)

I did refresh the page anbd i do not remeber ever doing a button template

Are you sure you have version 2.9? It should only refresh your page.

bashy
02-08-2006, 03:16 PM
I only downloaded it just before my post moanning about it not working ;)
Gonna shut the browser and try again... 2 secs.....

bashy
02-08-2006, 03:18 PM
Nope definatley popping up, and yeah its 2.9....
Gonna try removing the product and re-adding it...
2 secs... lol

bashy
02-08-2006, 03:19 PM
Still popping up im afraid :(
Take a gander if ya want?

bashy
02-08-2006, 03:29 PM
Nope im wrong...I got the wrong freaking HACK again....
What is it with me and your 2 hacks :o
Thanks for ya help...

Abe1
02-08-2006, 03:40 PM
Nope im wrong...I got the wrong freaking HACK again....
What is it with me and your 2 hacks :o
Thanks for ya help...

First, my like 10-15 hacks :P

Second, I dont know why. I would need a test account and access to your acp templates and plugins to see why.

If you can, please PM me the info.

matttiger
02-08-2006, 04:13 PM
I'm not sure whether this has been fixed in a recent version as the forum I was visiting has an older version of the hack installed.

But, on a guest's post, the Guest has been thanked but the guest's name doesn't appear in the box below the post, it just says "The following user says thanks to for this useful post"

Just a thought thats all :)

Abe1
02-08-2006, 04:13 PM
Nope im wrong...I got the wrong freaking HACK again....
What is it with me and your 2 hacks :o
Thanks for ya help...

All fixed. You had edited the button template.

Abe1
02-08-2006, 04:14 PM
I'm not sure whether this has been fixed in a recent version as the forum I was visiting has an older version of the hack installed.

But, on a guest's post, the Guest has been thanked but the guest's name doesn't appear in the box below the post, it just says "The following user says thanks to for this useful post"

Just a thought thats all :)

I dont think you can thank guests now.

funinthesun
02-08-2006, 05:40 PM
Sorry if this has been written before but I don't want to read through 31 pages of posts! I've done all the template edits and uploaded the gif to all of the buttons folders and imported the plugin but the image isn't showing on the posts. Any idea why?

Abe1
02-08-2006, 05:53 PM
Sorry if this has been written before but I don't want to read through 31 pages of posts! I've done all the template edits and uploaded the gif to all of the buttons folders and imported the plugin but the image isn't showing on the posts. Any idea why?

Are you looking at other users posts or yourse? Do you have more then one style? You have to do the template edits to each one.

Tuan Ly
02-09-2006, 07:01 AM
Version 2.9 (2/8/06):

[FIXED] Fixed allot of things in regard to deleting thanks using the "remove all thanks" and "Remove your thanks".


I recommend to run the counters for this hack after you upgrade. Ther had been a big problem with the count for how may posts thanked.

I am seeing a lot of changes from v2.8 - v2.9. I hope all changes are correct :rolleyes:

bryanb
02-09-2006, 11:48 AM
I've searched this thread, but maybe I missed it so please bear with me :D

Is there a way to see in the Admin control panel who has been thanked the most - or say, the top 10 thanked users etc.? I'm running the 2.6a version I believe.

I'd like to use incentives to prompt people to make posts that are worthy of being thanked - it would really help to be able to track these be being able to tell which members are being thanked the most.

funinthesun
02-09-2006, 12:02 PM
Are you looking at other users posts or yourse? Do you have more then one style? You have to do the template edits to each one.

I'm looking at everyone's posts. I can see the written words in the post bit and profile just can't see the thanks button.

Yes, I have more than one style and I've only edited the default style as the other styles aren't live yet. Do I need to edit the templates on the other styles for this to work as well?

Abe1
02-09-2006, 12:11 PM
I'm looking at everyone's posts. I can see the written words in the post bit and profile just can't see the thanks button.

Yes, I have more than one style and I've only edited the default style as the other styles aren't live yet. Do I need to edit the templates on the other styles for this to work as well?

You need to have the edits in any style that you want to see it.

Abe1
02-09-2006, 12:12 PM
I've searched this thread, but maybe I missed it so please bear with me :D

Is there a way to see in the Admin control panel who has been thanked the most - or say, the top 10 thanked users etc.? I'm running the 2.6a version I believe.

I'd like to use incentives to prompt people to make posts that are worthy of being thanked - it would really help to be able to track these be being able to tell which members are being thanked the most.

The only think I have is an addon to CMPS.

S1OPP
02-09-2006, 01:01 PM
Please post your comments or suggestions for this hack. I read ALL posts.


I've been hunting for something like this for my forum and I'm on the brink of installing this as it is, but since you asked for suggestions I thought I'd give it a try.

I'm looking for the ability for my users to click a button to either "Agree" or "Disagree" with a post. Each click would display a thumbs up or down for the post. With the ability to click and see a list of who's clicked which.

Clearly this hack would go some way to achieving this, I'm no coder so have no idea how much extra work would be involved, but I'm sure it something a lot of people would be very interested in.

Thanks for hearing me out.
S1OPP

Abe1
02-09-2006, 01:23 PM
I've been hunting for something like this for my forum and I'm on the brink of installing this as it is, but since you asked for suggestions I thought I'd give it a try.

I'm looking for the ability for my users to click a button to either "Agree" or "Disagree" with a post. Each click would display a thumbs up or down for the post. With the ability to click and see a list of who's clicked which.

Clearly this hack would go some way to achieving this, I'm no coder so have no idea how much extra work would be involved, but I'm sure it something a lot of people would be very interested in.

Thanks for hearing me out.
S1OPP

Nice Idea :) It has been asked a few times already. I will be coming out with a hack soon called "Post Groan Hack". It will not ba part of this hack but you will be able to run them both together. This one will just have the same type of image just called "groan" and will have a thumbs down.

S1OPP
02-09-2006, 02:05 PM
Fantastic, I'll look forward to running them both together.

funinthesun
02-09-2006, 02:50 PM
You need to have the edits in any style that you want to see it.
OK, well I only want it to show on my default style at the moment as the other styles aren't live yet so I've only edited the templates for the default style but the thanks button isn't showing up?

Abe1
02-09-2006, 02:53 PM
OK, well I only want it to show on my default style at the moment as the other styles aren't live yet so I've only edited the templates for the default style but the thanks button isn't showing up?

Are useing that style? If you are and still can't see it, I would have to look at your acp. If you can, I need need access to your templates and products. PM me the info.

funinthesun
02-10-2006, 12:24 PM
Thanks again Abe for fixing it for me. To everyone else it was my fault it wasn't working, I had put the code in the wrong place and forgotten to put another piece of code in. Note to self: Never install mods when you're half asleep ;)

Abe1
02-10-2006, 02:57 PM
Version 3.0 (2/10/06):

[FIXED] Fixed one more thing in regard to "remove all thanks".
[FIXED] Re-wrote the thanks actions so it they useless queried when you give or remove thanks.

firstrebel
02-10-2006, 03:37 PM
Thanks for the continued support with this great hack. I take it there are no template changes from v2.7?

Bob

D.Ilyin
02-10-2006, 03:37 PM
Abe1 it's very bad that i can't click "install" in second time :) Thank's!

Abe1
02-10-2006, 03:39 PM
I take it there are no template changes from v2.7?
Correct.

Stubager
02-10-2006, 06:45 PM
This is the most importan plugin ever! Keeps away one-liners!

IrPr
02-10-2006, 08:06 PM
Version 3.0 (2/10/06):

[FIXED] Fixed one more thing in regard to "remove all thanks".
[FIXED] Re-wrote the thanks actions so it they useless queried when you give or remove thanks.


WOW ! How to upgrade Abe?

Abe1
02-10-2006, 08:08 PM
WOW ! How to upgrade Abe?

Just upload the xml.

D.Ilyin
02-11-2006, 09:03 AM
Ops.... :( I catch a small bug, but it's not your's....
Whan i translate phrases in plugin i get the SQL error when i try to delete own thank's with old translation. Because:
DELETE FROM ". TABLE_PREFIX ."reputation WHERE postid = $postid AND reason='$vbphrase[post_thanks_thanked_post]
I must run that query:
UPDATE ". TABLE_PREFTIX ."reputation SET reason = "translated phrase" WHERE reason = "Thanked Post"
Am i rigth?

NeutralizeR
02-11-2006, 12:01 PM
There is a problem after the 3.0 upgrade.


Database error in vBulletin 3.5.3:

Invalid SQL:

UPDATE msx_user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times, post_thanks_thanked_posts = 1 + post_thanks_thanked_posts, reputation = $vboptions[post_thanks_reputation] + reputation
WHERE userid = 110261;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[post_thanks_reputation] + reputation
WHERE userid = 110261' at line 2
Error Number : 1064


Reputation is disabled under the hack settings. Waiting for a fix...

D.Ilyin
02-11-2006, 03:16 PM
and i have the same error when click THANKS:
Database error in vBulletin 3.5.3:

Invalid SQL:

UPDATE user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times, post_thanks_thanked_posts = 1 + post_thanks_thanked_posts, reputation = $vboptions[post_thanks_reputation] + reputation
WHERE userid = 38210;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[post_thanks_reputation] + reputation
WHERE userid = 38210' at line 2

Abe1
02-11-2006, 10:06 PM
Version 3.1 (2/11/06):

[FIXED] Fixed bug with reputation.

AnhTuanCool
02-12-2006, 02:16 AM
Hey Abe1,

Although the showthread page uses only ONE query, the load seems yet to loose.

I've attached the query exp of one normal thread on my forum. One post got thanked 13 times and it took almost 10 sec to query!
https://vborg.vbsupport.ru/ (http://img147.imageshack.us/my.php?image=qhev6tk.jpg)

Abe1
02-12-2006, 02:30 AM
Hey Abe1,

Although the showthread page uses only ONE query, the load seems yet to loose.

I've attached the query exp of one normal thread on my forum. One post got thanked 13 times and it took almost 10 sec to query!
http://img147.imageshack.us/img147/889/qhev6tk.th.jpg (http://img147.imageshack.us/my.php?image=qhev6tk.jpg)

This is what I got on my forum:

Time Before: 0.13631 seconds
Time After: 0.13647 seconds
Time Taken: 0.00016 seconds

AnhTuanCool
02-12-2006, 02:53 AM
Ahhhhh, I think I've made a terrible mistake here.

I figured out what the problem is that the mixing query I suggested awhile ago actually makes the hack's query time worse. When using multiple WHERE's in query, it queries ALL the entries out of the table and the filter it through the second WHERE. If there are a lot of thanks entries like mine, it tremendously stresses the server. Look at the image I attached above, at column Row and you'll understand why.

So I strongly recommend switch back to the old time query.
$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Lastly, I terribly sorry for suggesting such a flawful mod...

dai-kun
02-12-2006, 06:06 AM
For some reason, as soon as I enable this product, my server load spike up to 10-20... why is that?
I have a lot of members online (around 200 at the same time) and a lot of thanked posts.
I'm using the latest version.

As soon as I disable this, server load goes back to normal (1-3).

NeutralizeR
02-12-2006, 12:43 PM
Can't remove thanks.


Database error in vBulletin 3.5.3:

Invalid SQL:
DELETE FROM msx_reputation WHERE postid = 62668 AND AND whoadded = 1 reason = 'Teşekk?r Mesajı';

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND whoadded = 1 reason = 'Teşekk?r Mesajı'' at line 1
Error Number : 1064

Database error in vBulletin 3.5.3:

Invalid SQL:

UPDATE msx_user
SET post_thanks_user_amount = post_thanks_user_amount - 1
WHERE userid IN ();

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3 Error Number : 1064

dai-kun
02-12-2006, 04:59 PM
Ahhhhh, I think I've made a terrible mistake here.

I figured out what the problem is that the mixing query I suggested awhile ago actually makes the hack's query time worse. When using multiple WHERE's in query, it queries ALL the entries out of the table and the filter it through the second WHERE. If there are a lot of thanks entries like mine, it tremendously stresses the server. Look at the image I attached above, at column Row and you'll understand why.

So I strongly recommend switch back to the old time query.
$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Lastly, I terribly sorry for suggesting such a flawful mod...


Thanks, I've revert it back toversion 2.5 and the server load seems to be less than 3-4 now :D
Before it was 20-30

edit:

nvm.. it's fluctuating now.. going around 6-15

AnhTuanCool
02-12-2006, 07:14 PM
@dai-kun - Did you delete this line in the hook?
$post_thanks_cashe = $db->query("SELECT " . TABLE_PREFIX . "post_thanks.* FROM " . TABLE_PREFIX . "post_thanks, " . TABLE_PREFIX . "post WHERE " . TABLE_PREFIX . "post.postid = " . TABLE_PREFIX . "post_thanks.postid AND " . TABLE_PREFIX . "post.threadid = '$post[threadid]' ORDER BY " . TABLE_PREFIX . "post_thanks.username ASC");


If you didn't, please do so. It's the main problem source.

dai-kun
02-12-2006, 11:54 PM
Ok so how would I do this? Do I edit out that code in the 3.0 version? I tried that and it giving me errors.

Cam on.

global $post_thanks_cash, $post_thanks_done, $db;

if (empty($post_thanks_done))
{

$act = 1;

while ($thanks = $db->fetch_array($post_thanks_cashe))
{
$post_thanks_cash[$act][userid] = "$thanks[userid]";
$post_thanks_cash[$act][username] = "$thanks[username]";
$post_thanks_cash[$act][date] = "$thanks[date]";
$post_thanks_cash[$act][postid] = "$thanks[postid]";
$act ++;
}

AnhTuanCool
02-13-2006, 02:03 AM
Add the patch in my #485 post BEFORE:


$act = 1;


and that should be it!

dai-kun
02-13-2006, 03:11 AM
i did that


global $post_thanks_cash, $post_thanks_done, $db;

if (empty($post_thanks_done))
{
$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");

$act = 1;

and when i go to thank, i get this error


Database error in vBulletin 3.5.1:

Invalid SQL:

UPDATE vb3_user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times, post_thanks_thanked_posts = 1 + post_thanks_thanked_posts, reputation = $vboptions[post_thanks_reputation] + reputation
WHERE userid = 741;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[post_thanks_reputation] + reputation
WHERE userid = 741' at line 2

C_P
02-13-2006, 04:12 AM
Can't remove thanks.
Ditto! I get same error:
Database error in vBulletin 3.5.2:
Invalid SQL:
DELETE FROM reputation WHERE postid = 12795 AND AND whoadded = 1 reason = 'Thanked Post';
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND whoadded = 1 reason = 'Thanked Post'' at line 1
Error Number : 1064
Date : Monday, February 13th 2006 @ 06:08:34 AM
Script : http://www.cpfools.com/forum/showthread.php?do=post_thanks_remove_user&p=12795
Referrer : http://www.cpfools.com/forum/showthread.php?p=12795#post12795
IP Address : xxxxxx
Username : CP
Classname : xxxxxxxxxx

Also at top of my page it shows this:
Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(251) : eval()'d code on line 131

Warning: Invalid argument supplied for foreach() in /includes/class_postbit.php(251) : eval()'d code on line 141
/*+--------------------------------------------------------------------------| Cascading Style Sheet for MKportal "Forum" Portal Template| ========================================| by Meo aka Luponero [Amedeo de longis]| visiblesoul [Don K. Colburn]| (c) 2004-2005 mkportal.it| http://www.mkportal.it| Email: luponero@mclink.it+--------------------------------------------------------------------------| > MKPortal| > Written By Amedeo de longis| > Date started: 9.2.2004+--------------------------------------------------------------------------*//*=============================MK global stylesP=============================*//* IMPORT body */body,body{ background: #FFFFFF; color: #000000; font: 10pt verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif; padding: 0px;}body { font-size: 10px; margin:0px; padding:0px; /* Opera 0 margin */ text-align: center; /* center in IE */ }/* IMPORT body background (used for SMF) */.importbgbody { font-size: 10px;}/* portal wrapper */#mkwrapper { text-align:left; /* left-align text in IE */ margin: 0px auto 0px auto;}/* IMPORT logostrip */#mklogostrip,.page{ background: #FFFFFF; color: #000000;}/* logostrip */#mklogostrip { text-align: left;}/* IMPORT global font formatting */table,tr,td,.tdglobal,td, th, p, li{ font: 10pt 'trebuchet ms', verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif;}/* global font formatting */table,tr,td,.tdglobal { font-size: 10px; }/* IMPORT main portal table bg (if different than body bg) */.tabmain,.page{ background: #FFFFFF; color: #000000;}/* main portal table */.tabmain { margin:0px; padding:0px; }/* image link border */img { border: 0px;}/*=============================MK IMPORT LIGHT BACKGROUNDP=============================*/.modulecell,.urlo2,.tabnews,.trattini,.trattini3,. tablemenu,.taburlo,.alt1, .alt1Active{ background: #DFE6EE; color: #000000;}/*=============================MK IMPORT MEDIUM BACKGROUNDP=============================*/.navigatore,.tdblock,.moduleborder,.modulex,.mkpag ecurrent,.alt2, .alt2Active{ background: #DFE6EE; color: #000000;}/*=============================MK IMPORT DARK BACKGROUNDP=============================*/.urlo,.sottotitolo,.tcat{ background: #397DD0 url(../forum/images_pb/gradients/gradient_tcat.gif) repeat-x top left; color: #FFFFFF; font: bold 10pt verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif;}/*=============================MK border and divider stylesP=============================*//* vertical spacer image used in portal skin *//* .vspacer { background-image: url(../forum/../mkportal/templates/CPstyle/images/punto_vert.gif); background-repeat: repeat-y; background-color: transparent; } *//* IMPORT border-color */.tabmain,.tablemenu, /* block wrapper, chat button strip */.taburlo,.urlo2,.tabnews,.trattini,.trattini2,.tra ttini3,.mkpagelink,.mkpagelinklast,.mkpagecurrent, .titadmin,.tborder{ color: #000000; border: 1px solid #072A68;} .trattini { border-width: 1px 0 0 0; border-style: dashed;}/* blocks admin */.trattini2 { border-width: 0 1px 0 0; border-style: dashed;}/* Quotes, Shoutbox */.trattini3 { border-width: 0 0 1px 0; border-style: dashed;}/*=============================MK hyperlink stylesP=============================*//* IMPORT global links */a:link,a:active,a.uno:link,a:link{ color: #000000;}a:visited,a.uno:visited,a:visited{ color: #000000;}a:hover,a.uno:hover,a:hover, a:active{ color: #465584;}/* a:active { font-family: Verdana, Arial, Helvetica, sans-serif; color: #496c9f; text-decoration: none; } *//* bold navbar, block, module links */a.uno:link { font-size: 10px; font-weight: bold; text-decoration: none}a.uno:visited { font-size: 10px; font-weight: bold; text-decoration: none}a.uno:hover { font-size: 10px; font-weight: bold; text-decoration: underline;}/* block text links *//* .tablemenu a:link, a:visited { font-family: Verdana, Arial, Helvetica, sans-serif; color: #496c9f; text-decoration: none; }.tablemenu a:hover { text-decoration: underline;}.tablemenu a:active { text-decoration: none; } *//* global contrasting text and hyperlink color */.mktxtcontr,a.mktxtcontr:link, a.mktxtcontr:visited { color: #ff0000; font-weight: bold; text-decoration: none;}a.mktxtcontr:hover { font-weight: bold; text-decoration: underline;}/* contrasting text and hyperlink color 2 (admin) */.mktxtcontr2,a.mktxtcontr2:link, a.mktxtcontr2:visited { color: #0000ff; font-weight: bold; text-decoration: none;}a.mktxtcontr2:hover { font-weight: bold; text-decoration: underline;}/*=============================MK form stylesP=============================*//* IMPORT form styles */input,textarea,select,.bgselect, /* input fields */.mkbutton, /* global submit buttons */.mkblkinput, /* block input */.mkradio, .bginput{ background: #FFFFFF; color: #000000; font: 10pt verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif;}/* set form padding and margin *//*.mkbutton,*/ /* global submit buttons *//* textarea,*/input,select,.bgselect, /* input fields */.mkblkinput /* block input */{ margin: 0px; padding: 0px; font-size: 9px; font-weight: normal; /* needed for Mozilla */ }/* radio/checkbox buttons - remove background color and border in IE */ /* .mkradio { background-color: transparent; border-width: 0px;} *//* configure blog textarea */textarea.mkwrap1 { overflow: auto; /* width: 230px; */ width: 100%;}/* edit blog textarea */textarea.mkwrap2 { overflow: auto; width: 500px ;}/*=============================MK navstrip stylesP=============================*//* top navstrip */.navigatore { vertical-align: bottom; text-align: center; font-family: Verdana, Arial, Helvetica, sans-serif; font-weight: 300; font-size: 9px; border: 0;}/*=============================MK block stylesP=============================*//* used in functions.php (function main_page) */.blocks { padding: 0px;}/* block td cell */.tdblock { font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 10px; font-weight: bold; border: 0; margin: 2px; }/* block title bar */.sottotitolo { vertical-align: bottom; text-align: left; font-size: 11px; font-weight: bold; }/* horizontal spacer between blocks */.tdspacer { line-height: 3px;}/*=============================MK module global stylesP=============================*//* IMPORT module table headings */th.modulex,.thead{ background: #BCCFEA url(../forum/images_pb/gradients/gradient_thead.gif) repeat-x top left; color: #3A4F6D; font: bold 11px tahoma, verdana, geneva, lucida, 'lucida grande', arial, helvetica, sans-serif;}.modulex { border-width: 0 0 0 0; white-space: nowrap; /* font-weight: normal;*/}/* Reviews description text */.modulelite { font-size: 8pt; /* color:#a6bbcd;*/}/* block padding (news, admin) */.contents { padding: 10px; }/* module pagination links */.mkpagelink { padding:1px 3px 1px 3px; font-weight: normal;}.mkpagelinklast { padding:1px 3px 1px 3px; font-weight:normal;}.mkpagecurrent { padding:1px 3px 1px 3px; font-weight:normal;}/*=============================MK shoutbox module stylesP=============================*/td.taburlo{ margin:5px; padding:5px; border: 0; } /* shouter and date cell */.urlo { line-height: 18px; vertical-align: bottom; text-align: left; font-size: 11px; font-weight: bold; padding: 4px; }/* shout cell */.urlo2 { padding: 4px; border-width: 0 0 1px 0; border-style: solid; text-align: left; font-size: 11px; font-weight: bold;}/* white shouter text *//* .urlocontrast { color: #ffffff;} *//*=============================MK news module stylesP=============================*//* news table with border */.tabnews { border-width: 1px; border-style: dashed; margin:0px; padding:0px; font-size: 10px; }/*=============================MK admin cp stylesP=============================*//* admin cp titles with top border */.titadmin { margin: 0px; font-size: 11px; font-weight: bold; border-width: 1px 0 0 0; border-style: dashed;}/*=============================MK font stylesP=============================*//* red error page text */.mkerror { font-size: 12pt; color: #ff0000; font-weight:bold;}/* MKPQuote quotation text *//* .mkquote { color: #0000ff; } *//* MKPGallery module ecard */.ecardtitle { font-size: 10pt; font-weight: bold; text-align: center;}/* MKPGallery slideshow caption text (modules/gallery/index.php function slide_update) *//* .mkslidecap { font-family: Verdana, Arial, Helvetica, sans-serif; font-size: 12pt; font-weight: bold; color: #ffffff;} *//*=============================MK BBcode quote stylesP=============================*/.mkquoteball { font-size: 9px; color: #666666; font-family: Verdana, Arial, Helvetica, sans-serif; font-weight: normal; background-color: #ffffff; padding: 0; }.mkquotetext { font-size: 10px; color: #666666; font-family: Verdana, Arial, Helvetica, sans-serif; font-weight: normal; background-color: #ffffff; margin: 0; padding: 0; }table .mkquotetable{ width: auto; /* IE */ text-align: left;}


The only way I could get rid of it was to thank the post again!

NeutralizeR
02-13-2006, 08:40 AM
Waiting for a fix again...

Abe1
02-13-2006, 12:38 PM
Version 3.2 (2/13/06):

[FIXED] Fixed another bug with reputation.
[FIXED] Sped up the one query used to retrieve the thanks.

Abe1
02-13-2006, 12:39 PM
Ahhhhh, I think I've made a terrible mistake here.

I figured out what the problem is that the mixing query I suggested awhile ago actually makes the hack's query time worse. When using multiple WHERE's in query, it queries ALL the entries out of the table and the filter it through the second WHERE. If there are a lot of thanks entries like mine, it tremendously stresses the server. Look at the image I attached above, at column Row and you'll understand why.

So I strongly recommend switch back to the old time query.
$post_thanks_querys = $db->query("SELECT postid FROM ". TABLE_PREFIX ."post WHERE threadid = '$post[threadid]'");
$post_thanks_postids = 0;

while ($post_thanks_query = $db->fetch_array($post_thanks_querys))
{
$post_thanks_postids .= ",$post_thanks_query[postid]";
}

$post_thanks_cashe = $db->query("SELECT * FROM " .TABLE_PREFIX. "post_thanks WHERE postid IN ($post_thanks_postids) ORDER BY username ASC");


Lastly, I terribly sorry for suggesting such a flawful mod...

I went back to this BUT, I did not use a query to get the postids. I used the one that vb made already. You should see improvement in the speed.

Abe1
02-13-2006, 12:40 PM
Waiting for a fix again...

This update fixes this.

optrex
02-13-2006, 12:47 PM
I've got 2.6 - what is the most reliable upgrade proceedure

The Realist
02-13-2006, 12:50 PM
Getting this database error when thanks is clicked?


Database error in vBulletin 3.5.3:

Invalid SQL:

UPDATE user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times, post_thanks_thanked_posts = 1 + post_thanks_thanked_posts, reputation = $vboptions[post_thanks_reputation] + reputation
WHERE userid = 26;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[post_thanks_reputation] + reputation
WHERE userid = 26' at line 2
Error Number : 1064
Date : Monday, February 13th 2006 @ 02:48:06 PM
Script : http://www.tech-tronix.com/showthread.php?do=post_thanks&p=3718
Referrer :
IP Address : xx.xx.xx.xxx
Username : Realist
Classname : xxxxxxxx


Any ideas?

Laters

Abe1
02-13-2006, 01:35 PM
Getting this database error when thanks is clicked?


Database error in vBulletin 3.5.3:

Invalid SQL:

UPDATE user
SET post_thanks_thanked_times = 1 + post_thanks_thanked_times, post_thanks_thanked_posts = 1 + post_thanks_thanked_posts, reputation = $vboptions[post_thanks_reputation] + reputation
WHERE userid = 26;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '[post_thanks_reputation] + reputation
WHERE userid = 26' at line 2
Error Number : 1064
Date : Monday, February 13th 2006 @ 02:48:06 PM
Script : http://www.tech-tronix.com/showthread.php?do=post_thanks&p=3718
Referrer :
IP Address : xx.xx.xx.xxx
Username : Realist
Classname : vb_database


Any ideas?

Laters

Do you have the latest version installed?