Log in

View Full Version : Geek AutoLinker 4.02


Pages : 1 [2] 3 4

The Geek
04-10-2005, 10:21 AM
hi,

I installed the hack and it works great. Only one problem...after instalation, it changed the behaviour of my admin CP.

when I click on an option (on the left hand side), it opens on a new window as opposed to opening on the same page (on the right hand side).

How can I fix this?
eh? All of the links (i.e. vboptions) opens in a new window?
Double check your file edit to admincp/index.php
All that did was add a menu group.

Yehuda
04-10-2005, 10:40 AM
here is a portion. Please ell me if you see anything wrong.

}
//=== GEEK AUTOLINK step 4.2 ===
$printhr = true;
construct_nav_option($vbphrase['GAL_display'], 'GAL_admin.php');
construct_nav_option($vbphrase['GAL_add_new'], 'GAL_admin.php?do=add');
construct_nav_option($vbphrase['GAL_settings'], 'GAL_admin.php?do=rebuild');
construct_nav_group($vbphrase['GAL_CP']);
//=== /GEEK AUTOLINK ===

// *************************************************

$printhr = false;
if (can_administer('canadminstyles'))
{
$printhr = true;
construct_nav_option($vbphrase['style_manager'], 'template.php?do=modify', '<br />');
construct_nav_option($vbphrase['search_in_templates'], 'template.php?do=search', '<br />');
construct_nav_option($vbphrase['replacement_variable_manager'], 'replacement.php?do=modify', '<br />');
construct_nav_option($vbphrase['download_upload_styles'], 'template.php?do=files', '<br />');
construct_nav_option($vbphrase['find_updated_templates'], 'template.php?do=findupdates', '<br />');
construct_nav_group("$vbphrase[styles] &amp; $vbphrase[templates]", '<hr />');
}
// ***
if (can_administer('canadminlanguages'))
{
$printhr = true;
construct_nav_option($vbphrase['language_manager'], 'language.php?do=modify', '<br />');
construct_nav_option($vbphrase['phrase_manager'], 'phrase.php?do=modify&phrasetypeid=1', '<br />');
construct_nav_option($vbphrase['search_in_phrases'], 'phrase.php?do=search', '<br />');
construct_nav_option($vbphrase['download_upload_languages'], 'language.php?do=files');
construct_nav_group("$vbphrase[languages] &amp; $vbphrase[phrases]", '<hr />');
}
// ***
if (can_administer('canadminfaq'))
{
$printhr = true;
construct_nav_option($vbphrase['faq_manager'], 'faq.php?null=0', '|');
construct_nav_option($vbphrase['add_new_faq_item'], 'faq.php?do=add');
construct_nav_group($vbphrase['faq']);
}
if ($printhr == true)
{
construct_nav_spacer();
}

// *************************************************

construct_nav_option($vbphrase['announcement_manager'], 'announcement.php?do=modify', '|');
construct_nav_option($vbphrase['add_new_announcement'], 'announcement.php?do=add');
construct_nav_group($vbphrase['announcements']);
// ***
if (can_administer('canadminforums'))
{
construct_nav_option($vbphrase['forum_manager'], 'forum.php?do=modify', '|');
construct_nav_option($vbphrase['add_new_forum'], 'forum.php?do=add', '|');
construct_nav_option($vbphrase['forum_permissions'], 'forumpermission.php?do=modify', '<br />');
construct_nav_option($vbphrase['show_all_moderators'], 'moderator.php?do=showlist', '<br />');
construct_nav_option($vbphrase['view_permissions'], 'resources.php');
construct_nav_group("$vbphrase[forums] &amp; $vbphrase[moderators]");
}
construct_nav_spacer();

// *************************************************

The Geek
04-10-2005, 11:31 AM
here is a portion. Please ell me if you see anything wrong.
There isnt anything there that could cause the links to open in a new windw. ?!?

Yehuda
04-10-2005, 11:43 AM
that is what I thought...

But get this....not only does it open in a new window...but on the right hand side there is just nothing...is it blank...

On the admin CP all I see are the boxes with the links on the left...

I have no idea what is going on...any suggestions?

Lionel
04-10-2005, 11:55 AM
Make sure there are no extra spaces at the end of the php ' ?>'

Yehuda
04-10-2005, 12:04 PM
Make sure there are no extra spaces at the end of the php ' ?>'???
where?

Lionel
04-10-2005, 12:25 PM
nameofthepagethatyouaretryingtoopen.php

The Geek
04-10-2005, 12:49 PM
nameofthepagethatyouaretryingtoopen.php
admincp/index.php

Yehuda
04-10-2005, 02:09 PM
nothing wrong there....I am at lost!

The Geek
04-10-2005, 02:29 PM
that is what I thought...

But get this....not only does it open in a new window...but on the right hand side there is just nothing...is it blank...

On the admin CP all I see are the boxes with the links on the left...

I have no idea what is going on...any suggestions?
can you post some screen shots? I am not sure how adding a menu group would cause that kind of problem you are mentioning.

Yehuda
04-10-2005, 03:20 PM
can you post some screen shots? I am not sure how adding a menu group would cause that kind of problem you are mentioning.
I have attached the screenshot...as you can see...there is nothing on the right hand side...just empty space and when I click on a link, it opens in a new window

The Geek
04-10-2005, 03:36 PM
I have attached the screenshot...as you can see...there is nothing on the right hand side...just empty space and when I click on a link, it opens in a new window
You got me.
It looks like you have totally lost your frameset.

Why dont you backup your current version and re-upload a fresh one.
If that works fine, then re-add the code and see what happens.
The change to admincp/index.php just simply couldnt have caused this.

Also - check to see if the phrases were built correctly. So a phrase search for GAL_ as the variable... edit it... then click save and see if that helps.

T3MEDIA
04-12-2005, 01:44 PM
ah... gotcha. I used to do that. It works... but the trade off is that the following doesnt get picked up with a trailing space:
bobs
bob.
bob!
bob?
etc...

The leading space is the best 2nd option. Where that fails is:
Bob at the start of a paragraph
or .Bob at the start of a sentence with no space (or other mark like ").

So, it is a bit of a trade off. If you want less likely to screw up links... add the spaces (I would add only one space). However in over 2 years of using this... I have only had about 3 screwed up links. Saying that... it could be more for sponsored links. Take eBay for example. You can autolink all ebays, however any user linking to www.ebay.com (http://www.ebay.com/) would have their link broken.

Maybe an option is in order!

What do you guys think? Option to turn on leading space? Personally, I would opt out of training space becasue of punctuation issues.With this hack can I (I guess I will find out soon) do this:
Replace text: [joe, joey, friends, comedy tv] and all wil goto the same URL?

T3MEDIA
04-12-2005, 01:45 PM
Odd did I miss it or not? Where are the directions to actually use this?

The Geek
04-12-2005, 01:51 PM
Odd did I miss it or not? Where are the directions to actually use this?
Did you try the Readme?

As far as your previous question... it will do, however each word is a seperate entry.
You may also be interested in teh GAL3 that is in the beta forum. It has a lot more functionality as is about to go gold later today or tomorrow. I think its pretty much in its completed state.

T3MEDIA
04-12-2005, 02:38 PM
Did you try the Readme?

As far as your previous question... it will do, however each word is a seperate entry.
You may also be interested in teh GAL3 that is in the beta forum. It has a lot more functionality as is about to go gold later today or tomorrow. I think its pretty much in its completed state.well my question is can I do that in one line not 4-5 speperate entries... no I did not look at the read me I did not install it as of yet. I tried a long time ago and had a DB issue.

Tom1234
04-12-2005, 02:45 PM
As far as your previous question... it will do, however each word is a seperate entry.


This is a case where using regular expressions would be useful such as a "replace text" field of:
(joe|joey|friends|comedy tv)

I haven't tried the above. I don't know if we can use regexps here.

The Geek
04-12-2005, 03:15 PM
sure. It would be handy - however most users are not offay with regexps and I think it would complicate it more than it needs to be.
I can see the merit in almost an 'import' option where you can enter delimited keywords and then when you save - it creates an individual entry for each keyword based on the other settings. This is pretty much what the GAS interfeace does to some degree.

The Geek
04-12-2005, 08:26 PM
GAL3.0 is out.
Check the readme for details on new functionality and upgrade instructions.

Lionel
04-12-2005, 08:29 PM
is the function_gal good to go now? last time you told me not to upload it

The Geek
04-12-2005, 08:30 PM
is the function_gal good to go now? last time you told me not to upload it
? hmmm dont remember that. Should be fine. Its the latest build.
Just do not overwrite with the one from GAS - thats older (in fact I am going to go remove it now)

TTG
04-12-2005, 08:59 PM
Running the upgrade and last edit and it provides this message :-


"in clientscript/vbulletin_menu.js, replace: ???" .. Guess I must have missed something with the initial installation .. where does this go in vbulletin_menu.js

with:

function GAL_popup(e,value){
var leftpx = fetch_object_posleft(e);
var toppx = fetch_object_postop(e) + e.offsetHeight;
var dest=fetch_object("GALBox");
toppx=toppx-5;
dest.innerHTML=value;
dest.style.left = leftpx + "px";
dest.style.top = toppx + "px";
if ((window.document.body.clientWidth-dest.offsetWidth)<leftpx){
leftpx=window.document.body.clientWidth-dest.offsetWidth;
dest.style.left = leftpx + "px";
}
dest.style.visibility='visible';
}
function GAL_hidepopup(){
fetch_object("GALBox").style.visibility='hidden';
}
// ################################################## ###########################
// another function to handle the different event models of different browsers
// and prevent event bubbling in a lesser way

The Geek
04-12-2005, 09:03 PM
oops ;)

Just replace

// ################################################## ###########################
// another function to handle the different event models of different browsers
// and prevent event bubbling in a lesser way


With the code it gave you.
Looks like I forgot to put that in... Ill go off and update the installer now.

*edit - just fixed it. Thanks

memobug
04-12-2005, 09:06 PM
Hi TNG,

Two questions

1) I reported a bug with Gal 2 but never got a response in that thread so I will ask again here: in safe mode, certain punctuation before the leading space was causing links not to be made. Things like commas and periods for example would stop links:

. keyword would not link
text, keyword, keyword, keyword would not link

Has this issue been addressed?

2) Can you choose on a per-link basis whether the link will be a new window or the popup? I have some links that are board internal that should open in the same window while others (advertising-related) should open in new windows.

Regards,

Matt

The Geek
04-12-2005, 09:13 PM
Hi TNG,

Two questions

1) I reported a bug with Gal 2 but never got a response in that thread so I will ask again here: in safe mode, certain punctuation before the leading space was causing links not to be made. Things like commas and periods for example would stop links:

. keyword would not link
text, keyword, keyword, keyword would not link

Has this issue been addressed?

2) Can you choose on a per-link basis whether the link will be a new window or the popup? I have some links that are board internal that should open in the same window while others (advertising-related) should open in new windows.

Regards,

Matt
Hi Matt.

Point 1- that is by design. In safe mode, the word MUST have a leading space. Otherwise it wont link for fear it will mess up a link. Danger mode will link them though.

Point 2- You can overwrite on a per item basis. However the prefered and easier method is to now create a category for those special links and override the global replacement with whatever you want (ie taking out the target='_BLANK' option)

memobug
04-12-2005, 09:24 PM
Hi Matt.

Point 1- that is by design. In safe mode, the word MUST have a leading space. Otherwise it wont link for fear it will mess up a link. Danger mode will link them though.

Point 2- You can overwrite on a per item basis. However the prefered and easier method is to now create a category for those special links and override the global replacement with whatever you want (ie taking out the target='_BLANK' option)
Thanks but
in #1 all of those have leading spaces

.SPACEkeyword would not link
text,SPACEkeyword,SPACEkeyword,SPACEkeyword would not link

#2 - great!

The Geek
04-12-2005, 09:35 PM
Sorry - missed those spaces (I guess I 'spaced' them off! )

Well... a couple of users have mentioned this and I have to say I only just first witnessed it while testing 3.0. Thats because I generally use danger mode.
FOr the life of me I couldnt figure out why it wasnt linking (mind you - its still very rare). The only thing I can think of is that the message itself (out of the DB) has some formatting during parsing which does not equate to a literal space. This would explain why it is consistent on the same message, but sows up elsewhere.
If that is the case - it could be taken into account in the regex. However like I said - I only first just witnessed it.

If anyone has some ideas - let me know.

TTG
04-12-2005, 09:41 PM
Hate to find another problem .. my admin GAL items are now missing after the upgrade .. can someone post the edits for admincp/index.php .. thanks

The Geek
04-12-2005, 09:42 PM
Hate to find another problem .. my admin GAL items are now missing after the upgrade .. can someone post the edits for admincp/index.php .. thanks
Run the installer, choose the install path. THen click the manual install step. THat should bring it up

Lionel
04-12-2005, 10:06 PM
I don't know what I am doing wrong. I ran the upgrade, had to do a couple adjustment manually, but now links are not working. Am I supposed to use what is in Gal folder instead of regular forum?

First time I used the auto installer... did not realized I had to copy files over

venomx
04-12-2005, 10:19 PM
I am scared to upgrade.. I tried to upgrade the articles hack and it didnt work right. :(

Lionel
04-12-2005, 11:12 PM
there is a tiny bug.

<a href='$link' target='_blank' class='DEF' title='$description'>$text</a>
should be

<a href='$link' target='_blank' class='DEF' title=$description>$text</a>

description without the quote.

because it looks like you had them defined somewhere else also, causing the link to show the title with double single quotes ''....'' instead of '....' like the other tags and therefore not displaying the title. Once I removed it in description, then it displayed the tag '....'

bad example:

<a href='http://www.ap.org/' target='_blank' class='DEF' title=''International News Agency''>Associated Press</a>

TTG
04-13-2005, 04:45 AM
Using the code you provided for the popup ability :-

<div id="GALBox"
style="position: absolute; width: 200px; z-index: 100;
border: 1pt black solid; background: #FFFFCC;
visibility: hidden; padding: 10px;"
onmouseover="this.style.visibility='visible';"
onmouseout="this.style.visibility='hidden';">
</div>


how can I move the pop up to be a few pixels down from the link .. it covers the link at the moment.

The Geek
04-13-2005, 07:05 AM
Using the code you provided for the popup ability :-

<div id="GALBox"
style="position: absolute; width: 200px; z-index: 100;
border: 1pt black solid; background: #FFFFCC;
visibility: hidden; padding: 10px;"
onmouseover="this.style.visibility='visible';"
onmouseout="this.style.visibility='hidden';">
</div>


how can I move the pop up to be a few pixels down from the link .. it covers the link at the moment.
Lionel - thanks for the heads up with the $description. Ill change the readme and the default in the hack.

TTG - its in the javascript. Open vbulletin_menu.js and its right at the top (in one of the functions you added).
Look for toppx=toppx-(number) and change number to whatever offset you want. You can use 0 however depending on the style of your link - it could cause intermitten problems. I would use toppx=toppx-1;

nJoy

TTG
04-13-2005, 08:23 AM
Great support .. all works well with the upgrade on 3.0.6

Thanks The Geek

T3MEDIA
04-13-2005, 01:03 PM
ok. quick question. what version is this if I have the beta version. In other words how would I (if needed) upgrade to 3.

The Geek
04-13-2005, 01:15 PM
ok. quick question. what version is this if I have the beta version. In other words how would I (if needed) upgrade to 3.
File changes are the same... Depends on which package you were running. If you have categroy options in the admincp then your file changes should be updated (may want to double check the file changes to vbulletin_menu.js

Aside from that - just overwrite your GAL files with the ones in the latest package.

Hope that made sense!

fly
04-13-2005, 01:37 PM
Sweet. Gish didn't seem to work for me, other than the js file. Anything I can give/show to you to help improve it?

And I'm anxiously awaiting link timeouts after a certain period of time. THANKS MAN!

The Geek
04-13-2005, 01:45 PM
Sweet. Gish didn't seem to work for me, other than the js file. Anything I can give/show to you to help improve it?

And I'm anxiously awaiting link timeouts after a certain period of time. THANKS MAN!
Upgradin is seriously difficult with GISH (or any file hacker) as it totally depends on how you put the previous code in. I got it to work in most upgrade situations - but in many it wont. This I dont see as a problem becuase 1- there are only 4 small minor file edits. 2 - Worse case scenario, you will have to manually do them yourself.

The good news is that once they have been auto-hacked... future upgrades are much easier.
Saying that - Im half tempted to do away with the auto hacking for smaller file changes as no one ever seems to read the README. For something like GAS its essential as there are many file edits. For this - its could go either way.

Enough of a rant :)

Just do the js fiel change manually. GISH errs on the side of caution and wont touch the file if it doesnt think its 100% safe to.

As far as timeouts - I am planning on an optional integration between GAB and GAL so that people can place adverts AND key words however this may be a few weeks away.

fly
04-13-2005, 01:51 PM
Your coding skills are only matched by your bostaff skills and nunchuck skills.

T3MEDIA
04-13-2005, 06:22 PM
File changes are the same... Depends on which package you were running. If you have categroy options in the admincp then your file changes should be updated (may want to double check the file changes to vbulletin_menu.js

Aside from that - just overwrite your GAL files with the ones in the latest package.

Hope that made sense!Sorry I got the info late I have version GAL_RC2[1].10.

The Geek
04-13-2005, 06:59 PM
Sorry I got the info late I have version GAL_RC2[1].10.
I would jsut overwrite the existing files and double check the file changes. Im pretty sure you are up to date with everything.

JustAskJulie
04-13-2005, 08:49 PM
Are replacements case sensitive in safe mode?

The Geek
04-13-2005, 09:11 PM
nope

JustAskJulie
04-13-2005, 09:16 PM
nope

good.

I've installed it and it's working great. Just one more question. Is there a change I can make to that in safe mode it will require a space after but not before. IE. Currently in safe mode if I were to put

link here

it would not autolink it, but if i put link here (with space before and after) it will.

Lionel
04-14-2005, 08:25 AM
I have a small problem. Three times I have chosen to live dangerously, three times the settings reverted themselves to safe mode.

The Geek
04-14-2005, 10:12 AM
Ill look into it later today for you.

wolfyman
04-14-2005, 02:12 PM
I downloaded, opened it up to /forum, and uploaded. It didn't ask to overwrite anything on a fresh install. When installing, everything claimed to be successful except step 200, which I edited manually with no problem.

I added a word/url combo in the admincp, but - no linkie! What did I miss?

fly
04-14-2005, 02:24 PM
odd. I just checked mine too and it isn't working.

fly
04-14-2005, 03:36 PM
I just rechecked all the edits and stuff. Was I supposed to totally remove the old version first?

wolfyman
04-14-2005, 03:38 PM
I didn't have the old version.

JustAskJulie
04-14-2005, 03:55 PM
good.

I've installed it and it's working great. Just one more question. Is there a change I can make to that in safe mode it will require a space after but not before. IE. Currently in safe mode if I were to put

link here

it would not autolink it, but if i put link here (with space before and after) it will.

Nevermind, I read back where this is addressed.

I also found that it won't link words if there is puntuations around them. I had tried to make a list of the words that I had added for my mods and they were listed separated by commas.... they wouldn't link. Drove me insane for about 20 minutes trying to figure out why it wasn't working. No big deal tho, as I don't expect the words and phrases to be things that people list.

The Geek
04-14-2005, 04:39 PM
Remember that the changed files are in gish/gal

You shouldnt of had to remove the earlier version - just double check the file edits are up to date.

fly
04-14-2005, 05:02 PM
Remember that the changed files are in gish/gal

You shouldnt of had to remove the earlier version - just double check the file edits are up to date.
Yeah, I had to do all the file edits myself (except for the .js file) and they are all there. Admincp stuff is all there too, but the links just don't show up...

fly
04-14-2005, 05:03 PM
Whoa. I see my problem. I didn't actually submit the thread, only previewed it. I thought that worked on v2.0, but certainly doesn't on v3.0...

JustAskJulie
04-14-2005, 08:58 PM
Just ran into what appears to be a slight bug. I had been running in safe mode with the Link replacement limit set to 0 - all was fine. I changed the link replacement to 2 and it breaks. Instead of autolinking at it should, it adds the description text into the body of the post and links it as well as the autolink word/phrase, resulting in (some cases) two or three lines of linked text.

Any ideas?

On the replacement limit itself, it would be nice if that could be done on a link by link basis rather than globally - certain links limited while others aren't.

The Geek
04-14-2005, 09:06 PM
ill look into the limit bug when I can get my server back up and running (its currently down due to DNS woes).

As far as limiting per item - not really possible without overly slowing things down. THe replacements are done in one pre_replace call. Otherwise each link would have to be replaced in a loop. If you have 50 links in a thread showing 15 posts, thats 750 replacment calls instead of one!

Hope you dont hold it against me :)

Shackbase
04-14-2005, 09:59 PM
i did the install - i set up a sample keyword - logitech - http://www.talkshack.com/showthread.php?t=8

and nothing - what could I be missing?

Thanks for a most excellent addon (once I get my copy working). :)

--Tone

JustAskJulie
04-14-2005, 10:19 PM
ill look into the limit bug when I can get my server back up and running (its currently down due to DNS woes).

As far as limiting per item - not really possible without overly slowing things down. THe replacements are done in one pre_replace call. Otherwise each link would have to be replaced in a loop. If you have 50 links in a thread showing 15 posts, thats 750 replacment calls instead of one!

Hope you dont hold it against me :)

Nope, not at all. I give you mad props for your skillz and moreso for your fast responses and willingness to support your stuff.

Thanks for explaining the limit thing, I figured there was a good reason.

wolfyman
04-14-2005, 10:40 PM
i did the install - i set up a sample keyword - logitech - http://www.talkshack.com/showthread.php?t=8

and nothing - what could I be missing?

Thanks for a most excellent addon (once I get my copy working). :)

--Tone

Sounds like the same problem I have.

Shackbase
04-14-2005, 11:04 PM
ok - so I did not undertand (yes I DID read it) the manual - you need to copy the files that the script creates in the /gish/ directory.. sorry - that wasn't clear to me.

Wolfyman.. did you get that? it's a real neat way of doing things actually - kudos to The Geek...

Thanks,

--Tone

Shackbase
04-14-2005, 11:17 PM
I do have one question though... in your thread... http://www.thenailgeek.com/showthread.php?t=11011

doing a mouse over - there's a 2nd link in there.. how can I do that? let's say I want to add a <more> link instead or with the normal text link (in other words, add a more info link inside of the description like you have it); how would I do that?

--Tone

wolfyman
04-14-2005, 11:19 PM
I end up with these files - /forum/gish/gal/3.00/.. I need to copy those into the main directory........ ooooooooooh

wolfyman
04-14-2005, 11:22 PM
Geek, I just joined the masses. Thanks buddy :D

j_86
04-15-2005, 06:00 AM
When clicking "save ordinal" on "display" in the adminco when there are no links/ordinals entered, you get this error;

Warning: Invalid argument supplied for foreach() in /admincp/GAL_admin.php on line 425

The Geek
04-15-2005, 07:53 AM
Ill look into it today (along with the danger and limit bug) most likely later tonight. I just got my own server back up and running.

Shackbase: use the $url variable in your description to get a link to appear. You can also put HTML in the description when using popups - however DO NOT put any text in that could break a line (ie. <br /> or <p> tags). You can do physical line breaks - but all spaces are changed to &nbsp; otherwise your javascript will error.

fly
04-15-2005, 10:54 AM
ill look into the limit bug when I can get my server back up and running (its currently down due to DNS woes).

You must be on Comcast. Change your DNS server to 4.2.2.2 and your problems will disappear.

The Geek
04-15-2005, 11:14 AM
You must be on Comcast. Change your DNS server to 4.2.2.2 and your problems will disappear.
the problem was that the namespace server purged my records so everyone trying to resolve my domain name came up with nothing. Now its just a matter of waiting for all TTL's to expire :(

wolfyman
04-15-2005, 12:04 PM
can someone explain what the ordinal is and what else I can do with the bottom field in GAL?
(Replacement code
$link = url
$description = link title
$text is the text replacement.)

The Geek
04-15-2005, 12:23 PM
can someone explain what the ordinal is and what else I can do with the bottom field in GAL?
(Replacement code
$link = url
$description = link title
$text is the text replacement.)
ordinal is the order for replacment.

the lower the number, the more precedence it has.

So if you have 'my name is bob' and also 'bob' as replacments, you want the first to have a lower ordinal so it gets replaced first. Otherwise only the second will get matched.

$link=url
$description=description
$text=replacement text
$url=a rolled up version of $link and $text. Essentially, $url produces the following html:
<a href='$link' target='_BLANK'>$text</a>

So when using a popup, you can stick $url in the description and it will give you a link (this was mentioned a few posts back). You can also use html - but I would caution not to use anything that would give you a line break as it can break the variable sent to the popup javascript.

Technically, you could also use some posbit variables too.

Hope this isnt to confusing ;)

wolfyman
04-15-2005, 03:12 PM
I'm with it now, thank you very much :D

The Geek
04-15-2005, 05:11 PM
I cant replicate the limit bug you have mentioned. It seems to work fine at this end.
I cant replicate the settings not saving dangermode. It works as expected on a clean install.

I did find that putting $url in when you are not using the popup (in other words - using standard links) can cause extra HTML formatting to appear. It would be silly to put the $url variable just so it appears in a standard tooltip box anyway as it would be totally unusable.

I also found that in the replacement code - dont bother putting an apostraphe around the $description tag as one is done automatically within the construction of the variable.

HTH's

Quarterbore
04-15-2005, 05:32 PM
I just finished installing this on my board and it is a great mod!

I only had one problem with the install that you may want to evaluate...

In the install script there is line for "Modifying file: admincp/index.php"

In my install I got an error saying...


Can not complete change to admincp/index.php - step 200 as I can not find the text to replace. You will have to manually complete this step. [click here for manual step step 200]

I looked at the directions and it said to open admin/index.php and find

// *************************************************
if (can_administer('canadminstyles'))

and replace above with:

// === GAL step 200 ===
$printhr = true;
construct_nav_option($vbphrase['GAL_display'], 'GAL_admin.php');
construct_nav_option($vbphrase['GAL_add_new'], 'GAL_admin.php?do=add');
construct_nav_option($vbphrase['GAL_settings'], 'GAL_admin.php?do=settings');
construct_nav_option($vbphrase['GAL_cats'], 'GAL_admin.php?do=cats');
construct_nav_option($vbphrase['GAL_cat_add'], 'GAL_admin.php?do=addcat');
construct_nav_group($vbphrase['GAL_CP']);
// === /GAL step 200 ===

// *************************************************
if (can_administer('canadminstyles'))


In my file I had the following:

// *************************************************

$printhr = false;
if (can_administer('canadminstyles'))
{
$printhr = true;
construct_nav_option($vbphrase['style_manager'], 'template.php?do=modify', '<br />');
construct_nav_option($vbphrase['search_in_templates'], 'template.php?do=search', '<br />');
construct_nav_option($vbphrase['replacement_variable_manager'], 'replacement.php?do=modify', '<br />');
construct_nav_option($vbphrase['download_upload_styles'], 'template.php?do=files', '<br />');
construct_nav_option($vbphrase['find_updated_templates'], 'template.php?do=findupdates', '<br />');
construct_nav_group("$vbphrase[styles] &amp; $vbphrase[templates]", '<hr />');
}
// ***

So I updated my code by replacing the line:


// *************************************************

$printhr = false;
if (can_administer('canadminstyles'))


with


// *************************************************

$printhr = false;
// === GAL step 200 ===
$printhr = true;
construct_nav_option($vbphrase['GAL_display'], 'GAL_admin.php');
construct_nav_option($vbphrase['GAL_add_new'], 'GAL_admin.php?do=add');
construct_nav_option($vbphrase['GAL_settings'], 'GAL_admin.php?do=settings');
construct_nav_option($vbphrase['GAL_cats'], 'GAL_admin.php?do=cats');
construct_nav_option($vbphrase['GAL_cat_add'], 'GAL_admin.php?do=addcat');
construct_nav_group($vbphrase['GAL_CP']);
// === /GAL step 200 ===

// *************************************************
if (can_administer('canadminstyles'))



As for my board... I am running vB 3.0.7. and the only other Mod I have installed is vBAdvanced. The replacement code seems to work however with one minor thing I would like changed if possible...

If your keyword is used as the title for a link such as "Click here for link on vBulletin" and you use vBulletin as a replacement term then what happens is "Click here for link on" goes to the initial link while "vBulletin" goes to a different link as defined by this mod.

Is there any way to have the mod detect that text should not be between a [url= some url ]Click here for link on vBulletin[ /url]?

EDIT: ALSO whay aren't the font colors working on this board (vBulletin.org)?

The Geek
04-15-2005, 05:37 PM
It shouldnt do that in safe mode. Please let me know which mode you are running in.

Quarterbore
04-15-2005, 05:46 PM
I am using safe mode.

You can see it at work here:

http://www.quarterbore.net/forums/showthread.php?t=19

In reply to below... not a major issue and I can live with it... I just need ro remember not to use my keyword in my description of the link anymore! As I find them, I will just reword them...

Thanks again for an excellent mod!

The Geek
04-15-2005, 06:52 PM
It wont change anything except in a postbit.
As far as the [url=www.somesite]i like bob a lot[/bob] getting messed up... that is a limitation. Both safemode and danger mode will screw up that link.
The reason being that bob qualifies to get linked because there is a space in front of it.
There isnt really a way to determine (within reason) if bob is in middle of a link or not. All it can do is (in safe mode) determine that it isnt a link itself (ie www.bob.com). In order to determine if it is sitting in a url, you would have to come up with the mother of all regex that would find a match and scan backwards to ensure that there wasnt a < a href in front without a matching </a> after it. This would be a nightmare to make the regex and it would dramatically slow things down.

Sorry :(

rainyleaves
04-16-2005, 04:28 AM
Realy thanks..GEEK. Very cool hack.

I have major problem.
I can use English key words.
But I can not use Korean key words.
Korean key word can not link. Nothing appear.
Korean language is 2byte language.
How can I use Korean key word with GAL.

Thanks.
Sorry my English...^^

rjerina
04-16-2005, 05:57 AM
Is this supported in FireFox as well or is it just IE?

The Geek
04-16-2005, 06:41 AM
Is this supported in FireFox as well or is it just IE?

Works in FF as well.

rainyleaves - I really have no clue about that - maybe someone here can shed some light onto it. sorry :(

rainyleaves
04-16-2005, 06:43 AM
Thanks...^^ GEEK.

venomx
04-16-2005, 08:00 PM
This is odd. I am still using the old version and its linking a word that has text after it.

http://www.discussionjunction.com/forums/showthread.php?t=2024
I have it set to link amazon and this post has amazon.com 2 times.. the first one is linked.
I guess Ill try updating this hack but I am scared to because when I did the artivle hacks update it didnt work. :(

venomx
04-16-2005, 08:51 PM
Updated perfectly! W00t I had to make 3 or 4 edits on my own though.
Thing is the popup doesnt look right... its way too big compared to the one on the demo... :(

OrangeFlea
04-16-2005, 11:31 PM
I have 2.6

Is there any major reason for me to update the current version? The one I have now is perfect.

Kihon Kata
04-17-2005, 01:33 AM
I have 2.6

Is there any major reason for me to update the current version? The one I have now is perfect.
I have the new one and I can tell you, the mouseovers ROCK. Look here for an example and hover your mouse over the links: http://www.makeuptalk.com/forums/showthread.php?t=6357 (second post down)

The Geek
04-17-2005, 09:51 AM
I agree that the default style for the popup is a bit pants. If you want it changed - just change the style of the div box you put in your template (most likely the header).

swarangal.com
04-17-2005, 02:30 PM
hey geek i have integrated the Overlib in to this hack for mouse our ... u can see it in my test zone :)

http://www.swarangal.com/fingering/showthread.php?t=1

just check iranthavan / chandramuki

please suggest me whether it is right to change ?

The Geek
04-17-2005, 02:44 PM
hey geek i have integrated the Overlib in to this hack for mouse our ... u can see it in my test zone :)

http://www.swarangal.com/fingering/showthread.php?t=1

just check iranthavan / chandramuki

please suggest me whether it is right to change ?
hey there. I have no clue what overlib is. The mouse over looks kind of cool for chandramuki - however it doesnt work ;)
You can get the same look with the popup facility here. You dont need the other hack.

BTW: Is that my advertising hack to? ;)

Looks cool - just needs a <br /> before ad1 :)

The Geek
04-17-2005, 02:48 PM
oh, also - you are getting an error because your title is 'Iranthavan the Admin'
with the JS you included - it should be \'Iranthavan the Admin\'

T3MEDIA
04-17-2005, 02:55 PM
hey geek i have integrated the Overlib in to this hack for mouse our ... u can see it in my test zone :)

http://www.swarangal.com/fingering/showthread.php?t=1

just check iranthavan / chandramuki

please suggest me whether it is right to change ?huck us up with that code you use to make the mouse over bro... or give us a link SOMETHING!

venomx
04-17-2005, 03:06 PM
I think he is using a different hack for that popup design unless I am reading wrong...

swarangal.com
04-17-2005, 04:10 PM
Overlib is another nice Mouse over script guys its freeware (free wot ever it is) i just used the code ... and tested and its works and getting error so i asked geek more info goes here.

include the js in the headinclude and put the div in the header template and thats it

http://www.bosrup.com/web/overlib/

i really love this mouse over its KEWL :)

try geek to integrate properly i thinks it GPL so shud not be probz

The Geek
04-17-2005, 04:52 PM
script guys its freeware (free wot ever it is) i just used the code ... and tested and its works and getting error so i asked geek more info goes here.

include the js in the headinclude and put the

Why when you can do the same thing with this?

swarangal.com
04-17-2005, 05:19 PM
Why when you can do the same thing with this?
it has tons of other features ... like calling it left rite center top with background image i can even call my image when overed my nick stuff like that it will help my sponsperer's tat y urs is simple gr8 stuff but just adding my fancy stuff to it ... correct me if i AM wrong

T3MEDIA
04-17-2005, 06:28 PM
oh man thats hot.
He is using the link stuff but the pop up is just more nicer java thats all.
cool.

The Geek
04-17-2005, 06:45 PM
Cool. But im still not sure what you asking me. You want me to integrate my hack into their progam?

Cant really say I see it on the immediate horizon. sorry... just very busy with other hacks right now :(

swarangal.com
04-18-2005, 01:43 AM
Cool. But im still not sure what you asking me. You want me to integrate my hack into their progam?

Cant really say I see it on the immediate horizon. sorry... just very busy with other hacks right now :(
no probz just keep it in the corner of things to do :p

and yes its ur banner system !!! going to play around with ur article system and will bug u there :p

venomx
04-18-2005, 02:13 AM
Any way to make this work with the banner system you are setting up?

The Geek
04-18-2005, 06:10 AM
Any way to make this work with the banner system you are setting up?
It will do venom.
I am still juggling with how to get them to expire like ads though (oh yea, and there really isnt a way to track how mant imressions you get with a GAL)

Lionel
04-18-2005, 07:54 AM
It happened to me again that the settings reverted to safe mode. I think it does whenever a new link is added, directly or from GAS input.

The Geek
04-18-2005, 09:00 AM
It happened to me again that the settings reverted to safe mode. I think it does whenever a new link is added, directly or from GAS input.
THanks Lionel - ill investigate later today.

T3MEDIA
04-18-2005, 11:48 AM
Geek. I would love to have this work this way.
Child, children, boys, girls, at home mom, brats, kids
goto this url....

and imagine there was more than 1 url.

say the kids allways have fun. Kids will be kids.

I would like the URL to be differnt for each kid. (if I had three) If I had only 2 lets say then two will have the same and one differnt.

can this be done with the hack you have now?

The Geek
04-18-2005, 12:09 PM
:rolleyes:

You want the replacment to be dependant on the usergroupid? It can be done - but it isnt something that is in it now. I guess I can look at something like that for future versions.

HTH's

venomx
04-18-2005, 02:45 PM
The Geek

You could always do what the text ad places do. Insert an image...
like gal.gif?ad=1

The Geek
04-18-2005, 03:26 PM
The Geek

You could always do what the text ad places do. Insert an image...
like gal.gif?ad=1
Yea, that works for tracking clicks - but cant get how many times the link appears if you know what I mean...

Unless... you mean have like an image in the popup text like <img scr="www.mysite.com/image.php?id=5"> kind of thing. Not sure how well it would work though.

venomx
04-18-2005, 03:35 PM
I mean like..

<a href=mydomain.com/forums/gal.php?id=1>WORD</a><img scr="mydomain.com/galimage.php?id=1">

Thats how linkshare.com does the ads for affiliates. Click the link and it counts a click the loading of the image counts the impressions.

venomx
04-18-2005, 03:36 PM
the image would be a 1x1 trans. pixel image...

greenhybrid
04-18-2005, 07:49 PM
I don't quite understand what the "categories" are. Can someone please explain this?

The Geek
04-18-2005, 08:58 PM
I don't quite understand what the "categories" are. Can someone please explain this?
The categories allow you to categorize the links for easier management (only used in admincp).

THeir real power lies in the ability to override the global replacement text.
So, you can have 2 categories, 1 that produces a standard link and 1 that produces popups.

At the end of the day - you dont really have to use them - but it CAN make things much more flexible.

greenhybrid
04-18-2005, 09:00 PM
Popups? How? Also, what's the ordinal thing?

The Geek
04-18-2005, 09:14 PM
Popups? How? Also, what's the ordinal thing?
ordinal is the order of replacement that takes place.
so ebay sucks should have a lower ordinal than ebay otherwise ebay sucks wont get linked as by the time ebay sucks comes around - the ebay has already been changed (if that makes sens ;) )

Instructions for the poppup replacment code is in the readme. Just put it in the replacement box of the global, category, or item replacment box.

HTH's

venomx
04-18-2005, 09:30 PM
What I like about this is I own a ppc search site too so I can take the more popular search terms at my ppc search site and link to them on my forum.

greenhybrid
04-18-2005, 11:08 PM
I can't seem to get the popups working:
http://www.greenhybrid.com/discuss/post10992.html

The necessary code is in the file. Also, I don't see how the categories override or determine the replacement for their links.

|Jordan|
04-19-2005, 04:58 AM
How is this hack on performance? Does it slow down page loading, server resources, etc.?

The Geek
04-19-2005, 05:39 AM
it doesnt look like the change to vbulletin_menu.js was made.

if there is no individual replacement code for an item - it then uses the category replacment code. If there is no category replacement, it then uses the global.

myis jordan - its pretty hot. There are no additional runtime queries. Obviously the more replacments you have th more work has to be done to each postbit - however I havent heard of anyone mention a performance problem yet.

T3MEDIA
04-19-2005, 02:38 PM
:rolleyes:







You want the replacment to be dependant on the usergroupid? It can be done - but it isnt something that is in it now. I guess I can look at something like that for future versions.


HTH's

if this was for me no... I mean the target word kids could have a url.
or the target words kids, children could have the SAME url.
or the option to have the target word kids have multiple urls that rotate.
first instance goes to this URL
second on the page will go here.

that way if you have a page with the term kids all over it it will have differnt links.

this is a marketing dream.

The Geek
04-19-2005, 03:17 PM
if this was for me no... I mean the target word kids could have a url.
or the target words kids, children could have the SAME url.
or the option to have the target word kids have multiple urls that rotate.
first instance goes to this URL
second on the page will go here.

that way if you have a page with the term kids all over it it will have differnt links.

this is a marketing dream.
Ahhh... I see.

To create 1 link for many keywords isnt THAT hard to do (guess I could look into it for future versions). However a keyword to many url relationship could prove difficult without moving the system to a table and building the links at runtime. It is dooable - and I doubt the overhead would be too much - however it isnt something I would do as a default (making the links at runtime) and not something I would look into right away.

Still - guess Ill keep it in the back of my head ;)

adamgessel
04-19-2005, 11:42 PM
Awesome ;)

Thanks

T3MEDIA
04-20-2005, 11:21 AM
Ahhh... I see.

To create 1 link for many keywords isnt THAT hard to do (guess I could look into it for future versions). However a keyword to many url relationship could prove difficult without moving the system to a table and building the links at runtime. It is dooable - and I doubt the overhead would be too much - however it isnt something I would do as a default (making the links at runtime) and not something I would look into right away.

Still - guess Ill keep it in the back of my head ;)fair enough.

KTBleeding
04-20-2005, 10:13 PM
I apologize for the ignorance, but I really just can't seem to get this system to work. I've read the read me and this thread several times through but still can't figure it out. I manually installed the file edits and I have triple checked that they are correct but I still can't manage to get the keywords to link to anything at all.

OrangeFlea
04-21-2005, 12:29 AM
I have the new one and I can tell you, the mouseovers ROCK. Look here for an example and hover your mouse over the links: http://www.makeuptalk.com/forums/showthread.php?t=6357 (second post down)

That's pretty neat, but I have over 900 entries. I don't have the time or the inclination to add captions to all of them. Is that the only major upgrade from 2.6? If so, I'll just stick to what I have now.

greenhybrid
04-21-2005, 12:45 AM
I can't get the popups to work. The necessary code DOES seem to be in the page.
http://www.greenhybrid.com/discuss/t1917-automatic-text-links---testing.html

venomx
04-21-2005, 01:29 AM
900??? wow

greenhybrid did you add the code to the header ?

KTBleeding
04-21-2005, 02:03 AM
I apologize for the ignorance, but I really just can't seem to get this system to work. I've read the read me and this thread several times through but still can't figure it out. I manually installed the file edits and I have triple checked that they are correct but I still can't manage to get the keywords to link to anything at all.Well, I guess they are some what working? If a registered member posts then it works, but if I post one it doesn't seem to show up. Just a tad confused about it.. I tried a test account too and no go.

greenhybrid
04-21-2005, 02:13 AM
Yes, it's there.<div id="GALBox"
style="position: absolute; width: 200px; z-index: 100;
border: 1pt black solid; background: #FFFFCC;
visibility: hidden; padding: 10px;"
onmouseover="this.style.visibility='visible';"
onmouseout="this.style.visibility='hidden';">
</div>

Tom1234
04-21-2005, 03:19 AM
When entering HTML tags in the Description field for use in popups, it appears that the " (double quote) character cannot be used without corrupting the display of the primary autolink. When I used ' (single quote) instead of " (double quote) in the A HREF tags, it worked fine. This should be documented in the README.

Tom1234
04-21-2005, 03:38 AM
Geek,

The Description field is a VARCHAR(255) which means it is limited to 255 characters. For my purposes when entering HTML tags and text, 255 isn't always enough. I suppose I could change it from VARCHAR(255) to TEXT to permit larger entries. Do you think this is OK to do? I think the main difference between them, other than performance, is that the TEXT data type does not strip trailing spaces, but VARCHAR does. Do you rely on that stripping at all for it to work properly? Do you envision any other problems?

The Geek
04-21-2005, 05:47 AM
Tom - shouldnt be any problems. The text may have to be trimmed though. Ill look into the " problem. To me - that sounds like a minor bug

greenhybrid - you are getting js errors saying that the js functions are not there. Are you positive that you made the changes correctly to vbulletin_menu.js?

Orange - there are a few performance tweaks which makes it chug along a bit faster. Other than that and the categories - its it for the most part. If your happy with 2.6 - than no stress there. Saying that - you dont lose your existing entries. They only land in the 'unknown' category. The default replacement code is the standard one from 2.6. I guess what I am saying is that if you upgrade but dont do anything else with the settings - youll end up with exactly what you have now but slightly faster. Then as you add links - you can add them to new categories with popups or standard - or whatever.
Up to you ;) I am also believe in 'if it aint broke...'

KTBleeding - can you give me a few links with some examples so I can check it out?

KTBleeding
04-21-2005, 12:38 PM
KTBleeding - can you give me a few links with some examples so I can check it out?It's working. I'm just slow. It's supposed to have not posted the auto link if the post just contained the one word, right? It works if I use the auto links in sentences.. I'm assuming that was done to prevent spammers of some sort?

Anyways, it's working.. thanks again Geek.

The Geek
04-21-2005, 01:08 PM
It's working. I'm just slow. It's supposed to have not posted the auto link if the post just contained the one word, right? It works if I use the auto links in sentences.. I'm assuming that was done to prevent spammers of some sort?

Anyways, it's working.. thanks again Geek.
its to prevent breaking of url's. Only words with spaces before them can get linked in safe mode. Glad to hear its working though ;)

Lionel
04-23-2005, 10:02 PM
This is not really an important question but it bothers me. Why would Class DEF shows the link with the dotted lines sometimes and then sometimes not?

Visions
04-24-2005, 02:07 AM
Any Progress on the CMPS integration?

Tom1234
04-24-2005, 06:30 AM
Geek,

Has GISH been released as it's own hack to help other hackers automate the file edits of their hacks?

The Geek
04-24-2005, 07:30 AM
lionel - my guess would be a styles issue? Is the DEF class in all styles?

Visons1- To be honest - I havent looked into it. I would suspect it would be trivial and if you bug me in a couple days ill look into it for you.

Tom - I was working on it however vb3.1 will do most hack management/installations so there really isnt much reason to spend much more time on it.
Saying that - Im not too bothered if anyone uses it. Maybe ill stick it up for release for anyone that wants to use it in the iterim.

memobug
04-24-2005, 09:20 AM
Hi TNG, I am having an odd problem.

The links themselves seem to work but the title is messed up because it is encased in two sets of single ' 'like this' ' not one set of double quotes "like this"

Please note that these are different.

My output code looks like this:

Please note that is two single quotes ' ' Onsite_Link ' ' not one set of doubles "Onsite_Link" or one set of singles 'Onsite_Link'

Regards,

Matt

<a href='http://(omitted)' target='_SELF' class='DEF' title=''Onsite_Link''><!--GAL_REMOVAL--> memory stick</a>

The Geek
04-24-2005, 09:25 AM
Hi TNG, I am having an odd problem.

The links themselves seem to work but the title is messed up because it is encased in two sets of single ''like this'' not one set of double parens "like this"

Please note that these are different.

My output code looks like this:

Please note that is two single quotes ' ' Onsite Link ' ' not one set of doubles "Onsite_Link"

Regards,

Matt

<a href='http://www.pspfreaks.com/reviews/showproduct.php/product/21' target='_SELF' class='DEF' title=''Onsite_Link''><!--GAL_REMOVAL--> memory stick</a>
try escaping them \"like this \" and tell me if that works.

Thanks

memobug
04-24-2005, 09:27 AM
try escaping them \"like this \" and tell me if that works.

Thanks

There's nothing to escape. My description has no escapables in it. Just one word.

HELP

and it comes out like this

''HELP''

like this ' 'HELP' '
but with no space between them

target='_SELF' class='DEF' title=''HELP''


Anyway I put in \"TEST\" as you suggest, although I hope you understand I don't want any quotes, but anyway I got this:

<a href='http://...' target='_blank' class='DEF' title=''\\"TEST\\"''>psp</a> playing nes games.

that is

<a href='http://...' target='_blank' class='DEF' title=''\\"TEST\\"''>psp</a> playing nes games.

Regards,

Matt

memobug
04-24-2005, 10:04 AM
It also looks like the readme is out of date on the last section for individual link items.

The readme document has Replace Text, Link, Ignore threadid, Alt and Ordinal

The ones in the release are Replacement Text, Link, Ignore threadid, Description, Ordinal, Category Name, Replacement code.

The Geek
04-24-2005, 10:37 AM
It also looks like the readme is out of date on the last section for individual link items.

The readme document has Replace Text, Link, Ignore threadid, Alt and Ordinal

The ones in the release are Replacement Text, Link, Ignore threadid, Description, Ordinal, Category Name, Replacement code.
thanks memo. Ill update soon (am working on next release to support GAB).

Back to your problem. Im not sure what you are trying to do. Are you saying that you do not want the title parameter to have any quotes around it at all?

memobug
04-24-2005, 11:17 AM
Hi TNG,

I am not trying to do anything special at all other than get the titles to work right. I am not being clear, but I am trying to say that the TITLE description is not working at all. It is broken.

All I can tell you is this:

I put TEST in the description box.

In the alt text GALsurrounds that word text with two single quotes on each side. Not a pair of double quotes "TEST", not a pair of single quotes 'TEST' (either of those would work.) But what I get is TWO PAIR OF SINGLE QUOTES two on each side


<a href='http://...' target='_blank' class='DEF' title=''TEST''>psp</a> playing nes games.

That doesn't work. How can I explain this better?

It should just have a single set of quotes around it like this

<a href='http://...' target='_blank' class='DEF' title='TEST'>psp</a> playing nes games.

with four quote marks, if you have two words in the title, it really messes up the tag. I am trying to explain to you that it's broken but I don't know how to.

You have an extra quote in there.

Regards,

Matt

You asked me to escape it, there is nothing to escape, but I escaped it anyway and I posted the results above.

The Geek
04-24-2005, 11:43 AM
Hi TNG,

I am not trying to do anything special at all other than get the titles to work right. I am not being clear, but I am trying to say that the TITLE description is not working at all. It is broken.

All I can tell you is this:

I put TEST in the description box.

In the alt text GALsurrounds that word text with two single quotes on each side. Not a pair of double quotes "TEST", not a pair of single quotes 'TEST' (either of those would work.) But what I get is TWO PAIR OF SINGLE QUOTES two on each side


<a href='http://...' target='_blank' class='DEF' title=''TEST''>psp</a> playing nes games.

That doesn't work. How can I explain this better?

It should just have a single set of quotes around it like this

<a href='http://...' target='_blank' class='DEF' title='TEST'>psp</a> playing nes games.

with four quote marks, if you have two words in the title, it really messes up the tag. I am trying to explain to you that it's broken but I don't know how to.

You have an extra quote in there.

Regards,

Matt

You asked me to escape it, there is nothing to escape, but I escaped it anyway and I posted the results above.
do you have anything in the replacement code

memobug
04-24-2005, 12:13 PM
do you have anything in the replacement code

No there is nothing there, but I put it in and it didn't make any difference.

<a href='http://www.pspfreaks.com' target='_SELF' class='DEF' title=' 'TESTING' '>

anyway the replacement text looks like this:
<a href='$link' target='_SELF' class='DEF' title='$description'>$text</a>

That gives me two sets of quotes around the description and breaks all the links unless I take it out like this

<a href='$link' target='_SELF' class='DEF' title=$description>$text</a>

Then it works fine, but I don't think that is what you'd intended!

The only other installation I have seen of 3.0 is the Green Hybrid guy, and the link he posted above http://www.greenhybrid.com/discuss/t1917-automatic-text-links---testing.html

Has his tags totally messed up. I don't know if it's the same problem but it isn't right.

I think the linker has a bug, but sorry I can't describe it to you in a meaningful way. The title tags are broken and there are too many quotes. Do you understand what I am saying?

The Geek
04-24-2005, 03:19 PM
Just remove the single quotes from around $description for now. I think thats what I have.

blueuniverse
04-24-2005, 04:26 PM
Ok, I haven't read the whole thread so I'm not sure if that has been mentioned (or even if it currently implemented) but could you have this working on a per usergroup basis e.g. registered members and unregistered users see it, but those in a paid usergroup don't and therefore don't get the ads (because that is what I'll use it for). This would be even better if it could extend to a per category basis.

The Geek
04-24-2005, 04:36 PM
Ok, I haven't read the whole thread so I'm not sure if that has been mentioned (or even if it currently implemented) but could you have this working on a per usergroup basis e.g. registered members and unregistered users see it, but those in a paid usergroup don't and therefore don't get the ads (because that is what I'll use it for). This would be even better if it could extend to a per category basis.
No its not per usergroup - however its not a bad idea ;)

memobug
04-24-2005, 10:00 PM
Just remove the single quotes from around $description for now. I think thats what I have.

Sorry it doesn't work either.

I tried that but it seems that it falls apart if there are multiple words in the description field. I put

Link to onsite reviews for Need for Speed in the Description field and get this:



<div>I think I like the driving games like <a href='http://www.domain.com/reviews/showproduct.php/product/14' target='_SELF' class='DEF' title='Link to onsite <!--GAL_REMOVAL-->game <!--GAL_REMOVAL-->reviews <!--GAL_REMOVAL-->for <!--GAL_REMOVAL-->Need <!--GAL_REMOVAL-->for <!--GAL_REMOVAL-->Speed'>NFS</a> and



Regards,

Matt

The Geek
04-25-2005, 06:25 AM
let me see if I can get you a new version today.

greenhybrid
04-25-2005, 07:16 PM
Earlier, I had title="$text" because I didn't fill out the descriptions. Right now I'm having a problem where I have links inside of each other. I also had one where if I had, say "Prius's" it would show '> on the page. Or, something like that. I ended up taking the title completely out of the tag.

The Geek
04-26-2005, 06:01 AM
fingers crossed a new version will be out today.

T3MEDIA
04-26-2005, 10:54 AM
please just be file updates no coding...
please just be file updates no coding...
please just be file updates no coding...

Kihon Kata
04-26-2005, 01:04 PM
fingers crossed a new version will be out today.
Oh 3.0 is pretty darn good! So.........wait's patiently to see what changes come

The Geek
04-26-2005, 01:22 PM
Oh 3.0 is pretty darn good! So.........wait's patiently to see what changes come
well the next is far sweeter. However its giving me a mental breakdown in the process.
Basically, the next version is far easier to cusomtize the categories. You can customise the style of the popup per category (ie a sponsor popup and an definition popup).
You will also have the option to track impressions and click thrus. The popups will also be able to expire.
This is all to build up and into the new GAB system.
On the way I made the regex a little smarter so it catches more instances safely and fixed some of the issues that have been brought up lately.

Its almost there.

The Geek
04-26-2005, 01:24 PM
btw: what do you mena no coding media?

The popup js code has changed, a couple lines in functions_showthread have changed and there are a few more admincp options.
That means 3 file edits to do (which is all there ever was ;) ) as for the GAL files themselves - those have all changed :)

Kihon Kata
04-26-2005, 01:25 PM
well the next is far sweeter. However its giving me a mental breakdown in the process.
Basically, the next version is far easier to cusomtize the categories. You can customise the style of the popup per category (ie a sponsor popup and an definition popup).
You will also have the option to track impressions and click thrus. The popups will also be able to expire.
This is all to build up and into the new GAB system.
On the way I made the regex a little smarter so it catches more instances safely and fixed some of the issues that have been brought up lately.

Its almost there.
Oh my lord! You are the true king Geek. This sounds amazing! I'll upgrade mine asap! I am running 3.0 now and our users LOVE the mouseovers.

Taquila takes care of mental breakdowns ;)

Lionel
04-26-2005, 01:25 PM
please just be file updates no coding...
please just be file updates no coding...
please just be file updates no coding...

crossing them too
crossing them too
crossing them too

Kihon Kata
04-26-2005, 01:27 PM
Oh my lord! You are the true king Geek. This sounds amazing! I'll upgrade mine asap! I am running 3.0 now and our users LOVE the mouseovers.

Taquila takes care of mental breakdowns ;)
Oh, pls....if you can, make our upgrade process a smooth one. Thank you very much

Kihon Kata
04-28-2005, 01:48 AM
btw: what do you mena no coding media?

The popup js code has changed, a couple lines in functions_showthread have changed and there are a few more admincp options.
That means 3 file edits to do (which is all there ever was ;) ) as for the GAL files themselves - those have all changed :)
Eta Geek?

The Geek
04-28-2005, 07:34 AM
Trying to get it done today. Most likely have the coding done today and it may take another day for installation.upgrade package.

Just have to see how the rest of the coding goes.

T3MEDIA
04-28-2005, 06:19 PM
For some reason if you have a link on the edge of your articles the box becomes too big and you will never be able to actually click on anything.

Anyone else having this issue?

The Geek
04-28-2005, 06:29 PM
For some reason if you have a link on the edge of your articles the box becomes too big and you will never be able to actually click on anything.

Anyone else having this issue?
do you mean that the popup goes 'out of bounds'?

This has been improved for the next version but I cant say if its totally fixed yet.

New version is about done (and very sweet IMO) - now I ned to do the installer/upgrader :(
Man I cant wait till vb 3.1 comes out. Installers and upgraders chug.

Tom1234
04-28-2005, 09:02 PM
Geek, can you have GAL make autolinks in the post title (not thread title) as well?

libertate
04-29-2005, 01:42 AM
Ok, I installed this great hack. Thank you for making it.

Uhmmm... I do not understand the relationship between "Add new" and "Add category".

What is the difference between the two? I guess Category somehow relates to "new", since it can be picked in the edit, but...

And it doesn't seem to work. I have GAS installed, and I cannot see any of the changes in the articles.

I have a cagetory defined As
Description: ABC
Ordinal: 0
Replacement Code:
$link=http://www.somewhere.com/link/link/link
$description=Dr. ABC
$text=ABC

Then I added "new":

Replacement text : ABC
Link : http://www.somewhere.com/link/link/link
Ignore threadid (dont autolink this thread) 0
Description : Dr. ABC
Ordinal 0
Category name Dr. ABC
Replacement code :
$link=http://www.somewhere.com/link/link/link
$description=Dr. ABC
$text=ABC

Settings:
Safe mode
2
<a href='$link' target='_blank' class='DEF' title='$description'>$text</a>
---
What am I missing? Nowhere where there is ABC is replaced by the link...

limey
04-29-2005, 06:06 PM
I just installed as well, like it alot.

Two suggestions:
add a "duplicate this linked word" button in the admin panel so you can change the certain words from WalMart to walmart without having to retype the whole thing.

Second:
Make the pop up code have hte option of including a "Click to visit link" link in the popup code.

Yeh or nah? :)

The Geek
04-29-2005, 06:39 PM
liberate - check the readme for a good explination of the categories.
Essentially, you can define replacement code as item level, category level or global level.
For instance, if your item and category replacements are blank, but your global replacement is:
<a href='$link' target='_blank' class='DEF' title='$description'>$text</a>
then it will use that code.
$link is the url you specify, $description is the alt text and $text is the word that gets replaced.

LImey - the replace should be case insensitive anyway so it wouldnt make much sense (unless of course there is a bug where its not being case insensitive ;) )

Just wait till 4.0 - Its seriously sweet :)

Shackbase
04-29-2005, 07:05 PM
whats the eta on 4.0 geek? :)

--Tone

The Geek
04-29-2005, 07:18 PM
I always hate seeing this answer from other people... but here goes -
when its done ;)

blech.

Actually its not to far off now. Thought I would have finished the coding by early today but I rewrote it almost all virtually from scratch instead. The problem is I keep getting new ideas that require me to go back and rescrap loads of already written code. Couple that with regex hell (whoever invented it should go there - as brilliant as it is).
It a nutshell I am about 90% of the way done with the code and then I have to do an installer/upgrader.

For those that have not upgraded to 3.0 from 2.6 I would recommend it as I dont think ill include an upgrade from 2.6 to 4.0

I may get lucky and have it Sunday.

venomx
04-30-2005, 03:30 AM
The Geek.

Under Settings theres a Replacement code
Under add new theres Replacement code
Under add new cat theres. Replacement code

How do these work? I thought putting it under Settings would auto fill in the other two when I go to add a new one but nope. If all 3 are filled it does this break anything? If we have it in the settings do we need to add the code when making a new unknown one? What if we have it in the cat and make a new link with that cat. do we need to add it to the link when we make it?

Sorry for so many questions, just wondering why its needed 3 times.. :P

greenhybrid
04-30-2005, 04:19 AM
It seems there's a character limit on link text. Why? I can't use "real hybrid mileage database"

The Geek
04-30-2005, 07:24 AM
hybrid - changed in 4.0 ;)

venom - this has changed in 4.0 as I think it was (and is) confusing to people.
Essentially if you had replacement code in the settings - you didnt ever have to put replacement code in any categories or individual items - it is a 'global' value. However you could 'override' the global by putting replacements in at the category level.
THe idea being that the global would be the default - but then you could have category override it.
FInally - you could also put replacement code at the individual item level which would override the category setting.

Anyway - as handy as it is - I think its confusing and overkill. In 4.0 Most settings are handled at the category level

venomx
04-30-2005, 07:38 AM
I am glad we will have the option to track clicks or not because I just sold 5 links and he only bought them because it was a direct link to his site and not a redirect.. lol

Looks good!

blueuniverse
04-30-2005, 07:42 AM
Is the usergroup feature going to be implemented in v4 (it looks like it from that screenshot) but just to check. :)

The Geek
04-30-2005, 07:46 AM
Is the usergroup feature going to be implemented in v4 (it looks like it from that screenshot) but just to check. :)
yupp

KTBleeding
04-30-2005, 02:34 PM
NICE! That looks like it has covered everything I could want out of a hack like this. Geek, keep it up, you're awesome.

libertate
04-30-2005, 08:08 PM
liberate - check the readme for a good explination of the categories.

Thank you, I get the concept now.

Unfortunatelly, I still do not having working. Not just that, I cannot see the links on your example page either (MMA thing)! I tried both Firefox, and IE still nothing.

Any more suggestions?

The global setting is the default link <a href='$link' target='_blank' class='DEF' onmouseover="GAL_popup(this,$description);" onmouseout="GAL_hidepopup();">$text</a>

ChurchMedia
04-30-2005, 08:14 PM
I didn't see this problem mentioned, but when I edit a link it changes ALL my links to the same information. Then when I delete one it deletes all of them. What do you think is causing that?

The Geek
05-01-2005, 12:07 AM
Thank you, I get the concept now.

Unfortunatelly, I still do not having working. Not just that, I cannot see the links on your example page either (MMA thing)! I tried both Firefox, and IE still nothing.

Any more suggestions?

The global setting is the default link <a href='$link' target='_blank' class='DEF' onmouseover="GAL_popup(this,$description);" onmouseout="GAL_hidepopup();">$text</a>
liberate - my demos down as I am in the final stages of implimenting 4.0 :)
hmmm. your settings look right. Try changing the limit value to 0 to see if that helps. If not - double check your functions_showthread.php edit.

Church - er. Got me. SOunds like a bug however I would have thought that would have come up by now!

----------------------------
progress

Right. I have finially finished coding an RC for 4.0 (I have literally spent about 10 hours on it today). I am just going to iron out a couple of minor issues and work on the extensability (so you can run ANY text through it i.e. PM's, portal text, etc...) Then I will write an installer and most likely release tomorrow.

nJoy ;)

ChurchMedia
05-01-2005, 02:01 AM
Church - er. Got me. SOunds like a bug however I would have thought that would have come up by now!


I deleted the tables and re-ran the installer. It seems to be fine now. Just a weird thang...

Thanks for the cool hack!

libertate
05-01-2005, 02:07 AM
I did the same and seems to work, except for the javascript piece. I get the following link. The description seems correct, except for the GAL_REMOVAL stuff, and that it does not show... Any thoughts?

<a href='http://www.working.com' target='_blank' class='DEF' onmouseover="GAL_popup(this,'Dr. Test\' New test <!--GAL_REMOVAL-->alpha <!--GAL_REMOVAL-->beta <!--GAL_REMOVAL-->gamma <!--GAL_REMOVAL-->delta, <!--GAL_REMOVAL-->Dr. <!--GAL_REMOVAL-->epsilon\' <!--GAL_REMOVAL-->New <!--GAL_REMOVAL-->test <!--GAL_REMOVAL-->package.');" onmouseout="GAL_hidepopup();">replaceme</a>

An other minor "bug" I found. If the message contains html anchor for a link, then the text within the anchor open and close still gets processed.

i.e.
Text to replace : TEST
with : <a href="http://www.otherexample.com">test</a>


Original text:

<a hre="http://www.example.com">this is a test big one!</a>

Resulting text after GAL

<a hre="http://www.example.com">this is a <a href="http://www.otherexample.com">test</a> big one!</a>


This is also the case when regular BBCode URL is used.

As for the ordinals - Great! It works perfectly. When there is a "collission" the ordinals take care of it. i.e. when I have "Bob" and "Bob Smith" whichever has the lower ordinal will be the one executed. Not just that, if the first ordinal is exhausted through the "Limit replacement" order, the next occurence is used... Awesome!

This is like an Amazon money machine!

The Geek
05-01-2005, 07:44 AM
re: the js code - are you sure the change to vbulletin_menu.js has been made and that you have stuck the popup html in one of your templates (i.e. header)?
The gal removal is to prevent your description getting autolinked (which could screw it up big time).

There is no way to (sanely) discover if the text is already in a link. I minimise it as much as possible with safemode.

The Geek
05-03-2005, 02:18 PM
note:

GAL 4.0RC1 is in the beat section here-> https://vborg.vbsupport.ru/showthread.php?t=80929

memobug
05-06-2005, 08:03 AM
This site has some really sophisticated rollovers. I haven't played with the JS here with GAL, but can it do something like this? See the green links when you hover.

http://psp.ign.com/articles/599/599236p1.html


Regards,

Matt

venomx
05-06-2005, 08:35 AM
If someone has the code for that I would love to have it hehe
Just the popup part...

The Geek
05-06-2005, 09:28 AM
You can do that with GAL4

T3MEDIA
05-06-2005, 11:50 AM
This site has some really sophisticated rollovers. I haven't played with the JS here with GAL, but can it do something like this? See the green links when you hover.

http://psp.ign.com/articles/599/599236p1.html


Regards,

MattListen if ANYONE has the DHTML that can do that please advise!

The Geek
05-06-2005, 12:47 PM
Listen if ANYONE has the DHTML that can do that please advise!
we are talking about the advertising rollover from msn right?

venomx
05-06-2005, 05:51 PM
I think I am :)

gilbert
05-06-2005, 07:39 PM
How do i enter a 2 word phrase?

venomx
05-06-2005, 07:48 PM
Just enter it...

gilbert
05-06-2005, 07:52 PM
doesnt work, I entered a 2 word phrase and no link gets added

KAC
05-07-2005, 01:16 PM
Can you keep the popup box from coming up?

venomx
05-07-2005, 01:21 PM
KAC yes..

gilbert
05-07-2005, 06:10 PM
Still havent figured it out. can anyone help

KAC
05-07-2005, 10:02 PM
I can get it to install. I have CHMODED the folder to 777 but I get a whole list of errors. I manually edited the files and still nothing. Should there not be a selection in the admin panel for this? If so its not there.

KAC
05-07-2005, 10:06 PM
Nevermind. It did not do the edit. Thanxs for all the help.

KAC
05-07-2005, 10:50 PM
Ok, I have ran into another prob. I got autolinker to work but when I go to install autobanner I get this.

Parse error: parse error in /home/virtual/site33/fst/var/www/html/vb/admincp/index.php on line 591

Can I not use both hacks?

KAC
05-07-2005, 10:51 PM
Advertising and Banner system not AutoBanner. Sorry about that.

The Geek
05-08-2005, 06:43 AM
Are you talking about GAB or GAL? This is the thread for Geek Autolinker 3.0
The Gab thread is in the beta forum

venomx
05-08-2005, 06:48 AM
The Geek,

I was messing around with a member who asked why some words had dotted underlines. I posted the following

word1 word2 word3 word4 word5 word6

Only word2 word4 word5 and word6 changed to a link.. when I posted Wonder why word1 and word3 didnt work. they did in that reply.

Ideas?

gilbert
05-09-2005, 05:38 AM
How do i enter a 2 word phrase?
i have the same question

venomx
05-09-2005, 05:48 AM
I just set up testing this and when I posted testing this was linked...

The Geek
05-09-2005, 08:02 AM
I just set up testing this and when I posted testing this was linked...
are you using 3.0 or 4.0?

4.0 is much better at matching. Check out the source as well to make sure there is no formating around the words.

As far as two word phrases - just put it in as you would one word.

Jagged Tooth
05-09-2005, 10:03 AM
Cool hack, I just noticed that in the unistaller the you spelt "uninstall" as "uinstall" by accident I pressume. Anyway

/me Clicks Install

--Jagged Tooth--

fabrizio
05-09-2005, 03:05 PM
Excuse me guys,
I have just installed it and everything worked great, but now? How can I use it? How can I configure it? I cannot find any instructions or manual about it and I cannot find any link in my admin CP to Geek Autolinker... any suggestion?

Thank you.

Sincerely,
Fabrizio

The Geek
05-09-2005, 04:25 PM
Excuse me guys,
I have just installed it and everything worked great, but now? How can I use it? How can I configure it? I cannot find any instructions or manual about it and I cannot find any link in my admin CP to Geek Autolinker... any suggestion?

Thank you.

Sincerely,
Fabrizio
check your gish folder for the changed files as per the readme. Doesnt sound like you copied them over.

fabrizio
05-09-2005, 05:38 PM
Thank you for your reply.

Actually I had to reinstall it because it was not able to update the index.php file in the admincp directory, so I had to do it myself.

I have only a problem: when I click on the "Edit" link on a record of my replacements in the Display list of Geek AutoLink Manager, the form is empty, no information is displayed about the listing... any idea?

Also the description is not displayed int he browser because the code is written in this way:

<A href='http://www.virtualsheetmusic.com/Downloads.html' class='DEF' title=''browse our entire catalog of instantly downloadable sheet music.''>our catalog</A>

I don't know why Geek adds two '' in the title attribute by making it unusable and the link actually wrong... I solved the problem by changing the replacement code as following (by removing the two ' in the title attribute):

<a href='$link' class='DEF' title=$description>$text</a>


Thank you again.

All the best,
Fabrizio.

MichaelJM13k
05-10-2005, 04:14 AM
Where do i go in my AdminCP to define a keyword and edit settings?

fabrizio
05-10-2005, 04:43 AM
Under "Geek AutoLink Manager" click "Add new"

MichaelJM13k
05-10-2005, 05:00 AM
Yeah, it wasn't showing up but i fixed it.

Jagged Tooth
05-10-2005, 12:00 PM
I have just recently noticed that when you have formating such as bold, colour changes, etc. It will get rid of it a turn it in to just plain text (hyperlinked of course) Here is an Example (http://forums.runevengeance.com/showthread.php?p=72#post72) from my fourm you will notice that the work "Runescape" is white and the rest is bold and red. Anyway of fixing this?

The Geek
05-10-2005, 01:18 PM
I have just recently noticed that when you have formating such as bold, colour changes, etc. It will get rid of it a turn it in to just plain text (hyperlinked of course) Here is an Example (http://forums.runevengeance.com/showthread.php?p=72#post72) from my fourm you will notice that the work "Runescape" is white and the rest is bold and red. Anyway of fixing this?
danger mode is the only way and I wouldnt advise it. The problem is that safe mode links words with a preceeding space to prevent messing up URLs and HTML code. If there isnt a space (in the case <b>keyword is here</b>) then it wont link as there is no match.
4.0 is better at matching - but only marginal. It still wouldnt match the above example.
You could alter the regexp to make exceptions for certain preceeding markup - but only for a few and I dont think its worth it in the end (performance wise). To come up with a regex that would safely determine if the word was not in a URL, would be a freaking amazing task that would most likely slow your server to a crawl.

fabrizio
05-10-2005, 04:04 PM
Anyone know why when I click on the "Edit" link on a record of my replacements in the Display list of Geek AutoLink Manager, the form is empty, no information is displayed about the listing... any idea?

The Geek
05-10-2005, 04:06 PM
on the "Edit" link on a record of my replacements in the Display list of Geek AutoLink Manager, the form is empty, no information is displayed about the

What - its blank? A white page?

The Geek
05-10-2005, 04:41 PM
4.0 released.

nJoy

venomx
05-10-2005, 04:48 PM
Mod Version: 3.00 <-- Needs updated! hehe
thanks Geek!

Shackbase
05-10-2005, 04:49 PM
AWESOME! Thank you - is there a list of new things or am I just missing it?

Thank you Geek!

--Tone

oops:

Now in 4.0 you can create popups, track impressions and click-thrus, get statistics on them and specify more attributes of the links. The popups can now also use bbcode to create virtually any kind of popup you could imagine. You can limit categories of links to certain forums and also enable specific usergroups to toggle GALs on or off (by category).

venomx
05-10-2005, 05:19 PM
Fatal error: Call to undefined function: process_gal_text() in /home/forum/public_html/forums/includes/functions_showthread.php on line 956

The Geek
05-10-2005, 05:22 PM
Fatal error: Call to undefined function: process_gal_text() in /home/forum/public_html/forums/includes/functions_showthread.php on line 956
did you do the file changes? ie. global.php? And did you copy it from gish/gal/4.00 ?

venomx
05-10-2005, 05:26 PM
I had to do a few of them myself but the rest said they was done... :(
I edited the files in the gish/gal/4.00 for the ones missed then uploaded them all to the dir...

venomx
05-10-2005, 05:30 PM
Seems the auto upgrade didnt change global.php It doesnt even meantion it or upload it to the gish dir.

I edited it now the forum shows but I get this error at the top of the page
Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117

The Geek
05-10-2005, 05:40 PM
shows but I get this error at the top of the page
Warning: Invalid argument supplied for

Make sure you add the new styles and new replacements listed in the readme.

venomx
05-10-2005, 05:51 PM
I did and some of the words were not being linked.. I tried making a new post with a word to be linked.. I got like 25 of these..

Warning: Empty regular expression in /includes/functions_gal.php on line 106

And a warning where the thread should be saying

Unable to add cookies, header already sent.
File: /home/forum/public_html/forums/includes/init.php
Line: 27

venomx
05-10-2005, 06:08 PM
Found the problem!!!
I had to edit every listing. The cached stuff had to be set that way. :(
I dont remember seeing that in the install file hehe :P

Also if you change the Style of any of the Catagories youll need to edit every listing under it to update them.

venomx
05-10-2005, 06:11 PM
Under Catagories whats the difference between Box style and Style? They seem to be the same name...

The Geek
05-10-2005, 06:19 PM
Under Catagories whats the difference between Box style and Style? They seem to be the same name...
Box style is the table style/class, title style is the title td style or class and style is the text area style/class all depends on your settings. Its generally best to only use the box style if you can help it.

BTW: usually just clicking debug->rebuild sorts out most caching problems.

Lizard King
05-10-2005, 06:20 PM
Box style is the table style/class, title style is the title td style or class and style is the text area style/class all depends on your settings. Its generally best to only use the box style if you can help it.

BTW: usually just clicking debug->rebuild sorts out most caching problems.
Geek can you give an example how to make the pop up with td style :)

venomx
05-10-2005, 06:35 PM
Seems I have to use Box style hehe cause if I use just Style the popup is clear and you see whats under it. :)

If we use Box style what should Style be? none?

For Persist impressions thottle level is Settings I have 4. This mean I now rely on the cron job to run to show stats if linked listings show on the page more than 4 times?

One more question if you dont mind... How does it track clicks if you have it set to? NM I see it changes the link :)

The Geek
05-10-2005, 07:33 PM
The td stuff is done behind the scenes. All you do is specify the class name or the style css for it to use.
The box style does HAVE to be set to something. Other than that - I would generally only bother setting the title (if the category had one).

Venom - yes, on results with less than you throttle - the cron will record the impressions. Pages with fewer than 4 would appear real time though.
If you set no for tracking clicks - it just links the..er... link ;) Otherwise it sends them to a redirect (once it records the click).

venomx
05-10-2005, 07:42 PM
So I can just pick Yellow Box Yello Box and Gray Title?

Will that cause a prob?

The Geek
05-10-2005, 08:22 PM
So I can just pick Yellow Box Yello Box and Gray Title?

Will that cause a prob?
nope - should be fine

libertate
05-10-2005, 11:31 PM
Found the problem!!!
I had to edit every listing. The cached stuff had to be set that way. :(
I dont remember seeing that in the install file hehe :P

Also if you change the Style of any of the Catagories youll need to edit every listing under it to update them.

I continue to have the same problem...
Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117
Despite rolling everything back, and re-doing, then going through your steps (or at least I think I did those steps...)

Any other suggestions? I checked each file, copied them into the right place, added the styles to CSS, re-saved all the data, turned on the DB cache, ran debug/rebuild... :cry:

fabrizio
05-11-2005, 01:05 AM
Same problem folks! Here it is:

Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117

and here is a sample of a thread showing the error:

http://www.virtualsheetmusic.com/forums/showthread.php?p=32


Please, how to fix it? I need to do it as soon as possible! Thanks.

Fab.

fabrizio
05-11-2005, 02:53 AM
Since I have not yet received a reply about this issue, I am going to restore my forums and try to re-install it again, then I will let you know the results.

Thank you.

Fab.

SEO Report
05-11-2005, 03:14 AM
Same problem folks! Here it is:

Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117

and here is a sample of a thread showing the error:

http://www.virtualsheetmusic.com/forums/showthread.php?p=32


Please, how to fix it? I need to do it as soon as possible! Thanks.

Fab.

Same here :angry: I had to comment this line in showthread.php:

persist_gal_impressions();

It worked just fine in RC 2, strange...

-k

fabrizio
05-11-2005, 03:17 AM
Yes, by commenting that line removes the problem but makes the Geek AutoLinker unusable.

May I ask you if you upgraded from a previous version or did a clean install of the new Geek AutoLinker? I am tying to do a new clean install now, I will post the results very soon...

Thank you.

Fab.

fabrizio
05-11-2005, 03:38 AM
-k,
here is my experience:

1. I restored my vBulletin as "just installed" (without hacks or mods)

2. I did a clean install of Geek AutoLinker 4.0

3. The installer worked fine (no errors).

4. The "Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117" issue persists...

5. By commenting the mentioned line in showthread.php the problem disappears but the standard link replacement in Geek AutoLinker works anyway! (Yes, I was wrong...).

So, my question is: what I am missing by commenting that line in showthread.php? The basic feature of Geeck Autolinker seems to work fine (I don't know if I will use the new tracking and pop-ups features at the moment...).

Any idea is very welcome.

Thank you again.

Fab.

venomx
05-11-2005, 03:52 AM
Same problem folks! Here it is:

Warning: Invalid argument supplied for foreach() in /includes/functions_gal.php on line 117

and here is a sample of a thread showing the error:

http://www.virtualsheetmusic.com/forums/showthread.php?p=32


Please, how to fix it? I need to do it as soon as possible! Thanks.

Fab.

When I first visited that URL I got a white page, a refresh worked fine with no errors...

venomx
05-11-2005, 03:54 AM
Database error in vBulletin 3.0.7:

Invalid SQL: UPDATE geek_autolink SET view=views+5
WHERE id=
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 2

mysql error number: 1064

My cron just ran and I got that error in an email. :(

Edit: I tried a Run now on the cron, no error. I then set it to run every minute and it gives no error.

But I notice in my stats I am seeming to be missing something.. The stats show as:

Sponsors Statistics
Amazon 0 1 0% <-- Shouldnt there be a Hits: and Views: there or above?

T3MEDIA
05-11-2005, 04:08 AM
Its it only me but my stickies are now see thru. my pop ups seem to have no background????

venomx
05-11-2005, 04:09 AM
Its it only me but my stickies are now see thru. my pop ups seem to have no background????

Try editing all the listings...

venomx
05-11-2005, 04:20 AM
Spoke too soon. Still getting the error. :(

The Geek
05-11-2005, 05:59 AM
found the bug. It was simply an unchecked empty aray (epty if no results impressions were present). DOnt know why this didnt come up in beta ?!?

Anyhow... Its fixed. Download the latest package and replace your functions_gal.php

t3Media- change the Box style to something other than none.

nJoy

fly
05-11-2005, 03:58 PM
Yikes. I'm still getting a boatload of errors. I'm just rolling it back for now. I'll go through it tomorrow or maybe there will be an update by then. Sorry for the lack of info, but I'm really pressed for time.

TTG
05-11-2005, 04:07 PM
Any luck in solving changing the Popup offset having no effect ?

handholder
05-11-2005, 04:11 PM
hi geek,thanks for gal 4.0

here i have a problem

[QUOTE]
Warning: Invalid argument supplied for foreach() in /admincp/GAL_admin.php on line 2069
[QUOTE]

when i click "stats",then program display this error . and why after i added categories and added keyword , but program still not working on my forum?
i was install gal4.0 with "step by step" mode

kevinrstruck
05-11-2005, 04:24 PM
Warning: Invalid argument supplied for foreach() in /admincp/GAL_admin.php on line 2069
[QUOTE]

when i click "stats",then program display this error . and why after i added categories and added keyword , but program still not working on my forum?
i was install gal4.0 with "step by step" mode


I have the same problem after upgrading...

The Geek
05-11-2005, 04:25 PM
ttg - no word on offset problem. Is it a problem for you?

Flypaper - I need some more info when you get a minute.

Handholder - If you are not getting any results - make sure that you copied the modified files from the gish/gab folder

kevinrstruck
05-11-2005, 08:12 PM
YIKES. I get this when one of my keywords comes up:

href='autolink.php?id=31&script=showthread&forumid=16' target='_blank' class='DEF' onmouseover='GAL_popup(this,1, 0, "style=\"border: 1pt solid #000000;background: #FFFFCC;padding: 1px;font: 8pt;\"", "", "class=\"border: 1pt solid #000000;background: #FFFFCC;padding: 1px;font: 8pt;\"", "Sponsor ThePhotoStation.net", "style=\"border-top: 1px solid black;border-left: 1px solid black;border-right: 1px solid black;background: #CCCCCC;padding: 1px;font: 8pt;font-weight: bold;color: #000000;\"");' onmouseout='GAL_hidepopup();'>

That is the keyword.

What did I miss or do wrong. I went through all the file edits manually, maybe I missed one or did one wrong?

Example Thread: http://thephotostation.net/forums/showthread.php?t=12780

venomx
05-11-2005, 08:24 PM
Did you forget the < a in the settings for the code to use to replace?

kevinrstruck
05-11-2005, 08:26 PM
Did you forget the < a in the settings for the code to use to replace?


No, checked it and it looks fine:

<a href='$gal_link' target='_blank' class='DEF' onmouseover='GAL_popup(this,$gal_offset, $gal_width, "$gal_box_style", "$gal_description", "$gal_description_style", "$gal_title_prefix $gal_title", "$gal_title_style");' onmouseout='GAL_hidepopup();'>$gal_text</a>

venomx
05-11-2005, 08:38 PM
Check in replacements..

Hmm not sure then.. Maybe The Geek will know.. :(

T3MEDIA
05-11-2005, 08:52 PM
all of a sudden... photopost index.php page wont load.
almost as if the file is deleted but it is there.
the admin of photopost says it must be javascript... any ideas?

This is the only hack for that system.