Major Additions - iTrader v2.0.1 [Archive]

eoc_Jason

12-13-2005, 10:00 PM

iTrader - A user feedback add-on for vBulletin 3.5.x
Copyright ?2004-2005 Jason Rabel, All Rights Reserved.
__________________________________
Latest iTrader Verson: 2.0.1
vB Versions Supported: 3.5.x & 3.6.x
Author: Jason Rabel
Contact: PM me here.
Site: EXTREME Overclocking (http://www.extremeoverclocking.com/)
??????????????????????????????????
Description:
iTrader for vB 3.5.x & 3.6.x has evolved from Trader Ratings for vB 3.0.x which evolved from Buy/Sell/Trade User Rating System for vB 2.x. This is a rating system for when members buy / sell / trade items from each other (presumably on a FS section of your forum). It is somewhat based on the honor system since there is no automatic way to truly tell if they did engage in a transaction. iTrader came about because it was a pain to try and maintain a single thread listing good / bad traders and so far has worked out quite well.

Features:

Rate another member: Positive / Negative / Neutral
Specify in each transaction: Buyer, Seller, or Trade
Leave multiple comments about the deal
Dates & IPs are all recorded to prevent abuse
Specify a thread URL to the deal
Advanced URL checking
Display ratings over time
Filter based on Buyer/Seller/Trade/or feedback they left for others
Users can edit/delete ratings left for others (time based limitation)
iTrader Admins can edit/delete anyone's ratings (just incase)
PM notification when new rating or comment is left
Per-usergroup permissions
Lots of admin controllable options

Installation / Upgrade Info:
Read the included readme file, it explains everything.

Standard Disclaimer:
BACKUP YOUR DATABASE & FILES BEFORE IMPLEMENTING THIS HACK!!!

Donations:
This add-on will always be free, however your donations are kindly accepted and will help towards further development. The link is on the right under "The Developer" info. :)

Future Additions:

AdminCP & ModCP Menus for searching IPs, stats, mass-prune, etc
Better navigation across pages
Better error descriptions
Adjust action icons some
Page to link two ratings manually
AdminCP Option to choose how ratings are ordered (asc or desc by time)
AJAX editing

Release History:
2.0.1 - December 18, 2005
2.0.0 - December 14, 2005

Detailed template edits : (Link (https://vborg.vbsupport.ru/showthread.php?p=1255117#post1255117))

eoc_Jason

12-14-2005, 07:16 PM

Before anyone asks... The necessary info to upgrade from Trader Ratings 3.0.x is included in the zip file...

JulianD

12-14-2005, 07:17 PM

Thanks Jason!! upgrading right now!

Wait for my comments.

lanc3lot

12-14-2005, 07:26 PM

Damn i have lost the first reply :(

My damn phone call :(

Cheers, going to test it now:)

ImportPassion

12-14-2005, 07:26 PM

sweet. thanks dood!

mrderanged

12-14-2005, 07:27 PM

Jason,

First off thanks for your dedication in porting this to 3.5!!!

Quick question for you. I haven't installed this yet, but intend to as soon as possible.

I know that there are 3 choices "Buyer, Seller and Trade". How hard would it be to implement a 4th choice?

My forum deals with exotic pets (tarantulas mostly) and we do "breeding loans" and I would be interested in using this for feedback for that as well, so I would need that choice (in addition to the other 3) and the ability to group those transactions on the itrader page (like you can just view buyer, seller, trade or left feedback transactions currently)

Thanks for any info you could give,

Scott

eoc_Jason

12-14-2005, 07:28 PM

Yes, please let me know if it does not install correctly or something is missing! It shouldn't though since I developed it on a separate forum than my main one, and it installed on there okay.

I'm going to be gone for about 30min (from when I post this comment), so if someone else in this thread reports something is broken, please wait to download it so I can fix it.

Scott - It shouldn't be too difficult... Mostly just where it does the checks for transaction type, add a couple phrases & modify the templates.

grimmer

12-14-2005, 07:32 PM

i think i just had a joygasam....

dsotmoon

12-14-2005, 07:35 PM

thank you jason, going to install this evening

The Wise One

12-14-2005, 07:37 PM

installing on my test board now. will post a bit later when i have finished testing.

much thanks for all the hard work you put into this. im certain it wont dissapoint!

orban

12-14-2005, 07:38 PM

Where is that "home page" of the trader ratings? Where you could see latest trades and all?

lazyseller

12-14-2005, 07:39 PM

wow you made alot of people happy......... there are probally hundreds of 3.0 users waiting for this before they upgrade..

dieselpowered

12-14-2005, 07:43 PM

Well done again jason!!!!

Kihon Kata

12-14-2005, 07:51 PM

Gunna love this....

JulianD

12-14-2005, 07:52 PM

Successfully installed and upgraded on my live forums... I haven't opened the system to my users because it's not translated yet to spanish but everything seems to be working fine!

evenmonkeys

12-14-2005, 07:54 PM

Oh my god... just wet myself. Thanks!

eoc_Jason

12-14-2005, 07:59 PM

Where is that "home page" of the trader ratings? Where you could see latest trades and all?

There is no "home page" like there was on the old version. It really didn't provide relevant data, it was more of just a 'cool to look at' thing. When I get the admin / mod pages completed there will be a page similar to that so the staff can see what's going on.

There is still a lot of things to do, but right now the core stuff works. The admin pages will end up containing some stats stuff, IP search, etc...

lazyseller

12-14-2005, 08:18 PM

allowing users to change and delete their feedback whats a good setting for this ? i run an automotive site

dsotmoon

12-14-2005, 08:26 PM

Kihon Kata

12-14-2005, 08:31 PM

That is my line, don't steal it LOL

Oh my god... just wet myself. Thanks!

orban

12-14-2005, 08:34 PM

Noonster

12-14-2005, 08:34 PM

Installed - everything imported from old version without a problem and its working PERFECTLY!!!

Thanks :D

lexx27

12-14-2005, 08:41 PM

I like it! Nice Job

Spinball

12-14-2005, 08:44 PM

Thanks, Jason.
I clicked 'Begin Data Conversion' to upgrade and the browser timed out.
Reluctant to click it again.
What now?

[Edit - 21476 rows in the user_rate_trade table and 1923 rows in the itrader table]
[Edit 2 : If you want me to run this manually, will this SQL statement work? (I don't have any table prefix)? INSERT INTO itrader (userid, rateduserid, rating, buyselltrade, subject, dealurl, dateline) SELECT userid, rateduser, userrating, userbuysell, usercomments, userurl, userdate from user_rate_trade

puertoblack2003

12-14-2005, 09:28 PM

ok cool hack and **installed** :rolleyes: i want to do a test on it now where do i go and use the trader on a user? :ermm: :nervous:

dsotmoon

12-14-2005, 09:30 PM

ok cool hack and **installed** :rolleyes: i want to do a test on it now where do i go and use the trader on a user? :ermm: :nervous:

did you read the template info file and add it to your templates?, this will let users access it from postbit or memberinfo

coolgus

12-14-2005, 09:36 PM

Thank you Jason for all your work

2fast4ya

12-14-2005, 09:39 PM

Hello. I have 3.5, and i'm doing a fresh install of this hack. I've done all the uploads and plugins. I'm a bit stumped on the tempelate part though. Please consider I am a noob at this, and I beleive your explenation is a little too advanced for me to comprehend. Can you please assist me so I can finish this install? Thank you.

puertoblack2003

12-14-2005, 09:40 PM

did you read the template info file and add it to your templates?, this will let users access it from postbit or memberinfo

thanks, missed that part... :nervous:

akoj

12-14-2005, 09:45 PM

THANKS!! Upgraded on live board and all went well. In the process of deciding where to add in memberinfo and member_results...anyone have any creative ideas? :ermm:

coloradok5

12-14-2005, 09:57 PM

Awesome, can you restict the use of this to people in a secondary group? Would like to have it so everyone can view but only members in a secondary usergroup could leave feedback.

tylercruz

12-14-2005, 09:59 PM

Have it up and running at DomainForums.com

AWI

12-14-2005, 10:00 PM

Thanks man, installed on 3.5.2 and no problems to report.

eoc_Jason

12-14-2005, 10:05 PM

just installed on my live board, easy, easy install, great job Jason

while i was testing it out I noticed one thing maybe for the future...

when you edit additional comments via the detail page or post a reply it doesnt give you an easy way to get back to the detail page of the person you are editing without hitting the back button

hope that makes sense? not a biggie, just maybe a convenience add on for the future

thanks again Jason! awesome job

No sure what you mean exactly. After you submit a comment or edit it stays on the detail page. If you mean the user summary page, you *might* be able to via the navbits, otherwise you can click on their name that makes up the summary info in the top two rows. If that is not what you are looking for please be a bit more specific and I will see what I can do.

Thanks, Jason.
I clicked 'Begin Data Conversion' to upgrade and the browser timed out.
Reluctant to click it again.
What now?

[Edit - 21476 rows in the user_rate_trade table and 1923 rows in the itrader table]
[Edit 2 : If you want me to run this manually, will this SQL statement work? (I don't have any table prefix)?

You would end up with duplicate ratings, truncate the itrader table first. Yes that query *should* work. However after you do that you will need to run a global score update. There is an included PHP file to do that, it's in the extras/admincp folder in the zip.

----------------------------------------

Sorry I was short on the documentation. It was actually longer but I overwrote one of the files after I spent a bunch of time typing it all out so I had to start it over from scratch and just didn't have the energy to re-do it all as indepth again. I will write out better documentation when I get a little free time, or someone else is more than welcome to. ;)

I'm about to update the topbox thingy in this thread with the planned additions for the next update. However, I will say this now do not expect an update until after christmas or maybe even new years. (Unless there is a bug / flaw, those gets fixed asap).

dsotmoon

12-14-2005, 10:06 PM

THANKS!! Upgraded on live board and all went well. In the process of deciding where to add in memberinfo and member_results...anyone have any creative ideas? :ermm:

i added this to memberinfo under usernotes...


<div class="panel">
<div style="padding:;">
<fieldset class="fieldset">
<legend>$userinfo[username]s iTrader</legend>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
<tr>
<td>
iTrader: (<b><a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a></b>)
</td>
</tr>
</table>
</fieldset>
</div>
</div>

eoc_Jason

12-14-2005, 10:07 PM

Hmm... not 100% sure, but it *should* work properly as long as you set the primary group to view but not rate, then the other group to both view & rate. I do not use secondary groups on my forum, sorry.

If it doesn't work let me know, and I can look into it further.

Awesome, can you restict the use of this to people in a secondary group? Would like to have it so everyone can view but only members in a secondary usergroup could leave feedback.

dsotmoon - Could you please refrain from using the name "Trader Ratings", the product name is "iTrader"... I will hopefully be releasing a slightly different addon for vB with the name "Trader Ratings" and do not want people to get the two products confused.

iTrader = Local (forum) ratings only
Trader Ratings = Global ratings (same ratings over many forums)

akoj

12-14-2005, 10:12 PM

One, hopefully quick, thing I can't figure out....

I decided to set up the members_resultsbit like this:

hollyhobby420
iTrader: ()
Newbie

However, the trade number will not show...even for people who have feedback...have it in the template as such:

<tr align="center">
<td class="alt1Active" align="$stylevar[left]" id="u$userinfo[userid]">
<a href="member.php?$session[sessionurl]u=$userinfo[userid]">$userinfo[musername]</a>
<div>iTrader: (<b><a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a></b>)</div>
<if condition="$show['usertitlecol']"><div class="smallfont">$userinfo[usertitle]</div></if>
</td>

Can someone please tell me what I am doing wrong? The value is showing in the parathesis in the member info area.

The Wise One

12-14-2005, 10:12 PM

ok got it installed with zero problems. very nice!

im trying to tweak the MEMBERINFO template a little. id like to add the Feedback Score and Positive Feedback percentage but it wont show. so far ive tried adding the following code:

$userinfo[tradepcnt]%

$userinfo[tradescore]

neither of which are working. $vbphrase[itrader_positive_feedback]: isnt working either.

ive also tried including functions_itrader.php and itrader_global.php to member.php. that also didnt work.

is there a relatively easy way to make this work? i dont mind file edits.

dsotmoon

12-14-2005, 10:14 PM

dsotmoon - Could you please refrain from using the name "Trader Ratings", the product name is "iTrader"...

sure no problem, i changed it for you, its just what I call it on my forum, thats all

The Wise One

12-14-2005, 10:14 PM

Daniel

12-14-2005, 10:18 PM

Nicely done :)

akoj

12-14-2005, 10:18 PM

try changing

$post[itrader_total]

to

$userinfo[itrader_total]
Did the trick...thanks so much!!!

eoc_Jason

12-14-2005, 10:27 PM

akoj - the members_resultsbit is a member search result page. The variable is not $post, it is $userinfo, so use $userinfo[itrader_total]... ;)

The Wise One The phrase 'itrader_positive_feedback' is in the iTrader phrase group which probably isn't loaded. You can create one for whatever the member stuff is supposed to be on or in the GLOBAL group, or just don't use a phrase. ;) Also, you are trying to add the wrong variables, the variables are itrader_total & itrader_pcnt, not tradescore & tradepcnt. ;)

Everything variable-wise should start with 'itrader_' so that it won't ever conflict with other products or variables.

The Wise One

12-14-2005, 10:38 PM

puertoblack2003

12-14-2005, 10:39 PM

THANKS!! Upgraded on live board and all went well. In the process of deciding where to add in memberinfo and member_results...anyone have any creative ideas? :ermm:

i put mines underneath the referral

The Wise One

12-14-2005, 10:43 PM

and just an FYI for ya (very minor but necessary for xhtml compliance)

the following block of code in the itrader_user template contains 4 instances of <br> where they should be <br />

<tr>
<td><b>$vbphrase[itrader_feedback_score]:</b><br><b>$vbphrase[itrader_positive_feedback]:</b></td>
<td><b>$userinfo[tradescore]<br>$userinfo[tradepcnt]%</b></td>
</tr>
<tr>
<td>$vbphrase[itrader_positive_members]:<br>$vbphrase[itrader_negative_members]:</td>
<td>$userinfo[tradepos]<br>$userinfo[tradeneg]</td>
</tr>

eoc_Jason

12-14-2005, 10:54 PM

and just an FYI for ya (very minor but necessary for xhtml compliance)

the following block of code in the itrader_user template contains 4 instances of <br> where they should be <br />

lol, minor yes... But I'll make a mental note and correct it for the next release. I'm sure there is other little HTML cleanup that can be done too.

You should of see it before, instead of the little icons I had dropdown boxes like the "quick links" on the navbar, but that ended up looking too messy and I thought the icons were nicer and more informative.

Anyhow, I guess nobody has run into any real problems?

Before anyone says, yes technically an admin could probably rate him/her self by manually typing the URL because of how admin permissions override all the other checks. But if you can't trust the admins who can you trust? lol... All other checks should be kosher, I actually kind of went overboard in most cases, most things are double checked (i.e. checked when they want to go to the new / edit feedback page, and check again when the info is submitted) so they can't try to bypass a page and succeed.

IP checking is done only for members with a score of 5 or below I think, and if a match is found it will email the admin a warning with the IP and link and such. IPs are logged for all transactions & comments, but I just don't have any admin page for it yet.

Spinball

12-14-2005, 11:34 PM

You would end up with duplicate ratings, truncate the itrader table first. Yes that query *should* work. However after you do that you will need to run a global score update. There is an included PHP file to do that, it's in the extras/admincp folder in the zip.
That SQL statement does indeed work, but the score update also times out.
Jason is there any way that you could possibly do a version of the script which processes a smaller number of records at a time like many other vB scripts?
This way, people with thousands of records stand a chance of upgrading successfully?
Many thanks for your consideration on this.

ryansmith

12-14-2005, 11:39 PM

Took me a little while to figure out the templates because I'm not real good at those, but I got it and it works now.

One question though. I did this on a test board and left myself a negative feedback. On my postbit templates, I use the format:

itrader_pcnt% (itrader_total)

That gives you something like 100% (1). When I rated myself a negative, it still says 0% (0) which means it didn't count my negative. Does it count positive feedbacks only, or did I do something wrong?

duskdawn

12-14-2005, 11:50 PM

Thank you, Jason, Waiting for this for a long time.

djwins

12-15-2005, 12:23 AM

There is no "home page" like there was on the old version. It really didn't provide relevant data, it was more of just a 'cool to look at' thing. When I get the admin / mod pages completed there will be a page similar to that so the staff can see what's going on.

There is still a lot of things to do, but right now the core stuff works. The admin pages will end up containing some stats stuff, IP search, etc...

I'm thankful that you converted this to 3.5 and am EXTREMELY grateful for this add-on, but I am hoping you will reconsider the untimely death of the "home page".

I think that page is relevant for the following reasons:

1) The Recent Ratings Column helps the community police each other as any unusual activity will be easily spotted there.

2) The Top Rated Traders is good fun for the users who can compete for bragging rights about being the most prolific/best trader.

3) The usefullness of the Wall of Shame is pretty obvious.

4) The Rating Statistics show how active the trading community is on your site.

I have been holding out on upgrading to vB 3.5 as I was waiting for this upgrade...say it ain't so, Joe (er, Jason)!

doug97gxe

12-15-2005, 12:41 AM

Installed it on my test server.. works perfectly

akoj

12-15-2005, 12:41 AM

Is anyone else getting this message when trying to submt feedback?

The message you have entered is too short. Please lengthen your message to at least 10 charaters

It is ten characters or more :ermm:

akoj

12-15-2005, 12:43 AM

Ahhh, I see that additional comments are required. How can we make them optional?

lifesourcerec

12-15-2005, 12:43 AM

Here is a suggestion for a future upgrade:

"If it's possible, how 'add a column for the value of the deal.

$0-$25
$25-$50
$50-$100
$100-$500
Over $500

Or even "Low", "Mid", "High-End". That way people can see how many big transactions someone had before making a deal. Someone won't have 10 feedbacks of $1 trades and then screw someone out of a $500 trade."

ChrisBaktis

12-15-2005, 12:54 AM

A couple things...

First GREAT hack - loved for 3.0 and love it more for 3.5

Second - Making the 'Additional Comments' optional is something I would like to see. Many members might not like the fact they have to input the url (i made it required) then also post additional comments.

Third - wether or not you use the ebay style for points the trader rating always shows the unique number of comments...for example I have 71 Positive Feedbacks with 38 being unique. I hve mine setup to NOT use the ebay style so I would like the 71 to show as the clickable link instead of 38.

Keyser S?ze

12-15-2005, 01:09 AM

yea i agree, that whole additional comments thing is a waste to me, and annoance, would be nice to be able to make it not even be there at all (admincp option)

past that tho great hack!

definatly has my vote for HOTM

KidneyBoy

12-15-2005, 01:38 AM

iTrader = Local (forum) ratings only
Trader Ratings = Global ratings (same ratings over many forums)

Firstoff, eoc_Jason thank you so much for this. It has installed and seems to be working great! Yes it would be nice the suggestions above, but I'm just happy to have something like this for my B/S/T site. This is so great, and I thank you so much! When I get paid next (first week in January) I will donate 25.00 to you. I know it's not a heckuva lot, and all honesty this mod is worth WELL more than that, but unfortunately disability out-right sucks for an income, so that's about the best I can do. I just hope others show their appreciation as well (and don't let those few "+++++ers" get to you. I KNOW The people thankful for what you have produced WELL outweighs the people who "expect" your free services and "expect" you to use every ounce of non-working life working on this, and expect you to not run into any "bumps in the road" and release it YESTERDAY.

I also was a bit curious about this "Trader Ratings" modification you will be creating in the future. Will this at all be compatible with "iTrader" or will there be a way to intermesh the two?

And another question. Is there any chance that the ability to use "Trader Ratings" with other board styles, such as phpBB? Or at least somebody (that knows what they are doing) to write a code compatible to "Trader Ratings"?

Again, thank you *SO* much for "iTrader". It really helps complete my forums!!!

Take it easy
KidneyBoy

dsotmoon

12-15-2005, 01:46 AM

ok, think i found a bug, one you may be aware of not sure

if a users has it set not to receive PM's in their user cp option there is an error if someone leaves them feedback

Fatal error: Unable to proceed with save while $errors array is not empty in class vb_datamanager_pm in /includes/class_dm.php on line 758

it will leave the ffedback after the error but will not update the feedback if you view it in postbit, memberinfo, etc it will still show (0)

can anyone confirm this? i tried it with 2 testuser accounts in various usergroups and get the same thing and with one live user, he brought it to my attention and the PM setting was the only thing different

KidneyBoy

12-15-2005, 01:56 AM

Confirmed. I get the exact same error. It pulls up a completely blank page except the text as posted in dsotmoon's post (ps cool name DS) and it's the same line 758.

Hope this helps!

Take it easy
KidneyBoy

JulianD

12-15-2005, 02:51 AM

dsotmoon

12-15-2005, 03:06 AM

i tried that, didnt work

JulianD

12-15-2005, 03:15 AM

Yes, the last bracket is needed. Make sure you're including the opening bracket in the first file edit.

dsotmoon

12-15-2005, 03:19 AM

this is what it looks like

// Send a PM to the rated user.
if ($userinfo['options'] & $vbulletin->bf_misc_useroptions['receivepm']) {
$vbphrase['itrader_pm_message_x'] = construct_phrase($vbphrase['itrader_pm_message'], $vbulletin->userinfo['username'], $vbulletin->options['bburl'], $itrader['rateid'], $userinfo['userid']);
$cantrackpm = $permissions['pmpermissions'] & $vbulletin->bf_ugp_pmpermissions['cantrackpm'];

$pmdm =& datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY);
$pmdm->set('fromuserid', $vbulletin->userinfo['userid']);
$pmdm->set('fromusername', $vbulletin->userinfo['username']);
$pmdm->set('title', $vbphrase['itrader_pm_subject']);
$pmdm->set('message', $vbphrase['itrader_pm_message_x']);
$pmdm->set_recipients($userinfo['username'], $permissions);
$pmdm->set('dateline', TIMENOW);
$pmdm->set_info('receipt',1);
$pmdm->set_info('cantrackpm', $cantrackpm);
$pmdm->save();
}

if that is correct, it does not work, i still get the fatal error

eoc_Jason

12-15-2005, 03:41 AM

Spinball - Yes I can make a script that processes in batches, I'll do that tomorrow (It's 11pm here, about to go to sleep).

Ryansmith - My mistake, there is a small bug in the DB. It will be fixed in the next version, until then anyone can fix this glitch with the following sql statement. I don't know why/how I set it to unsigned, I guess I just wasn't thinking. After making the change you will need to run the mass-update script to ensure that any user that would be negative is, otherwise their score would show up as zero.

ALTER TABLE user CHANGE itrader_total itrader_total INT( 10 ) NOT NULL DEFAULT '0'

I *might* make the home page again, but it's really not a top priority. Like I said in a previous post, the relevant info will end up being in the Admin / Mod CP. More than likely there will be an admin email notification when a person reaches a certain threshold in the negative range.

As for additional comments being optional, yes I can do that too (right now it's hardcoded) and will have it in the next version. The main reason I made it required was the fact that info there is more permanent than in threads. i.e. there is no time limit on my forum for users to edit posts, thus they could go and edit a deal and that info would be lost forever. They enter it in the iTrader comment and it can not be changed after the edit time limit (5min). Also, I don't know if anyone noticed, but admin's can post comments in other's deal threads.

I'll consider the deal price range, but most people either go and look at their previous deals to see what they bought or sold, that's why you can make the URLs required. A person can just as easily choose a higher price range if they wanted to start scamming others.

URL can be set to required or optional. Bare in mind even if URLs are set to optional, and strict URL checking is set to yes, then that URL will have to match up with a thread in the forum. (It actually can accept a threadid or postid, if it's a postid I just searches for the matching thread).

If you change your rating style from unique to non-unique, you will have to run the mass-update script (in the extras/admincp included in zip) to recalcualte all user data and update the fields in the user table.

The PM addition was hastly put in at the last minute (I just completely forgot, I'm sorry). I will definitly fix that too asap, I know there needs to be some checks to make sure they can accept PMs, their PM box isn't full, etc... If you want to fix it yourself, you will need to do a pre_save & check for the existance of the $errors variable.

I also wanted to double check some things and make the "Can Rate" usergroup permission actually function more as "Can Rate / Be Rated", as it wouldn't make sense to allow one group to rate another (yet that person can't rate back).

Well, it looks like we have enough to get a 2.0.1 release out the door. I was hoping to finally get back to doing some other work tomorrow, but for you guys I can make an exception, what's one more day after working on this thing for the past who knows how many weeks. If you guys ever get bored, you should really browse some of the code, I can't believe how much it's grown since the previous version.

Finally, to answer the person's post about "Trader Ratings". My goal is to have a completely stand-alone site where registered users can rate each other, with a twist. I don't want to go into details about the site and such, but one of the big features will be the ability for forums to request data & verify user authenticity. So you know John Doe on forum X is the same John Doe on forum Y with the same rating, you can also see which forum they deal the most on, etc. In theory any forum could interface with it since I'm planning on just passing the data via XML. All actual ratings will be stored on the TR website, the forums will essentially only have to store minimal user data & retrieve rating updates. There's a LOT more to it than just that, but that is the "in a nutshell" overview. It is technically possible for me to import data from forums, however that would require working with the site admin so they can export the necessary data. But the big goal I wanted to overcome was the problem of ratings being local to only one forum. By overcoming that, it also helps with another problem which is trolling / fraud. Since often a person will go to one forum, try to scam some people, and once he gets booted he just moves on to another, rinse, wash, and repeat. I do know a few of the people that manage Troll Hunters, and plan on working with them extensively and hopefully bringing them on as part of the staff for the site. Nobody likes to get ripped off, and hopefully I can do something to help prevent that.

dsotmoon

12-15-2005, 03:58 AM

The PM addition was hastly put in at the last minute (I just completely forgot, I'm sorry). I will definitly fix that too asap, I know there needs to be some checks to make sure they can accept PMs, their PM box isn't full, etc... If you want to fix it yourself, you will need to do a pre_save & check for the existance of the $errors variable.

i have no idea how to do that so I will await your fix, thanks for working hard on this, i have very few users who disable PM's but as you can see its already come up

Finally, to answer the person's post about "Trader Ratings". My goal is to have a completely stand-alone site where registered users can rate each other, with a twist.

since "trader ratings" or TR was so widely used in the first hack why didnt you stick with it for the 3.5 upgrade? and rebrand the global system as iTrader, as in i(nternet)Trader that would suit working across all forums? just asking, i know there are alot of big webmaster/domain forums who use trader ratings/TR and in the long run could confuse the two just because users are already used to calling it that

eoc_Jason

12-15-2005, 04:05 AM

since "trader ratings" or TR was so widely used in the first hack why didnt you stick with it for the 3.5 upgrade? and rebrand the global system as iTrader, as in i(nternet)Trader that would suit working across all forums? just asking, i know there are alot of big webmaster/domain forums who use trader ratings/TR and in the long run could confuse the two just because users are already used to calling it that

Because the domain "TraderRatings.com" was available, but iTrader was taken. In fact probably every word you can think of has been registered with an 'i' in front of it... lol... Also I like the name Trader Ratings better, the name says exactly what it is.

I'm sure some people will hold on to the older version, but a majority of people have upgraded to 3.5.x. It's not a huge deal, I figured if I was going to make the name change, now would be the time.

Anyhow, thanks everyone for the feedback. Yes I know this addon is nowhere near completed for all the features I would like to see, but it is more than useable (once I fix these last few little bugs). I know how many sites rely on this add-on, it gives members a piece of mind when dealing on a forum. In fact, just the other day I had a member PM me about being ripped off by another member, when that incident could of been avoided if the iTrader system was in place.

Okay, it's midnight now... time to hit the sack, not to mention my back is still killing me from the other day.

dsotmoon

12-15-2005, 04:11 AM

I'm sure some people will hold on to the older version, but a majority of people have upgraded to 3.5.x. It's not a huge deal, I figured if I was going to make the name change, now would be the time.

yes thats very true, not knocking it, just wondering

Okay, it's midnight now... time to hit the sack, not to mention my back is still killing me from the other day.

wrong, its 1 am here :D rest yourself Jason and again, thanks

Areku

12-15-2005, 04:25 AM

Yeeeeeeeeeha! Thanks Jason!!!!

techxpert

12-15-2005, 05:54 AM

I upgrade from earlier version.Looks good but what is home page after upgrade,earlier it was traderratings.php.
(which show a summary of all feedbacks ,top traders etc...)

It does not have any such file now?

dmark101

12-15-2005, 06:07 AM

installed. looks like the wait was worth it so far. i do miss being able to see the top rated people. hope that is part of the next update. :)

i am getting the following error when trying to access the itrader_global.php page:
Warning: main(DIR/includes/functions_itrader.php): failed to open stream: No such file or directory in /var/www/forums.********.com/itrader_global.php on line 19

Fatal error: main(): Failed opening required 'DIR/includes/functions_itrader.php' (include_path='.:/usr/local/lib/php') in /var/www/forums.********.com/itrader_global.php on line 19

why is that?

Spinball

12-15-2005, 07:04 AM

Spinball - Yes I can make a script that processes in batches, I'll do that tomorrow (It's 11pm here, about to go to sleep).
Brilliant, thanks. Presumably this overwrites all the values in the user table which are currently totally wrong?

Watson

12-15-2005, 08:13 AM

Superb, been waiting for this. Loving it Jason. Thanks for this

[edit]

Just wondering, when I put the link in for the navbar, it seems to go to what people would see when they click on my rating. Aint this spose to be the top 10 traders bit? or is that in the next version.

Sorry if I missed this in another post, did read it, but a bit tired

sensimilla

12-15-2005, 08:35 AM

Nice hack.. although i dont know how to make it work..
How do I leave rating to a user...? cant figure it out

Watson

12-15-2005, 08:57 AM

Nice hack.. although i dont know how to make it work..
How do I leave rating to a user...? cant figure it out

Once you put the code in the postbit/postbit_lgacy template, you will see iRating : (0) click on that to leave a rating for a user

Watson

chimaira

12-15-2005, 12:50 PM

All installed fine but it seems when i submit feedback on the itrader
for the code i put in postbit it still remains like this
iTrader: (0)

when it should be

iTrader: (1)

Anyidea's dude?

eoc_Jason

12-15-2005, 02:21 PM

dmark101 - did you upload the files to the '/includes' and '/includes/xml' directory as per the directions? Because it sure doesn't look like it from that error.

Watson - Guess you didn't read the thread as it was mentioned multiple times. There is no home page like before. However since so many people have requested it I will create one.

Anyhow, I'm about to start working on fixing all the little bugs and such discovered last night. Hopefully I can release an update today, or tomorrow at the latest.

OttawaGolf

12-15-2005, 02:26 PM

Jason, Will you be making the required link back to the sale thread an option?
That's pretty important to me, since my site uses frames.

KidneyBoy

12-15-2005, 02:31 PM

OttawaGolf: If I'm not mistaking, it's already just an option, and defaulted to "off". The option is in the ACP section (The top one) just scroll down all the configuration options until you find the iTrader one (toward the bottom of the configuration list).

Hope this helps
KidneyBoy

mrderanged

12-15-2005, 02:34 PM

Jason,

Since some are interested in the home page and some are not, maybe an option whether or not to use it?

Just a suggestion :)

eoc_Jason

12-15-2005, 02:53 PM

OttawaGolf - Look in your admincp -> vbulletin options -> itrader settings... sheesh...

mrderanged - It's not that it will be an option, it will be a separate file, so if someone wants to use it they can, if not then they don't even have to bother uploading it. However I will tell you now that it will not be maintained all that much as I personally do not see much value in it.

OttawaGolf

12-15-2005, 02:57 PM

Sorry Jason I have not installed it yet. I thought I had seen that it was not an option.

harpez

12-15-2005, 03:24 PM

When I go to itrader.php I get the following:
Harry, you do not have permission to access this page. This could be due to one of several reasons:
Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.
Hope you can help, Harry/Harpez

Ncturnal

12-15-2005, 03:26 PM

When I go to itrader.php I get the following:

Hope you can help, Harry/Harpez

Did you configure permissions in Usergroup Manager to allow viewing and use of the rating system for the applicable groups you wish to have access?

ryansmith

12-15-2005, 03:29 PM

When I go to itrader.php I get the following:

Hope you can help, Harry/Harpez

Did you change all the permissions? In AdminCP, under Usergroups, go to Usergroup Manager, iTrader has its own setting in the "Edit Usergroup" section (at the very bottom). By default they're all disabled, even administrators. You have to enable the appropriate usergroups before you can use it.

If you've already done that, sorry, that's the only idea I have. lol.

Ryan

eoc_Jason

12-15-2005, 03:31 PM

As I stated in the "Readme First" file...

Please follow the following steps IN ORDER, otherwise the install will not work properly and I will not even bother to reply to any of your help requests.

I'm willing to bet money you did not configure your usergroup permissions properly, or you uploaded the product XML before uploading your files (which is a no-no)...

harpez

12-15-2005, 03:37 PM

I've sorted it know, it was my own stupidity :p

Kidswap

12-15-2005, 03:52 PM

Installed great on my forum. Thank you so much!

eoc_Jason

12-15-2005, 03:53 PM

I have a few things I was hoping I could get feedback from everyone on...

First, if anyone would like to help with this I would be more than grateful. A *huge* help would be someone to write some thorough documentation / instructions / usage guide. (For both installation and also something to implement in vB for members to read).

Second, a person who could make some graphics would help out. I woud like to replace the pos/neg/neutral images with something a little nicer. Also the others can be changed if you are really good. ;)

Third, (this was something someone was asking me about via PM, but also an idea I had a while back). I was thinking rather than make it strictly rating, the code could be altered in such a way that a person could rate another, except omit the pos/neg/neu rating initially. That way they have a record of the intended transaction. Then once the deal is finally completed, they can rate it, which will also "finialize" the deal (thus no more comments or editing). A 4th icon can be created to signify "In-Progress" or "Pending", so the person knows how many deals they have going on.

Yea / nay?

ryansmith

12-15-2005, 03:59 PM

Jason,

I was going to write up an iTrader how-to for my forum. I tend to get in depth with things because you'd be surprised at how many members can't just figure things out. So I was going to have a little information about what each icon meant, how to leave a rating, etc. If I get something in a timely manner I'll send it to you.

As for the graphics... I was hoping someone would use something similar to the online/offline ones here at vB.org... a green plus for positive, a red minus for negative, etc. So if anyone reads this and wants to take that into consideration... thanks :)

Ryan

fiber_cut

12-15-2005, 04:52 PM

When I try to installthe xml file it says "Invalid File Specified"

Any help?

fiber_cut

12-15-2005, 05:09 PM

Was a permissions issue, But how does one use this program..?

How does opne leave feedback for others and where does one go look for feedback for others?

ryansmith

12-15-2005, 05:18 PM

Was a permissions issue, But how does one use this program..?

How does opne leave feedback for others and where does one go look for feedback for others?

Did you edit the templates and put in the code for iTrader? You have to manually edit the templates for postbit and/or postbit_legacy, MEMBERINFO, etc. Jason included two readme files in the zip and the one called Template Info should explain what the code is and examples of where to put it.

You have to do this step so that iTrader shows up in member profiles and postbits. Then you can click on their rating to view their score or leave them feedback.

Ryan

Snake

12-15-2005, 05:19 PM

Bingo!

fiber_cut

12-15-2005, 05:21 PM

Is there a way to set it that only if you made a eal wiht the person on you can leave feedback? I see I am able to go to any user and leave feedback

djwins

12-15-2005, 10:10 PM

Jason, thanks so much for reconsidering adding the home page...there is much rejoicing in the land of iTrader!

MR-2ZZ

12-15-2005, 10:14 PM

Thanks Jason!

Hawkbizkit

12-16-2005, 03:22 AM

well done Jason ;)

Areku

12-16-2005, 07:07 AM

Is there a way to set it that only if you made a eal wiht the person on you can leave feedback? I see I am able to go to any user and leave feedback

If that's true, then this script is useless!?!?!

Areku

12-16-2005, 07:12 AM

Jason,

May be it can be implemented so "SUBMIT FEEDBACK FOR THIS USER" is ONLY shown on the actual URL the trade happened *AND* this would make the TRADING URL auto-filled in the LEAVE FEEDBACK form, *AND* the link for leaving feedback would only be visible for the 2 users who actually took part on the trade?

What about that?

I'd even be willing to pay to make this happen, if you don't wanna code it generally!

007

12-16-2005, 07:15 AM

Maybe add a way for the thread starter to set a thread to "sold" and have to enter the buyers username. Then make it so the transaction thread is required, and feedback can only be left between the person who started the thread and the person who the thread author sets as the buyer. Wouldn't be too hard to do, and would fix a lot of potential problems.

Although I think in most communities people would respect the rules. There are always a few stinkers though.

djwins

12-16-2005, 07:21 AM

If that's true, then this script is useless!?!?!
Don't be an idiot. The old version was this way and I have over 11,000 pieces of feedback (http://www.cheapassgamer.com/forums/traderratings.php?) entered. My users love this system and there are plenty of vB admins who have held up on updating their forums to 3.5 because they were waiting for this update.

Speaking of useless, you should probably take advantage of the "Edit" post feature instead of double posting.

Areku

12-16-2005, 07:34 AM

Don't be an idiot. The old version was this way and I have over 11,000 pieces of feedback (http://www.cheapassgamer.com/forums/traderratings.php?) entered. My users love this system and there are plenty of vB admins who have held up on updating their forums to 3.5 because they were waiting for this update.

Speaking of useless, you should probably take advantage of the "Edit" post feature instead of double posting.

Hey m8, calm down, I do think this is a GREAT mod and I LOVE IT, but I'm asking if it is correct or not that anyone can feedback any user on the forum no matter if they dealed before or not.

In short, if i'm pissed of the forum, I'll begin leaving - feedback TO EVERYONE, even if it's 1 per 24h.

Dont get me wrong, i don't expect 100% automation, but I don't want to rely on a 24/7 admin team to look forward correct feedback being applied.

I'll EDIT what I consider I need to EDIT.

My first post was a reply and my second a message to jason.

Areku

12-16-2005, 07:36 AM

Although I think in most communities people would respect the rules. There are always a few stinkers though.

Only 1 stinker can make you waste tons of minutes to fix things up, email upset users, etc. and the worst: recovering loyalty on the system.

Needless to say, if you plan to create a "fair system", what about 1 user with 2 accounts (1gmail, 1hotmail) and mutually leaving + fb between them so they have 200 feedbacks in a glimpse?

Gavin B.

12-16-2005, 10:04 AM

Excellent work jason, very well thought out!

Enthonia Tech

12-16-2005, 10:41 AM

GREAT MOD!!!

/me clicks install

ChrisBaktis

12-16-2005, 11:45 AM

agiacosa

12-16-2005, 12:17 PM

YEA - that would be great

Thanks for the great mod Jason!

I want to show the total number of ratings in the postbit. I also want to show the percentage of positive ratings BUT ONLY IF the member has at least 1 rating or feedback. Otherwise, the Positive Feedback: 0% would be misleading as it would suggest no positive feedback.

I assume that the conditional to get this done would be if itrader_total DOES NOT EQUAL zero, then show [insert positive feedback percentage code]. I just don't know how to write the conditional for vB.

I would appreciate help from someone that knows.

Thanks in advance.

dmark101

12-16-2005, 03:50 PM

dmark101 - did you upload the files to the '/includes' and '/includes/xml' directory as per the directions? Because it sure doesn't look like it from that error.

yup. sure did. still get it.

:(

chimaira

12-16-2005, 05:04 PM

hmm recently been getting
Fatal error: Unable to proceed with save while $errors array is not empty in class vb_datamanager_pm in /includes/class_dm.php on line 756

dsotmoon

12-16-2005, 06:02 PM

thats a bug i brought up a few pages back, Jason is aware of it, it happens to my users who have PMs turned off

OttawaGolf

12-16-2005, 06:29 PM

I have granted permissin for registered users to access iTrader

Some are presented with "iTrader is closed" logged in or not.

Some have said "but in the upper right it had the log in box that was empty I put in my username and password and everything has been fine since. Not sure why it does not work for. At the time I was already logged into the regular section of the site."

Others have said "I only see a Log Out option. If I select this and re-enter my info I get logged back in but nothing changes, Itrader is still not available. Have tried using both IE and Firefox browsers."

and others "Worked ok for me. I just clicked on the numbers in the profile, and I didn't have to log in."

Any thoughts?

eoc_Jason

12-16-2005, 06:30 PM

fiber cut - Yes you can rate anyone, to a certain extent. Because of the generic nature of the forum / threads, there is no "true" automated way to know if the person did engage in the deal with the other. That issue is somewhat overcome if you require a thread URL to the deal. Then a person viewing the deal can go and see if indeed they did as said.

Areku - If you think this is "useless", then by all means, DO NOT USE IT! Nobody is forcing this down your throat. If you want to overcome most problems, you can require the thread url, and turn on strict url checking, and set specific forum sections. When those are enabled then the thread in question must: 1. Be a valid thread on your forum, 2. One of the two people involved in the deal must be the thread creator, and 3. Must be in one of the forumid's specificed.

About 1 member with 2 accounts. Yes he can sign up on your forum and attempt to start rating himself, however he will run into an issue that his IPs will more than likely not change during that time frame, and thus an admin email will be sent to warn about the fruad. Also he can not rate the same person but once per day (or change it longer if you like in the admincp), so it would take a while, not to mention that several feedbacks all coming from the same inital person just throws up a red flag right there.

007 - I did have an idea like that initially, and even started to expand upon it more. However the one thing I found out is when you are working with threads and trying to integrate bits of code here and there, it gets ugly quick. vBulletin is designed to be a forum, not a classified / auction package. Trying to alter a thread to do as such causes too many headaches, and every time there is a big change in vB it pretty much makes author's like myself have to start back from square one and re-evaluate everything. Having to enter a name really accomplishes little if you really think deeply about it.

agiacosa - <if condition="$post[itrader_total]">$post[itrader_pcnt]%</if>

------------------------------------

Guys, as it is stated in the description, this add-on at the core relies mostly on the honor system, as does any rating system. I find members are very cautious and know when something doesn't look right, they do report suspicious ratings to a staff member (and now it's even easier with the "report rating" button). Also if someone gives them a bogus rating, they notice that too extremely quickly. Yes, more could be done to try and integrate stuff with threads, however IMO I do not think it will actually change the nature of anything. Anything that could be faked currently could be faked after making those changes. I don't care to go mucking around with thread/post code trying to alter how that works and having to edit a dozen vB templates, create a bunch of hooks, and god knows what else. The effort / complexity involved is not worth the minimal return in value. Issues arrise where say, one thread a person lists various items, and sells them to several people. Then what would you do if you only had 1 box to enter who bought stuff? If your thought about it is trying to prevent abuse, it still does nothing to stop a person with 2 accounts from rating himself.

Everyone runs their forum differently, and I'm not out to try and change how they do it, this system is meant to be as flexible as possible to try and accomidate everyone's needs and differences. If your goal or needs are so different than what is offered here, then either 1. Code your own, or 2. modify this code to suite your own forum's needs. But do NOT by any means complain about something that is offered free to the community out of my own (and other authors') kindness.

If you wanted to have something like a "rate this deal" link in a thread, you can accomplish it with a little fancy work using template conditionals. There's actually a lot you can do with the template conditionals and not have to code things in a file or use any hooks.

In the several years (since the original conception in vB 2.x) I have had *very* few reports of abuse / fradulent activity, and overall the system has worked out extremely excellent, especially to weed out the bad traders. Seeing a user with a good score & positive rating (just about everyone on my forum has 100% positive) gives other members a piece of mind & confidence in the deal they are engaging. The system gives a quick historical view of their past transactions, and if you force URLs & don't delete the threads, then they can go and visit each of those transactions should they wish. But seeing a person rated 20, 50, or even over 100 times from different members is usually evidence enough that they are legit.

There are a bunch of new anti-abuse / anti-fraud features (and I'm planning on adding more soon) in this version. I've seen cases in the past where a newbie decides to go bezerk and rate a person negative 100 times, or rate dozens and dozens of members negative. Now they simply can't do that with current limitations. In the past, catching a user registering multiple times had to be done looking at IPs of posts they made, now the iTrader system tracks all that so admins can (when I finish the admin pages) cross-check deal/comment IPs. Also new traders automatically get their IP dupe-checked and a warning email is sent to admins if they match. Yes, that does not prevent a person from using a proxy to access your forum, but if they are that hell-bent on ripping people off you have a bigger problem.

I could code things to make users jump through dozens of hoops before they can rate each other, but the BIGGEST problem isn't the code, it's the forum members. The more work / steps that a member has to do to rate someone, the less inclined they are to use the system, especially once they have established a decent rating. Making it overy-complex turns away people (especially who are unfamilliar with how it works) faster than you can say apple pie.

eoc_Jason

12-16-2005, 06:33 PM

iTrader Closed only comes up if there is a version mismatch, or you have the iTrader system set to not active in your vBulletin Options.

Logging in / out issues might be related to people that do not use cookies, and you did not include the $session[sessionurl] in your URL strings that you created linking to iTrader pages.

I have granted permissin for registered users to access iTrader

Some are presented with "iTrader is closed" logged in or not.

Some have said "but in the upper right it had the log in box that was empty I put in my username and password and everything has been fine since. Not sure why it does not work for. At the time I was already logged into the regular section of the site."

Others have said "I only see a Log Out option. If I select this and re-enter my info I get logged back in but nothing changes, Itrader is still not available. Have tried using both IE and Firefox browsers."

and others "Worked ok for me. I just clicked on the numbers in the profile, and I didn't have to log in."

Any thoughts?

OttawaGolf

12-16-2005, 07:23 PM

Thanks Jason. It was not active. It is now working. As an admin I could see it and so could the mods. As for the login, that just added to the confusion. I duno but they are happy now.

My compliments to the chef. This is a great hack.

ChrisBaktis

12-16-2005, 09:00 PM

Any chance we can get a quick code change to make the Additonal Comments optional? I dont want to release the hack on the site with this as a required field.

VBUsers

12-16-2005, 09:09 PM

great hack ! working great! thanks

Areku

12-17-2005, 05:52 AM

Areku - If you think this is "useless", then by all means, DO NOT USE IT! Nobody is forcing this down your throat.

My apologies if i sounded too rude! I've been waiting for your hack anxiously like many more and will definetly use it, but i was thinking it would be more strict...

I just tested it and i could leave several times a + fb to the same user more than once every 24h...

What I'll do is try to hack it a bit more so:

1) user A opens a new deal thread
2) users B, C, D "bid" or offer a trade on A
3) A chooses who to close deal with and then

a) thread closes, no1 else can reply
b) A and C recieve a PM stating they now finish to close the deal
c) A and C have now the option to rate each other wisely
d) once rated, it's over! No other can rate any other if they actually didnt engage on a deal, nor rerate more than once.

Much like ebay works.

On top of that

4) URL for the deal will be REQUIRED and will only be ACCEPTED if:

a) it is in the form of showthread (no more showpost URLs accepted)
b) has not been used before for other deals (aka u cant put the same URL deal to get several ratings from different users)
c) it belongs to desired irating enabled forums

5) Additional Notes made optional.

Once we test this out, we can share if you (or any1) need to!

zlos

12-17-2005, 05:59 AM

Unfortunately I cannot upgrade, still getting some mysql erorrs:

Database error in vBulletin 3.5.1:

Invalid SQL:
UPDATE user
SET itrader_total = 1,
itrader_pcnt = 100,0
WHERE userid = 29466
LIMIT 1;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '0
WHERE userid = 29466
LIMIT 1' at line 3

???

Areku

12-17-2005, 06:09 AM

In your advanced language settings, try to switch decimal and thousands punctuation...

zlos

12-17-2005, 06:18 AM

Unfortunately I cannot upgrade, still getting some mysql erorrs:

???

I have found the problem source:

line 148 ./includes/functions_itrader.php

simply replace

itrader_pcnt = " . $userinfo['tradepcnt'] . "

with

itrader_pcnt = '" . $userinfo['tradepcnt'] . "'

:)

eoc_Jason

12-17-2005, 03:18 PM

Chrisbaktis - I'll be releasing an update today, and that will be included as an admincp option. ;)

Areku - Admin's override all restrictions, for various reasons, that's why you can leave multiple feedback within the restricted timeframe. If a postid is submitted in the URL all it does is back-check to the the threadid, it's just there for convience. I allowed duplicate threadid's because on many sites a person has a single "FS" listing URL, thus multiple people could end up linking to it. Like I said, a person is free to edit this however they feel fit for their own forum use. Everyone runs their forum differently, for instance, in my FS/WTB sections, a user can create the thread and edit it, but that's it. People can not reply because that would alter the natural order of items being listed FS.

zlos - I'll be sure to fix that with the next update.

ChrisBaktis

12-17-2005, 03:32 PM

Sweet!

klaush

12-17-2005, 05:13 PM

I have found the problem source:

line 148 ./includes/functions_itrader.php

simply replace

itrader_pcnt = " . $userinfo['tradepcnt'] . "

with

itrader_pcnt = '" . $userinfo['tradepcnt'] . "'

:)

Thanks, i had the same error with a fresh install.

Any idea why only we!

By the way, great product!

dsotmoon

12-17-2005, 05:25 PM

Chrisbaktis - I'll be releasing an update today

great news, thanks Jason

eoc_Jason

12-18-2005, 12:22 AM

Here's a quick list of some things for the 2.0.1 version. I'm sure there is more but these are just off the top of my head. It's late and my brain is only halfway functioning so I'm going to wait to release this till tomorrow so I can double-check everything one last time and make sure I package up everything properly in the zip. If I do it tonight I'm sure there will be something small I'll miss. ;)

Please let me know if I happened to miss any bugs. I looked over the thread tonight and did not see anything that I haven't fixed. I meant to get this out earlier today but one thing always leads to another, you know how it goes.

Fixed:

Several Changes In Upgrade Script to process users in batches
Checks PM for errors before attempting to save
Altered user table to accomidate negative scores
Some phrase fixes
Changed templates to $show (instead of $itrader) when deciding blocks of HTML to show
Changed a few instances of <br> to <br />

Changed:

Edit Time Limit is now specified in minutes (instead of seconds)
Duplicate User Rating Time Limit is now specified in hours (instead of seconds)
Adjusted checking to accomidate more than 3 types of deals (ex: loan, rent, whatever)

Added:

AdminCP iTrader Menu - Update iTrader Scores (Batch Updating)
Admin Option - Detail comments minimum characters (0 will disable / make comments optional)
Admin Option - Contact staff on negative rating (Y/N)
Admin Option - Maximum Time To Return Rating (specified in days)
Admin Option - "New Trader" Score (Affects how other options function)
Added indexes on ipaddress for faster IP checking (No admincp IP searching yet)

Kihon Kata

12-18-2005, 12:24 AM

woot, im the first and pee pee cometh

dsotmoon

12-18-2005, 12:31 AM

Here's a quick list of some things for the 2.0.1 version.

think you got it covered Jason, great job as always, cant wait

dsotmoon

12-18-2005, 12:32 AM

oh, will the script change the seconds to minutes, etc or will we have to go in and change them after upgrade?

thanks

cbr929rrerion

12-18-2005, 03:25 AM

Clicks install.. great item.. the icons for the positive, negative neatural are not included.. Did not read the whole thread but I am sure it says somewhere to chose your own.. lol

OttawaGolf

12-18-2005, 07:27 AM

I guess the home page with top ten isn't going to make it. My users are asking for this.

Just a question, not to be taken as critical;
Why do you consider it such a low priority when so many users want it? I would hope for a rankings overview page with a full set of options for listing rankings by various parameters and flexible list lengths. I'd write it myseld if I could.

Thanks for your consideration.

djwins

12-18-2005, 09:03 AM

OttawaGolf, you probably missed this...
There is no home page like before. However since so many people have requested it I will create one.

OttawaGolf

12-18-2005, 11:40 AM

Yes I did see that, but I see it did not make it into this update.
He also said this
It's not that it will be an option, it will be a separate file, so if someone wants to use it they can, if not then they don't even have to bother uploading it. However I will tell you now that it will not be maintained all that much as I personally do not see much value in it.So I just want him to know that although he does not see much value to it, My users have asked for a rankings overview page so I know they will use it. I am hoping for something a touch more versatile than he described, ( sort by a few fields, and variable lenth lists, not just top ten) I am also advocating that it not get ignored as development continues. :up:

djwins

12-18-2005, 11:55 AM

I agree the home page is very useful.
I have a very active Trader Ratings 1.2 installed on my boards (11,000+ ratings and 1,200+ users rated). I am going to hold off on the update to iTrader until the home page is implemented as I think my users will mostly focus on the removed home page, rather than the added features.

eoc_Jason

12-18-2005, 07:56 PM

dsotmoon - Users upgrading will need to make 2 changes in the admincp to accomidate the changes in time value, It is documented in the upgrade text & changelog. I recommend all people read over AdminCP options carefully as there are a few more now. ;)

cbr929rrerion - pos/neg/neu icons are just default vB emoticons. I made a plea in an earlier post asking for a talented graphic artist to maybe create some nicer custom images for everyone to use.

OttawaGolf - No, the home page is not going to make it with the release. I'll try to convert the old one this afternoon and get a separate file online as a temporary fix for you guys. I was going to re-code some of the functions to make it handle the global scope, but I can do that with the next version to integrate it all better. I consider it a low priority because it is a low priority to me and I'm the one having to code everything. ;) It does not affect functionality or increase usefulness, thus it is a lower priority than things that actually contribute to the rating system itself. The very nature of the rating system negates everything that is displayed on a summary page like that. It does not matter who the top rated people are if you are not engaged in a deal with them. It does not matter who the negative rated people are because you would see the negative rating on any item they tried to list FS. There is just nothing (from a user standpoint) that a summary page can accomplish in a productive manner. I'm not trying to dog you, I'm just trying to give you my point of view on the matter.

---------------

Anyhow, I've got a couple little things to fix in the upgrade script, and update some documentation, then I'll be posting v2.0.1 online & sending out a notice. I updated my forum and everything seems kosher, it made the table changes correctly, updated templates & phrases, and added the admincp options. :bunny:

eoc_Jason

12-18-2005, 10:04 PM

I have updated the package to v2.0.1 here & sent out an email update. Please read the "Readme First.html" file included in the package for instructions on what needs to be changed manually (just 2 admincp options).

If you find a bug and do not see me reply about it, please send me a PM after waiting a day or so.

romow

12-18-2005, 10:25 PM

do we need to reinstall the product as well, or just modify those two options only?
thanks,

I have updated the package to v2.0.1 here & sent out an email update. Please read the "Readme First.html" file included in the package for instructions on what needs to be changed manually (just 2 admincp options).

cbr929rrerion

12-18-2005, 10:28 PM

Before I upgrade can you tell us what bugs were fixed and what options were changed/added

eoc_Jason

12-18-2005, 10:34 PM

romow - You need to upgrade the product first (do not uninstall the existing product). To upgrade you click on the add/import product link, just like the initial install. It will do the upgrade process for you. Very important to select "Yes" for "Allow Overwrite" on that page.

cbr929rrerion - Bug list is kind of several posts up, I don't remember every last little thing I changed, you can always do a diff on the files & templates. All templates were changed, some more than others. Most files were changed, it would probably be easiest just to re-upload them all. Images did not change any.

Oh, I also uploaded a screenshot of the admincp menu options.

chimaira

12-18-2005, 10:44 PM

Ah awsome... Now the amount of ratings appear in itrader ( here )
top job

dsotmoon

12-18-2005, 11:10 PM

Ah awsome... Now the amount of ratings appear in itrader ( here )
top job

yes, everything working correctly now as far as the PM bug goes, thanks jason

sellbuydomain

12-19-2005, 03:02 AM

i have a problem like this , after i submit a feedback, i see an error, however , it redirect to itrade page, here is the error

Warning: array_merge() [function.array-merge]: Argument #1 is not an array in /itrader_feedback.php on line 243

also i test all feedback , the percentage count incorrectly, if i post negative feedback more , will only list 50% ,for example 4 negative feedback, 3 postive feedback, should 42% , why always 50%

sadecosefo

12-19-2005, 03:51 AM

*clicked install*

Have installed mine with no problems as of yet. Will need to continue test drive to see if anything comes up. This is a fantastic thing you got going here. Thank you very much. REALLY appreciate all the hard work you've put into this. It is what our forum has been needing for quite some time.

I'd like to try and mess with it to see if I can get different icons for the amount of (good) trades. If anyone has figured that out and would like to share, that would be great. If I figure it out I'll pass on the info.

d2sector

12-19-2005, 06:36 AM

Are you any closer to releasing a better Template documentation for the hack?
One of the places i've implemented it so far is in the popup menu for a username. Underneath the Homepage, Send X a Private message etc.


<tr><td class="thead">Trading</a></td></tr>
<tr><td class="vbmenu_option"><a href="itrader_feedback.php?u=$post[userid]" rel="nofollow">Leave Trade Feedback!</a></td></tr>
<tr><td class="vbmenu_option"><a href="itrader.php?u=$post[userid]" rel="nofollow">View Trade History</a></td></tr>


Is there a better way to code this?

Oblivion Knight

12-19-2005, 06:43 AM

Superb addon.! Thanks for sharing your hard work.. :D

* Oblivion Knight installs.

Spinball

12-19-2005, 08:26 AM

Thanks Jason. Installed and upgraded without problems.

mrderanged

12-19-2005, 12:55 PM

Jason,

Is there a reason that the "short comment" field is limited to 80 characters? (re: formatting maybe?). Any possibility to make the character limit admin configurable for those that would like to allow larger "visible to all users" ratings?

Thanks

eoc_Jason

12-19-2005, 01:02 PM

sellbuydomain - Ah, minor bug, I'll release a file update in about an hour once I get to the office. All that will be needed is to re-upload a couple files, no other modifications needed.

The reason it would still be 50% is because calculations are done based on UNIQUE userids. Unless you change the option in the admincp to non-unique.

d2sector - I'll try to write up some more documentation today, I meant to yesterday but did not get a chance. Really template implementation is a user-preference on exactly where and how they want to do it.

eoc_Jason

12-19-2005, 01:49 PM

Attention:

To fix a small glitch in the code I've updated the zip file. If you already upgraded to 2.0.1 then simply re-upload the following two files that have been fixed.

itrader_feedback.php
itrader_detail.php

Noonster

12-19-2005, 03:22 PM

Upgraded from 2.0.0 to 2.0.1 :D

Thanks and keep up the great work!!

GTAce

12-19-2005, 05:33 PM

How do I get this to display in the memberlist? Simply adding a line to memberlist_resultsbit isn't enough...there is more to it than that.

Thanks!

msimplay

12-19-2005, 05:42 PM

How do I get this to display in the memberlist? Simply adding a line to memberlist_resultsbit isn't enough...there is more to it than that.

Thanks!

yeah the documentation isn't completed , i personally took reference from the 1.2 version of this hack for vbulletin3.X
and added the itrader ratings to the memberlist aswell

GTAce

12-19-2005, 06:11 PM

yeah the documentation isn't completed , i personally took reference from the 1.2 version of this hack for vbulletin3.X
and added the itrader ratings to the memberlist aswell

So you got it to work?

I tried adding this
(<a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a>)

After this
<a href="member.php?$session[sessionurl]u=$userinfo[userid]">$userinfo[musername]</a>

in memberlist_resultsbit....but all it showed was ( )

Even if it did work, I would consider it a temporary solution...as I'd like to see Trader Ratings as its own, separate column

eoc_Jason

12-19-2005, 06:18 PM

I know the documentation is incomplete, however look what you are doing...

the variables used should be $userinfo not $post for that template. ;)

GTAce

12-19-2005, 06:28 PM

Oh :nervous:

oops, you're right

(<a href="itrader.php?$session[sessionurl]u=$userinfo[userid]">$userinfo[itrader_total]</a>)

^^^ that works...but I'd still love to see it in its own column

ryansmith

12-19-2005, 06:56 PM

Jason,

I have a question. I switched the eBay Style option from No to Yes, but now I need to recalculate the point scores. You mentioned earlier in the post about a mass-update script. Where is that exactly? I know there's one in the zip file in Extas/admincp but that's for upgrading from the old to the new versions. Is there another one located somewhere?

Ryan

eoc_Jason

12-19-2005, 06:57 PM

It's meant to be short... lol. Probably because I think eBay does 80, that's why I chose that number.

Anyhow, it's limited in the DB (you can change the field from 80 to 255), and in the template field form. No other length checking is done, so it would be easy to customize.

Jason,

Is there a reason that the "short comment" field is limited to 80 characters? (re: formatting maybe?). Any possibility to make the character limit admin configurable for those that would like to allow larger "visible to all users" ratings?

Thanks

eoc_Jason

12-19-2005, 06:58 PM

In your AdminCP there should be a new section called "iTrader Options", there is currently only one choice which is to re-calc all the scores.

Jason,

I have a question. I switched the eBay Style option from No to Yes, but now I need to recalculate the point scores. You mentioned earlier in the post about a mass-update script. Where is that exactly? I know there's one in the zip file in Extas/admincp but that's for upgrading from the old to the new versions. Is there another one located somewhere?

Ryan

ryansmith

12-19-2005, 06:59 PM

Ah ha :) I knew it must be easy. LOL. Thanks Jason, it's working great.

Ryan

Spinball

12-19-2005, 07:45 PM

Hi Jason,
quick question. Might it be possible to specify the user groups/ user ids to email when there is suspicious activity? At the moment all the moderators are getting the emails and it's not appropriate.
Thanks

mrderanged

12-19-2005, 07:47 PM

Just want to make sure that I have this right. The "detailed comment minimum characters" field corresponds with the "Additional comments field". Is this correct?

If so, then I'm having the following problem:

I have it set to "0" to disable it, but I am still getting a message that I must have a minimum of 10 characters in my post...

If not, then sorry to have bugged you :)

Thanks

mvigod

12-19-2005, 10:40 PM

Will you be adding something so one can pick the For Sale forums by id and then have the user shown a dropdown choice of buy/sell/tradewhen creating the thread? This attribute would then be displayed on the forumdisplay so users know what type of ad it is before clicking in. Also this attribute can later be used to verify the seller/buyer role perhaps?

JulianD

12-19-2005, 11:21 PM

Upgraded to 2.01a! :)

benFF

12-20-2005, 09:24 AM

Upgraded from 2.0.0 to 2.0.1 :D

Thanks and keep up the great work!!

Fantastic - just one request - is it possible to have a "user must have been registered for X days" option to stop people signing up with multiple accounts in a short space of time just to boost ratings?

zlos

12-20-2005, 09:45 AM

Thanks, i had the same error with a fresh install.

Any idea why only we!

By the way, great product!

Yeap! I am running non-english forum, where dots are automatically replaced with commas. So:

$itrader[pcnt]=100.0
is fine for MySQL serwer, but
$itrader[pcnt]=100,0 (comma!)
means for MySQL server, that we try to send command "0" to a server, which ends up in an error :)

zlos

12-20-2005, 11:06 AM

Upgrage from 2.0.0 to 2.0.1 went smooooothly :)

Good job! :up:

zendiver

12-20-2005, 01:37 PM

Jason, in your template info.html you mention:
You can get creative and use some stars or something based on their score or positive ranking.
I am assuming (yeah I know :)) that this would be a conditional that would check their percentages and adjust the images accordingly. Am I off-base on this one?

eoc_Jason

12-20-2005, 02:38 PM

Spinball - It is coded so any group set to "iTrader Admin" will receive the emails. You can customize this quite easily by editing the functions_itrader.php file and changing the function itrader_email_admins. Just edit the WHERE clause in the query to your liking. That function is used to report suspicious activity & negative comments. The "report rating" page uses it's own chunk of code in its file, so if you want that changed too you will need to edit that file. In the next version I'll try to code it all to use that one function for simplicity.

mrderanged - Yes, that vB option controls the detailed comment length. If you customized any templates, you will need to revert them because of code changes. That's probably why it's not working.

mvigod - No, sorry, but I am not integrating anything into the thread/post tables or templates. I'm trying to keep this as separate as possible from the stock vB stuff. As mentioned before, this is meant to be very flexible and coding things like that would in effect limit how listings are posted, and also how the system can be used.

bennFF - That can (and should) be done using usergroups & auto-promotions.

zlos - That bug should have been fixed in 2.0.1, are you still experiencing it after upgrading?

zendiver - Yes, easiest thing would be to use some nested conditionals in your templates.

eoc_Jason

12-20-2005, 02:49 PM

One little glitch has been discovered that might affect your iTrader system from always showing as closed. There a few other changes / suggestions that have been made so I will try to release another update within the next couple days. (Today I have to go do my Christmas shopping!)

In the interm, if you are experiencing the problem described above, please PM me and I will explain a quick-fix.

GTAce

12-20-2005, 02:55 PM

Thanks Jason, I'm looking forward to the update - great job on this mod by the way, I'm VERY impressed!

mrderanged

12-20-2005, 03:32 PM

mrderanged - Yes, that vB option controls the detailed comment length. If you customized any templates, you will need to revert them because of code changes. That's probably why it's not working.

That did it. Thanks!!!

mrderanged

12-20-2005, 04:44 PM

Is it possible to edit who can view the detailed comments, say on a usergroup basis?

For example a usergroup permission "can view detailed comments"

just wondering

eoc_Jason

12-21-2005, 02:36 PM

mrderanged - Yes, you could add another setting in the itrader usergoup, all you have to do is modify the XML file, then rebuild your usergroup permissions, then add in permission checks at the various places.

VBUsers

12-21-2005, 11:35 PM

is there a way to get the search member option like in the older hack? or how bout a list of positive feed backs?

Trana

12-22-2005, 12:29 AM

What permissions do I need to change after the upgrade from 3.0.7 to 3.5? I found the one to allow view and ratings (Usergroup Manager, near the top), but my test user still can't view my own rating.

Any ideas?

Ncturnal

12-22-2005, 03:41 AM

dsotmoon

12-22-2005, 02:53 PM

Agreed. I have it installed, but I'm not able to use it at all. :(

there are many places throughout this thread showing the codes to use and where to put them

agiacosa

12-22-2005, 09:17 PM

Folks,

Does has anyone put together a rating dispute policy that they would care to share?

Thanks.

Trana

12-22-2005, 10:26 PM

Nevermind, I figured out what I was doing wrong.

sbryan

12-23-2005, 10:04 AM

hi guys i installed this tonight and all my old Trader Rating data migrated over perfectly!

just one question, i want the menu link to go to the Top traders list, not just your own feedback.

the existing code in my navbar template is;

<a href="itrader.php?$session[sessionurl]">Trader Rating</a>

what should i change it to?

Also can anyone recommend a good way to add this to peoples profile pages?

zendiver

12-23-2005, 01:52 PM

just one question, i want the menu link to go to the Top traders list, not just your own feedback.
I too would rather see the Top Trader list instead of my own profile. This would help others see exactly what is going on constantly instead of having to check out each member. Jason, is this possible?

Thanks and Merry Christmas all.

mrderanged

12-23-2005, 02:39 PM

There currently is no top trader list with this release. Hopefully the next one :)

tanker300

12-24-2005, 04:40 AM

Hi seems easy so far on istall. I think I have it on our new forums www.drywallzone.com
I placed a link on bottom for access to ratings area. How do you place a feedback?
I can not find it. I looked in the forum replies and threads. Is there some other code I need to place somewhere.

sadecosefo

12-24-2005, 03:17 PM

is there a way to get the search member option like in the older hack? or how bout a list of positive feed backs?

I would love to see a landing page with this. It is such a valuable tool it would be nice to have a little portal with it or something to view more ratings at one time, more statistics. You know, if someone has a few hundred hours of free time and absolutely nothing to do but codecodecode, right? ;)

Ncturnal

12-24-2005, 07:02 PM

there are many places throughout this thread showing the codes to use and where to put them

Many? I saw maybe a couple. Pardon me if I don't understand by looking at the code what it's supposed to look like. I didn't think a bit more explanation for someone who isn't a coder was too much to ask considering other people have requested the same thing I did, since Jason also admitted the documentation was lacking, and especially since I took the initiative to donate money. I'm not asking for a hand-out. I think it's a superb hack, and as such it should be well documented. The first hack description post should be updated so someone new to the hack doesn't have to look through 185+ posts just to figure out how to put working links on their board. Much of the 185 posts are troubleshooting other problems as well, so the specific fix I'm looking for isn't exactly easy to find. That's great that you know how to do this already, and even better that you think it's easy. If I was a pro at this, I wouldn't have been asking in the first place. I'm sure other amatuer hack installers would appreciate documentation in order to avoid the risk of breaking something else in the process. Also, it's not like I'll be the last one to ask if the documentation never gets updated.

Here's a good example of what I'm talking about with another mod. https://vborg.vbsupport.ru/showthread.php?t=65198

Damian

12-24-2005, 09:32 PM

Agreed. I have it installed, but I'm not able to use it at all. :(

What do you need help with?

GamerJunk.net

12-24-2005, 10:24 PM

Awesome I will install this as soon as possible

Jon_Simmonds

12-26-2005, 04:09 PM

installed and all workign so far

is there a possibility for a reent feedback given screen in the admin cp?

Thanks for this :D

dsotmoon

12-26-2005, 09:43 PM

That's great that you know how to do this already, and even better that you think it's easy. If I was a pro at this, I wouldn't have been asking in the first place.

hey, easy there big fella, i was just pointing out a fact in response to your post, if you dont want to search thru the posts to figure it out so you can use the hack thats up to you, I never said it was easy, I'm no coder or anything either, I read through and figured it out

Ncturnal

12-26-2005, 09:48 PM

hey, easy there big fella, i was just pointing out a fact in response to your post, if you dont want to search thru the posts to figure it out so you can use the hack thats up to you, I never said it was easy, I'm no coder or anything either, I read through and figured it out

Where did I ever say I didn't want to? I did search through every post in this thread. There were two instances (not many as you stated) citing examples to use that were not very clear, one of which put the results on the memberlist. A hack of this caliber should be well documented in the description area considering the majority of hacks released do so.

Ranger187

12-26-2005, 09:50 PM

Where did I ever say I didn't want to? I did search through every post in this thread. There were two instances (not many as you stated) citing examples to use that were not very clear, one of which put the results on the memberlist. A hack of this caliber should be well documented in the description area considering the majority of hacks released do so.

This hack was easy as pie to install... Installed.

Ncturnal

12-26-2005, 09:51 PM

This hack was easy as pie to install... Installed.

Yes, the install was easy. No doubt. Where do you put the links though? Something other than "get creative" with them as the documentation stated.

It's not like this has to be anything difficult either, which is why I really don't understand why it hasn't been done.

In the MEMBERINFO template:

Find:

sample code

replace with:

iTrader link code

I'd say 100% of the hacks I've installed had something along those lines. iTrader is by far a premier hack, and can't provide something that simple??? https://vborg.vbsupport.ru/external/2005/12/2.gif

Damian

12-26-2005, 11:03 PM

I'd say 100% of the hacks I've installed had something along those lines. iTrader is by far a premier hack, and can't provide something that simple??? https://vborg.vbsupport.ru/external/2005/12/2.gif

I offered to help you but it looks like you would rather just complain about the lack of documentation.
Maybe give that a rest and just post what you are wanting to do so you can get some help. :)

Ncturnal

12-26-2005, 11:05 PM

I offered to help you but it looks like you would rather just complain about the lack of documentation.
Maybe give that a rest and just post what you are wanting to do so you can get some help. :)

Was that you that IM'd me offering to help install it? I have it installed. I just need help with what templates should be modified for the links to show up. Basically just like my example above.

Damian

12-26-2005, 11:08 PM

No I didn't IM you but if you like you can just post where you want the links and I will write it up for you.

Ncturnal

12-26-2005, 11:11 PM

Like your board under the user's post count would be fine with me.

Damian

12-26-2005, 11:25 PM

Like your board under the user's post count would be fine with me.

To add to postbit

In postbit_legacy

Find:

<div>$vbphrase[posts]: $post[posts]</div>

After add:

<div>iTrader: <strong><a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a></strong> / $post[itrader_pcnt]% </div>

Ncturnal

12-26-2005, 11:30 PM

Thanks!

Ncturnal

12-26-2005, 11:55 PM

It looks like Strict URL Checking will not function if you have vBSEO installed.

cgchris99

12-27-2005, 12:31 AM

Ncturnal,

I'm just getting ready to put in iTrader and will be putting vbSEO in. Any further info on this. Is it a problem?

thanks

Ncturnal

12-27-2005, 12:36 AM

I haven't confirmed that is the cause yet, but I'm guessing it is. When you enter the thread URL, it's supposed to be http://www.site.com/forum/showthread.php?t=1234. vBSEO changes the thread URL to http://www.site.com/forum/forum-title/1234-thread-title.html. I'm guessing if you "reconstruct" the thread to the expected format (first link), and not the vBSEO format, it will work. Obviously, this is something beyond what most users will be able to figure out. I'm working on some bugs with the Paypal Donations hack. When I finish that, I'll do some testing.

barnie

12-27-2005, 02:34 AM

Who wants to help a new guy who has no idea how the heck to do this. 10 mins on MSN should do the trick :)

P.S. I got it to work on the member list page. I'd like it to work on the drop box when you click a name and on a user's profile page.

eoc_Jason

12-27-2005, 04:07 PM

Since vBSEO is a pay product, I have no way of testing / fixing issues related to it. However from the issue you described, you could edit the iTrader function to parse the string accordingly, shouldn't be too difficult to change.

Anyhow, I've been working on the documentation some, and it will be updated in the 2.0.2 release. Hopefully it will aleviate some of these questions about placement. I've been working on adding some more features too.

Nobody has really commented on the current setup. How does everything work for you guys? Easy to use? Difficult? Icons don't make sense? Links not working as expected? Bugs? Come on guys, give me some feedback... lol.

Now that Christmas is *finally* over I can get back to working on this.

zendiver

12-27-2005, 04:25 PM

Jason,

I really like like it and have since the earlier version. There really wasn't much difficulty getting this installed (yes, more documentation would have been nice, but I still had my old notes :)) so it really wasn't that difficult. I do miss not being able to see ALL the feedback given, instead of defaulting to your own page. If you want to see what someones elses rating is, you have to hunt that person down and click on their link that I have posted in the postbit. Other than that, I have no complaints what-so-ever. BTW, thanks for the feedback on the added feature with the feedback ratings conditional. Works great so far on my test site.

Merry belated Christmas to you, now "Get back to work!" :D

Ncturnal

12-27-2005, 04:26 PM

I love the current setup. I'm not used to the comment box, but I think it's a good idea. I did really like the Trader Ratings home page in the older version and would definitely like to see that one again.

KidneyBoy

12-27-2005, 05:47 PM

Sorry for no feedback Jason.

The software is wonderful. So far, there's been a bit confusion with the name "iTrader", but it works great, and is otherwise very easy to understand! I installed from a FRESH install, and it worked great the first time. I did the update as well, and that was problem-free.

I couldn't find the way to place the code in the memberlist, but I'm just not using it there, so it's working great otherwise. I was able to find what I felt was good placement for the profile, and postbit (and main index menu).

I don't know if you are accepting requests or not, but if there's something I would like to be able to display from the iTrader menu, it would be something like "The Last 10 or 20 feedbacks (of all member's feedback). I have heard also people request a "Top Posters" page if I understood right. This too might be a good place for such a request. But all honesty if you never added such a feature, I'd still be as happy as a pig in slop. I'm just thankful for what you have delivered to us so far (and I remember my promise to you the beginning of January.)

This program is so appreciated by me and my users, I cannot begin to thank you enough for it. Thank you for taking the time to create this! I look so forward to the "Trader Ratings" you'll be working on in the future!!!

Take it easy
KidneyBoy

WichitaRacing

12-27-2005, 06:02 PM

OK, first time for me using the Plugins system.

I uploaded all the files and imported the xml file. I now have iTrader Tools listed in the admincp.

However, that's all I have - nothing in the forum permissions.

Not sure where to go from here. I've attached a pic of my Plugin Manager screen.

lazyseller

12-27-2005, 06:12 PM

wichita go to usergroup settings and it will rebuilt the bitfields than u will see it at the bottom

How would i show the itrader ratings per forum only ? i tried adding a if conditional but its not showing up in the postbit... any ideas ?

WichitaRacing

12-27-2005, 07:13 PM

Got it guys, thanks. :)

WichitaRacing

12-27-2005, 11:28 PM

OK, more help required. I'm a coding newb.

I got a link in USERCP_SHELL. But it the cell w/ my link is a different color than the rest (see attachment).

Here's a snippet from the template:
do=editlist">$vbphrase[buddy_ignore_lists]</a></td>
</tr>
<if condition="$show['attachments']">
<tr>
<td class="$navclass[attachments]" nowrap="nowrap"><a class="smallfont" href="profile.php?$session[sessionurl]do=editattachments">$vbphrase[attachments]</a></td>
</tr>
</if>


<tr>
<td nowrap="nowrap">
<a class="smallfont" href="itrader.php?$session[sessionurl]">My iTrader</a>
</td>
</tr>


</table>


</td>

dsotmoon

12-28-2005, 12:57 AM

i may be mistaken but the alt color is probably called in the td class ...

<td class="$navclass[attachments]"

WichitaRacing

12-28-2005, 01:40 AM

i may be mistaken but the alt color is probably called in the td class ...

<td class="$navclass[attachments]"
That did it! Thanks!

What's the template that holds the post count, location, join date, etc. that is in every post?

Damian

12-28-2005, 01:58 AM

What's the template that holds the post count, location, join date, etc. that is in every post?

postbit and postbit_legacy

WichitaRacing

12-28-2005, 02:25 AM

postbit and postbit_legacy

Ah, forgot the darn legacy template. Thanks.

benFF

12-28-2005, 02:32 AM

Ah, forgot the darn legacy template. Thanks.

Awesome, with only a few extra lines, I've also got it verifying against a Photopost Classifieds installation :) I'll wait until the new version of this pops out though before i post it, just in case any major changes happen.

Rock on Jason!

Dennis B

12-29-2005, 03:02 PM

Thanks Jason!

/me upgrades!

sellbuydomain

12-29-2005, 03:32 PM

hi, i just move my new the forum to another hosting ,so i backup forum database and restore database in new hosting, does this mean the i trade database did not backup? i see there is an insert itrade database error, it looks like no table in the my database after i move the forum, can you guys look this error up
any way i can fix it? i already install the product and install the xml product again, problem still same,

Database error in vBulletin 3.5.2:

Invalid SQL:
INSERT INTO pmreceipt
(pmid, userid, touserid, tousername, title, sendtime)
VALUES
(35, 2, 5,
'dkegie', 'iTrader Rating Notification', 1135876701);

MySQL Error : Duplicate entry '35' for key 1
Error Number : 1062
Date : Thursday, December 29th 2005 @ 12:18:21 PM
Script : http://www.xxxx.net/itrader_feedback.php
Referrer : http://www.xxxx.net/itrader_feedback.php?u=5
IP Address : 71.34.223.543
Username : nertt
Classname : vb_database

Ncturnal

12-29-2005, 03:39 PM

benFF

12-29-2005, 03:45 PM

Before anyone asks... The necessary info to upgrade from Trader Ratings 3.0.x is included in the zip file...

Not sure if this is a bug or feature, but if you have strict checking on, and you put a post url (rather than a thread) - it still uses the name of the user who made the THREAD as its check.

So say for example, fred posted a thread, then joe posted saying he had that item (so you bought it)

When you came to link to the post as the deal post, it wouldn't let you, as it would say that rep can only be left for fred (not joe).

Or is it supposed to be like that?

eoc_Jason

12-29-2005, 04:28 PM

Ncturnal - Can you give me some specific URL examples that vBSEO makes? Or better yet just the URL to your forum so I can browse them myself? I can then create an option in the admincp to enable/disable vBSEO URL style when checking.

benFF - ThreadID or PostID it makes no difference. The PostID just queries back to find the Thread ID, thread creator id, etc. One of the two people engaged in the deal must be the thread creator or it will return invalid. If neither fred or joe originally created the thread, then it will not work. -- I'll double check verification though just for you.

On a different note, I was hoping to get some feedback from you guys. How much do you use the filters for "From Buyers", "From Sellers", "From Trades"? I want to add the capability to add in extra view types, however each time you add them, there's really no automatic way to make a filter work how you want without some additional coding from the end user. I was thinking just having two filter choices, "Feedback Received" and "Feedback Left For Others". I'll try to see if I can figure a better method as I don't want to loose the functionality, but at the same time I think additional user-defined rating types is important to have.

One of my own forum members found a little bug dealing with an error page not showing the correct date when trying to rate the same user. But that is minor, it will be fixed in 2.0.2

I've got my list of current things I'm trying to get in the 2.0.2 release, and am slowly whittling it down.

I'm sorry if I've been short with some of you guys lately, if you remember a while back I had to take my mom to the medical center for some tests, and well, they *thought* they saw something in her scans so she had to go back (went yesterday). I can breathe a big sigh of relief now as they said that there is nothing wrong and she is okay. (I was half expecting them to say there was a tumor or cancer or something, that's why I've been kind of on edge.)

Ncturnal

12-29-2005, 06:19 PM

Ncturnal - Can you give me some specific URL examples that vBSEO makes? Or better yet just the URL to your forum so I can browse them myself? I can then create an option in the admincp to enable/disable vBSEO URL style when checking.

Sure. It's www.mr2board.com. Also, I don't know if this helps at all, but I found this: http://www.vbseo.com/f2/vbseo-functions-extensibility-1662 It may as well be in Greek though, because I don't really know what they are saying there. :speechless: If you need to see any of the behind the scenes stuff just PM me.

phonexpo

12-29-2005, 08:39 PM

Excellent, installed. Thanks... :)

benFF

12-30-2005, 11:51 AM

Excellent, installed. Thanks... :)

Hi Jason,

Yes that was what I was saying - whereas I wanted it so if the *post* was by one of them it would validate (even if they hadn't started the thread) - I've modified my code to allow this..

So don't worry, your code is fine ;) Just not what I wanted to use it for :D

The only confusing thing my users find is the "Trades" - does this means trades as in a swap, or traders as in commercial entities? :)

eoc_Jason

12-30-2005, 01:43 PM

Trade as in swap (or barter)...

I'll get to looking at the vBSEO thing today.

Probably will have 2.0.2 released on Monday. Not sure if I will have all the features I was planning on adding, but it will have some more stuff I'm sure you guys will like.

I'm still trying to think more about how to make the choices customizable, and I think I've come up with a reasonable solution, but coding it is going to be a pain, so there will not be a time frame for when it will be implemented. Until then I guess the best course of action would be to edit it to suit your own needs, which isn't too difficult (to add extra transaction types).

Kihon Kata

12-30-2005, 01:56 PM

Jason, I have tried to PM you.

sellbuydomain

12-31-2005, 04:57 AM

hi, Jason, can you look up my last post here, i have an error on the forum, can you take a few mins to look up the error i post, please help, thank you

techxpert

12-31-2005, 11:46 AM

I also can't users to strict URL when submitting feedback.
I have static URL on my forum like www.website.com/forum/thread133.html

Is there is any work around?

telc

12-31-2005, 05:24 PM

Is there a way to setup a conditional in the the postbit, so it only shows the "iTrader" info if the user has at least 1 feedback?

djwins

01-03-2006, 04:35 AM

<if condition="$post['ratetradetotal']"></if>

That was for the older Trader Ratings code...the new one is probably itradertotal or something...

Puntoboy

01-03-2006, 12:00 PM

i want to add the itrader score so that it shows up when users post.

how would i do this so it appears under their post count?

<<<<< over here.

telc

01-03-2006, 12:21 PM

i want to add the itrader score so that it shows up when users post.

how would i do this so it appears under their post count?

<<<<< over here.

Add it to the postbit template or postbit_legacy template, whichever you use on your forum.

Puntoboy

01-03-2006, 12:27 PM

whats the code and where do i add it?

telc

01-03-2006, 01:00 PM

whats the code and where do i add it?

Its in the installation instructions.

Puntoboy

01-03-2006, 01:02 PM

i looked there, found the code, but it didn't really explain in any detail where to put it.

Puntoboy

01-03-2006, 01:49 PM

here is the code that my old 3.0.6 template had...

<if condition="$post['field2']"><div>$vbphrase[location_perm]: $post[field2]</div></if>
<if condition="$post['field68'] == ''">
<div>Region:</div>
<else />
<div>Region: $post[field68]</div>
</if>
<if condition="$post['userid']"><div>Trader Rating: (<a href="traderratings.php?$session[sessionurl]u=$post[userid]">$post[ratetradetotal]</a>)</div></if>
<if condition="$post['age']"><div>$vbphrase[age]: $post[age]</div></if>
<if condition="$post['field5'] == ''">
<div>Punto:</div>
<else />
<div>Punto: $post[field5]</div>

it also displays some of their frofile information. but this doesn't appear to work.

dsotmoon

01-03-2006, 05:44 PM

it should look something like this

<div>
$vbphrase[posts]: $post[posts]
</div><br />
<if condition="$post['userid']"><div>iTrader : (<b><a href="itrader.php?$session[sessionurl]u=$post[userid]">$post[itrader_total]</a></b>)</div></if><

Puntoboy

01-03-2006, 06:59 PM

thanks, but i've tried inserting it into the postbit template, but nothing happens.

here is my postbit code


<if condition="$show['spacer']">
$spacer_open
<div id="edit$post[postid]" style="padding:0px 0px $stylevar[cellpadding]px 0px">
<if condition="!$post['islastshown']"></if>
</if>

<table class="tborder" id="post$post[postid]" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="thead" $post[scrolltothis]>
<div class="normal" style="float:$stylevar[right]">
 
<if condition="$show['postcount']">#<a href="showpost.php?$session[sessionurl]p=$post[postid]&postcount=$post[postcount]" target="new" rel="nofollow" id="postcount$post[postid]" name="$post[postcount]"><strong>$post[postcount]</strong></a>  </if>
<if condition="$show['reputationlink']"><a href="reputation.php?$session[sessionurl]p=$post[postid]" rel="nofollow"><img class="inlineimg" src="$stylevar[imgdir_button]/reputation.gif" alt="<phrase 1="$post[username]">$vbphrase[add_to_xs_reputation]</phrase>" border="0" /></a>  </if>
<if condition="$show['reportlink']"><a href="report.php?$session[sessionurl]p=$post[postid]" rel="nofollow"><img class="inlineimg" src="$stylevar[imgdir_button]/report.gif" alt="$vbphrase[report_bad_post]" border="0" /></a>  </if>
$post[iplogged]
<if condition="$show['inlinemod']">
<input type="checkbox" name="plist[$postid]" id="plist_$postid" style="vertical-align:middle; padding:0px; margin:0px 0px 0px 5px" value="$post[checkbox_value]" onclick="inlineMod.toggle(this)" />
</if>
</div>

<div class="normal">

<a name="post$post[postid]"><img class="inlineimg" src="$stylevar[imgdir_statusicon]/post_$post[statusicon].gif" alt="$post[statustitle]" border="0" /></a>
<if condition="!$show['announcement']">
$post[postdate]<if condition="!$show['detailedtime']">, $post[posttime]</if>
<else />
<phrase 1="$post[startdate]" 2="$post[enddate]">$vbphrase[x_until_y]</phrase>
</if>
$post[firstnewinsert]

</div>
</td>
</tr>
<tr>
<td class="alt2" style="padding:0px">

<table cellpadding="0" cellspacing="$stylevar[cellpadding]" border="0" width="100%">
<tr>
<if condition="$show['avatar']"><td class="alt2"><a href="member.php?$session[sessionurl]u=$post[userid]"><img src="$post[avatarurl]" $post[avwidth] $post[avheight] alt="<phrase 1="$post[username]">$vbphrase[xs_avatar]</phrase>" border="0" /></a></td></if>
<td nowrap="nowrap">

<div id="postmenu_$post[postid]">
<if condition="$show['profile']">
<a class="bigusername" href="member.php?$session[sessionurl]u=$post[userid]">$post[musername]</a> <if condition="$post['arcadeawards']"><a class="bigusername" href="member.php?$session[sessionurl]u=$post[userid]"><img src="$vboptions[arcadeimages]/trophy.gif" align="absmiddle" alt="$vbphrase[arcade_champion]" border="0" /></a></if>

$post[onlinestatus]
<script type="text/javascript"> vbmenu_register("postmenu_$post[postid]", true); </script>
<else />
$post[musername]
</if>
</div>

<if condition="$post['usertitle']"><div class="smallfont">$post[usertitle]</div></if>
<if condition="$post['rank']"><div class="smallfont">$post[rank]</div></if>

</td>
<td width="100%"> </td>
<td valign="top" nowrap="nowrap">

<div class="smallfont">
<if condition="$post['joindate']"><div>$vbphrase[join_date]: $post[joindate]</div></if>
<if condition="$post['field2']"><div>$vbphrase[location_perm]: $post[field2]</div></if>
<if condition="$post['age']"><div>$vbphrase[age]: $post[age]</div></if>
<div>
$vbphrase[posts]: $post[posts]
</div>
<if condition="$show['reputation']"><if condition="$show['reppower']">$vbphrase[reppower]: $post[reppower] </if><div>$post[reputationdisplay]</div></if>
<div>$post[icqicon] $post[aimicon] $post[msnicon] $post[yahooicon] $post[skypeicon]</div>
</div>

</td>
</tr>
</table>

</td>
</tr>
<tr>
<td class="alt1" id="td_post_$post[postid]">


<if condition="$show['messageicon'] OR $post['title']">

<div class="smallfont">
<if condition="$show['messageicon']"><img class="inlineimg" src="$post[iconpath]" alt="$post[icontitle]" border="0" /></if>
<if condition="$post['title']"><strong>$post[title]</strong></if>
</div>
<hr size="1" style="color:$stylevar[tborder_bgcolor]" />

</if>


<div id="post_message_$post[postid]">$post[message]</div>


<if condition="$show['attachments']">

<div style="padding:$stylevar[cellpadding]px">

<if condition="$show['thumbnailattachment']">
<fieldset class="fieldset">
<legend>$vbphrase[attached_thumbnails]</legend>
<div style="padding:$stylevar[formspacer]px">
$post[thumbnailattachments]
</div>
</fieldset>
</if>

<if condition="$show['imageattachment']">
<fieldset class="fieldset">
<legend>$vbphrase[attached_images]</legend>
<div style="padding:$stylevar[formspacer]px">
$post[imageattachments]
</div>
</fieldset>
</if>

<if condition="$show['imageattachmentlink']">
<fieldset class="fieldset">
<legend>$vbphrase[attached_images]</legend>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
$post[imageattachmentlinks]
</table>
</fieldset>
</if>

<if condition="$show['otherattachment']">
<fieldset class="fieldset">
<legend>$vbphrase[attached_files]</legend>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
$post[otherattachments]
</table>
</fieldset>
</if>

<if condition="$show['moderatedattachment']">
<fieldset class="fieldset">
<legend>$vbphrase[attachments_pending_approval]</legend>
<table cellpadding="0" cellspacing="$stylevar[formspacer]" border="0">
$post[moderatedattachments]
</table>
</fieldset>
</if>

</div>

</if>

<if condition="$post['signature']">

<div>
__________________<br />
$post[signature]
</div>

</if>

<if condition="$show['postedited']">

<div class="smallfont"> <hr size="1" style="color:$stylevar[tborder_bgcolor]" />
<em>
<phrase 1="$post[edit_username]" 2="$post[edit_date]" 3="$post[edit_time]">$vbphrase[last_edited_by_x_on_y_at_z]</phrase>.
<if condition="$post['edit_reason']">$vbphrase[reason]: $post[edit_reason]</if>
</em>
</div>

</if>

<div align="$stylevar[right]">

<if condition="$post['editlink']">
<a href="$post[editlink]" name="vB::QuickEdit::$post[postid]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
</if>
<if condition="$post['forwardlink']">
<a href="$post[forwardlink]"><img src="$stylevar[imgdir_button]/forward.gif" alt="$vbphrase[forward_message]" border="0" /></a>
</if>
<if condition="$post['replylink']">
<a href="$post[replylink]" rel="nofollow"><img src="$stylevar[imgdir_button]/<if condition="$post['forwardlink']">reply_small<else />quote</if>.gif" alt="$vbphrase[reply_with_quote]" border="0" /></a>
</if>
<if condition="$show['quickreply'] AND !$show['threadedmode']">
<a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<if condition="$show['moderated']">
<img src="$stylevar[imgdir_misc]/moderated.gif" alt="$vbphrase[moderated_post]" border="0" />
</if>

</div>



</td>
</tr>
</table>


<div class="vbmenu_popup" id="postmenu_$post[postid]_menu" style="display:none">
<table cellpadding="4" cellspacing="1" border="0">
<tr>
<td class="thead">$post[username]</td>
</tr>
<if condition="$show['profile']">
<tr><td class="vbmenu_option"><a href="member.php?$session[sessionurl]u=$post[userid]">$vbphrase[view_public_profile]</a></td></tr>
</if>
<if condition="$show['pmlink']">
<tr><td class="vbmenu_option"><a href="private.php?$session[sessionurl]do=newpm&u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[send_private_message_to_x]</phrase></a></td></tr>
</if>
<if condition="$show['emaillink']">
<tr><td class="vbmenu_option"><a href="sendmessage.php?$session[sessionurl]do=mailmember&u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[send_email_to_x]</phrase></a></td></tr>
</if>
<if condition="$show['homepage']">
<tr><td class="vbmenu_option"><a href="$post[homepage]"><phrase 1="$post[username]">$vbphrase[visit_xs_homepage]</phrase></a></td></tr>
</if>
<if condition="$show['search']">
<tr><td class="vbmenu_option"><a href="search.php?$session[sessionurl]do=finduser&u=$post[userid]" rel="nofollow"><phrase 1="$post[username]">$vbphrase[find_all_posts_by_x]</phrase></a></td></tr>
</if>
<if condition="$post['userid'] AND $show['member']">
<tr><td class="vbmenu_option"><a href="profile.php?$session[sessionurl]do=addlist&userlist=buddy&u=$post[userid]"><phrase 1="$post[username]">$vbphrase[add_x_to_buddy_list]</phrase></a></td></tr>
</if>

<if condition="$post['arcadeawards']">
<tr><td class="thead"><phrase 1="$post[username]">$vbphrase[xs_arcade_awards]</phrase></a></td></tr>
$post[arcadeawards]
</if>
<if condition="($post['arcadeoptions'] & 1) AND $post['userid']!=$bbuserinfo['userid']">
<tr><td class="thead">$vbphrase[arcade]</a></td></tr>
<tr><td class="vbmenu_option"><a href="arcade.php?do=newchallenge&userid=$post[userid]"><phrase 1="$post[username]">$vbphrase[challenge_x_in_the_arcade]</phrase></td></tr></if>

</table>
</div>


<if condition="$show['spacer']">
</div>
$spacer_close
</if>


where would i add your code so a users current trader rating appears above their post count?