Improved PM Popup JavaScript

What's it do?
Simple: it checks to see how many new PMs a user has. If they've only got one (which is usually the case...I don't think many people get tons of new PMs), the popup JavaScript alert displayed to them will let them know who sent them the message, what it's title is, and, rather than take them to the Inbox, it'll take them directly to the message.

If there's more than one, it'll display a more vague message, letting them know just how many new messages they have, and redirecting them to their Inbox (which is where the current popup directs you). Anyway, here's the hack:


Open global.php. Around line 266 you should see the following:

$newpmmsg=1;

RIGHT below it, place this (REPLACE your current code for this hack with the code below, if you happen to be one of the few people who actually intalled this originally from the Beta Hacks forum. )

  $latest_pm = $DB_site->query("SELECT p.privatemessageid AS pm_popup_id, p.title AS pm_popup_title, u.username AS pm_popup_username FROM privatemessage p, user u WHERE messageread = 0 AND p.userid = $bbuserinfo[userid] AND p.fromuserid = u.userid ORDER BY dateline DESC");
  $hack_pm_total  = $DB_site->num_rows($latest_pm);
  
    if ($hack_pm_total > 1) {
      eval("\$pm_popup_text = \"".gettemplate('pm_popup_multiple')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url_multiple')."\";");
    } else {
      extract($DB_site->fetch_array($latest_pm));
      eval("\$pm_popup_text = \"".gettemplate('pm_popup')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url')."\";");
    }

Now, create the four new templates. I've attached a file to this post containing the names of the four templates, and the text I've used to populate them -- which will probably be the same text and such you'll want to use. Don't be intimidated...they're all very small.

After that, edit your head_newpm template to make use of the new variables. Here's my use of it (highly suggested):

<script language="JavaScript">
<!--
function confirm_newpm() {
	input_box = confirm("$pm_popup_text");
	if (input_box == true) { // Output when OK is clicked
		second_box = confirm("Open in new window?\n\n(Press cancel to open your $inboxname in the current window.)");
		if (second_box == true) {
			window.open('$pm_popup_url','pmnew','width=600,height=500,menubar=yes,scrollbars=yes,toolbar=yes,location=yes,directories=yes,resizable=yes,top=50,left=50'); 
		} else {
			window.location = "$pm_popup_url";
		}
	} else {
	// Output when Cancel is clicked
	}
}
-->
</script>

Enjoy.

[TWTCommish]

Here's an image of what the single-PM popup looks like:
https://vborg.vbsupport.ru/attachmen...414&fullpage=1

[Scott MacVicar]

you could have moved the thread from the beta forum to the full releases forum you know :P cause you have permission to do that.

anyway i've installed something like this, but it shows you how many unread messages you have and the last time and username

[TWTCommish]

Actually, I contacted FireFly via PM and asked him how I should go about this, and he advised me to create a new thread and close the old one; so I did. I also sent an update to the old users informing them of the new thread.

anyway i've installed something like this, but it shows you how many unread messages you have and the last time and username

I'm afraid I don't understand. My hack does the same thing, doesn't it? If you have more than one, it tells you how many you have waiting and takes you to the Inbox. If you have only one, it gives you the title, the sender's username, and takes you right to the message itself. Perhaps you're thinking of the functionality of this hack when I released it in the Beta forum, rather than it's functionality now.

[Ninth Dimension]

This is a cool hack, i've just installed it, thank you.

One question, and as always, I could be wrong, but should this line not be removed from the file?

PHP Code:

  eval("\$headnewpm = \"".gettemplate('head_newpm')."\";"); 


Thanx

[TWTCommish]

From what file -- global.php? No! That's the part that processes the finished template and makes it available globally. Absolutely essential.

[Ninth Dimension]

ah ok, my bad

[TWTCommish]

No problem: thanks for installing it. I'm glad you like it. I get a real kick out of anyone who finds this stuff useful.

[squawell]

a good hack!!but it seems can't work for me!!i think maybe i do something wrong??see the below code what i change to

PHP Code:

 $newpmmsg=1; 
    $latest_pm = $DB_site->query("SELECT p.privatemessageid AS pm_popup_id, p.title AS pm_popup_title, u.username AS pm_popup_username FROM privatemessage p, user u WHERE messageread = 0 AND touserid = $bbuserinfo[userid] AND p.fromuserid = u.userid ORDER BY dateline DESC");
    $hack_pm_total  = $DB_site->num_rows($latest_pm);
  
    if ($hack_pm_total > 1) {
      eval("\$pm_popup_text = \"".gettemplate('pm_popup_multiple')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url_multiple')."\";");
    } else {
      extract($DB_site->fetch_array($latest_pm));
      eval("\$pm_popup_text = \"".gettemplate('pm_popup')."\";");
      eval("\$pm_popup_url  = \"".gettemplate('pm_popup_url')."\";");
    }

    eval("\$headnewpm = \"".gettemplate('head_newpm')."\";");
  } 


am i do something wrong??

[TWTCommish]

Hmmm -- did you install the templates, too?