Whats wrong with this code?

[Rich]

Hello,

This code isn't working as expected. I am not familiar with 3.5, so I am not certain what is wrong with it. This was a 3.0.X modification and I am trying to implement it on my 3.5 board.

How it is SUPPOSED to work:

Shows the guest a message - that works

Once registered, if they haven't confirmed their email, it will show an "Unconfirmed" message.

Once confirmed, it will show a new box at the top telling them they haven't posted yet and encourages them to post a welcome message in the "intro" forum.

I haven't been able to locate where I got this modification, so I couldn't contact the original author for advice. Here is the code:

<if condition="$show['guest']"> 
<!-- guest welcome message --> 
<br />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr> 
<td class="alt1" colspan="6">
     <phrase 1="faq.php?$session[sessionurl]" 2="register.php?$session[sessionurl]">$vbphrase[first_visit_message]</phrase>
     $vbphrase[welcome_ads]
</td>
</tr>
</thead>
</table>
<!-- / guest welcome message -->
<else /> 
<if condition="!is_member_of($userinfo, 3)">
<!-- / unconfirmed user message -->
<br />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr> 
<td class="alt1" colspan="6">
   $vbphrase[welcome_unconfirmed]
   $vbphrase[welcome_ads]
</td>
</tr> 
</thead>
</table>
<!-- / unconfirmed user message -->
<else />
<if condition="$bbuserinfo[postcount] == 0">
<!-- never posted message -->
<br />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr>
   <td class="alt1" colspan="6">
     <phrase 1="$bbuserinfo[username]">$vbphrase[welcome_neverposted]</phrase>
       $vbphrase[welcome_ads]
</td>
</tr>
</thead>
</table> 
<!-- / never posted message -->
</if></if></if><br />

I have been testing it, and it freezes on the "Unconfirmed Message". Even when confirmed, it stays on the unconfirmed message. I removed that section, and it then freezes on the first "Post Message" even after several posts have been made.

I know that this is a quick fix for those of you that know the 3.5 code. I have been researching it and looking at other modifications, but I can't see what the problems are.

Any help would be greatly appreciated.

[Andreas]

<if condition="is_member_of($bbuserinfo, 3)">, as you want to show that for Users in Usergroup ID 3, right?

<if condition="$bbuserinfo[postcount] == 0"> should be <if condition="!$bbuserinfo[lastpost]"> or <if condition="!$bbuserinfo[posts]"> (if you only want it to disappear for counted posts)

[Rich]

Hello,

Thanks Kirby. Here is my dilemma. I must be doing something wrong, I don't know.

I have decided to do everything by usergroup id and promotions. I have created the following promotions:

Registered Users - are at zero posts
Registered Users 1 - 1 post
Registered Users 2 - 2 posts
Registered Users 3 - 35 posts (gets sigs)

So, if I am correct, Registered users (usergroup id 2) would be promoted to registered 1 after they make 1 post (usergroup id 10)

After 2 posts, they go to registered 2 (usergroup id 9)

After 35 posts, they would go to registered 3 (usergroup id 11)

This is what my code now says:

<if condition="$show['guest']"> 
	<!-- guest welcome message --> 
	<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
	<thead>
	<tr> 
	<td class="alt1" colspan="6">
	    <phrase 1="faq.php?$session[sessionurl]" 2="register.php?$session[sessionurl]">$vbphrase[first_visit_message]</phrase>
	     $vbphrase[welcome_ads]
	</td>
	</tr>
	</thead>
	</table>
	<!-- / guest welcome message -->
<else />
<if condition="is_member_of($bbuserinfo, 2)">
<!-- never posted message -->
<br />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr>
   <td class="alt1" colspan="6">
     <phrase 1="$bbuserinfo[username]">$vbphrase[welcome_neverposted]</phrase>
       $vbphrase[welcome_ads]
</td>
</tr>
</thead>
</table> 
<!-- / never posted message -->
<else />
<if condition="is_member_of($bbuserinfo, 10)">
<!-- never posted message -->
<br />
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr>
   <td class="alt1" colspan="6">
     <phrase 1="$bbuserinfo[username]">$vbphrase[welcome_postedone]</phrase>
       $vbphrase[welcome_ads]
</td>
</tr>
</thead>
</table> 
<!-- / never posted message -->
</if>
</if>
</if>
<br />

I am still stuck with the "never posted message" after they posted! I don't understand why. They should be seeing the second message after they made their first post I would have thought.