Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 08-26-2005, 03:57 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Firefox Quick Reply Problem

I recently added an ad banner in the postbit. The banner is set up to show up in the last post on the page being viewed.

If I use QR now with firefox, the page hangs after I sumbit the reply and it tries to load the banner as the whole page for some odd reason.

In IE, it works just fine. The page shows and there is no ad in the last post unless you view thread again.

If I use the regular reply button in firefox, it works as well. I am redirected to the page and the ad shows.

I guess one fix would be for me to redirect members back to the forumdisplay page instead of their post - but I don't want to penalize people for a bug that seems to just affect firefox.

Also, my most active members won't have the problem because they don't have ad banners on their pages.

Any ideas on how I can fix this?

Amy
Reply With Quote
  #2  
Old 08-26-2005, 04:30 PM
Chris M's Avatar
Chris M Chris M is offline
 
Join Date: Dec 2001
Location: Northampton, England
Posts: 6,186
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by amykhar
I recently added an ad banner in the postbit. The banner is set up to show up in the last post on the page being viewed.

If I use QR now with firefox, the page hangs after I sumbit the reply and it tries to load the banner as the whole page for some odd reason.

In IE, it works just fine. The page shows and there is no ad in the last post unless you view thread again.

If I use the regular reply button in firefox, it works as well. I am redirected to the page and the ad shows.

I guess one fix would be for me to redirect members back to the forumdisplay page instead of their post - but I don't want to penalize people for a bug that seems to just affect firefox.

Also, my most active members won't have the problem because they don't have ad banners on their pages.

Any ideas on how I can fix this?

Amy
Deny all firefox users from viewing your site, with a message like "Get Internet Explorer you rebel!"

Satan
Reply With Quote
  #3  
Old 08-26-2005, 04:35 PM
Adrian Schneider's Avatar
Adrian Schneider Adrian Schneider is offline
 
Join Date: Jul 2004
Posts: 2,528
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by hellsatan
Deny all firefox users from viewing your site, with a message like "Get Internet Explorer you rebel!"

Satan
That leaves those who can't operate the quick reply!

Just kidding.
Reply With Quote
  #4  
Old 08-26-2005, 04:36 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I use firefox
Reply With Quote
  #5  
Old 08-26-2005, 04:38 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thinking out loud here. I wonder if giving the google span an id and then figuring out how to set that puppy to not show right after a QR ajax update would work?
Reply With Quote
  #6  
Old 08-26-2005, 06:15 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Fixed it. I doubt anybody else will have this problem, but if you do, there's an easy solution.

In the function function qr_do_ajax_post(), slap this at the top of the function:
Code:
	if (!is_ie)
	{
		 window.location.reload(true);
	}
No more page hangs. Whew!
Reply With Quote
  #7  
Old 08-26-2005, 08:55 PM
Marco van Herwaarden Marco van Herwaarden is offline
 
Join Date: Jul 2004
Posts: 25,415
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hmm i think i actually have the same problem with ad-sense on a board i do. I have ad-sense after each first post, and i had also complaints about pages not loading after quick reply.
Reply With Quote
  #8  
Old 08-30-2005, 02:04 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Marco,
Scott gave me a better solution.

If we make sure that $vbulletin->GPC['ajax'] is not true before we show the ad, it should be ok.
Reply With Quote
  #9  
Old 08-30-2005, 03:37 PM
Gryphon's Avatar
Gryphon Gryphon is offline
 
Join Date: Oct 2001
Location: Seattle, WA
Posts: 617
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by amykhar
Marco,
Scott gave me a better solution.

If we make sure that $vbulletin->GPC['ajax'] is not true before we show the ad, it should be ok.
Can you detect that with template edits alone? I assume that $vbulletin->GPC['ajax'] is used via file edit?

Code:
<if condition="!$GLOBALS['FIRSTPOSTID'] && !$vbulletin->GPC['ajax']">
Reply With Quote
  #10  
Old 08-30-2005, 03:38 PM
amykhar's Avatar
amykhar amykhar is offline
 
Join Date: Oct 2001
Location: PA
Posts: 4,438
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

It's a template conditional in the postbit template.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 04:44 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05113 seconds
  • Memory Usage 2,255KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_code
  • (3)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete