Regular members can see notes?

I'm not quite sure if this is an error on my part or not. x.X; The settings are correct in the admincp for the Admins & Mods group, and none of the members seems to accidentally be in any of those groups, but I've had a regular member tell me they say one of the Notes above the posts.

I'm using the Legacy postbit, and I did make sure to read the special instructions for it. There doesn't seem to be anything missing between the fresh install and the upgrade install!

[sv1cec]

Can that member of yours see the "Warn XYZ" link or button?

[Diana Notacat]

Nope, they don't see any of the links to warn users or add the notes, but he said he saw the note itself. o.o

[sv1cec]

That's wierd. In order for the note to be shown, the post should have a note and the $showviewwarnlink parameter be set. This parameter gets set depending on the usage or not of the hierarchical schema, only for the management team (there are some details there, but in general, that's the idea). It's impossible for a member to see a note, as it is impossible to see the "View XYZ's Warnings" button.

Please check the code again, in includes/functions_showthread.php, in case you have made a mistake.

[Xoxideforums]

I'm having the exact same problem but it's only the public notes that the regular users (including guests) can see, the private notes are hidden correctly. Any ideas? The "add note", "view warnings", etc. links are NOT visible for normal users (or guests).

[sv1cec]

Sorry guys, one of my twins is in the hospital, so I can't check anything out at this time. Probably over the weekend if the kid is released on Saturday morning.

Sorry

[bigcurt]

Hope everything is ok John..take care.

~Curt

[sv1cec]

I am checking the program for the notes issue, being viewable by normal members, and from what I see, in order to a note to be shown, the member has to be able to view the "View XYZ Warnings" link as well.

That means that depending on your settings:

1) The post is not made by a mod, smod or admin, while the user viewing the post is either a mod, smod or admin (when not using the hierarchical schema)
2) The post is made by someone who is not a mod/smod/admin, and the user is an smod/mod/admin, or the post is made by a mod and the user is an smod/admin, or finally if the user is an admin and the post hasn't been made by another admin.

I can see no way that a regular user can see a note, if the changes made in functions_showthread.php are correct. Please verify these changes, and if you still have issues please come back giving me some details of the post and the user, as well as your settings (if you are using hierarchical or not).

[sv1cec]

OK, I have that figured out, are you folks using "Who can view warning points" set to "Yes"?

If so, there will be a bug fix release out in a while, 3.4.16.

Rgds

[sv1cec]

Golks, please note that there is a bug in the instructions, for the includes/functions_showthread.php file, which caused your user to see the notes. A darn ; in the wrong place was causing all this. Please open that file and fnd:

if ($post['warn_notes']==1 AND ($useradmin==1 OR $usersmod==1 OR $usermod==1));

Remove that ; from the end of the line, and everything should work as expected.

Sorry, my bad!