Thread title first character uppercase

[Andy]

I like to see the thread title always start with an uppercase. I was able to figure out how to do this in newthread.php

In v3.5.0 beta 4 I added to line 133 this code...

$newpost['title'] = strtoupper($newpost['title']{0}).substr($newpost['title'], 1);

However I also need to add a similar code to the editpost.php file. I tried many things but was not able to do it.

Can someone who understands editpost.php better take a look and see where I can add code to make edited thread titles always start with an uppercase character.

Thank you.

[Christine]

Just at a quick glance, but take a look around line 387

PHP Code:

$threadman->set('title', unhtmlspecialchars($edit['title'])); 


If I am reading that right, that routine should edit the title of the thread if the post being edited is the first post.

[Andreas]

*** Untested ***

Hookname: threadfpdata_presave

PHP Code:

$this->thread['title'] = ucfirst($this->thread['title']);
$this->post['title'] = ucfirst($this->post['title']); 


Hookname: postdata_presave

PHP Code:

if ($this->existing['postid'] == $this->info['thread']['firstpostid'])
{
    $this->post['title'] = ucfirst($this->post['title']);
} 


Hookname: threaddata_presave

PHP Code:

$this->thread['title'] = ucfirst($this->thread['title']); 


This should take care of Thread Titles, no matter where they are being set/edited.

[Christine]

Hi Andy,

You may want to remove the code edits and try Kirby's suggestions. If what he is thinking will work, then it will be 2 less files that you have to fiddle with on upgrades.

Personally, I can't wait until I have a handle on the new plugin system. I am still in find-code-modify-code mode.

[Andy]

Thank you Christine for your time.

Kirby your awesome, that worked perfect. :up:

[Christine]

Andy,

No problem. Don't know why you deleted your post, but don't forget to take out the code edits you made. That would be a Christine move. Heh.

[Andy]

Hi Christine,

The Automerged Doublepost hack had me all confused. What PITA that is, people should be able to post twice in a row.

[Andreas]

Originally Posted by Andy

What PITA that is, people should be able to post twice in a row.

Sorry, but I have to disagree strongly
People posting several times in a row are a PITA!

Prevent Doubleposting is one of the best Hacks ever.

[Andy]

Originally Posted by KirbyDE

*** Untested ***

Hookname: threadfpdata_presave

PHP Code:

$this->thread['title'] = ucfirst($this->thread['title']);
$this->post['title'] = ucfirst($this->post['title']); 


Hookname: postdata_presave

PHP Code:

if ($this->existing['postid'] == $this->info['thread']['firstpostid'])
{
    $this->post['title'] = ucfirst($this->post['title']);
} 


Hookname: threaddata_presave

PHP Code:

$this->thread['title'] = ucfirst($this->thread['title']); 


This should take care of Thread Titles, no matter where they are being set/edited.

There is a bug in this code. If a users posts a new posts to the thread, the thread title changes to a "0".

[Andreas]

Great that I labeled it untested

Hookname: threaddata_presave

PHP Code:

if ($this->thread['title'])
{
    $this->thread['title'] = ucfirst($this->thread['title']);
}