Go Back   vb.org Archive > vBulletin Modifications > Archive > vB.org Archives > Premium Archives > Advanced Warning System (AWS)
FAQ Community Calendar Today's Posts Search

Closed Thread
 
Thread Tools
Code optimization Details »»
Code optimization
Version: , by kmike kmike is offline
Developer Last Online: Apr 2014 Show Printable Version Email this Page

Version: Unknown Rating:
Released: 04-28-2005 Last Update: Never Installs: 0
 
No support by the author.

It is possible to reduce code size by some twenty lines, using regular expressions.
in includes/functions_showthread.php, whole fragment
Code:
		$admgroups=explode("|",$vboptions['warn_admingroups']);
		$modgroups=explode("|",$vboptions['warn_modgroups']);
		$smodgroups=explode("|",$vboptions['warn_smodgroups']);
		
		if($admgroups[0])
		{
			foreach($admgroups as $adm)
			{
				if ($adm==$bbuserinfo['usergroupid'])
				{
					$useradmin=1;
				}
			}
		}
		if($modgroups[0])
		{
			foreach($modgroups as $mod)
			{
				if ($mod==$bbuserinfo['usergroupid'])
				{
					$usermod=1;
				}
			}
		}
		if($smodgroups[0])
		{
			foreach($smodgroups as $smod)
			{
				if ($smod==$bbuserinfo['usergroupid'])
				{
					$usersmod=1;
				}
			}
		}
		
		if($admgroups[0])
		{
			foreach($admgroups as $adm)
			{
				if ($adm==$userinfo['usergroupid'])
				{
					$postadmin=1;
				}
			}
		}
		if($modgroups[0])
		{
			foreach($modgroups as $mod)
			{
				if ($mod==$userinfo['usergroupid'])
				{
					$postmod=1;
				}
			}
		}
		if($smodgroups[0])
		{
			foreach($smodgroups as $smod)
			{
				if ($smod==$userinfo['usergroupid'])
				{
					$postsmod=1;
				}
			}
		}
could be replaced with
Code:
                $useradmin = preg_match("/^(.*|)?$bbuserinfo[usergroupid](|.*)?$/",$vboptions['warn_admingroups']);
                $postadmin = preg_match("/^(.*|)?$post[usergroupid](|.*)?$/",$vboptions['warn_admingroups']);

                $usermod = preg_match("/^(.*|)?$bbuserinfo[usergroupid](|.*)?$/",$vboptions['warn_modgroups']);
                $postmod = preg_match("/^(.*|)?$post[usergroupid](|.*)?$/",$vboptions['warn_modgroups']);

                $usersmod = preg_match("/^(.*|)?$bbuserinfo[usergroupid](|.*)?$/",$vboptions['warn_smodgroups']);
                $postsmod = preg_match("/^(.*|)?$post[usergroupid](|.*)?$/",$vboptions['warn_smodgroups']);
There's exactly the same code fragment in member.php which should use the similar treatment.

Show Your Support

  • This modification may not be copied, reproduced or published elsewhere without author's permission.

Comments
  #2  
Old 04-28-2005, 12:37 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks for the tip, I'll check it out.
Closed Thread


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 06:59 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03473 seconds
  • Memory Usage 2,199KB
  • Queries Executed 15 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (2)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)modsystem_post
  • (1)navbar
  • (6)navbar_link
  • (120)option
  • (2)post_thanks_box
  • (2)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit_info
  • (1)postbit
  • (2)postbit_onlinestatus
  • (2)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete