Fix for smilie display problem

As many of you know, the parsing of vB smilies is rather odd and can be a huge headache when it comes to multiple codes not parsing correctly

ie:

uke: and

as you can see, the smilies are parsed by display order so

:p

gets parsed before

:puke:

therefore the longer smilie code doesn't display correctly. An easy fix is to parse the smilies in order of their code length. The following two quick hacks will do just that!

BEFORE ATTEMPTING THIS - MAKE BACKUP COPIES OF:

/includes/adminfunctions.php
/includes/functions_bbcodeparse.php

Whenever you are changing files you should always have a proper backup!



open /includes/adminfunctions.php and goto line 2192

you will see this line

	$items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");

replace that line with this code

	if ($table == 'smilie') 
                {
                     $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "smilie ORDER BY LENGTH(smilietext) DESC");  
                }
                else
                {
                    $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");  
                }

open includes/functions_bbcodeparse.php and goto line 385

you will see this line

SELECT smilietext, smiliepath, smilieid FROM " . TABLE_PREFIX . "smilie

replace it with this

SELECT smilietext, smiliepath, smilieid FROM " . TABLE_PREFIX . "smilie  ORDER BY LENGTH(smilietext) DESC

After this is complete, go into your Admin CP, view your smilies and just click "Save Display Order" This will update the cached smilie's datastore. This hack won't have any effect until this is done

Enjoy proper smilies ! Let me know how it works for ya!

[sabret00the]

that's great work although theirs a mistake

PHP Code:

    if ($table == 'smilie') 
                {
                     $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "smilie ORDER BY LENGTH(smilietext) DESC");  
                |
                else
                {
                    $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");  
                } 


should read

PHP Code:

    if ($table == 'smilie') 
                {
                     $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "smilie ORDER BY LENGTH(smilietext) DESC");  
                }
                else
                {
                    $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");  
                } 


[sabret00the]

will this also fix the :lol problem?

[GenSec]

Very usefull. Thanks!

[Boots]

fixed this in the original post. I don't know how the | got in there as I copied it directly from my code ? weird. Oh well, fixed now

Originally Posted by sabret00the

that's great work although theirs a mistake

PHP Code:

    if ($table == 'smilie') 
                {
                     $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "smilie ORDER BY LENGTH(smilietext) DESC");  
                |
                else
                {
                    $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");  
                } 


should read

PHP Code:

    if ($table == 'smilie') 
                {
                     $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "smilie ORDER BY LENGTH(smilietext) DESC");  
                }
                else
                {
                    $items = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "$table ORDER BY imagecategoryid, displayorder");  
                } 


[Boots]

Originally Posted by sabret00the

will this also fix the :lol problem?

yes

(:lol

displays perfectly fine on my forum

[Boofo]

Can you please post this in a text file also for easier downloading and saving?

[Boots]

Sure thing. i'll post one up tommorow

[NYI Fan]

thanks, i was wondering when Iw as going to find some time to clean this mess up LOL and youve saved me the trouble!

*clicks install*

[NuclioN]

Fantastic! Tnx.