The Arcive of Official vBulletin Modifications Site.

Davey · #1 08-14-2004, 09:16 AM

Table coming up blank. Everything else was peachy.
I kind of troubleshot it down to roughly where it is, seems my fetch_template() calls aren't doing their job properly.
Called from DB, if my query wasn't successful, surely it'd have fetched the error template (no num_rows)
Anyway... the stuff.

File: guild.php
Incompleted.

PHP Code:


			
<?php



error_reporting(E_ALL & ~E_NOTICE);



define('NO_REGISTER_GLOBALS', 1);

define('THIS_SCRIPT', 'guild');



// precache templates used by all actions

$globaltemplates = array(

'members',

'treasury'

);



// precache templates used by specific actions

$actiontemplates = array(

    'members' => array(

        'guild_memberrow',

        'guild_memberslist'

    ),

);



if (empty($_REQUEST['do']))

{

    $_REQUEST['do'] = 'members';

}



require_once("./global.php");



if ($_REQUEST['do'] == 'members')

{

    // build the query

    $memberlistquery = $DB_site->query("

        SELECT *

        FROM " . TABLE_PREFIX . "user

        WHERE '8' IN (membergroupids)

        ORDER BY username ASC

    ") or die("mysql error");

    $endtemplate = '';

    // check if there are any members from this group

    if ($DB_site->num_rows($memberlistquery) == '0')

    {

        eval('$endtemplate = "' . fetch_template('guild_error_nomembers') . '";');

    }

    // start getting the users

    while ($memberlist = $DB_site->fetch_array($memberlistquery))

    {

        eval('$endtemplate .= "' . fetch_template('guild_memberrow') . '";');

    }

    // done

    $templatename = 'guild_memberslist';



}



$navbits = array();

$navbits[$parent] = 'Guild Members';

$navbits = construct_navbits($navbits);

eval('$navbar = "' . fetch_template('navbar') . '";');

eval('print_output("' . fetch_template($templatename) . '");');



?>

Template: guild_memberslist

Code:

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
<title>$vboptions[bbtitle]</title>
$headinclude
</head>
<body>
$header

$navbar

<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<tr>
<td class="tcat" colspan="6" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_memberlist]</strong>
</td>
</tr>
<tr>
<td class="tcat" colspan="1" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_desc_username]</strong>
</td>
<td class="tcat" colspan="1" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_desc_rank]</strong>
</td>
<td class="tcat" colspan="1" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_desc_class]</strong>
</td>
<td class="tcat" colspan="1" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_desc_profession]</strong>
</td>
</tr>

$endtemplate

<tr>
<td class="tcat" colspan="7" style="text-align: center; vertical-align: middle">
<strong>$vbphrase[guild_memberlist]</strong>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>

$footer
</body>
</html>

Template: guild_memberrow

Code:

<tr>
<td style="text-align: center; vertical-align: middle">
<a href="member.php?u=$memberlist[userid]">$memberlist[musername]</a>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field5]">
$memberlist[field5]
</if>
<if condition="!$memberlist[field5]">
Undisclosed.
</if>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field6]">
$memberlist[field6]
</if>
<if condition="!$memberlist[field6]">
Undisclosed.
</if>
</td>
<td style="text-align: center; vertical-align: middle">
<if condition="$memberlist[field7]">
$memberlist[field7]
</if>
<if condition="!$memberlist[field7]">
Undisclosed.
</if>
</td>
</tr>

Template: guild_error_nomembers

Code:

<tr><td>There are no members in this group.</td></tr>

String: guild.php?do=members
Outcome: See attachment screenshot.

Colin F · #2 08-14-2004, 09:43 AM

It's probably not it, but you're missing <tr>'s around the two tcat rows.

Also, look in your database for how many rows should be returned.

CarCdr · #3 08-14-2004, 10:02 AM

If there are no rows retrieved, you will not see the error. Right after you set "$endtemplate" to the error message you set it to the empty string in the line:

$endtemplate = '';

Also, I would do the check for an empty $_REQUEST['do'] so that it is set before including global.php. This will allow it to pre-cache the $actiontemplates.

Finally, as Colin pointed out, I would fix your <TR>/<TD> tags before debugging much further.

Davey · #4 08-14-2004, 10:24 AM

OK well I did everything listed (check the code above).
The SQL in phpmyadmin returns 1 user (me)
I'm still getting nothing, not even an error message.
edit.-

Could it be I need something else included? Maybe I've set the $actiontemplates or $globaltemplates wrong? After all I don't understand what either do so I'm not sure if they're right or not.

Colin F · #5 08-14-2004, 10:40 AM

Try adding a $DB_site->data_seek(0,$memberlistquery); after the if(blabla =='0'){ bla }

Dean C · #6 08-14-2004, 11:03 AM

No wonder, put all this inside the if($_REQUEST['do']... bit:

PHP Code:


			
$navbits = array();

$navbits[$parent] = 'Guild Members';

$navbits = construct_navbits($navbits);

eval('$navbar = "' . fetch_template('navbar') . '";');

eval('print_output("' . fetch_template($templatename) . '");');

Davey · #7 08-14-2004, 11:26 AM

@Dean C:
Are you sure??

The nav bits is nothing to do with listing the members.
It does output the page, it just doesn't output what it needs to.
If you look in the vBulletin 3 files, that is all at the bottom.

In the 'if($_REQUEST['do']...' bit, there is a bit at the end:

$templatename = 'template_name';//replace "template_name" with name of template.

@Colin F:
$test = $DB_site->data_seek(0,$memberlistquery);
echo $test;

Returns '1'.. (whatever that means, lol)

Davey · #8 08-14-2004, 11:30 AM

Oh and Dean, I did what you said...

PHP Code:


			
<?php



error_reporting(E_ALL & ~E_NOTICE);



define('NO_REGISTER_GLOBALS', 1);

define('THIS_SCRIPT', 'guild');



// precache templates used by all actions

$globaltemplates = array(

'members',

'treasury'

);



// precache templates used by specific actions

$actiontemplates = array(

    'members' => array(

        'guild_memberrow',

        'guild_memberslist'

    ),

);



if (empty($_REQUEST['do']))

{

    $_REQUEST['do'] = 'members';

}



require_once("./global.php");



if ($_REQUEST['do'] == 'members')

{

    // build the query

    /*

    SELECT * FROM vb3_user WHERE '8' IN (membergroupids) ORDER BY username ASC

    */

    $memberlistquery = $DB_site->query("

        SELECT *

        FROM " . TABLE_PREFIX . "user

        WHERE '8' IN (membergroupids)

        ORDER BY username ASC

    ");

    $endtemplate = '';

    // check if there are any members from this group

    if ($DB_site->num_rows($memberlistquery) == '0')

    {

        eval('$endtemplate = "' . fetch_template('guild_error_nomembers') . '";');

    }

    // start getting the users

    while ($memberlist = $DB_site->fetch_array($memberlistquery))

    {

        eval('$endtemplate .= "' . fetch_template('guild_memberrow') . '";');

    }

    // done

    $templatename = 'guild_memberslist';



    $navbits = array();

    $navbits[$parent] = 'Guild Members';

    $navbits = construct_navbits($navbits);

    eval('$navbar = "' . fetch_template('navbar') . '";');

    eval('print_output("' . fetch_template($templatename) . '");');

}



?>

Still returns nothing but an empty table.

Dean C · #9 08-14-2004, 11:44 AM

Ok then debug it like so:

PHP Code:


			
error_reporting(E_ALL & ~E_NOTICE);



define('NO_REGISTER_GLOBALS', 1);

define('THIS_SCRIPT', 'guild');



// precache templates used by all actions

$globaltemplates = array(

'members',

'treasury'

);



// precache templates used by specific actions

$actiontemplates = array(

    'members' => array(

        'guild_memberrow',

        'guild_memberslist'

    ),

);



if (empty($_REQUEST['do']))

{

    $_REQUEST['do'] = 'members';

}



require_once("./global.php");



if ($_REQUEST['do'] == 'members')

{

    echo 'one';

    // build the query

    /*

    SELECT * FROM vb3_user WHERE '8' IN (membergroupids) ORDER BY username ASC

    */

    $memberlistquery = $DB_site->query("

        SELECT *

        FROM " . TABLE_PREFIX . "user

        WHERE '8' IN (membergroupids)

        ORDER BY username ASC

    ");

    $endtemplate = '';

    // check if there are any members from this group

    if ($DB_site->num_rows($memberlistquery) == '0')

    {

        echo ',two';

        eval('$endtemplate = "' . fetch_template('guild_error_nomembers') . '";');

    }

    // start getting the users

    while ($memberlist = $DB_site->fetch_array($memberlistquery))

    {

        echo ',bits';

        eval('$endtemplate .= "' . fetch_template('guild_memberrow') . '";');

    }

    // done

    $templatename = 'guild_memberslist';



    $navbits = array();

    $navbits[$parent] = 'Guild Members';

    $navbits = construct_navbits($navbits);

    eval('$navbar = "' . fetch_template('navbar') . '";');

    eval('print_output("' . fetch_template($templatename) . '");');

}

What does it echo to the browser

?

Davey · #10 08-14-2004, 11:53 AM

I didn't try that because I figured out the problem. I assume it would have echo()'ed "one" in the browser.

That bit is working fine.

Code:

<tr>
<td style="text-align: center; vertical-align: middle">
<a href="member.php?u=1">Davey</a>
</td>
<td style="text-align: center; vertical-align: middle">
Founder
</td>
<td style="text-align: center; vertical-align: middle">
Warrior
</td>
<td style="text-align: center; vertical-align: middle">
Carpentry
</td>
</tr>

The above works, displays fine. So this bug in my code is the $memberlist variable.

edit.- I have to eval() the $memberlist variable, no..?

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04020 seconds Memory Usage 2,310KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (4)bbcode_code (4)bbcode_php (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (10)postbit (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!