Question on PHP Syntax used in AdminCP/Index.php

[Ocean]

Hi! I have a quick question... In vBulletin 3.03's AdminCP/Index.php, you'll find the following code for the Navigation Bar:

PHP Code:

 
if (can_administer('canadminusers'))
{
$printhr = true;
construct_nav_option($vbphrase['add_new_user'], 'user.php?do=add', '|');
construct_nav_option($vbphrase['search_for_users'], 'user.php?do=modify', '|');
construct_nav_option($vbphrase['merge_users'], 'usertools.php?do=merge', '|');
construct_nav_option($vbphrase['ban_user'], "../$modcpdir/banning.php?do=banuser", '<br />');
construct_nav_option($vbphrase['prune_users'], 'user.php?do=prune', '|');
construct_nav_option($vbphrase['private_message_statistics'], 'usertools.php?do=pmstats', '<br />');
construct_nav_option($vbphrase['referrals'], 'usertools.php?do=referrers', '|');
construct_nav_option($vbphrase['search_ip_addresses'], 'usertools.php?do=doips', '<br />');
construct_nav_option($vbphrase['view_banned_users'], "../$modcpdir/banning.php?do=modify", '<br />');
construct_nav_option($vbphrase['send_email_to_users'], 'email.php?do=start', '|');
construct_nav_option($vbphrase['generate_mailing_list'], 'email.php?do=genlist', '<br />');
construct_nav_option($vbphrase['access_masks'], 'accessmask.php?do=modify', '<br />');
construct_nav_group($vbphrase['users']);
} 


Here's my question... Some of those lines end in '|', while others end in '<br />'.

Looking at the code, I can't figure out why a line would require one as opposed to the other.


So far, people on vBulletin.com are stumped.


Can anyone help enlighten me on this?

Thanks!

[Modin]

it does nothing from what I can see and it even looks like a bug.

the function for "construct_nav_option" looks like

function construct_nav_option($title, $url, $extra = '')

though, $extra is never used in within it... however $_extra is used, which is naturally empty all the time. I tried changing that to $extra but that just puts vertical bars after the the options with it. Looks like they were trying to do something by separating some options by vertical bars but then stopped halfway through. Maybe due for a later release?

but doesn't do anything atm

[CarCdr]

So far, people on vBulletin.com are stumped.

Now, that's not fair.
http://www.vbulletin.com/forum/showpost.php?p=709784

This is not a PHP question, syntax or otherwise. It's an issue of function definition and usage. Functions are passed parameters when they are called. Whether the parameters are used by the function itself, is the question here.

[Ocean]

Originally Posted by CarCdr

So far, people on vBulletin.com are stumped.

Now, that's not fair.
http://www.vbulletin.com/forum/showpost.php?p=709784

This is not a PHP question, syntax or otherwise. It's an issue of function definition and usage. Functions are passed parameters when they are called. Whether the parameters are used by the function itself, is the question here.

No offense, CarCdr.

At the time I made this post, I still had not gotten a definitive answer as to why the statements were ending differently.


By now, of course, you and Slappy have gone into further detail, and Modin has corroborated your statements - and, at the very least, I am less worried about how to properly format my added code.

Thank you - all of you - for helping me with this. Your time and efforts are greatly appreciated.