Question re: hack rules, PHP only

[tamarian]

Hi Admins,

I was about to release vBouncer for vB3, but noticed the new rule that hacks must be in PHP?

Hacks are PHP code changes, nothing more and nothing less.

The vB2 hack was in both Perl and PHP. However, vB3 now includes the -f mail option in the admin panel, so there are no more PHP changes required, just the Perl script.

So, please let me know if you'd like it released, withheld, or have any suggestions.

TIA

[Link14716]

Originally Posted by tamarian

Hi Admins,

I was about to release vBouncer for vB3, but noticed the new rule that hacks must be in PHP?


The vB2 hack was in both Perl and PHP. However, vB3 now includes the -f mail option in the admin panel, so there are no more PHP changes required, just the Perl script.

So, please let me know if you'd like it released, withheld, or have any suggestions.

TIA

You could release a Perl script I believe, but to tell you the truth, if it's Perl, I wouldn't touch it.

[tamarian]

Originally Posted by Link14716

You could release a Perl script I believe, but to tell you the truth, if it's Perl, I wouldn't touch it.

No one is asking anyone to touch anything This is a simple yes/no question directed to the vBulletin.org administrators or moderators regarding the hack rules posted, with the relavent part in quotes.

[Link14716]

Originally Posted by tamarian

No one is asking anyone to touch anything This is a simple yes/no question directed to the vBulletin.org administrators or moderators regarding the hack rules posted, with the relavent part in quotes.

I was just staing my personal opinion along with an answer that I believe is correct.

The rules announcement leaves a lot to be desired though - besides the fact that there are probably rules that aren't even in there (as was the case with the HTL deal), it seems that it is just a copy of the vB2 announcement with a few things changed. Here's a big dose of contradiction(sp?) right here:

As there seems to be some confussion as to what is allowed and what is not I'll clear it up:

* PHP Include hacks/modifications are allowed, and should normally go in the mini-mods forum as they are adding PHP Code.
* Hacks or addons with additional PHP files included or those which make one or more edits to standard vBulletin files.
* Template modifications that add a new level of functionality to vBulletin through the use of conditionals and PHP Include system.

Hacks are PHP code changes, nothing more and nothing less. As a rule, remember that if your 'hack' can be done solely from the Admin Control Panel, then it does not qualify as a hack. Furthermore, hacks are not template changes. If you have a cool idea that is based solely on editing templates (excluding PHP Include hacks, which should go in the Mini-Mods section) - should be released on vBulletin Templates.

[sabret00the]

* Template modifications that add a new level of functionality to vBulletin through the use of conditionals and PHP Include system.

i do beleive that's the bit that's wrong

[tamarian]

Umm, the boucing emails hack has nothing to do with templates or includes. Would be great to find a PHP solution, but I'd really hate to allow apache/php to access any secure files on my servers. Any PHP security suggestions to translate this hack would be welcome though, preferably in another thread.

In the mean time, the final judgement as to what the rules mean belong to those who apply them. I personally think it's fine to release it, but hate to have it deleted after all the writing/editing if the mods think otherwise.

[MindTrix]

I dont believe it's ok to release it as it does not edit vB in anyway, Or does it?

[tamarian]

Originally Posted by MindTrix

I dont believe it's ok to release it as it does not edit vB in anyway, Or does it?

It used to (vB2 version of the hack) alter vB files, but those edits are now part of vB3, for the sending part. So no PHP edits are required in vB3.

The remaining portion in Perl handles the server mail spool and alters vB members subscriptions to threads if their email is bounced above certain limit, to reduce server loads on large vB's.

And yes, I agree with your interpretation that it's not o.k., but thought I'd confirm from vb.org folks to see if they want it anyway.

[MindTrix]

Well i believe people will find it usefull. However if it does not edit a single vB php file i do not believe it will class as a hack.

[Xenon]

from what i see within the old thread, it's a file which has to be uploaded, so it's not doable just from within the ACP, and therfore can be released here.

btw. @Link: do not claim something wrong.
The 'no htl only' rule was there at the moment HTL got released.
The thread was posted within the announcementforum, and a lot of people replied to it.
It's just that we forgot to change the full releases announcement at the same time (we did it a bit later), but there was an announcement before you released your hack!