in_array(): Wrong datatype for second argument

[SmEdD]

Warning: in_array(): Wrong datatype for second argument on line 123

PHP Code:

if ($bbuserinfo['userid']) {
    $datecut = $bbuserinfo['lastvisit'];
} else {
    $datecut = TIMENOW - (24 * 60 * 60 * 1);
}

$countnew = $DB_site->query("
        ## GET NEW POSTS / THREADS ##
        SELECT post.postid, post.threadid
        FROM " . TABLE_PREFIX . "post AS post
        WHERE dateline >= $datecut
        AND visible = '1'");

while($getnew = $DB_site->fetch_array($countnew)) {
    $new['posts']++;
    if (!in_array($getnew['threadid'], $threadids)) {
        $new['threads']++;
        $threadids[] = $getnew['threadid'];
    }
} 


Line 123 is

PHP Code:

if (!in_array($getnew['threadid'], $threadids)) { 


[Lesane]

Try to change:

PHP Code:

$datecut = TIMENOW - (24 * 60 * 60 * 1); 


into:

PHP Code:

$datecut = TIMENOW() - (24 * 60 * 60 * 1); 


[SmEdD]

Didn't work

[Xenon]

before that line:

PHP Code:

while($getnew = $DB_site->fetch_array($countnew)) { 


put that code:

PHP Code:

$threadids = array(); 


[Dean C]

if (!in_array($getnew['threadid'], explode(',', $threadids))) {

[SmEdD]

Hmmm . . . still don't work, I donno how it didn't since you are all amazing coders . . . Is there any other way of redoing the in_array. I also tryed a combination of all of thoes lines but nothing seems to want to work.

[Dean C]

I'm assuming the contents of $threadids is a list of thread id's. If so the code above should work ^^ I use it all the time with global admin cp options

[Xenon]

@Dean: you should look at the code before trying to help:

PHP Code:

$threadids[] = $getnew['threadid']; 


you can clearly see it's not a list but an array


but it hasn't been intialised in the first loop.
that's why i thought the initialisation of it in front of the loop should do it...

[KuraFire]

Putting

PHP Code:

$threadids = array(); 


all the way at the top of the code segment you pasted in the first post should do it.


HOWEVER!

This code gives you the exact same results and is cleaner and simpler:

PHP Code:

$datecut = ($bbuserinfo['userid'] != 0) ? $bbuserinfo['lastvisit'] : TIMENOW - (24 * 60 * 60 * 1);
   
   $new = $DB_site->query_first("SELECT COUNT(post.postid) as posts, COUNT(DISTINCT(post.threadid)) as threads
   FROM " . TABLE_PREFIX . "post AS post
   WHERE dateline >= $datecut
   AND visible = '1'"); 


Depending on the amount of data, it can be a lot faster (with lots of threads and posts) to a little bit slower (with few threads and posts on a big board nonetheless).

You may want to do some benchmarking on your own board to see which method is faster on your forums. Keep in mind that the results (speed-wise) will depend solely on how many new threads / posts there actually are in the result.

Good luck

[SmEdD]

lol I am so stupid . . . The reason the other wern't working was cause I was uploading to the wrong site, but I wasn't paying attection when I clicked connect so that is why.

But ya it works now, so thanks.