while statements, eval, and only one result showing :(

[dv6cougar]

hey guys, i'm using the Template Hack, mucho props to whomever made that, it's a great hack!

however, i'm trying to make a raffle like hack with this, so far i'm not doign to bad

this would be my first attempt at a hack.

i have this in my code

PHP Code:

//check to see that $id is not set
if(!isset($id)) {
    $raffle = $DB_site->query("SELECT * FROM raffle_list WHERE status='current'");
        while($raffleql = $DB_site->fetch_array($raffle)) {
        
        $raftitle = $raffleql['title'];
        $rafid = $raffleql['id'];
         eval("\$ticketid = \"".logiciangettemplate('ticketid')."\";");
        }//end while
}//end $id is not set 


and then i have my template set to use $ticketid, which works great

but then the ticketid tempalte looks like this

PHP Code:

<a href="show.php?pg=raffle&id=$rafid">$raftitle</a> 


the $rafid and $raftitle work like a charm, however, if i have 2 raffles i want to show up it only shows one

how do you make the while statement work correctly? i know you can do it, since teh forumhome and forumdisplay does it

thanks alot

[colicab-d]

yeah ive had this prob before, with a simple shout box i made, when i eval`d i could only get 1 result showing

[JulianD]

After a quick look to your code, try to replace this:

PHP Code:

eval("\$ticketid = \"".logiciangettemplate('ticketid')."\";"); 


for this:

PHP Code:

eval("\$ticketid .= \"".logiciangettemplate('ticketid')."\";"); 


[dv6cougar]

hmm ok i even tried it within my original raffle template and not using $ticketid and what not as seperate templates....


any help would be great here usually there will only be one raffle but there may be more then 1 sometimes thanks for your input

[dv6cougar]

Today at 03:20 PM JulianD said this in Post #3
After a quick look to your code, try to replace this:

PHP Code:

eval("\$ticketid = \"".logiciangettemplate('ticketid')."\";"); 


for this:

PHP Code:

eval("\$ticketid .= \"".logiciangettemplate('ticketid')."\";"); 


actually that would make sense .= so it takes more as needed

thanks!

[JulianD]

No problem

[filburt1]

Be uber-certain to either unset() or set to "" $ticketid first to avoid HTML injection.

[Boofo]

Would this be the same thing then?

$pollrun = "";
unset($pollrun);

even though the variable hasn't been declared yet?

[filburt1]

Either:

PHP Code:

unset($pollrun); // i like because it happens to free memory too 


or

PHP Code:

$pollrun = ""; 


works. Remember with vB2, register_globals is explicitly turned on which is the biggest security hole known to mankind.

[Boofo]

Which one would you have to use with register_globals turned off?