PHP Warning: Undefined array key "rating" in ..../includes/class_postbit.php(368) : eval()'d code on line 68
Industry coding standards - vb.org Archive
Go Back   vb.org Archive > vBulletin Article Depository > Read An Article > vBulletin 3 Articles
Reload this Page Industry coding standards
Register FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools
Industry coding standards
filburt1
Join Date: Feb 2002
Posts: 6,144

 

Maryland, US
Show Printable Version Email this Page Subscription
filburt1 filburt1 is offline 04-26-2003, 09:00 PM
Half of these are from NASA's Java style guide that I use at work(http://aaa.gsfc.nasa.gov/Files/JavaFinal.doc).

1. Use whitespace liberally for readability:
Wrong:
PHP Code:
if($somevar==aconstant){dothis();dothat();}
Right:
PHP Code:
if ($somevar == aconstant)
{
    dothis();
    dothat();
}
2. Braces on newlines:
PHP Code:
if ($result) {
    dowhatever();
}
Right:
PHP Code:
if ($result)
{
    dowhatever();
}
(this might not look important but in big files it greatly helps)

3. Don't exceed 80 chars per line (for code printing and reading on low-res and effectively-low-res environments). No example because it'll break the layout here, but if a line exceeds 80 chars, break it up a bit before 80, and then continue it on the next line while indenting one tab (NASA suggests two tabs but it can make the code very messy).

4. Use a 4-space (not a tab character) indent.
Wrong (right from vB2...):
PHP Code:
if ($HTTP_POST_VARS['action']=="doupload") {

  if ($HTTP_POST_FILES['avatarfile']) {
    $avatarfile = $HTTP_POST_FILES['avatarfile']['tmp_name'];
    $avatarfile_name = $HTTP_POST_FILES['avatarfile']['name'];
  }
  copy("$avatarfile","../$avatarpath/$avatarfile_name");

  $avatarpath.="/$avatarfile_name";

  echo "<p>avatar successfuly uploaded</p>";

  $HTTP_POST_VARS['action']="insert";
}
Right:
PHP Code:
if ($HTTP_POST_VARS['action'] == "doupload")
{
    if ($HTTP_POST_FILES['avatarfile'])
    {
        $avatarfile = $HTTP_POST_FILES['avatarfile']['tmp_name'];
        $avatarfile_name = $HTTP_POST_FILES['avatarfile']['name'];
    }
    copy("$avatarfile","../$avatarpath/$avatarfile_name");
    
    $avatarpath .= "/$avatarfile_name";
    echo "<p>avatar successfuly uploaded</p>";
    $HTTP_POST_VARS['action'] = "insert";
}
5. NEVER use deprecated methods of coding. Examples:
1. $HTTP_POST_VARS
2. $somearray[somenonconstant]
3. mysql_db_query()

Fixed:
1. $_POST
2. $somearray['somenonconstant'] (a very common problem that you need to lose!)
3. mysql_query()


There are more and I don't mean to sound pushy, but every single thing I've said in this post is considered the professional industry standard and if you program for a profession then you'd be expected to follow these.
Reply With Quote
  #2  
Old 04-27-2003, 05:32 PM
grog6's Avatar
grog6 grog6 is offline
 
Join Date: Apr 2002
Location: France
Posts: 328
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Thx for it Filburt, but we can't consider it as mistakes ... it's just better if you don't work alone, so it is clearer for everybody

I'll take care for it in the future
Reply With Quote
  #3  
Old 04-27-2003, 06:40 PM
Brad Brad is offline
 
Join Date: Nov 2001
Posts: 4,765
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
A very good read.
Reply With Quote
  #4  
Old 04-27-2003, 06:58 PM
filburt1 filburt1 is offline
 
Join Date: Feb 2002
Location: Maryland, US
Posts: 6,144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Quote:
Today at 03:32 PM grog6 said this in Post #2
Thx for it Filburt, but we can't consider it as mistakes ... it's just better if you don't work alone, so it is clearer for everybody

I'll take care for it in the future
It's still a good habit to use for when you look back on your code a few months later and think "what the hell was I doing right here?"
Reply With Quote
  #5  
Old 04-27-2003, 08:26 PM
colicab-d's Avatar
colicab-d colicab-d is offline
 
Join Date: Dec 2002
Location: Glasgow
Posts: 382
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
format of your code is a biggy... and fro some langiages can be a bloody joke.. ie truebasic , tho i have to admit ive seen a fair few php scripts that over look putting braces on new lines etc.

Its amazing how annoying something like that can be sometimes
Reply With Quote
  #6  
Old 04-28-2003, 11:43 AM
Dean C's Avatar
Dean C Dean C is offline
 
Join Date: Jan 2002
Location: England
Posts: 9,071
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Good tips there filburt

- miSt
Reply With Quote
  #7  
Old 04-28-2003, 02:20 PM
Xenon's Avatar
Xenon Xenon is offline
 
Join Date: Oct 2001
Location: Bavaria
Posts: 12,878
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
everyone started coding in a crappy style i think, but it's improving.

vb3 will follow these standarts above
Reply With Quote
  #8  
Old 04-28-2003, 04:39 PM
Dean C's Avatar
Dean C Dean C is offline
 
Join Date: Jan 2002
Location: England
Posts: 9,071
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Well i found out all about indenting by accident in my text editor today. It does it all automatically so...

- miSt
Reply With Quote
Reply

« Previous Thread | Next Thread »

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT. The time now is 12:59 AM.

Contact Us - Archive - Privacy Statement - Top

Powered by vBulletin® Version 3.9.0
Copyright ©2000 - 2017, vBulletin Solutions Inc.