The Arcive of Official vBulletin Modifications Site.

whats here wrong?? · **Released**: 04-07-2003

Hi,

i have a problem with my self made hack, i become all the time a parse error, which } is wrong there?

Code:

  

if (($X==1) && $X) {
    if (($X == '') && ($X == '') && ($X == '') && ($X == '') && ($X == '')) {
      $DB_site->query("DELETE FROM X WHERE threadid='$threadid'");
    } else {
      $data=$DB_site->query_first("SELECT X,X,X,X,X from X WHERE threadid=$threadid");
      if (($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '')) {
        $DB_site->query("UPDATE X SET X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."' WHERE threadid='$threadid'");
      } else {
        $DB_site->query("INSERT INTO X (threadid,X,X,X,X,X) VALUES('$threadid','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."')");
      } else {
        $DB_site->query("UPDATE IGNORE X SET threadid='$threadid',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."'");
      }
    }
  }

  eval("standardredirect(\"".gettemplate("X")."\",\"showthread.php?s=$session[sessionhash]&postid=$postid#post$postid\");");
}

thanks for help!

MUG · #2 04-07-2003, 06:12 PM

The last one is incorrect. Get rid of it, and move the eval() statement up.

PHP Code:


			
if (($X==1) && $X) {

  if (($X == '') && ($X == '') && ($X == '') && ($X == '') && ($X == '')) {

    $DB_site->query("DELETE FROM X WHERE threadid='$threadid'");

  } else {

    $data=$DB_site->query_first("SELECT X,X,X,X,X from X WHERE threadid=$threadid");

    if (($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '')) {

      $DB_site->query("UPDATE X SET X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."' WHERE threadid='$threadid'");

    } else {

      $DB_site->query("INSERT INTO X (threadid,X,X,X,X,X) VALUES('$threadid','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."')");

    } else { // WTF? What's up with this extra else statement?

      $DB_site->query("UPDATE IGNORE X SET threadid='$threadid',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."'");

    }

  }



  eval("standardredirect(\"".gettemplate("X")."\",\"showthread.php?s=$session[sessionhash]&postid=$postid#post$postid\");");

}

Edit: There's also two else statements for the same if()?

Exo · #3 04-07-2003, 06:27 PM

thanks for help

the last one is for if there is nothing or no change, that it does nothing.

Xenon · #4 04-07-2003, 06:54 PM

PHP Code:


			
} else {

      $DB_site->query("INSERT INTO X (threadid,X,X,X,X,X) VALUES('$threadid','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."')");

    } else {

two elses!!
that's the buggy part

Exo · #5 04-07-2003, 07:04 PM

hm or can i make

PHP Code:


			


if (($X==1) && $X) {

  if (($X == '') && ($X == '') && ($X == '') && ($X == '') && ($X == '')) {

    $DB_site->query("DELETE FROM X WHERE threadid='$threadid'");

  } else {

    $data=$DB_site->query_first("SELECT X,X,X,X,X from X WHERE threadid=$threadid");

    if (($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '') && ($data['X'] != '')) {

      $DB_site->query("UPDATE X SET X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."',X='".addslashes($X)."' WHERE threadid='$threadid'");

    } else {

      $DB_site->query("INSERT INTO X (threadid,X,X,X,X,X) VALUES('$threadid','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."','".addslashes($X)."')");

    } else { // WTF? What's up with this extra else statement?

      exit;

    }

  }



  eval("standardredirect(\"".gettemplate("X")."\",\"showthread.php?s=$session[sessionhash]&postid=$postid#post$postid\");");

}

when i try this i became also a parse error.

Xenon · #6 04-07-2003, 07:06 PM

you have to take out the second else at all..

Exo · #7 04-07-2003, 07:58 PM

how can i say with a if, that when nothing is change that it do nothing

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04060 seconds Memory Usage 2,295KB Queries Executed 20 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)bbcode_code (3)bbcode_php (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (7)post_thanks_box (7)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (7)post_thanks_postbit_info (6)postbit (7)postbit_onlinestatus (7)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!