non-vb script help

[ManagerJosh]

Could someone tell me what I did wrong? I suck at PHP and it shows really

Parse error: parse error, unexpected T_STRING in /home/virtual/site3/fst/var/www/html/store/admin/includes/functions/general.php on line 785

PHP Code:

// the $filename parameter is an array with the following elements:
// name, type, size, tmp_name
  function tep_copy_uploaded_file($filename, $target) {
 
    if (substr($target, -1) != '/') $target .= '/$manufacturers_data['manufacturers_directory']';

    $target .= $filename['name'];

    move_uploaded_file($filename['tmp_name'], $target);
  } 


I modified this and it gave me the error

PHP Code:

    if (substr($target, -1) != '/') $target .= '/$manufacturers_data['manufacturers_directory']'; 


[NTLDR]

Try:

PHP Code:

if (substr($target, -1) != '/') $target .= "/$manufacturers_data['manufacturers_directory']"; 


I expect it doesn't like the nested ' in the variable name

[ManagerJosh]

Originally posted by NTLDR
Try:

PHP Code:

if (substr($target, -1) != '/') $target .= "/$manufacturers_data['manufacturers_directory']"; 


I expect it doesn't like the nested ' in the variable name

I got

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/virtual/site3/fst/var/www/html/store/admin/includes/functions/general.php on line 782

with your recommended suggestion.

[NTLDR]

Lets try with {}:

PHP Code:

if (substr($target, "-1") != "/") {
    $target .= "/$manufacturers_data['manufacturers_directory']";
} 


If that doesn't work try:

PHP Code:

$target2=substr($target, "-1");
if ($target2!= "/") {
    $target .= "/$manufacturers_data['manufacturers_directory']";
} 


[ManagerJosh]

Originally posted by NTLDR
Lets try with {}:

PHP Code:

if (substr($target, "-1") != "/") {
    $target .= "/$manufacturers_data['manufacturers_directory']";
} 


If that doesn't work try:

PHP Code:

$target2=substr($target, "-1");
if ($target2!= "/") {
    $target .= "/$manufacturers_data['manufacturers_directory']";
} 


Neither works NTLDR.


Just to let you know the original is:

PHP Code:

  function tep_copy_uploaded_file($filename, $target) {
 
    if (substr($target, -1) != '/') $target .= '/';

    $target .= $filename['name'];

    move_uploaded_file($filename['tmp_name'], $target);
  } 


Problem is that with that, it uploads a file to a directory and I'm hoping that variable I added (From data it is pulling from the MySQL) will allow me to upload to that directory I specified.

THe current directory it is uploading to is /images/

I'm hoping with that variable it uploads to: /images/$manufacturers_data['manufacturers_directory'] where $manufacturers_data['manufacturers_directory'] would be information it is obtaining from MySQL.

I think i might be overlooking something which may be why it isn't working.

[ManagerJosh]

Here are the files just to give you an idea what I'm dealing with

-_-

[NTLDR]

All I can think of is to make sure you add:

PHP Code:

global $manufacturers_data; 


After the function line which is need, other than that I can't think of anything else right now.

[ManagerJosh]

in general.php and not another php script in the zip file I attached.

Perhaps I should ask for help to finish this script up cause I'm stumped really bad.

Should I ask in this forum or should I ask in the Help Me Finish Forum? I get the impression the Help Me Finish Forum is limited to vB hacks...though I might be wrong..

If a mod would point this thread in the right direction...

[MUG]

You can't use quotes when dealing with arrays in double-quotes. Try:

PHP Code:

if (substr($target, -1) != '/') $target .= "/$manufacturers_data[manufacturers_directory]"; 


[ManagerJosh]

Originally posted by MUG
You can't use quotes when dealing with arrays in double-quotes. Try:

PHP Code:

if (substr($target, -1) != '/') $target .= "/$manufacturers_data[manufacturers_directory]"; 


Wouldn't that affect my variable in the first place? Because my variable is:

PHP Code:


$manufacturers_data['manufacturers_directory'] 


where i have specified earlier that:

PHP Code:

    $manufacturers_array = array(array('id' => '', 'text' => TEXT_NONE));
    $manufacturers_query = tep_db_query("select manufacturers_id, manufacturers_name, manufacturers_directory from " . TABLE_MANUFACTURERS . " order by manufacturers_name");
    while ($manufacturers = tep_db_fetch_array($manufacturers_query)) {
      $manufacturers_array[] = array('id' => $manufacturers['manufacturers_id'],
                                     'text' => $manufacturers['manufacturers_name']);
    }
    
// Directory Code Hack
    $manufacturers_data = tep_db_fetch_array($manufacturers_query);
// Directory Code Hack 


Edited: your suggestion works MUG, but I wonder if it affects my variable...