The Arcive of Official vBulletin Modifications Site.

Closed Board - Mod & Admin Access · **Released**: 09-08-2002

My board is currently closed when while I hack up 2.2.7 and finish off the new style for it, by default only admins can access a closed board, but I want a supermod to as well, I changed:

PHP Code:


			
// check that board is active - if not admin, then display error

if (!$bbactive) {

  if (!$permissions['cancontrolpanel']) {

    eval("standarderror(\"".str_replace("\'", "'", addslashes($bbclosedreason))."\");");

    exit;

  }

}

in global.php to:

PHP Code:


			
// check that board is active - if not admin, then display error

if (!$bbactive) {

  if ((!$permissions['cancontrolpanel']) or (!$permissions['ismoderator'])) {

    eval("dooutput(\"".gettemplate("classic_bbclosed")."\");");

    exit;

  }

}

classic_bbclosed is a template with the entire page to be displayed instead of the standard error, now this worked for a few days then suddenly stoped, I didn't do anything to change it and have tried every way I can think of. ismoderator is set to 1 for the usergroup (the default sup mod group).

Any ideas?

g-force2k2 · #2 09-08-2002, 08:31 PM

NTLDR try this code...

PHP Code:


			
// check that board is active - if not admin, then display error

if (!$bbactive) {

  if (!$permissions['cancontrolpanel']) {

    if (!$permissions['ismoderator']) {

      eval("dooutput(\"".gettemplate("classic_bbclosed")."\");");

      exit;

    }

  }

}

regards...

g-force2k2

NTLDR · #3 09-08-2002, 08:38 PM

Thank you g-force2k2, that seems to be doing the trick

its been a nightmare trying to get that to work. Thanks once again

g-force2k2 · #4 09-08-2002, 08:42 PM

np NTLDR... it was very perplexing to me as well O_o i was trying to short hand it into one line... but the statement that you had stated...

if they can't access the control panel 'or' they aren't a moderator

see the thing is moderators can't access the control panel so no matter what that part will always return false meaning it wont work...

how my works is

if they can't access the control panel... then

if they aren't a moderator... then...

hope that helps you see the light

regards...

g-force2k2

NTLDR · #5 09-08-2002, 08:53 PM

After a little confusion I see now that my code would never work and how yours does.

I hade:

PHP Code:


			
if (!$permissions['cancontrolpanel'] or !$permissions['ismoderator']) {

origional which I know worked for a couple of days which is why I couldn't see what was wrong. Do the extra set of brackets around each !$permissions bit have any effect or just make the statment clearer?

Thanks for the explanation though, I helped me see what was obviously wrong

g-force2k2 · #6 09-08-2002, 08:58 PM

yeah i see what you mean about the brackets

i guess we both learn something out of it... glad to see the one liner working again

regards...

g-force2k2

NTLDR · #7 09-08-2002, 09:08 PM

I don't think I explained very well *lol*

The one liner just suddenly stopped working. Anyway your code works a treat and I'm not going to play and break it again

Scott MacVicar · #8 09-09-2002, 07:14 AM

PHP Code:


			
if (!$permissions['cancontrolpanel'] or !$permissions['ismoderator']) {

that should be

PHP Code:


			
if (!$permissions['cancontrolpanel'] and !$permissions['ismoderator']) {

because a mod will match the ismoderator but not cancontrol panel and since one of them will return true they get the error.

NTLDR · #9 09-09-2002, 11:58 AM

I realise how stupid I've been now, not taking the fact that each one was negated so 'and' would work

g-force2k2 · #10 09-09-2002, 02:01 PM

yeah thanks PPN

im been toasting my brain

g-force2k2

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04334 seconds Memory Usage 2,305KB Queries Executed 23 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (6)bbcode_php (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)modsystem_post (1)navbar (6)navbar_link (120)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (9)postbit (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!