The Arcive of Official vBulletin Modifications Site.

Velocd · #1 07-26-2002, 04:05 AM

..that I need your opinion on, and what vulnerabilities it could possibly cause for the forum.

This hack will create a new large profile field similar to the signature field in the user-profile page. There a user will allow to enter all the web authoring code they want (assume there is no block of which languages they could use), and then this code is stored in the user table as a new column of data, called "custompage".

I create a new template, inside the template I place $headinclude, $header, and $footer. Between the $header and $footer I place this variable: $custompage

$custompage referes to all the data that the user inputted into their field.

Initially, by a link in each users profile, which will look something like: http://www.mysite.com/forums/member.php?s=$session[sessionhash]&action=getcustompage&userid=$userinfo[userid], the member will be sent to a new page that contains all the content they entered in their custompage field. Ofcourse this content will be translated into weblanguage code, and thus displaying that users custom page!

Sounds cool, right? Well now I know the uses of HTML on the forum are bad enough for vulnerabilities, so what serious problems would occur allowing this?

What comes to my mind ofcourse is malicious users making PHP queries in the field and corrupting my database! Totally possible from my point of view. Other things include calling variables from the global.php, since it is being referenced in members.php, and also calling other variables from members.php.

So..to prevent these things, disabling (ofcourse) PHP and other non-HTMl/Javascript languages would probably be a very high priority. As for HTML and javacript itself though, what problems can occur?

Any help on this would be great!

Regards,
Velocd

Admin · #2 07-26-2002, 06:09 AM

Quote:

Originally posted by Velocd
What comes to my mind ofcourse is malicious users making PHP queries in the field and corrupting my database! Totally possible from my point of view. Other things include calling variables from the global.php, since it is being referenced in members.php, and also calling other variables from members.php

Well that's not possible, not if you escape the variable properly. But that's the least of your problems... I say drop it. People can use HTML in there that could redirect your users to their own Web site, and even worse, send the viewer's cookie data to their own server.

Dean C · #3 07-26-2002, 07:39 AM

surely if you can disable html code in profile fields in member.php currently you could stop it from being used in that field

Admin · #4 07-26-2002, 07:59 AM

Quote:

Originally posted by Mist
surely if you can disable html code in profile fields in member.php currently you could stop it from being used in that field

What would be the point of having your own custom page where you can't use HTML?

Dean C · #5 07-26-2002, 08:40 AM

oh... i see what this hack is now ...

...

sounds nice

Velocd · #6 07-26-2002, 03:47 PM

Hmm, I see. Well, the only things that come to mind is somehow disabling certain tags in HTML so you can't use them. But that would be way too hard...I think.

Or..create custom vBulletin tags that act as HTML tags, but again that would be outta line.

...*ponders*
Well I'll try to think of some similar hack..

edit:

Quote:

Originally posted by FireFly

Well that's not possible, not if you escape the variable properly. But that's the least of your problems... I say drop it. People can use HTML in there that could redirect your users to their own Web site, and even worse, send the viewer's cookie data to their own server.

My moderators and I will be more than likely watching over each members custom page, and if we find anything strange or suspecious in the source we could always warn/ban the member. I could easily create an option that would just disable custom pages for that member, if they were caught doing something wrong.

Dean C · #7 07-26-2002, 05:34 PM

how about just banning the malicious html tags thru the "vbulletin options"..

im sure there was a thread on vbulletin.com full of malicious tags... and you could add a little footnote on creation and editing of the page of the tags that cannot be used

Velocd · #8 07-26-2002, 06:00 PM

I'll figure something out..

Dean C · #9 07-26-2002, 06:17 PM

looking forward to it

!

NTLDR · #10 07-26-2002, 06:32 PM

Just a suggestion, but why don't you make it so you have to moderate there custom page and updates to it to check the content of it before visitors can view it?

Just my $0.02.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04140 seconds Memory Usage 2,275KB Queries Executed 12 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (3)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (1)pagenav (1)pagenav_curpage (2)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (10)postbit (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!