Fix animated smilies after clicking

Not much of a hack, this one... and it only works in IE4+ and the very latest of the other browsers.

Basically, it stops the animated smilies in the clickable list from halting their animation cycle after you click one.

Very simple really... change the vbcode_smiliebit template from this:

<a href="javascript:smilie('$smilie[smilietext]')"><img src="$smilie[smiliepath]" alt="$smilie[title]" border="0"></a>

to this

<img src="$smilie[smiliepath]" alt="$smilie[title]" border="0"
	onmouseover="this.style.cursor='hand';"
	onclick="smilie('$smilie[smilietext]');">

[snyx]

hey this is really cool kier, installing it now, thx!

[Sephi]

Good
It works
Thx !

[FWC]

Thanks, Kier.

[voogru]

thanks

[Mystics]

Big Thx @Kier!

One small addon:
You also should fix the "Smilies List Popup" (misc.php?action=getsmilies&s=)

To do that, change the vbcode_popup_smiliesbits template from this:

<td bgcolor="$backcolor"><a href="javascript:opener.smilie('$smilie[text]')"><img src="$smilie[path]" border="0" alt="$smilie[title]"></a></td>
<td bgcolor="$backcolor"><normalfont>$smilie[text]</normalfont></td>

to this

<td bgcolor="$backcolor"><img src="$smilie[path]" border="0" alt="$smilie[title]"
	onmouseover="this.style.cursor='hand';"
	onclick="opener.smilie('$smilie[text]');"></td>
<td bgcolor="$backcolor"><normalfont>$smilie[text]</normalfont></td>

[JJR512]

I've applied both of these template mods and they are great. However, one little thing...and I mean really little...When you click the link that says "Get More," the smilies there still do stop animating. Could someone tell us how to fix that, too?

[Mystics]

Originally posted by JJR512
When you click the link that says "Get More," the smilies there still do stop animating. Could someone tell us how to fix that, too?

One solution would be to remove the javascript from the "Get More"-Link and to open just a normal Page, but then you can't let open the Smilie Window with a special size (for example 240x280 as default), because it just opens a new, normal Browser Instance.

However, to do this you have to change the Template vbcode_smilies_getmore

Search:

<a href="javascript:opensmiliewindow(240,280,'$session[sessionhash]')">

and replace that with:

<a href="misc.php?action=getsmilies&s=$session[sessionhash]" target="_blank">

[EDIT]
Ok, the solution of Kier is of course much better, so please ignore (or delete @Mods) this Posting.

[Kier]

Edit the vbcode_smilies_getmore template to this:

<a href="javascript:opensmiliewindow(240,280,'$session[sessionhash]')">Get More</a>

to this

<span onmouseover="this.style.cursor='hand';" onclick="opensmiliewindow(240,280,'$session[sessionhash]');">
Get More
</span>

edited to prevent smilie parsing

[haas]

Great hack!! Installing now!