PM on Promotion

[lange]

Hi,

I would be interested by this mod under vB3 (maybe vB5 too).

https://vborg.vbsupport.ru/showthread.php?t=140629

No problem for the install. Promotions are done with no error message but no PM is sent to the user. No PHP error in the logs too. Tested on default style.

I will retest later.

Regards

[TheLastBatman]

Not tested but in the install instructions change $pmdm =& datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY); to $pmdm = datamanager_init('PM', $vbulletin, ERRTYPE_ARRAY);

[lange]

Installed the product again, replaced the line of code and tested the promotion...

This time as it is said in the last message of the topic, the cron job does not work, the promotion is not done automatically. No PM sent to the user again.


In the logs:

PHP Deprecated:  implode(): Passing glue string after array is deprecated. Swap the parameters in /home/.../public_html/.../includes/class_dm.php on line 810
PHP Fatal error:  <ul><li>blabla</ul>Unable to proceed with save while $errors array is not empty in class <strong>vB_DataManager_PM</strong> in /home/.../public_html/.../includes/class_dm.php on line 810

.

[TheLastBatman]

Got it working

PHP Code:

$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_primary_alertpm'], $promotion['username'], $promotion['title']);
                $pmdm = datamanager_init('PM', $vbulletin, ERRTYPE_SILENT);
                $pmdm->set_info('is_automated', true);
                $pmdm->set('fromuserid', $vbulletin->options['sendpm_on_promotion_fromuserid']);
                $pmdm->set('fromusername', $vbulletin->options['sendpm_on_promotion_fromusername']);
                $pmdm->set_info('receipt', false);
                $pmdm->set_info('savecopy', false);
                $pmdm->set('title', $vbulletin->options['sendpm_on_promotion_pm_subject']);
                $pmdm->set('message', $pmbody);
                $pmdm->set_recipients($promotion['username'], $pmpermissions);
                $pmdm->set('dateline', TIMENOW);
        $pmdm->set('allowsmilie', true);

                ($hook = vBulletinHook::fetch_hook('private_insertpm_process')) ? eval($hook) : false;

                $pmdm->pre_save();
        if (empty($pmdm->errors))
                {
                    $pmdm->save();
                    ($hook = vBulletinHook::fetch_hook('private_insertpm_complete')) ? eval($hook) : false;
                }
                unset($pmdm); 


[lange]

I tested quickly by forcing promotions to 2 of my 11 usergroups and it works fine on PHP 7.4.x with no error message in the logs. I will restore my database and let the automatic promotion system go to see if it still works. I will give you some feedback but there is no reason that the automatic system does not work.

I only tested for the number of posts as a requirement for promotions. Do you think it will work if reputation is considered in promotions?

Anyway, I'll test that too before the feedback.

Thank you very much!

[lange]

OK, tested on a clean new install/restored database.

The mod works well by manually running the promotion, the PM is sent and received correctly by the user. Unfortunately it's not working automatically, it's listed, enabled and scheduled in the scheduled task but the PM is not sent and received by the user. No PHP error in the log.

I checked the scheduled task log, it's listed. See the Attach File.
Log Phrase: Usergroup: <strong>{1}</strong>{2}; Users: {3}<dfn>* = Primary Usergroup, % = Secondary Usergroup</dfn>

The other tasks seem to work normally, at least for the Thread Views task. I did not check for other tasks.

Maybe something needs to be fixed in cron.php or some other files.

Regards

[lange]

I think I will use this mod by disabling the User Promotions cron on the list and manually running it once a day for example. It just remains to check if everything else is working properly.

[Seven Skins]

See if this helps...

Change this line:

PHP Code:

$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_alertpm'], $promotion['username'], $promotion['title']); 


TO:

PHP Code:

$pmbody = construct_phrase($vbphrase['sendpm_on_paid_promotion_primary_alertpm'], $promotion['username'], $promotion['title']); 


[lange]

Thanks

It's already included there

Tested this morning.

[TheLastBatman]

yeah if the auto cron isnt running that may be an issue else were, I had a member on my site report they never received a registration verification email either, so there may be a hick-up in the php 7.4 version.