Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Design and Graphics Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 09-03-2015, 10:13 PM
COOLORANGEFREEZ COOLORANGEFREEZ is offline
 
Join Date: Jul 2009
Posts: 22
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Why does this code work there but not here?

So I'm using the exact same code for rotating banners on my regular html cover page site (http://www.wartornnations.net/) and for my vBulletin 3.8.3 too (http://www.wartornnations.net/forum/).

It rotates just fine on the html site but it rotates sporadically only when I refresh the vBulletin site. What in the vBulletin code would hang up such a simple banner rotation code?

Any help is appreciated. The code follows:

HTML SITE CODE:

Code:
<html>
<head>
<title>www.wartornnations.net</title>
</head>
<body>
<DIV ALIGN=CENTER>
<script language="JavaScript">
<!--
function adArray() {
 for (i=0; i*2<adArray.arguments.length; i++) {
  this[i] = new Object();
  this[i].src = adArray.arguments[i*2];
  this[i].href = adArray.arguments[i*2+1];
 }
 this.length = i;
}
function getAdNum() {
 dat = new Date();
 dat = (dat.getTime()+"").charAt(8);
 if (dat.length == 1)
  ad_num = dat%ads.length;
 else
  ad_num = 0;
 return ad_num;
}
 var ads = new adArray(
"http://d2ysc6lw6qcd4g.cloudfront.net/728x90-proudly-support.jpg",
"http://www.woundedwarriorproject.org/",
"http://www.veteranscrisisline.net/banners/public/ads/VeteransCrisisLine-728x90-1-Static.gif",
"http://www.veteranscrisisline.net/"
);

var ad_num = getAdNum(); 

document.write('<table cellpadding=0 cellspacing=1 border=0><tr><td '
+'align="left">'
+'<A href="'+ads[ad_num].href+'"><IMG SRC="'+ads[ad_num].src+'" '
+'height="60" width="468" border="0" name="js_ad"></a></td></tr></table>');

link_num = document.links.length-1;

function rotateBanner() {
 if (document.images) {
  ad_num = (ad_num+1)%ads.length;
  document.js_ad.src = ads[ad_num].src;
  document.links[link_num].href = ads[ad_num].href;
  setTimeout("rotateBanner()",5000);
 }
}
setTimeout("rotateBanner()",5000);

// -->
</script>
</DIV>
</body>
</html>
VBULLETIN HEADER CODE:

Code:
<html>
<head>
<title>UKBL ~ 10 Second Banner Rotator</title>
</head>
<body>
<DIV ALIGN=CENTER>
<script language="JavaScript">
<!--
function adArray() {
 for (i=0; i*2<adArray.arguments.length; i++) {
  this[i] = new Object();
  this[i].src = adArray.arguments[i*2];
  this[i].href = adArray.arguments[i*2+1];
 }
 this.length = i;
}
function getAdNum() {
 dat = new Date();
 dat = (dat.getTime()+"").charAt(8);
 if (dat.length == 1)
  ad_num = dat%ads.length;
 else
  ad_num = 0;
 return ad_num;
}
 var ads = new adArray(
"http://d2ysc6lw6qcd4g.cloudfront.net/728x90-proudly-support.jpg",
"http://www.woundedwarriorproject.org/",
"http://www.veteranscrisisline.net/banners/public/ads/VeteransCrisisLine-728x90-1-Static.gif",
"http://www.veteranscrisisline.net/",
"http://firstrespondersomaha.org/wp-content/uploads/2015/03/TrueBlue-728x90.gif",
"http://firstrespondersomaha.org/support-blue-materials/"
);

var ad_num = getAdNum(); 

document.write('<table cellpadding=0 cellspacing=1 border=0><tr><td '
+'align="left">'
+'<A href="'+ads[ad_num].href+'"><IMG SRC="'+ads[ad_num].src+'" '
+'height="90" width="728" border="0" name="js_ad"></a></td></tr></table>');

link_num = document.links.length-1;

function rotateBanner() {
 if (document.images) {
  ad_num = (ad_num+1)%ads.length;
  document.js_ad.src = ads[ad_num].src;
  document.links[link_num].href = ads[ad_num].href;
  setTimeout("rotateBanner()",5000);
 }
}
setTimeout("rotateBanner()",5000);

// -->
</script>
</DIV>
</body>
</html>
Reply With Quote
  #2  
Old 09-03-2015, 10:37 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You didn't add the <html> and <body> and <head> tags (and other tags that go with those) into the header, did you? You are going to break the html on your site if you don't just add the javascript for it into the header template.
Reply With Quote
Благодарность от:
COOLORANGEFREEZ
  #3  
Old 09-03-2015, 10:46 PM
COOLORANGEFREEZ COOLORANGEFREEZ is offline
 
Join Date: Jul 2009
Posts: 22
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I did add those.

I will take them out and reassess later this eve.

Thanks for the quick response.
Reply With Quote
  #4  
Old 09-04-2015, 10:43 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

After you change it, run the page through here and see if there are any errors related to any of the code you added - http://validator.w3.org/
Reply With Quote
Благодарность от:
TheLastSuperman
  #5  
Old 09-25-2015, 07:38 PM
COOLORANGEFREEZ COOLORANGEFREEZ is offline
 
Join Date: Jul 2009
Posts: 22
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Way overdue... thank you for your suggestion. It worked.
Reply With Quote
Благодарность от:
TheLastSuperman
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 02:26 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03513 seconds
  • Memory Usage 2,210KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_code
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (5)post_thanks_box
  • (3)post_thanks_box_bit
  • (5)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (3)post_thanks_postbit
  • (5)post_thanks_postbit_info
  • (5)postbit
  • (5)postbit_onlinestatus
  • (5)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete