Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 05-06-2015, 02:44 PM
the one the one is offline
 
Join Date: Nov 2013
Posts: 243
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Problems with inline mod dropdown

Can someone help me please? I'm having problems with the inline mod dropdown menu. Specifically, I am trying to select unapproved posts, but nothing happens. Then I tried to select all, and that only selects the first post of the thread. Any ideas?

I'm the administrator of a forum, but not the forum owner. I'm trying to fix this problem for the owner because he is on paternity leave at the moment. I just had my moderators go through a thread that was well over 100 pages deep, had them "unapprove" all posts that were off topic, and now I want to select all those unapproved posts so I can move them all to a new thread, for this off topic discussion. I would love some help from the geniuses here. Thank you.

Can i also state its now showing post to moderate 1,298 in admin cp.We need all them going in one thread

Reply With Quote
  #2  
Old 05-06-2015, 03:03 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hmm..have you looked at the browser console to see if there are any js errors?
Reply With Quote
Благодарность от:
the one
  #3  
Old 05-06-2015, 03:09 PM
the one the one is offline
 
Join Date: Nov 2013
Posts: 243
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thank you for the response!

No I haven't done that, but I should say that I immediately did think this might have been a browser/javascript problem, so I tried to perform the function on IE, Firefox, and Chrome. Oh, and also Opera on my android phone. The problem occurs in every browser. I'll go ahead and check the console on my Firefox install though, since that's my primary browser...

--------------- Added [DATE]1430933985[/DATE] at [TIME]1430933985[/TIME] ---------------

Okay so I opened the browser console in Firefox, then navigated to my forum, then to the thread in which I am trying to select all unapproved posts, then I cleared the browser console log so I could have a blank slate. Then, back on the forum page, I clicked "Select Unapproved Posts" from the inline mod dropdown, and now the browser console has this message:

TypeError: this.checkbox is null vbulletin-core.js:11:34601
"Do:Select <b>Unapproved</b> Posts, IDost_imodsel:flag:1" vbulletin-core.js:11:31997
"Set Inlinemod State for 841923356 - removeClass"



Does that mean anything to anyone? I'm sorry, I'm just not as computer literate as I'd like to be.

--------------- Added [DATE]1430937082[/DATE] at [TIME]1430937082[/TIME] ---------------

Is this something in the settings that i need to tweak?
Reply With Quote
  #4  
Old 05-06-2015, 05:00 PM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

If you have the Separate Sticky and Normal Threads product installed there's an incompatibility between it and stock vbulletin code (particularly the vbulletin-core.js file) where stock vbulletin is not checking if a variable is not null before trying to do stuff with it, which causes the error you're seeing. If you look in the thread I've got a fix posted for editing the vbulletin-core.js file and there's another fix listed there as well. Others have moved to other mods for separating stickies and non-stickies.
Reply With Quote
  #5  
Old 05-06-2015, 05:02 PM
the one the one is offline
 
Join Date: Nov 2013
Posts: 243
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ok i have just disable the plugin system and it now works

So how do i find which plugin was doing this and not making it work

Many thanks
Reply With Quote
  #6  
Old 05-06-2015, 05:15 PM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

That error is the reason it's not working, but it doesn't say exactly what's causing the error. The standard response to a question like yours should be to tell you to try a new style and disable hooks and see if you still have the problem, and I didn't tell you that, but fortunately squidsk did (or at least figured out that it was probably a mod).

Anyway, you pretty much just have to enable (or disable) them one at a time and see which one causes the problem. If you have one or more that have to do with threads you could start with those and it might save time.
Reply With Quote
  #7  
Old 05-06-2015, 07:06 PM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Do you have the Separate Sticky and Normal Threads product? As I mentioned this has a known conflict with core vbulletin that behaves exactly as you described above.
Reply With Quote
  #8  
Old 05-06-2015, 07:07 PM
the one the one is offline
 
Join Date: Nov 2013
Posts: 243
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Ok i found the problem its the post thanks hack when i turn that off the inline mod menu works perfectly.But i like the post thanks hack can you suggest anything i can do for this to work with the post thanks hack turned on

Can i add anything to my config php file for this to work

Many thanks

--------------- Added [DATE]1430993358[/DATE] at [TIME]1430993358[/TIME] ---------------

Hi can anyone help with my last post

Many thanks xxx
Reply With Quote
  #9  
Old 05-07-2015, 05:23 PM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by michelle81 View Post
Ok i found the problem its the post thanks hack when i turn that off the inline mod menu works perfectly.But i like the post thanks hack can you suggest anything i can do for this to work with the post thanks hack turned on

Can i add anything to my config php file for this to work

Many thanks

--------------- Added [DATE]1430993358[/DATE] at [TIME]1430993358[/TIME] ---------------

Hi can anyone help with my last post

Many thanks xxx
You can try the same change I used for the same problem for the Separate Sticky and Normal Threads Product
Assuming you have compressed javascript make the following changes to clientscript/vbulletin-core.js

Search for this.collection[A].checkbox.check and you add the bit in red:
Code:
if(this.collection[A].checkbox&&this.collection[A].checkbox.checked)
The next two changes are trickier because you need to surround lines of code with an if statement.

Search for this.checkbox.checked=! and add the two bits in red:
Code:
if(this.checkbox){switch(A[1]){case"invert":this.checkbox.checked=!this.checkbox.checked;break;case"none":this.checkbox.checked=false;break;case"class":this.checkbox.checked=YAHOO.util.Dom.hasClass(this.container,A[2]);break;case"flag":if(typeof A[2]!=undefined&&!isNaN(A[2])){this.checkbox.checked=this.checkbox.value&A[2]}else{this.checkbox.checked=true}break;default:case"all":this.checkbox.checked=true;break}}
Search for this.checkbox.check? and add the two bits in red:
Code:
if(this.checkbox){var A=(this.checkbox.checked?"addClass":"removeClass");YAHOO.util.Dom[A](this.container,"imod_highlight");console.log("Set Inlinemod State for %s - %s",this.itemid,A)}
You can also vote to have the bug patched at http://tracker.vbulletin.com/browse/VBIV-6156, you'll need to be logged in to vb.com to see the bug report.
Reply With Quote
2 благодарности(ей) от:
MarkFL, the one
  #10  
Old 05-08-2015, 09:58 AM
the one the one is offline
 
Join Date: Nov 2013
Posts: 243
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Wow have you seen all the coding in that clientscript/vbulletin-core.js file

I will have to be very careful not to mess anything up.

Would you suggest i download it before i try and make any changes just encase i make any mistakes

Many thanks
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 12:45 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04665 seconds
  • Memory Usage 2,263KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (2)pagenav_pagelink
  • (10)post_thanks_box
  • (3)post_thanks_box_bit
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (2)post_thanks_postbit
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete