Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 02-11-2013, 02:46 AM
LifesGreatestGift's Avatar
LifesGreatestGift LifesGreatestGift is offline
 
Join Date: Jul 2009
Location: Louisville, KY USA
Posts: 885
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Can this query be simplified?

I have the following query. Here is how it works, there are multiple tables. When the initial record is made, its data/columns are stored "shorthand/url friendly". When I pull them with this query it queries the shorthand for an equivelent in a "definition" table for the long/full version.

PHP Code:
    $q vB::$db->query_first("  
                        SELECT `price`,   
                                `obo`,   
                                `offer`,   
                                `state`, 
                                `location` AS `location_org`, 
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_locations` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`location` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid ") AS `location_full`,    
                                `area`,   
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_posttype` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`posttype` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid ") AS `posttype`,
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_posttype_firearm` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`posttype_firearm` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid ") AS `posttype_firearm`,
                                (SELECT `id` FROM " 
TABLE_PREFIX "`thread_classifieds_posttype_firearm` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`posttype_firearm` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid ") AS `typenum`,                                
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_caliber` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`caliber` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid " && " TABLE_PREFIX "`thread_classifieds_caliber`.`type` = `typenum`) AS `caliber`,   
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_manufacturer` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`manufacturer` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid " && " TABLE_PREFIX "`thread_classifieds_manufacturer`.`type` = `typenum`) AS `manufacturer`,   
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_action` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`action` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid " && " TABLE_PREFIX "`thread_classifieds_action`.`type` = `typenum`) AS `action`,   
                                (SELECT `long` FROM " 
TABLE_PREFIX "`thread_classifieds_type` WHERE `short` = " TABLE_PREFIX "`thread_classifieds`.`type` && " TABLE_PREFIX "`thread_classifieds`.`threadid` = " $threadid " && " TABLE_PREFIX "`thread_classifieds_type`.`type` = `typenum`) AS `type`   
                                FROM " 
TABLE_PREFIX "`thread_classifieds`   
                                WHERE `threadid` = " 
$threadid " LIMIT 1
                                    "
); 
The query as-is, works. but I feel it can be simplified. Just not sure how.

--------------- Added [DATE]1360626868[/DATE] at [TIME]1360626868[/TIME] ---------------

ended up figuring it out

PHP Code:
$q vB::$db->query_first(
select c.`price`,     
  c.`obo`,     
  c.`offer`,     
  c.`state`,   
  c.`location` AS `location_org`, 
  l.`long` AS `location_full`, 
  c.`area`, 
  p.`long` AS `posttype`, 
  pf.`long` AS `posttype_firearm`, 
  pf.id AS `typenum`, 
  cc.`long`  AS `caliber`, 
  m.`long`  AS `manufacturer`, 
  a.`long`  AS `action`, 
  t.`long`  AS `type`  
from thread_classifieds c 
left join thread_classifieds_locations l 
  on c.location = l.short 
left join thread_classifieds_posttype p 
  on c.posttype = p.short 
left join thread_classifieds_posttype_firearm pf 
  on c.posttype_firearm = pf.short 
left join thread_classifieds_caliber cc 
  on c.caliber = cc.short 
  and pf.id = cc.`type` 
left join thread_classifieds_manufacturer m 
  on c.manufacturer = m.short 
  and pf.id = m.`type` 
left join thread_classifieds_action a 
  on c.action = a.short 
  and pf.id = a.`type` 
left join thread_classifieds_type t 
  on c.type = t.short 
  and pf.id = t.`type` 
where c.`threadid` = 72 LIMIT 1; 
"
); 
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:57 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03099 seconds
  • Memory Usage 2,188KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (2)bbcode_php
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete