Issues with Hook

[James Birkett]

Basically, I'm using a plugin on the fetch_musername hook to allow users to choose their own colour.

Here's the code:

PHP Code:

global $field7_cache; 

if (!is_array($field7_cache))  
{  
    $field7_cache = array();  
}  

$exclusives = array( 
    'Duck'        =>    '#FFD953', 
    'Penguin'    =>    '#8496B0', 
    'Emerald'    =>     '#46C184', 
    'Ruby'        =>    '#EB1264', 
    'Sapphire'    =>    '#008AFB', 
    'Tourmaline'=>    '#F7A9C3', 
    'Purple'    =>    '#9D6DCD', 
    'Aquamarine'=>    '#88E1FB', 
    'Silver'    =>    '#A5A5A5', 
    'Orange'    =>    '#DE5E12', 
    'Teal'        =>    '#2D8181', 
    'Pink'        =>    '#FF397F' 
); 


if($user['displaygroupid'] == 9) 
{ 
    if($user['field7']) 
    { 
        $field7_cache[$user['userid']] = $user['field7']; 
    } 
    else 
    { 
        $row = $vbulletin->db->query_first(sprintf("SELECT field7 FROM " . TABLE_PREFIX ."userfield WHERE userid = %d", $user['userid'])); 
        $field7_cache[$user['userid']] = $row['field7']; 
    } 

    if($field7_cache[$user['userid']]) 
    { 
        $field = $field7_cache[$user['userid']]; 
    } 

    if($field) 
    { 
        $user['field7'] = $field; 
    } 


    $colour = $exclusives[$user['field7']]; 
    $vbulletin->usergroupcache["9"]['opentag'] = "<span style=\"color: {$colour}; font-weight:bold\">"; 
    $vbulletin->usergroupcache["9"]['closetag'] = "</span>"; 
    $user['musername'] = $vbulletin->usergroupcache["9"]['opentag'] . $user['username'] . $vbulletin->usergroupcache["9"]['closetag']; 


I'm using a plugin to show coloured usernames on forumdisplay and forumhome and I just wanted to make sure that my plugin isn't the cause of the issue before I decide to pull apart the other plugins.

Thanks in advance!

[kh99]

What is the problem you're having? I think the code is basically correct, but I don't think you need to be using $vbulletin->usergroupcache["9"] - that might end up changing the color for users of group 9 (if you have one).

[James Birkett]

The problem I'm having is that users are being shown in a different colour than the one they've selected.

The usergroup cache update is because all of the users are in usergroup 9, so I figured if I set the musername and update the usergroup tags it's a foolproof way to go about it.

--------------- Added [DATE]1341483055[/DATE] at [TIME]1341483055[/TIME] ---------------

OK I've established that my code is fine - and the other plugins are causing the issue.

I have a question though:
Another plugin is calling the fetch_musername function to generate the markup username, using this code:

PHP Code:

if($thread['post_user_displaygid']!=0) 
        { 
            $thread['postusername'] = fetch_musername($thread, 'post_user_displaygid', 'postusername');             
        } 
        else 
        {     
            $thread['postusername'] = fetch_musername($thread, 'post_user_usergid', 'postusername');             
        } 


As you can see, it's calling the fetch_musername hook, on the threadbit_process hook. Now, this doesn't seem to be calling the mark-up username via my hook, almost as if it's being processed before the hook code is being called.

Anyone have any ideas?

--------------- Added [DATE]1341484926[/DATE] at [TIME]1341484926[/TIME] ---------------

After further playing, it seems the $vbulletin->usergroupcache["9"][opentag] & [closetag] aren't being overwritten in the array via my above code.