Go Back   vb.org Archive > vBulletin 3 Discussion > vB3 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 02-09-2012, 12:28 AM
Micolithe Micolithe is offline
 
Join Date: Apr 2006
Posts: 2
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Custom Ban Lengths

What I'm trying to do is add additional ban lengths that are less than 1 day. (one hour, six hours, and twelve hours, specifically).

I found in modcp/banning.php where I can add options to the dropdown menu but these options don't seem to do anything, as they just create a ban that is listed as -0 days.

What I want to know is how to define the values H_1, H_6, and H_12 as hours to ban for. I can't seem to find where D_1, etc, are defined otherwise I could just use that as a reference.

If someone can point me in the right direction that would be rad.
Reply With Quote
  #2  
Old 02-09-2012, 02:28 AM
kh99 kh99 is offline
 
Join Date: Aug 2009
Location: Maine
Posts: 13,185
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

If you look in banning.php around line 261, there's this code:

Code:
	// check that the number of days is valid
	if ($vbulletin->GPC['period'] != 'PERMANENT' AND !preg_match('#^(D|M|Y)_[1-9][0-9]?$#', $vbulletin->GPC['period']))
	{
		print_stop_message('invalid_ban_period_specified');
	}

you'll have to add h to the (D|M|Y) part to allow it as valid. Also, because it uses the function convert_date_to_timestamp() (in includes/functions_banning.php) to calcualte the lift date from the "period", it looks like you'll have to use lower case h instead of H.

Another issue may be that because the bans are lifted by a scheduled task, you'll also have to make sure that that task runs more often than once a day. ETA: ... turns out it does run once per hour by default.
Reply With Quote
  #3  
Old 02-09-2012, 04:13 AM
Micolithe Micolithe is offline
 
Join Date: Apr 2006
Posts: 2
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I forgot to mention that I added capital H to the exclusion list in that code but thank you so much, using lowercase H made it work.

Also, I upped the frequency of unban users to 15 minutes.

So the code I added, aside from what was posted in the previous reply, in case anyone happens across this later on, is this:

The ones with stars at the start (which you should obviously exclude) are the ones I added.

file: modcp/banning.php
Code:
	// make a list of banning period options
	$periodoptions = array(
		$temporary_phrase => array(
*		    'h_1' => "1 $vbphrase[hour]",
*			'h_6' => "6 $vbphrase[hours]",
*			'h_12' => "12 $vbphrase[hours]",
			'D_1'  => "1 $vbphrase[day]",
			'D_2'  => "2 $vbphrase[days]",
			'D_3'  => "3 $vbphrase[days]",
			'D_4'  => "4 $vbphrase[days]",
Reply With Quote
  #4  
Old 06-30-2016, 05:39 PM
jkotlowski jkotlowski is offline
 
Join Date: May 2015
Posts: 36
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by kh99 View Post
If you look in banning.php around line 261, there's this code:

Code:
	// check that the number of days is valid
	if ($vbulletin->GPC['period'] != 'PERMANENT' AND !preg_match('#^(D|M|Y)_[1-9][0-9]?$#', $vbulletin->GPC['period']))
	{
		print_stop_message('invalid_ban_period_specified');
	}

you'll have to add h to the (D|M|Y) part to allow it as valid. Also, because it uses the function convert_date_to_timestamp() (in includes/functions_banning.php) to calcualte the lift date from the "period", it looks like you'll have to use lower case h instead of H.

Another issue may be that because the bans are lifted by a scheduled task, you'll also have to make sure that that task runs more often than once a day. ETA: ... turns out it does run once per hour by default.
I wanted to bump this and say thanks!

You should consider adding this to the template mods for vBulletin 5. I've been trying to figure this out for hours now and happened to stumble upon your post.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 08:22 AM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2024, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.03471 seconds
  • Memory Usage 2,189KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (3)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (4)post_thanks_box
  • (4)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (4)post_thanks_postbit_info
  • (4)postbit
  • (4)postbit_onlinestatus
  • (4)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete