How to return error phrase in attachdata_presave hook?

[JamesAB]

I'm trying to block certain attachments from being posted. When I make use of returning "false" in the attachdata_presave hook I can successfully stop the file from being saved in VB. However, when I try to customize the error message shown in the browser to the end-user, it only works when I am logged in as "admin". Registered users still see the standard error message.

Here's what I have in attachdata_presave

$bannedmatches = $this->dbobject->query_first("
	SELECT COUNT(*) AS count
	FROM " . TABLE_PREFIX . "banned_attachment
	WHERE filehash = '" . $this->fetch_field('filehash') . "'
");

if ($bannedmatches['count'] > 0)
{
     $return_value = false;
     $this->error('jb_file_not_allowed_here');
}

When I'm logged in as admin and try to upload a banned attachment I see my custom error phrase in the response page.

hippos.jpg:
This file is not allowed to be uploaded on our website.

When I'm logged in as a registered user and try to upload the same attachment, I see the standard error phrase.

hippos.jpg:
Upload of file failed.

What am I missing? What would be the best way to set the error text here to use my own custom phrase?

Thanks for your help,
James

[Simon Lloyd]

Why would you go to all that trouble?, just don't allow the file type in the attachments manager?

That said you can display an error message like this example, if you create a custom hook (custom_template_permissions)

if (is_member_of($vbulletin->userinfo, 1))
{
        print_no_ permission_ custom_ template(); 
        exit(); 
}
if (is_member_of($vbulletin->userinfo, 8,9,10))
{
        print_no_ permission(); 
}

In fact the easiest would probably be to edit the newattachment_errormessage template, remove the $errormessage and put your own text in there and/or conditions

These should help too
HOOKS CALLED
init_startup
fetch_userinfo_query
fetch_musername
fetch_userinfo
cache_permissions
fetch_foruminfo
style_fetch
cache_templates
global_start
parse_templates
notices_check_start
notifications_list
global_setup_complete
newattachment_start
attachdata_start
upload_accept
error_fetch
newattachment_attach
editor_wysiwyg_compatible
newattachment_complete

TEMPLATES CALLED
newattachment
newattachment_errormessage
newattachment_keybit

PHRASE GROUPS CALLED
global
posting
prefix

[JamesAB]

Simon,
Thanks for your help. I'm not trying to block certain types of attachments. I'm trying to block specific attachments by comparing the filehash of the file that the member uploaded to a list filehash values I'll maintain of "banned" files/attachments.

I'm still trying to figure out why my error phrase is working correctly for the admin usergroup, but registered users are seeing the VB default phrase. I double-checked and both phrases are the same type.

(Stock VB phrase)
Front-End Error Messages
upload_file_failed
"Upload of file failed."

(My custom phrase)
Front-End Error Messages
jb_file_not_allowed_here
"This file is not allowed to be uploaded on our website."

It's a mystery to me why different usergroups are seeing different phrases.

Thanks,
James

[Simon Lloyd]

Do you have your error phrase in the error phrases or in global or.....etc?

[JamesAB]

I put my custom phrase in "Front-End Error Messages".

Thanks,
James

[kh99]

Originally Posted by JamesAB

It's a mystery to me why different usergroups are seeing different phrases.

Are you sure it's getting to that point for registered users? Maybe it's a different error.

[JamesAB]

Yes. I know the code in the hook is being executed because the line above the line that sets the error is being executed:

$return_value = false;

This is stopping the attachment from being saved and is working as expected for both admins and registered users.

[kh99]

So if you disable your plugin and upload the file as a registered user, it works?

[JamesAB]

Originally Posted by kh99

So if you disable your plugin and upload the file as a registered user, it works?

Yes. When I disable the plugin, "Manage Attachments" works as expected. All usergroups can upload the same files with no limitations or error messages.

--------------- Added [DATE]1328496982[/DATE] at [TIME]1328496982[/TIME] ---------------

Maybe something weird is happening with the vB_Upload_Attachment datamanager?

Here is where newattachment.php is getting the error text from:

				if ($error = $upload->fetch_error())
				{
					$errors[] = array(
						'filename' => is_array($attachment) ? $attachment['name'] : $attachment,
						'error'    => $error,
					);
				}

[kh99]

Originally Posted by JamesAB

Yes. When I disable the plugin, "Manage Attachments" works as expected. All usergroups can upload the same files with no limitations or error messages.

OK, just wanted to make sure. I tried your code (well, I really just set the return value and error message) and I do get the same problem.