The Arcive of Official vBulletin Modifications Site.

SteveLV702 · #1 11-22-2011, 05:08 AM

Site is currently running vb 4.0.7 trying to upgrade it to vb 4.1.8 for my client as they want to be able to create iOS/Android app but I am having a little issue....

they have some ads along the side that I can't seem to fix....

http://www.pro-touring.com/forum.php <--- original site running 4.0.7

http://www.pro-touring.com/beta/forum.php <--- 4.1.8 working on

attached I included some screen shots as can see got /forum.php working/looking right but if click on a thread the ads are at the top and gotta scroll all the way to bottom of ads before see threads... same thing if click on a post....

Anyone help me fix this.

nerbert · #2 11-22-2011, 07:23 AM

I think you need a "clear:none;" in the css for the ad column. "clear:left;" will not allow anything to the left of the column so it drops below the ads. I don't know where there would be a"clear:left;" for the ad column but you can override it with an inline style if you need to.

kall · #3 11-22-2011, 07:50 AM

You know that your testing instance is not allowed to be accessible to the public, right?

(If you have 2 licenses for this domain, disregard my comment.)

SteveLV702 · #4 11-22-2011, 02:03 PM

not my site.. I am just helping fix this issue... but I will let the owner know...

--------------- Added [DATE]1321974573[/DATE] at [TIME]1321974573[/TIME] ---------------

Quote:

Originally Posted by nerbert

I think you need a "clear:none;" in the css for the ad column. "clear:left;" will not allow anything to the left of the column so it drops below the ads. I don't know where there would be a"clear:left;" for the ad column but you can override it with an inline style if you need to.

there is no css for the ad (that I am aware of) there is just a plugin with this info

Code:

// info: init_startup(), Prod: vbulletin, name: Ad Generator



$sql = "SELECT styleid, multiplicity FROM " . TABLE_PREFIX . "adv_banner_style";
$adv_styles = $vbulletin->db->query_read_slave($sql);
while ($adv_style = $vbulletin->db->fetch_array($adv_styles))
{
    $sql = "SELECT bannerid, src, alt, url FROM " . TABLE_PREFIX . "adv_banner WHERE styleid = " . $adv_style['styleid'];
    $sql .= " ORDER BY RAND() ";
    if ($adv_style['multiplicity'] > 0) $sql .= " LIMIT " . $adv_style['multiplicity'];

    $adv_q = $vbulletin->db->query_read_slave($sql);
    $banner[$adv_style['styleid']] = "";
    while ($bnr = $vbulletin->db->fetch_array($adv_q))
    {
        if (substr($bnr['src'], -4) == '.txt')
        { // Scripted creative
            if ($bannerFile = fopen($bnr['src'], "r"))
            {
                $bannerSource = fread($bannerFile, filesize($bnr['src']));
                @fclose($bannerFile);
            } else {
                $bannerSource = "";  // Place error message/image here if you desire one
            }
            $banner[$adv_style['styleid']] .= '<div style="padding: 1px; border: none;">' . $bannerSource . '</div>';
        } else {
          // Image / URL creative
            $banner[$adv_style['styleid']] .= '<div style="padding: 1px; border: none;"><a href="' . $bnr['url'] . '" target="_New"><img src="' . $bnr['src'] . '" alt="' . $bnr['alt'] . '" border="0" /></a></div>';
        }
    }
}

vB_Template::preRegister('navbar', array('banner' => $banner));

vB_Template::preRegister('FORUMHOME', array('banner' => $banner));

vB_Template::preRegister('SHOWTHREAD', array('banner' => $banner));

vB_Template::preRegister('FORUMDISPLAY', array('banner' => $banner));

vB_Template::preRegister('search_resultlist', array('banner' => $banner));

then in FORUMDISPLAY there is this code in there

Code:

<div style="float:right; width:100px; position:relative;">{vb:raw banner.1}</div>

<div id="content_container">
    <div id="content" style="margin-right:120px;">

then in FORUMHOME there is this code

Code:

<!-- Adversiting Edit -->
    <div id="sidebar_container" style="float:right; width:100px; margin:0px; padding:0px; margin-top:20px; position:relative;">{vb:raw banner.1}</div>


	<!-- Advertising Edit -->
	<div id="content_container">
		<div id="content" style="margin-right:120px;">

in navbar there is

Code:

<div style="width:468px; margin-left:auto; margin-right:auto; margin-bottom:5px; margin-top:-5px;">{vb:raw banner.2}</div>

search_resultlist there is

Code:

<!-- Adversiting Edit -->
    <div id="sidebar_container" style="float:right; width:100px; margin:0px; padding:0px; margin-top:20px; position:relative;">{vb:raw banner.1}</div>


	<!-- Advertising Edit -->
	<div id="content_container">
		<div id="content" style="margin-right:120px;">

and finally but not least in SHOWTHREAD there is

Code:

<div style="float:right; width:100px; position:relative;">{vb:raw banner.1}</div>

<div id="content_container">
    <div id="content" style="margin-right:120px;">

nerbert · #5 11-22-2011, 03:53 PM

I would just go through all the div tags in all those pieces of code and insert "clear:none;" in the style statements until it works. If doing that doesn't change anything edit it out. If a div doesn't have a style statement add one style="clear:none;" I would start with the code you posted on the bottom in the first div tag.

clear:none probably won't hurt anything and you can experiment around with html and css all you want without worrying you are going ruin anything -- if it does't work undo it.

SteveLV702 · #6 11-22-2011, 04:09 PM

ya didn't work :'(

nerbert · #7 11-22-2011, 04:20 PM

There are two div's in the first block of code, did you try those ?

PHP Code:


			
            $banner[$adv_style['styleid']] .= '<div style="padding: 1px; border: none;">' . $bannerSource . '</div>';
        } else {
          // Image / URL creative
            $banner[$adv_style['styleid']] .= '<div style="padding: 1px; border: none;"><a......

SteveLV702 · #8 11-22-2011, 04:45 PM

Yup

Code:

// info: init_startup(), Prod: vbulletin, name: Ad Generator



$sql = "SELECT styleid, multiplicity FROM " . TABLE_PREFIX . "adv_banner_style";
$adv_styles = $vbulletin->db->query_read_slave($sql);
while ($adv_style = $vbulletin->db->fetch_array($adv_styles))
{
    $sql = "SELECT bannerid, src, alt, url FROM " . TABLE_PREFIX . "adv_banner WHERE styleid = " . $adv_style['styleid'];
    $sql .= " ORDER BY RAND() ";
    if ($adv_style['multiplicity'] > 0) $sql .= " LIMIT " . $adv_style['multiplicity'];

    $adv_q = $vbulletin->db->query_read_slave($sql);
    $banner[$adv_style['styleid']] = "";
    while ($bnr = $vbulletin->db->fetch_array($adv_q))
    {
        if (substr($bnr['src'], -4) == '.txt')
        { // Scripted creative
            if ($bannerFile = fopen($bnr['src'], "r"))
            {
                $bannerSource = fread($bannerFile, filesize($bnr['src']));
                @fclose($bannerFile);
            } else {
                $bannerSource = "";  // Place error message/image here if you desire one
            }
            $banner[$adv_style['styleid']] .= '<div style="clear:none; padding: 1px; border: none;">' . $bannerSource . '</div>';
        } else {
          // Image / URL creative
            $banner[$adv_style['styleid']] .= '<div style="clear:none; padding: 1px; border: none;"><a href="' . $bnr['url'] . '" target="_New"><img src="' . $bnr['src'] . '" alt="' . $bnr['alt'] . '" border="0" /></a></div>';
        }
    }
}

vB_Template::preRegister('navbar', array('banner' => $banner));

vB_Template::preRegister('FORUMHOME', array('banner' => $banner));

vB_Template::preRegister('SHOWTHREAD', array('banner' => $banner));

vB_Template::preRegister('FORUMDISPLAY', array('banner' => $banner));

vB_Template::preRegister('search_resultlist', array('banner' => $banner));

then I even tried with a clear: none;

Code:

// info: init_startup(), Prod: vbulletin, name: Ad Generator



$sql = "SELECT styleid, multiplicity FROM " . TABLE_PREFIX . "adv_banner_style";
$adv_styles = $vbulletin->db->query_read_slave($sql);
while ($adv_style = $vbulletin->db->fetch_array($adv_styles))
{
    $sql = "SELECT bannerid, src, alt, url FROM " . TABLE_PREFIX . "adv_banner WHERE styleid = " . $adv_style['styleid'];
    $sql .= " ORDER BY RAND() ";
    if ($adv_style['multiplicity'] > 0) $sql .= " LIMIT " . $adv_style['multiplicity'];

    $adv_q = $vbulletin->db->query_read_slave($sql);
    $banner[$adv_style['styleid']] = "";
    while ($bnr = $vbulletin->db->fetch_array($adv_q))
    {
        if (substr($bnr['src'], -4) == '.txt')
        { // Scripted creative
            if ($bannerFile = fopen($bnr['src'], "r"))
            {
                $bannerSource = fread($bannerFile, filesize($bnr['src']));
                @fclose($bannerFile);
            } else {
                $bannerSource = "";  // Place error message/image here if you desire one
            }
            $banner[$adv_style['styleid']] .= '<div style="clear: none; padding: 1px; border: none;">' . $bannerSource . '</div>';
        } else {
          // Image / URL creative
            $banner[$adv_style['styleid']] .= '<div style="clear: none; padding: 1px; border: none;"><a href="' . $bnr['url'] . '" target="_New"><img src="' . $bnr['src'] . '" alt="' . $bnr['alt'] . '" border="0" /></a></div>';
        }
    }
}

vB_Template::preRegister('navbar', array('banner' => $banner));

vB_Template::preRegister('FORUMHOME', array('banner' => $banner));

vB_Template::preRegister('SHOWTHREAD', array('banner' => $banner));

vB_Template::preRegister('FORUMDISPLAY', array('banner' => $banner));

vB_Template::preRegister('search_resultlist', array('banner' => $banner));

neither worked :'(

Lynne · #9 11-25-2011, 04:33 PM

I can't see the non-working site.

SteveLV702 · #10 11-25-2011, 05:02 PM

Quote:

Originally Posted by Lynne

I can't see the non-working site.

like can't see it cause its turned off? or can't see it cause its down cause some people its appearing down all together (like me) while others can see just fine...

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.04988 seconds Memory Usage 2,298KB Queries Executed 12 (?)
More Information
Template Usage: (1)SHOWTHREAD (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)ad_showthread_beforeqr (1)ad_showthread_firstpost (1)ad_showthread_firstpost_sig (1)ad_showthread_firstpost_start (8)bbcode_code (1)bbcode_php (2)bbcode_quote (1)footer (1)forumjump (1)forumrules (1)gobutton (1)header (1)headinclude (1)navbar (3)navbar_link (120)option (1)pagenav (1)pagenav_curpage (1)pagenav_pagelink (10)post_thanks_box (10)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (10)post_thanks_postbit_info (10)postbit (4)postbit_attachment (10)postbit_onlinestatus (10)postbit_wrapper (1)spacer_close (1)spacer_open (1)tagbit_wrapper Phrase Groups Available: global inlinemod postbit posting reputationlevel showthread	Included Files: ./showthread.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showthread_start showthread_getinfo forumjump showthread_post_start showthread_query_postids showthread_query bbcode_fetch_tags bbcode_create showthread_postbit_create postbit_factory postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_attachment postbit_display_complete post_thanks_function_can_thank_this_post_start pagenav_page pagenav_complete tag_fetchbit_complete forumrules navbits navbits_complete showthread_complete
Messages:

The Arcive of Official vBulletin Modifications Site.

It is not a VB3 engine, just a parsed copy!