Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 Programming Discussions
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 11-29-2010, 09:56 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Help making sig fit better

Now, i think I know the answer to this is probably going to be "rewrite the entire legacy postbit using tables".

However, I'm just wondering if there's a better way.

Currently, vB4 sigs are pushed to the bottom, which I like. (I hate the sigs (flaoting up0 to just below the end of the post).

HOWEVER, they are taking up another block of space below the postbit, wherwas on my 3.8 site I had styled it so they fitted WITHIN the postbit.

To explain better what I mean:

Here is how my vB4 postbit looks at present:



And here is a mockup of how I would LIKE it to look:



Is there any feasible way to achieve this on vB4 without completely re-writing the postbit? It was easy enough on vB3 due to the table structure.
Reply With Quote
  #2  
Old 12-02-2010, 06:56 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I did it!

I thought, I can't be bothered trying to rewrite the entire postbit_legacy template, and besides I'd make a right mess of it, so how about if I just throw some basic tables around what's already there and see what happens?"

And - unbelievably - within 30 minutes and with a few tweaks, it's working perfectly! tested in Chrome, Firefox and IE8 anyway and everything (as far as i can see) still works, including highlighting on inlinemod and the quick edit box.

That's too good to be true, SOMETHING has got to be broken. But I'll wait and see.

Not sure if this is a tribute to the flexibility of vB4's CSS or what.

Of course, it does mean I've got yet another table! I feel like I've got more tables now than vB3 had! But as long as it looks right to the end user, I don't actually care.

The blow screenshot is no longer a mockup, it's an actual screenshot from the test site:

Reply With Quote
  #3  
Old 12-02-2010, 06:58 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Nice!
Reply With Quote
  #4  
Old 12-02-2010, 08:06 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks.

Got to check it in IE7 yet but there's a lot of things I have to tweak for that...and IE6 is just....arrrggh....
Reply With Quote
  #5  
Old 12-02-2010, 10:02 PM
Lynne's Avatar
Lynne Lynne is offline
 
Join Date: Sep 2004
Location: California/Idaho
Posts: 41,180
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

hehe. On my site, according to google analytics, 40% of the users use IE. Of those 40%, 81% use IE8 and 14% use IE7 and 1% user IE9. I'm not gonna worry about that last 4%. (Yeah, I'm a mean, mean admin!)
Reply With Quote
  #6  
Old 12-02-2010, 10:49 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Lynne View Post
hehe. On my site, according to google analytics, 40% of the users use IE. Of those 40%, 81% use IE8 and 14% use IE7 and 1% user IE9. I'm not gonna worry about that last 4%. (Yeah, I'm a mean, mean admin!)
I've pretty much decided that IE6 users are going to have to be "unsupported" once we move to vB4. They pretty much are anyway since my 3.8 site's full of PNGs and various CSS tricks that IE6 doesn't like.

As far as I can tell most things "work" in vB4 on IE6, the only thing I'll want to really do is sort out the "enormous avatars" issue, not quite sure why they do that in IE6 but I'm sure a browser conditional can sort it.

IE7, the only thing I am now aware of (unless this postbit change broke anything) is my tweaked clickable smiliey boxes don't display properly...the smilies don't sit within the box, they spill out. I think this is due to the smiliebits using <li> tags rather than <td> tags as they did in 3.8. And I don't think there's an easy fix. I might have to conditionalise them into not appearing in IE7 at all....

Beyond that I'll rig up some sort of notice at the top advising IE6 users that the site may not function or display correctly. If it's good enough for Facebook, Google etc then it's good enough for us.
Reply With Quote
  #7  
Old 12-03-2010, 02:12 PM
Bluebell Bluebell is offline
 
Join Date: Dec 2009
Posts: 8
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

You must share this beautiful thing Mark B, we've been wanting that for a long time.
Reply With Quote
  #8  
Old 12-03-2010, 02:20 PM
seite7 seite7 is offline
 
Join Date: Jul 2010
Posts: 21
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Yes, please share! :-)
Reply With Quote
  #9  
Old 12-03-2010, 03:07 PM
Mark.B Mark.B is offline
Senior Member
 
Join Date: Feb 2004
Posts: 1,354
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I will try to next week (on hols for a few days now).

The problem is that my postbit is now a bit of an untidy mess, template wise, and I need to clean it up a bit to make any instructions meaningful.

My best bet might be to create a default style, and try and reapply those specific changes to the default postbit legacy, then I'll throw the lot in here for people to play with.

Not guarantees on timescales, I'll do it when I can. Also bear in mind that this uses tables so will probably not be "valid code" by various standards. But it works.

Finally it's not quite right in IE7, the top part (ion red on mine) doesn't display correctly. I'm sure there's a fairly easy fix to that though.
Reply With Quote
  #10  
Old 12-03-2010, 07:38 PM
OurCouponHome OurCouponHome is offline
 
Join Date: May 2010
Posts: 114
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

What is wrong with me that I can't see the difference?
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT. The time now is 06:47 PM.


Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.04335 seconds
  • Memory Usage 2,250KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (1)pagenav
  • (1)pagenav_curpage
  • (1)pagenav_pagelink
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 

Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • pagenav_page
  • pagenav_complete
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete