Go Back   vb.org Archive > vBulletin 4 Discussion > vB4 General Discussions
Reload this Page Combining CSS using minify and delivering using if/elseif isn't working
FAQ Community Calendar Today's Posts Search

Reply
 
Thread Tools Display Modes
  #1  
Old 06-21-2010, 10:21 AM
Abhik's Avatar
Abhik Abhik is offline
 
Join Date: Jun 2006
Location: Kolkata, India
Posts: 144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Combining CSS using minify and delivering using if/elseif isn't working
Hello,
I am using Minify to combining the CSS files and delivering it with if/elseif conditions.. The index is working fine, but the other's is not.

Please tell me where I am doing wrong

1. I am storing CSS as files in filesystem

2. Replacing the code at headerinclude template

PHP Code:
<vb:if condition="$vboptions['storecssasfile']">
    {vb:cssfile main-rollup.css}
        {vb:raw template_hook.custom_css_links}
<vb:else />
    {vb:cssfile  bbcode.css,editor.css,popupmenu.css,reset-fonts.css,vbulletin.css,vbulletin-chrome.css,vbulletin-formcontrols.css{vb:raw  template_hook.custom_css_list}}
</vb:if> 
with

PHP Code:
<vb:if condition="$vboptions['storecssasfile']">
<vb:if condition="THIS_SCRIPT == 'index'"><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumhome-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'forumdisplay'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumdisplay-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'showthread'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,showthread-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'usercp' AND THIS_SCRIPT ==  'private' AND THIS_SCRIPT == 'member'" /><link rel="stylesheet"  type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,usercp-rollup.css,datepicker.css,private.css,additional.css,postbit.css,usercp-rollup.css,memberinfo-rollup.css"  />

<vb:elseif condition="THIS_SCRIPT == 'newreply'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,reviewpost.css,attachment.css"  />

<vb:elseif condition="THIS_SCRIPT == 'group'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,socialgroups.css,socialgroups_overview.css"  />

<vb:else />
    {vb:cssfile main-rollup.css}
        {vb:raw template_hook.custom_css_links}

</vb:if>
</vb:if> 
Only the index is working, but the other elseif conditions isn't working. When I enter the combined CSS link in browser, it's loading though.

TIA

BTW, at 4.0.3, I had this in headerinclude template to call the CSS. But, in 4.0.4, it's changed a bit.
PHP Code:
<vb:if condition="$vboptions['storecssasfile']">
    <link rel="stylesheet" type="text/css" href="{vb:raw vbcsspath}main-rollup.css" />
        {vb:raw template_hook.custom_css_links}
<vb:else />
    <link rel="stylesheet" type="text/css" href="{vb:raw vbcsspath}bbcode.css,editor.css,popupmenu.css,reset-fonts.css,vbulletin.css,vbulletin-chrome.css,vbulletin-formcontrols.css{vb:raw template_hook.custom_css_list}" />
</vb:if> 
Reply With Quote
  #2  
Old 06-21-2010, 10:22 AM
ChopSuey ChopSuey is offline
 
Join Date: Jun 2009
Location: Alaska
Posts: 2,140
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Just store CSS as files, much better imo.
Reply With Quote
  #3  
Old 06-21-2010, 10:28 AM
Abhik's Avatar
Abhik Abhik is offline
 
Join Date: Jun 2006
Location: Kolkata, India
Posts: 144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
I am already doing that, just to tell you if you haven't read the post properly.
What I am trying is to combine them. That's all
Reply With Quote
  #4  
Old 06-21-2010, 02:56 PM
ChopSuey ChopSuey is offline
 
Join Date: Jun 2009
Location: Alaska
Posts: 2,140
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
They're not working because you didn't close all the IF Conditions.
Reply With Quote
  #5  
Old 06-21-2010, 04:54 PM
Abhik's Avatar
Abhik Abhik is offline
 
Join Date: Jun 2006
Location: Kolkata, India
Posts: 144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Aah!! Okay..
So, what should I do to close them properly?
Reply With Quote
  #6  
Old 06-21-2010, 04:59 PM
ChopSuey ChopSuey is offline
 
Join Date: Jun 2009
Location: Alaska
Posts: 2,140
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Close every single one of them.
Reply With Quote
  #7  
Old 06-21-2010, 08:49 PM
DragonBlade's Avatar
DragonBlade DragonBlade is offline
 
Join Date: May 2006
Posts: 189
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
They are closed properly

Debug your if statements by putting some strings and see what happens.
Reply With Quote
  #8  
Old 06-23-2010, 01:08 PM
ChopSuey ChopSuey is offline
 
Join Date: Jun 2009
Location: Alaska
Posts: 2,140
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
He needs to close 5 more tags.
Reply With Quote
  #9  
Old 06-23-2010, 02:21 PM
Abhik's Avatar
Abhik Abhik is offline
 
Join Date: Jun 2006
Location: Kolkata, India
Posts: 144
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Quote:
Originally Posted by ChopSuey View Post
He needs to close 5 more tags.
So, you mean, this should be..?
PHP Code:
<vb:if condition="$vboptions['storecssasfile']">
<vb:if condition="THIS_SCRIPT == 'index'"><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumhome-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'forumdisplay'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,forumdisplay-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'showthread'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,showthread-rollup.css,additional.css"  />

<vb:elseif condition="THIS_SCRIPT == 'usercp' AND THIS_SCRIPT ==  'private' AND THIS_SCRIPT == 'member'" /><link rel="stylesheet"  type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,usercp-rollup.css,datepicker.css,private.css,additional.css,postbit.css,usercp-rollup.css,memberinfo-rollup.css"  />

<vb:elseif condition="THIS_SCRIPT == 'newreply'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,reviewpost.css,attachment.css"  />

<vb:elseif condition="THIS_SCRIPT == 'group'" /><link  rel="stylesheet" type="text/css" href="{vb:raw  vboptions.bburl}/min/b=clientscript/vbulletin_css/style00025l&f=main-rollup.css,additional.css,socialgroups.css,socialgroups_overview.css"  />

<vb:else />
    {vb:cssfile main-rollup.css}
        {vb:raw template_hook.custom_css_links}

</vb:if>
</vb:if>
</vb:if> 
</vb:if> 
</vb:if> 
</vb:if> 
</vb:if> 
Reply With Quote
  #10  
Old 06-23-2010, 03:01 PM
ChopSuey ChopSuey is offline
 
Join Date: Jun 2009
Location: Alaska
Posts: 2,140
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default
Yes sir.
Reply With Quote
Reply

« Previous Thread | Next Thread »

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Forum Jump


All times are GMT. The time now is 02:01 AM.

Contact Us - Archive - Top

Powered by vBulletin® Version 3.8.12 by vBS
Copyright ©2000 - 2025, vBulletin Solutions Inc.
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.05165 seconds
  • Memory Usage 2,287KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)ad_showthread_beforeqr
  • (1)ad_showthread_firstpost
  • (1)ad_showthread_firstpost_sig
  • (1)ad_showthread_firstpost_start
  • (4)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)forumjump
  • (1)forumrules
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (1)navbar
  • (3)navbar_link
  • (120)option
  • (10)post_thanks_box
  • (10)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (10)post_thanks_postbit_info
  • (10)postbit
  • (10)postbit_onlinestatus
  • (10)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open
  • (1)tagbit_wrapper 
Phrase Groups Available:
  • global
  • inlinemod
  • postbit
  • posting
  • reputationlevel
  • showthread
Included Files:
  • ./showthread.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 
Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showthread_start
  • showthread_getinfo
  • forumjump
  • showthread_post_start
  • showthread_query_postids
  • showthread_query
  • bbcode_fetch_tags
  • bbcode_create
  • showthread_postbit_create
  • postbit_factory
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • tag_fetchbit_complete
  • forumrules
  • navbits
  • navbits_complete
  • showthread_complete